)]}'
{"ansible/roles/pip/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"53afc6557a0f6cb3df21e7ce15d09fc289853f39","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Optional: a list of \u0027trusted\u0027 hosts for which SSL verification will be"},{"line_number":15,"context_line":"# disabled"},{"line_number":16,"context_line":"pip_trusted_hosts: []"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_538fb7cb","line":16,"updated":"2018-08-07 08:11:28.000000000","message":"These also need adding to etc/kayobe/pip.yml","commit_id":"ac4b20012aa3ade1724cd00828dfb106faa4f39e"}],"ansible/roles/pip/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"53afc6557a0f6cb3df21e7ce15d09fc289853f39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- block:"},{"line_number":3,"context_line":"    - include_tasks: pip_local_mirror.yml"},{"line_number":4,"context_line":"      loop: \"{{ pip_applicable_users }}\""},{"line_number":5,"context_line":"      loop_control:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_9391cf55","line":2,"updated":"2018-08-07 08:11:28.000000000","message":"Is the block required?","commit_id":"ac4b20012aa3ade1724cd00828dfb106faa4f39e"}],"ansible/roles/pip/tasks/pip_local_mirror.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"122535800dfce18ea2d11fbd205920e733adeec0","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Deactivate the virtualenv"},{"line_number":4,"context_line":"  include_role:"},{"line_number":5,"context_line":"    name: deactivate-virtualenv"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Create local .pip directory for {{ user }}"},{"line_number":8,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_413af7cb","line":5,"updated":"2018-08-13 18:07:05.000000000","message":"Might need a matching activate-virtualenv at the end like in kayobe-target-venv.yml:\n\n        - name: Activate the virtualenv\n          include_role:\n            name: activate-virtualenv\n          vars:\n            activate_virtualenv_path: \"{{ virtualenv }}\"","commit_id":"21f49f85f2ee80a1a88dc1e6659cb92dc9553e44"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d3487618823d180503cf457f7dd92dd56105795e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- name: Deactivate the virtualenv"},{"line_number":4,"context_line":"  include_role:"},{"line_number":5,"context_line":"    name: deactivate-virtualenv"},{"line_number":6,"context_line":"  when: virtualenv is defined"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Create local .pip directory for {{ user }}"},{"line_number":9,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3f79a3b5_081c5e75","line":6,"updated":"2018-09-03 16:58:37.000000000","message":"I think we\u0027re missing a task to set this variable based on ansible_python_interpreter.","commit_id":"6672317ac7cac8ec773040774d5ffaa7f679e716"}],"etc/kayobe/pip.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"25027614b1a1389f3b9307365d32e19cda81a63a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pip_local_mirror: false"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Users for which the necessary configuration will be put in place in order to"},{"line_number":5,"context_line":"# install PyPI packages from a mirror"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_765a2c83","line":2,"updated":"2018-08-15 14:38:48.000000000","message":"Normally the vars in etc/kayobe/ are commented out with the value removed, so that they are not set by default.","commit_id":"7fb62d5ab6344a58bebe3a4ff68c64a906d6819c"}],"kayobe/cli/commands.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"53afc6557a0f6cb3df21e7ce15d09fc289853f39","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            sys.exit(1)"},{"line_number":286,"context_line":"        playbooks \u003d _build_playbook_list("},{"line_number":287,"context_line":"            \"ip-allocation\", \"ssh-known-host\", \"kayobe-ansible-user\","},{"line_number":288,"context_line":"            \"kayobe-target-venv\", \"users\", \"pip\", \"yum\", \"dev-tools\","},{"line_number":289,"context_line":"            \"network\", \"sysctl\", \"ntp\", \"seed-hypervisor-libvirt-host\")"},{"line_number":290,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":291,"context_line":"                                  limit\u003d\"seed-hypervisor\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_93f6af8f","line":288,"updated":"2018-08-07 08:11:28.000000000","message":"There\u0027s a potential ordering issue here since kayobe-target-venv.yml uses pip. OTOH, the remote virtualenv (if using one) might not exist until kayobe-target-venv.yml has run.\n\nWe could resolve this by running the pip.yml playbooks first, and using the deactivate-venv role (to ensure the virtualenv is not used) prior to running kayobe-target-venv.yml (see kayobe-target-venv.yml for an example of this).\n\n\nFor the seed and overcloud, there\u0027s also the question of whether the kolla user exists yet. It gets created in kolla-ansible bootstrap-servers, which happens after this.\n\nPerhaps we need to split the pip config for kolla from that for kayobe and root.","commit_id":"ac4b20012aa3ade1724cd00828dfb106faa4f39e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"53afc6557a0f6cb3df21e7ce15d09fc289853f39","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        playbooks \u003d _build_playbook_list("},{"line_number":287,"context_line":"            \"ip-allocation\", \"ssh-known-host\", \"kayobe-ansible-user\","},{"line_number":288,"context_line":"            \"kayobe-target-venv\", \"users\", \"pip\", \"yum\", \"dev-tools\","},{"line_number":289,"context_line":"            \"network\", \"sysctl\", \"ntp\", \"seed-hypervisor-libvirt-host\")"},{"line_number":290,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":291,"context_line":"                                  limit\u003d\"seed-hypervisor\")"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_73cbd352","line":289,"updated":"2018-08-07 08:11:28.000000000","message":"This will require an update to the unit tests.","commit_id":"ac4b20012aa3ade1724cd00828dfb106faa4f39e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"122535800dfce18ea2d11fbd205920e733adeec0","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        # Run final kayobe playbooks."},{"line_number":425,"context_line":"        playbooks \u003d _build_playbook_list("},{"line_number":426,"context_line":"            \"kolla-target-venv\", \"kolla-host\", \"docker\")"},{"line_number":427,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks, limit\u003d\"seed\")"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_21425b3f","line":426,"updated":"2018-08-13 18:07:05.000000000","message":"We\u0027ll need the same thing the overcloud has here.","commit_id":"21f49f85f2ee80a1a88dc1e6659cb92dc9553e44"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"122535800dfce18ea2d11fbd205920e733adeec0","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        self.run_kolla_ansible_overcloud(parsed_args, \"bootstrap-servers\","},{"line_number":730,"context_line":"                                         extra_vars\u003dextra_vars)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        # If necessary, re-run the Pip role after we\u0027ve bootstrapped the Kolla user"},{"line_number":733,"context_line":"        if hostvars.get(\"pip_local_mirror\"):"},{"line_number":734,"context_line":"            extra_vars[\"pip_applicable_users\"] \u003d [hostvars.get(\"kolla_ansible_user\")]"},{"line_number":735,"context_line":"        # Further kayobe playbooks."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_0f718b0c","line":732,"updated":"2018-08-13 18:07:05.000000000","message":"Shoud reinitialise extra_vars here to {}.","commit_id":"21f49f85f2ee80a1a88dc1e6659cb92dc9553e44"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8d66a97fb24ff9c3e1692e55e2f3d9849ce7739","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if parsed_args.wipe_disks:"},{"line_number":399,"context_line":"            playbooks +\u003d _build_playbook_list(\"wipe-disks\")"},{"line_number":400,"context_line":"        playbooks +\u003d _build_playbook_list("},{"line_number":401,"context_line":"            \"users\", \"pip\", \"yum\", \"dev-tools\", \"disable-selinux\", \"network\","},{"line_number":402,"context_line":"            \"sysctl\", \"ip-routing\", \"snat\", \"disable-glean\", \"ntp\", \"lvm\")"},{"line_number":403,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks, limit\u003d\"seed\")"},{"line_number":404,"context_line":"        playbooks \u003d _build_playbook_list(\"kolla-ansible\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_4a4e6a38","line":401,"updated":"2018-08-15 11:53:30.000000000","message":"Does pip need to go before kayobe-target-venv here too?","commit_id":"5ccb5b92e95a85470880168bb59ab354d4bcaddf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8d66a97fb24ff9c3e1692e55e2f3d9849ce7739","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        # the Kolla user"},{"line_number":426,"context_line":"        pip_local_mirror \u003d hostvars.get(\"pip_local_mirror\")"},{"line_number":427,"context_line":"        kolla_ansible_user \u003d hostvars.get(\"kolla_ansible_user\")"},{"line_number":428,"context_line":"        if pip_local_mirror:"},{"line_number":429,"context_line":"            extra_vars[\"pip_applicable_users\"] \u003d [kolla_ansible_user]"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        # Run final kayobe playbooks."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_ca103a03","line":428,"updated":"2018-08-15 11:53:30.000000000","message":"Weird corner case alert: this will still run if pip_local_mirror is set to the string \"no\".\n\nWe could get away with running the playbook every time here (as above), since the pip_local_mirror flag will be checked in each case.","commit_id":"5ccb5b92e95a85470880168bb59ab354d4bcaddf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8d66a97fb24ff9c3e1692e55e2f3d9849ce7739","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            \"pip\", \"kolla-target-venv\", \"kolla-host\", \"docker\")"},{"line_number":434,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":435,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":436,"context_line":"        extra_vars \u003d {}"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"class SeedHostUpgrade(KollaAnsibleMixin, KayobeAnsibleMixin, VaultMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_2ae52e38","line":436,"updated":"2018-08-15 11:53:30.000000000","message":"Need to set this before L428.","commit_id":"5ccb5b92e95a85470880168bb59ab354d4bcaddf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8d66a97fb24ff9c3e1692e55e2f3d9849ce7739","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        if parsed_args.wipe_disks:"},{"line_number":715,"context_line":"            playbooks +\u003d _build_playbook_list(\"wipe-disks\")"},{"line_number":716,"context_line":"        playbooks +\u003d _build_playbook_list("},{"line_number":717,"context_line":"            \"users\", \"pip\", \"yum\", \"dev-tools\", \"disable-selinux\", \"network\","},{"line_number":718,"context_line":"            \"sysctl\", \"disable-glean\", \"disable-cloud-init\", \"ntp\", \"lvm\")"},{"line_number":719,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks, limit\u003d\"overcloud\")"},{"line_number":720,"context_line":"        playbooks \u003d _build_playbook_list(\"kolla-ansible\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_0a6632c2","line":717,"updated":"2018-08-15 11:53:30.000000000","message":"Does pip need to go before kayobe-target-venv here too?","commit_id":"5ccb5b92e95a85470880168bb59ab354d4bcaddf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d8d66a97fb24ff9c3e1692e55e2f3d9849ce7739","unresolved":false,"context_lines":[{"line_number":751,"context_line":"            \"docker\", \"ceph-block-devices\")"},{"line_number":752,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":753,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"overcloud\")"},{"line_number":754,"context_line":"        extra_vars \u003d {}"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"class OvercloudHostUpgrade(KayobeAnsibleMixin, VaultMixin, Command):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_ead4164a","line":754,"updated":"2018-08-15 11:53:30.000000000","message":"Need to set this before L745.","commit_id":"5ccb5b92e95a85470880168bb59ab354d4bcaddf"}]}
