)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8f74dcf415a8c07c1497db9c499f26ca99547d82","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A control plane is first deployed using the Kayobe stable/pike branch"},{"line_number":14,"context_line":"and associated default configuration. The control plane is tested by"},{"line_number":15,"context_line":"deploying then deleting a server instance. An upgrade to Queens is"},{"line_number":16,"context_line":"performed, using the Kayobe master branch, or code in review if"},{"line_number":17,"context_line":"applicable. The upgraded control plane is tested by deploying then"},{"line_number":18,"context_line":"deleting a second server instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3f79a3b5_ec3fc4dc","line":15,"range":{"start_line":15,"start_character":57,"end_line":15,"end_character":63},"updated":"2018-11-05 11:18:15.000000000","message":"Given that this is on master, would it be better to test Rocky to Stein?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"93a0a6b6222e244ea9217d6708269ae1d55354a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A control plane is first deployed using the Kayobe stable/pike branch"},{"line_number":14,"context_line":"and associated default configuration. The control plane is tested by"},{"line_number":15,"context_line":"deploying then deleting a server instance. An upgrade to Queens is"},{"line_number":16,"context_line":"performed, using the Kayobe master branch, or code in review if"},{"line_number":17,"context_line":"applicable. The upgraded control plane is tested by deploying then"},{"line_number":18,"context_line":"deleting a second server instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3f79a3b5_b2db624a","line":15,"range":{"start_line":15,"start_character":57,"end_line":15,"end_character":63},"in_reply_to":"3f79a3b5_ec3fc4dc","updated":"2018-11-05 12:02:26.000000000","message":"I\u0027d like to get this merged before we merge the rocky support, then backport it to the stable/queens branch, then modify the rocky patch to upgrade Queens to Rocky. Then, when we release Rocky we can develop against master of kolla and modify it to test Rocky to master (Stein).\n\nMake sense?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"}],"dev/functions":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8f74dcf415a8c07c1497db9c499f26ca99547d82","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    environment_setup"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    echo \"Bootstrapping the Ansible control host\""},{"line_number":199,"context_line":"    for i in $(seq 1 10); do"},{"line_number":200,"context_line":"        if run_kayobe control host bootstrap; then"},{"line_number":201,"context_line":"            chb_success\u003d1"},{"line_number":202,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_6c289497","line":199,"range":{"start_line":199,"start_character":21,"end_line":199,"end_character":23},"updated":"2018-11-05 11:18:15.000000000","message":"10 retries seems pretty high - is it really that flaky?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"93a0a6b6222e244ea9217d6708269ae1d55354a3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    environment_setup"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    echo \"Bootstrapping the Ansible control host\""},{"line_number":199,"context_line":"    for i in $(seq 1 10); do"},{"line_number":200,"context_line":"        if run_kayobe control host bootstrap; then"},{"line_number":201,"context_line":"            chb_success\u003d1"},{"line_number":202,"context_line":"            break"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_b2c4c262","line":199,"range":{"start_line":199,"start_character":21,"end_line":199,"end_character":23},"in_reply_to":"3f79a3b5_6c289497","updated":"2018-11-05 12:02:26.000000000","message":"Perhaps you\u0027re right, I just got tired of seeing it fail when it was flaky for a time. I\u0027ll reduce to 3.","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"115c02ed45f4ecbf3c16d7c2a6f3cdc6b6d637b7","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    if is_deploy_image_built_locally; then"},{"line_number":271,"context_line":"        echo \"Building overcloud deployment images\""},{"line_number":272,"context_line":"        run_kayobe overcloud deployment image build"},{"line_number":273,"context_line":"    else"},{"line_number":274,"context_line":"        echo \"Not building overcloud deployment images\""},{"line_number":275,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_72938a5a","line":272,"updated":"2018-11-05 11:25:22.000000000","message":"do we need a --force-rebuild here?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"93a0a6b6222e244ea9217d6708269ae1d55354a3","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    if is_deploy_image_built_locally; then"},{"line_number":271,"context_line":"        echo \"Building overcloud deployment images\""},{"line_number":272,"context_line":"        run_kayobe overcloud deployment image build"},{"line_number":273,"context_line":"    else"},{"line_number":274,"context_line":"        echo \"Not building overcloud deployment images\""},{"line_number":275,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_35989cc9","line":272,"in_reply_to":"3f79a3b5_72938a5a","updated":"2018-11-05 12:02:26.000000000","message":"Good point.","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"115c02ed45f4ecbf3c16d7c2a6f3cdc6b6d637b7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    pip install python-openstackclient"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    source \"${KOLLA_CONFIG_PATH:-/etc/kolla}/admin-openrc.sh\""},{"line_number":307,"context_line":"    if ! openstack image show cirros \u003e/dev/null 2\u003e\u00261; then"},{"line_number":308,"context_line":"        echo \"Running kolla-ansible init-runonce\""},{"line_number":309,"context_line":"        ${KOLLA_VENV_PATH:-$HOME/kolla-venv}/share/kolla-ansible/init-runonce"},{"line_number":310,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"3f79a3b5_f2055a10","line":307,"updated":"2018-11-05 11:25:22.000000000","message":"I guess this could lead to a race condition if you forked multiple processes that ran overcloud_test. mkdir (which is an atomic operation) could be used as an alternative. However, all this stuff is run serially at the moment, so it doesn\u0027t really matter.","commit_id":"05040b8980365597bd17362a5528eb394ec89337"}],"playbooks/kayobe-overcloud-upgrade-base/pre.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8f74dcf415a8c07c1497db9c499f26ca99547d82","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      with_items:"},{"line_number":67,"context_line":"        - \"ip l add breth1 type bridge\""},{"line_number":68,"context_line":"        - \"ip l set breth1 up\""},{"line_number":69,"context_line":"        - \"ip a add 192.168.33.3/24 dev breth1\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_1231f6bb","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":23},"updated":"2018-11-05 11:18:15.000000000","message":"nit: Is there anyway this could this reference the dev config?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"93a0a6b6222e244ea9217d6708269ae1d55354a3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      with_items:"},{"line_number":67,"context_line":"        - \"ip l add breth1 type bridge\""},{"line_number":68,"context_line":"        - \"ip l set breth1 up\""},{"line_number":69,"context_line":"        - \"ip a add 192.168.33.3/24 dev breth1\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_122b369b","line":69,"range":{"start_line":69,"start_character":20,"end_line":69,"end_character":23},"in_reply_to":"3f79a3b5_1231f6bb","updated":"2018-11-05 12:02:26.000000000","message":"That would definitely be nicer, although we do it this way in other jobs. I\u0027ll think about it for a follow up.","commit_id":"05040b8980365597bd17362a5528eb394ec89337"}],"playbooks/kayobe-overcloud-upgrade-base/run.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8f74dcf415a8c07c1497db9c499f26ca99547d82","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # handling the SIGHUP after being upgraded, leading to \"In shutdown, no new"},{"line_number":70,"context_line":"        # events can be scheduled\" errors when booting an instance."},{"line_number":71,"context_line":"        - name: Workaround for SIGHUP issue - restart nova-compute service"},{"line_number":72,"context_line":"          shell:"},{"line_number":73,"context_line":"            cmd: docker restart nova_compute"},{"line_number":74,"context_line":"          become: true"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_3202f2ba","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":15},"updated":"2018-11-05 11:18:15.000000000","message":"Any reason not to use the docker_container module?","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"93a0a6b6222e244ea9217d6708269ae1d55354a3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # handling the SIGHUP after being upgraded, leading to \"In shutdown, no new"},{"line_number":70,"context_line":"        # events can be scheduled\" errors when booting an instance."},{"line_number":71,"context_line":"        - name: Workaround for SIGHUP issue - restart nova-compute service"},{"line_number":72,"context_line":"          shell:"},{"line_number":73,"context_line":"            cmd: docker restart nova_compute"},{"line_number":74,"context_line":"          become: true"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_d56928c0","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":15},"in_reply_to":"3f79a3b5_3202f2ba","updated":"2018-11-05 12:02:26.000000000","message":"Just had a look at that and I think it requires the container to be fully defined - it deleted my laptop\u0027s registry container then failed to recreate it...","commit_id":"05040b8980365597bd17362a5528eb394ec89337"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a34b2b85d90ee2b96d9634ed33ba89d2f25ebeef","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # handling the SIGHUP after being upgraded, leading to \"In shutdown, no new"},{"line_number":70,"context_line":"        # events can be scheduled\" errors when booting an instance."},{"line_number":71,"context_line":"        - name: Workaround for SIGHUP issue - restart nova-compute service"},{"line_number":72,"context_line":"          shell:"},{"line_number":73,"context_line":"            cmd: docker restart nova_compute"},{"line_number":74,"context_line":"          become: true"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3f79a3b5_983527df","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":15},"in_reply_to":"3f79a3b5_d56928c0","updated":"2018-11-05 12:36:49.000000000","message":"argh, no worries.","commit_id":"05040b8980365597bd17362a5528eb394ec89337"}]}