)]}'
{"ansible/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7147b2d604c679dad88cfe4f342cda123711b1fd","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  - regex: skydive"},{"line_number":193,"context_line":"    enabled: \"{{ kolla_enable_skydive | bool }}\""},{"line_number":194,"context_line":"  - regex: storm"},{"line_number":195,"context_line":"    enabled: \"{{ kolla_enable_storm | bool or kolla_enable_monasca | bool }}\""},{"line_number":196,"context_line":"  - regex: swift"},{"line_number":197,"context_line":"    enabled: \"{{ kolla_enable_swift | bool }}\""},{"line_number":198,"context_line":"  - regex: telegraf"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_e09b5661","line":195,"updated":"2018-09-14 00:47:04.000000000","message":"I\u0027m not sure about the logic here. Don\u0027t we want to build this only if storm is enabled. And we enable storm by default if monasca is enabled. So this would be just kolla_enable_storm, and the default for that variable below would be kolla_enable_monasca.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"627a7e286642632953aa9e6238abcdf0b06e4810","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  - regex: skydive"},{"line_number":193,"context_line":"    enabled: \"{{ kolla_enable_skydive | bool }}\""},{"line_number":194,"context_line":"  - regex: storm"},{"line_number":195,"context_line":"    enabled: \"{{ kolla_enable_storm | bool or kolla_enable_monasca | bool }}\""},{"line_number":196,"context_line":"  - regex: swift"},{"line_number":197,"context_line":"    enabled: \"{{ kolla_enable_swift | bool }}\""},{"line_number":198,"context_line":"  - regex: telegraf"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_7a292d87","line":195,"in_reply_to":"3f79a3b5_e09b5661","updated":"2018-09-14 10:07:05.000000000","message":"Agreed, I\u0027ve fixed the other services in a separate commit.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7147b2d604c679dad88cfe4f342cda123711b1fd","unresolved":false,"context_lines":[{"line_number":200,"context_line":"  - regex: tgtd"},{"line_number":201,"context_line":"    enabled: \"{{ kolla_enable_cinder | bool or kolla_enable_ironic | bool }}\""},{"line_number":202,"context_line":"  - regex: zookeeper"},{"line_number":203,"context_line":"    enabled: \"{{ kolla_enable_zookeeper | bool or kolla_enable_kafka | bool or kolla_enable_storm | bool }}\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# List of regular expressions matching names of container images to build for"},{"line_number":206,"context_line":"# overcloud hosts."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_a0a55ea1","line":203,"updated":"2018-09-14 00:47:04.000000000","message":"As above, and same for a few others e.g. kibana, etc.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"}],"ansible/roles/kolla-openstack/molecule/enable-everything/tests/test_default.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7147b2d604c679dad88cfe4f342cda123711b1fd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"     \u0027neutron.conf\u0027,"},{"line_number":76,"context_line":"     \u0027nova.conf\u0027,"},{"line_number":77,"context_line":"     \u0027sahara.conf\u0027,"},{"line_number":78,"context_line":"     \u0027storm.yaml\u0027,"},{"line_number":79,"context_line":"     \u0027zookeeper.cfg\u0027])"},{"line_number":80,"context_line":"def test_service_ini_file(host, path):"},{"line_number":81,"context_line":"    # TODO(mgoddard): Check more of config file contents."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a0d31e01","line":78,"updated":"2018-09-14 00:47:04.000000000","message":"This is a YAML file, but this test is for INI files.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"}],"ansible/roles/kolla-openstack/vars/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7147b2d604c679dad88cfe4f342cda123711b1fd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - src: \"{{ kolla_extra_config_path }}/storm\""},{"line_number":64,"context_line":"    dest: \"{{ kolla_node_custom_config_path }}/storm\""},{"line_number":65,"context_line":"    patterns: \"*\""},{"line_number":66,"context_line":"    enabled: \"{{ kolla_enable_storm }}\""},{"line_number":67,"context_line":"  # Ironic."},{"line_number":68,"context_line":"  - src: \"{{ kolla_extra_config_path }}/ironic\""},{"line_number":69,"context_line":"    dest: \"{{ kolla_node_custom_config_path }}/ironic\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c0f73a8c","line":66,"updated":"2018-09-14 00:47:04.000000000","message":"I wonder if this would work to avoid the boilerplate (in addition to the above):\n\n  - src: \"{{ kolla_extra_config_path }}\"\n    dest: \"{{ kolla_node_custom_config_path }}\"\n    patterns: \"storm.yaml\"\n    enabled: \"{{ kolla_enable_storm }}\"\n\nOr perhaps we need a more sane way to pass though single files, since this will result in a directory list and patten match.\n\nNo need to change unless you\u0027re feeling keen.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"627a7e286642632953aa9e6238abcdf0b06e4810","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - src: \"{{ kolla_extra_config_path }}/storm\""},{"line_number":64,"context_line":"    dest: \"{{ kolla_node_custom_config_path }}/storm\""},{"line_number":65,"context_line":"    patterns: \"*\""},{"line_number":66,"context_line":"    enabled: \"{{ kolla_enable_storm }}\""},{"line_number":67,"context_line":"  # Ironic."},{"line_number":68,"context_line":"  - src: \"{{ kolla_extra_config_path }}/ironic\""},{"line_number":69,"context_line":"    dest: \"{{ kolla_node_custom_config_path }}/ironic\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_da6721ea","line":66,"in_reply_to":"3f79a3b5_c0f73a8c","updated":"2018-09-14 10:07:05.000000000","message":"Thanks, I\u0027ll bear that in mind for future changes. Since the extra config for storm.yaml isn\u0027t required at the moment I\u0027ve removed it.","commit_id":"0fd64cfaf2af444f6f86bd6550917871d0c5adff"}]}