)]}'
{"dev/functions":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":"function is_deployed_by_agent {"},{"line_number":338,"context_line":"    true"},{"line_number":339,"context_line":"}"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"function configure_iptables {"},{"line_number":342,"context_line":"    # NOTE(wszumski): taken from the ironic devstack plugin"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_3e1c94c0","line":339,"updated":"2018-10-03 09:42:56.000000000","message":"Guess we don\u0027t need this?","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    # NOTE(wszumski): taken from the ironic devstack plugin"},{"line_number":343,"context_line":"    # FIXME(wszumski): set these variables with values from kayobe-config"},{"line_number":344,"context_line":"    HOST_IP\u003d\u0027192.168.33.3\u0027"},{"line_number":345,"context_line":"    INTERNAL_VIP\u003d\u0027192.168.33.2\u0027"},{"line_number":346,"context_line":"    IRONIC_TFTPSERVER_IP\u003d\"$HOST_IP\""},{"line_number":347,"context_line":"    IRONIC_SERVICE_PORT\u003d6385"},{"line_number":348,"context_line":"    IRONIC_INSPECTOR_PORT\u003d5050"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_3b71060e","line":345,"updated":"2018-10-03 09:42:56.000000000","message":"These two could be tricky. There isn\u0027t an easy way to extract these from the config right now.","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    IRONIC_INSPECTOR_PORT\u003d5050"},{"line_number":349,"context_line":"    IRONIC_HTTP_SERVER\u003d\"$INTERNAL_VIP\""},{"line_number":350,"context_line":"    GLANCE_SERVICE_PORT\u003d9192"},{"line_number":351,"context_line":"    IRONIC_IPXE_ENABLED\u003d\"False\""},{"line_number":352,"context_line":"    IRONIC_STORAGE_INTERFACE\u003d\"noop\""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    #TODO:"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_9ec5a83f","line":351,"updated":"2018-10-03 09:42:56.000000000","message":"Could be queried via kayobe config, see is_deploy_image_built_locally","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":375,"context_line":"    # open ironic API on baremetal network"},{"line_number":376,"context_line":"    sudo iptables -I INPUT -d $IRONIC_HTTP_SERVER -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":377,"context_line":"    # allow IPA to connect to ironic API on subnode"},{"line_number":378,"context_line":"    sudo iptables -I FORWARD -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":379,"context_line":"    # allow IPA to connect to ironic inspector on subnode"},{"line_number":380,"context_line":"    sudo iptables -I FORWARD -p tcp --dport $IRONIC_INSPECTOR_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_1e08b88e","line":377,"updated":"2018-10-03 09:42:56.000000000","message":"d/on subnode/","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    sudo iptables -I INPUT -d $IRONIC_HTTP_SERVER -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":377,"context_line":"    # allow IPA to connect to ironic API on subnode"},{"line_number":378,"context_line":"    sudo iptables -I FORWARD -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":379,"context_line":"    # allow IPA to connect to ironic inspector on subnode"},{"line_number":380,"context_line":"    sudo iptables -I FORWARD -p tcp --dport $IRONIC_INSPECTOR_PORT -j ACCEPT || true"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    if is_deployed_by_agent; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_befae473","line":379,"updated":"2018-10-03 09:42:56.000000000","message":"as above","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    if is_deployed_by_agent; then"},{"line_number":383,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":384,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"},{"line_number":385,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $GLANCE_SERVICE_PORT -j ACCEPT || true"},{"line_number":386,"context_line":"    fi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_be7d04e7","line":385,"updated":"2018-10-03 09:42:56.000000000","message":"I expect we\u0027ll be using iscsi deployment rather than direct, so these aren\u0027t necessary. Probably doesn\u0027t hurt though.","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":386,"context_line":"    fi"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ; then"},{"line_number":389,"context_line":"        sudo iptables -I INPUT -d $IRONIC_HTTP_SERVER -p tcp --dport $IRONIC_HTTP_PORT -j ACCEPT || true"},{"line_number":390,"context_line":"    fi"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    if [[ \"${IRONIC_STORAGE_INTERFACE}\" \u003d\u003d \"cinder\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_5e6cf031","line":389,"updated":"2018-10-03 09:42:56.000000000","message":"This should use HOST_IP rather than IRONIC_HTTP_SERVER","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"}],"playbooks/kayobe-overcloud-base/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        cmd: dev/tenks-deploy.sh \u0027{{ tenks_src_rel_path }}\u0027 \u003e {{ logs_dir }}/ansible/tenks-deploy"},{"line_number":22,"context_line":"        chdir: \"{{ kayobe_src_dir }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Configure the firewall"},{"line_number":25,"context_line":"      shell:"},{"line_number":26,"context_line":"        cmd: dev/configure_firewall.sh"},{"line_number":27,"context_line":"        chdir: \"{{ kayobe_src_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_de0b2079","line":24,"updated":"2018-10-03 09:42:56.000000000","message":"Ideally we\u0027d do this before deploying openstack, but I suppose the host config needs to have been applied.","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f358750fa03fe11691691abc4a62debe0d72d5d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    - name: Configure the firewall"},{"line_number":25,"context_line":"      shell:"},{"line_number":26,"context_line":"        cmd: dev/configure_firewall.sh"},{"line_number":27,"context_line":"        chdir: \"{{ kayobe_src_dir }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Perform testing of the overcloud"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_5be962a8","line":26,"updated":"2018-10-03 09:42:56.000000000","message":"micronit: hyphen","commit_id":"d8d065324fac8a21ddc762e81bc8a5214256d1b3"}]}