)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_ea628541","line":15,"updated":"2018-11-01 11:12:10.000000000","message":"Story/task?","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}],"ansible/baremetal-compute-serial-console-post-config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# ironic_serial_console_enable is set to true."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- import_playbook: baremetal-compute-serial-console.yml"},{"line_number":6,"context_line":"  when: ironic_serial_console_enable | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_2a815dc3","line":6,"updated":"2018-11-01 11:12:10.000000000","message":"Interesting, didn\u0027t realise this worked.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}],"ansible/group_vars/all/ironic":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":137,"context_line":"# Ironic Node Configuration"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Whether or not to enable the serial consoles on post configure"},{"line_number":140,"context_line":"ironic_serial_console_enable: false"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# This defines the start of the range of TCP ports to used for the IPMI socat"},{"line_number":143,"context_line":"# serial consoles"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_aaa1ed3c","line":140,"updated":"2018-11-01 11:12:10.000000000","message":"Wonder if this should be called \u0027autoenable\u0027?","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f67988eea662f9a315eb5cf512e8657d7a3a3057","unresolved":false,"context_lines":[{"line_number":137,"context_line":"# Ironic Node Configuration"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"# Whether or not to enable the serial consoles on post configure"},{"line_number":140,"context_line":"ironic_serial_console_enable: false"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# This defines the start of the range of TCP ports to used for the IPMI socat"},{"line_number":143,"context_line":"# serial consoles"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_4d5b9388","line":140,"in_reply_to":"3f79a3b5_aaa1ed3c","updated":"2018-11-01 11:57:59.000000000","message":"Sounds good.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}],"ansible/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":360,"context_line":"kolla_enable_neutron_lbaas: \"no\""},{"line_number":361,"context_line":"kolla_enable_neutron_provider_networks: \"no\""},{"line_number":362,"context_line":"kolla_enable_nova: \"yes\""},{"line_number":363,"context_line":"kolla_enable_nova_serialconsole_proxy: \"{{ ironic_serial_console_enable | bool }}\""},{"line_number":364,"context_line":"kolla_enable_osprofiler: \"no\""},{"line_number":365,"context_line":"kolla_enable_prometheus: \"no\""},{"line_number":366,"context_line":"kolla_enable_sahara: \"no\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_4a5b7988","line":363,"updated":"2018-11-01 11:12:10.000000000","message":"I\u0027m undecided on whether this is the right default. They\u0027re kind of separate things, although it could be quite useful. At least, it should also require kolla_enable_nova to be true.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}],"ansible/kolla-ansible.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        - name: Check kolla_enable_nova_serialconsole_proxy is enabled"},{"line_number":183,"context_line":"          fail:"},{"line_number":184,"context_line":"            msg: \u003e"},{"line_number":185,"context_line":"              You must enable kolla_enable_nova_serialconsole_proxy if you have ironic_serial_console_enable set to true"},{"line_number":186,"context_line":"          when: not kolla_enable_nova_serialconsole_proxy | bool"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        - name: Check ipmitool-socat is in enabled in kolla_ironic_enabled_console_interfaces"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_2ae87d79","line":185,"updated":"2018-11-01 11:12:10.000000000","message":"nit: wrap line?","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":183,"context_line":"          fail:"},{"line_number":184,"context_line":"            msg: \u003e"},{"line_number":185,"context_line":"              You must enable kolla_enable_nova_serialconsole_proxy if you have ironic_serial_console_enable set to true"},{"line_number":186,"context_line":"          when: not kolla_enable_nova_serialconsole_proxy | bool"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        - name: Check ipmitool-socat is in enabled in kolla_ironic_enabled_console_interfaces"},{"line_number":189,"context_line":"          fail:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_8add11e0","line":186,"updated":"2018-11-01 11:12:10.000000000","message":"nit: we could potentially use ironic without nova, but still want to enable the serial consoles.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":198,"context_line":"          fail:"},{"line_number":199,"context_line":"            msg: \u003e"},{"line_number":200,"context_line":"              The default console interface must be ipmitool-socat if you set ironic_serial_console_enable to true"},{"line_number":201,"context_line":"          when: kolla_ironic_default_console_interface !\u003d \u0027ipmitool-socat\u0027"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      when: ironic_serial_console_enable | bool"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_6abc356b","line":201,"updated":"2018-11-01 11:12:10.000000000","message":"I don\u0027t think this is correct - nodes could be defined with an explicit console interface.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f67988eea662f9a315eb5cf512e8657d7a3a3057","unresolved":false,"context_lines":[{"line_number":198,"context_line":"          fail:"},{"line_number":199,"context_line":"            msg: \u003e"},{"line_number":200,"context_line":"              The default console interface must be ipmitool-socat if you set ironic_serial_console_enable to true"},{"line_number":201,"context_line":"          when: kolla_ironic_default_console_interface !\u003d \u0027ipmitool-socat\u0027"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      when: ironic_serial_console_enable | bool"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_ed1dbfbf","line":201,"in_reply_to":"3f79a3b5_6abc356b","updated":"2018-11-01 11:57:59.000000000","message":"I was following:\n\nhttps://docs.openstack.org/ironic/latest/admin/console.html\n\nMaybe what we need is a way to specify the type of console interface this applies to. Could we change the check to:\n\nironic_serial_console_enable | bool and kolla_ironic_default_console_interface \u003d\u003d \u0027ipmitool-socat\u0027\n\nand we could potentially support different console interfaces?","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0503615201d0e0cdcca1d2a9700e8180879a8dfa","unresolved":false,"context_lines":[{"line_number":198,"context_line":"          fail:"},{"line_number":199,"context_line":"            msg: \u003e"},{"line_number":200,"context_line":"              The default console interface must be ipmitool-socat if you set ironic_serial_console_enable to true"},{"line_number":201,"context_line":"          when: kolla_ironic_default_console_interface !\u003d \u0027ipmitool-socat\u0027"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"      when: ironic_serial_console_enable | bool"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_90145eec","line":201,"in_reply_to":"3f79a3b5_ed1dbfbf","updated":"2018-11-01 12:30:21.000000000","message":"I think this check is not necessary. As long as the interface is enabled, it doesn\u0027t need to be the default.","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}],"etc/kayobe/ironic.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e8097eafa24526344ce8bbbdd3abd7dc4010504","unresolved":false,"context_lines":[{"line_number":110,"context_line":"# Ironic Node Configuration"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Whether or not to enable the serial consoles on post configure"},{"line_number":113,"context_line":"#ironic_serial_console_enable"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# This defines the start of the range of TCP ports to used for the IPMI socat"},{"line_number":116,"context_line":"# serial consoles"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_0ab10192","line":113,"updated":"2018-11-01 11:12:10.000000000","message":"micronit: trailing colon","commit_id":"12aa7b0ffcf8a5380b5d66c920576ceb29f8cbe3"}]}