)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b59f15bed843496c27f51cc71e754c3839f296c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pierre Riteau \u003cpierre@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-23 15:50:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[DNM] Allow to configure where to deploy a Docker Registry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the docker-registry playbook to deploy a Docker"},{"line_number":10,"context_line":"Registry on hosts in the docker-registry group, rather than being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_06d6c7f2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2019-01-23 16:01:50.000000000","message":"Ready to merge?","commit_id":"faf335545a4114d987d9f32685f4a391a47b231f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4ba46777565ec26a48dba7d327017381eae4ad86","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pierre Riteau \u003cpierre@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-01-23 15:50:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[DNM] Allow to configure where to deploy a Docker Registry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit changes the docker-registry playbook to deploy a Docker"},{"line_number":10,"context_line":"Registry on hosts in the docker-registry group, rather than being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9fdfeff1_69576404","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9fdfeff1_06d6c7f2","updated":"2019-01-23 16:19:29.000000000","message":"I would like to give it another try on a fresh install first. If you think that the upgrade path is good enough with just the release note and have no other concerns, I will remove the [DNM] tag once I have tested.","commit_id":"faf335545a4114d987d9f32685f4a391a47b231f"}],"ansible/docker-registry.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"18547b2874ef285268a83518bdcf5a2908e50971","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_6a85bbce","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"updated":"2019-01-29 12:23:49.000000000","message":"What will happen if someone adds more than one node to this group?","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f6aa3bdeb029a49f9cb420d39cfecd1afce2fe14","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_a4ed17f1","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"in_reply_to":"9fdfeff1_6a85bbce","updated":"2019-01-29 14:42:48.000000000","message":"It would deploy a registry on each host. I don\u0027t think there is any harm in doing that: configuring hosts to use a registry is configured separately and explicitly.\n\nDeploying multiple registries might be useful if one ever became a bottleneck.","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2ed236cd5905b652e1c9e3e24d9248d22b65e727","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_67b971ca","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"in_reply_to":"9fdfeff1_87349594","updated":"2019-01-29 15:44:40.000000000","message":"Done","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a85507f43ba2031aa75d51683e70b98d47b8ec54","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_e4b23f94","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"in_reply_to":"9fdfeff1_a4ed17f1","updated":"2019-01-29 15:06:09.000000000","message":"The main issue would be that without shared storage backing the docker volume, each registry would be independent.","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"abde49ecbeadbea358d57096e62ffb173a5b688c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_87349594","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"in_reply_to":"9fdfeff1_e4b23f94","updated":"2019-01-29 15:27:33.000000000","message":"Just wondering if we should add a comment in `etc/kayobe/inventory/groups` advising against more than one node unless you know what you\u0027re doing?","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2ed236cd5905b652e1c9e3e24d9248d22b65e727","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# action: One of deploy, destroy, pull, reconfigure, upgrade"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure a local Docker registry is deployed"},{"line_number":10,"context_line":"  hosts: docker-registry"},{"line_number":11,"context_line":"  tags:"},{"line_number":12,"context_line":"    - docker-registry"},{"line_number":13,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fdfeff1_a7a9997c","line":10,"range":{"start_line":10,"start_character":9,"end_line":10,"end_character":24},"in_reply_to":"9fdfeff1_e4b23f94","updated":"2019-01-29 15:44:40.000000000","message":"Yes. I was thinking about the pull through cache scenario, where there\u0027s no push to the registry.","commit_id":"a3669e824947b6b672d2d5c810e68b12e9ced414"}],"kayobe/cli/commands.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0cb5bfdbefe9edad443c2ed55302fc0f08395172","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":441,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # Optionally, deploy a Docker Registry."},{"line_number":444,"context_line":"        playbooks \u003d _build_playbook_list(\"docker-registry\")"},{"line_number":445,"context_line":"        extra_vars \u003d {\"kayobe_action\": \"deploy\"}"},{"line_number":446,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":447,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"class SeedHostPackageUpdate(KayobeAnsibleMixin, VaultMixin, Command):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_303b3439","line":447,"range":{"start_line":443,"start_character":0,"end_line":447,"end_character":70},"updated":"2019-01-21 10:59:12.000000000","message":"Typically the \u0027host configure\u0027 commands don\u0027t run services in containers - they only affect the host. How about adding this to the start of \u0027seed service deploy\u0027 and \u0027seed service upgrade\u0027?","commit_id":"a858c661ec94f605f11d64a6916fa77d2b0e8aa8"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"37cc864a82f0f338315b620571588e526691dda4","unresolved":false,"context_lines":[{"line_number":440,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":441,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # Optionally, deploy a Docker Registry."},{"line_number":444,"context_line":"        playbooks \u003d _build_playbook_list(\"docker-registry\")"},{"line_number":445,"context_line":"        extra_vars \u003d {\"kayobe_action\": \"deploy\"}"},{"line_number":446,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":447,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"class SeedHostPackageUpdate(KayobeAnsibleMixin, VaultMixin, Command):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_d0871561","line":447,"range":{"start_line":443,"start_character":0,"end_line":447,"end_character":70},"in_reply_to":"9fdfeff1_303b3439","updated":"2019-01-23 14:49:43.000000000","message":"Done","commit_id":"a858c661ec94f605f11d64a6916fa77d2b0e8aa8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c0aa51e2067bc4f6acd105976a62ea56619cbaa5","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # Optionally, deploy a Docker Registry."},{"line_number":545,"context_line":"        playbooks \u003d _build_playbook_list(\"docker-registry\")"},{"line_number":546,"context_line":"        extra_vars \u003d {\"kayobe_action\": \"deploy\"}"},{"line_number":547,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":548,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_d365df46","line":546,"range":{"start_line":546,"start_character":40,"end_line":546,"end_character":46},"updated":"2019-01-23 15:38:15.000000000","message":"nit: upgrade","commit_id":"c33f23841c57dad7daf58dacdbfb99a8ad60e9ad"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c7bd5421695d57f59005595cb014629714fe981a","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"        # Optionally, deploy a Docker Registry."},{"line_number":545,"context_line":"        playbooks \u003d _build_playbook_list(\"docker-registry\")"},{"line_number":546,"context_line":"        extra_vars \u003d {\"kayobe_action\": \"deploy\"}"},{"line_number":547,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":548,"context_line":"                                  extra_vars\u003dextra_vars, limit\u003d\"seed\")"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_2698abbe","line":546,"range":{"start_line":546,"start_character":40,"end_line":546,"end_character":46},"in_reply_to":"9fdfeff1_d365df46","updated":"2019-01-23 15:50:27.000000000","message":"Done","commit_id":"c33f23841c57dad7daf58dacdbfb99a8ad60e9ad"}],"playbooks/kayobe-seed-base/overrides.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"66c2e2ba436cffd2c3c976ce0f47779b0aa069e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"disable_selinux_do_reboot: false"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Avoid a circular dependency on the registry for pulling this image."},{"line_number":7,"context_line":"docker_registry_image: registry"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Use the OpenStack infra\u0027s Dockerhub mirror."},{"line_number":10,"context_line":"docker_registry_mirrors:"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"9fdfeff1_c45140db","line":7,"updated":"2019-01-29 09:43:14.000000000","message":"I put this in the wrong patch. We can remove it when the [DNM] is removed.","commit_id":"507beca9d3a9e0408ed779a24a18d77640c25126"}],"releasenotes/notes/docker-registry-on-seed-2eb4fb643d6fda9a.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0cb5bfdbefe9edad443c2ed55302fc0f08395172","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``docker-registry`` group, which defaults to include the seed. The existing"},{"line_number":6,"context_line":"    behaviour of deploying on the first controller can be retained by removing"},{"line_number":7,"context_line":"    the seed group from ``[docker-registry:children]`` in"},{"line_number":8,"context_line":"    ``$KAYOBE_CONFIG_PATH/inventory/groups` and adding ``controllers[0]`` to a"},{"line_number":9,"context_line":"    ``[docker-registry]`` group in your `hosts` inventory file."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_f044ccb9","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":71},"updated":"2019-01-21 10:59:12.000000000","message":"Annoyingly, you can\u0027t index groups in an inventory. You\u0027d have to add the first controller by name.","commit_id":"a858c661ec94f605f11d64a6916fa77d2b0e8aa8"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"37cc864a82f0f338315b620571588e526691dda4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    ``docker-registry`` group, which defaults to include the seed. The existing"},{"line_number":6,"context_line":"    behaviour of deploying on the first controller can be retained by removing"},{"line_number":7,"context_line":"    the seed group from ``[docker-registry:children]`` in"},{"line_number":8,"context_line":"    ``$KAYOBE_CONFIG_PATH/inventory/groups` and adding ``controllers[0]`` to a"},{"line_number":9,"context_line":"    ``[docker-registry]`` group in your `hosts` inventory file."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fdfeff1_b084d15f","line":8,"range":{"start_line":8,"start_character":68,"end_line":8,"end_character":71},"in_reply_to":"9fdfeff1_f044ccb9","updated":"2019-01-23 14:49:43.000000000","message":"Done","commit_id":"a858c661ec94f605f11d64a6916fa77d2b0e8aa8"}]}
