)]}'
{"ansible/kayobe-target-venv.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            name: pip"},{"line_number":53,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":54,"context_line":"            virtualenv_site_packages: True"},{"line_number":55,"context_line":"          when: ansible_distribution_major_version | int \u003d\u003d 7"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        - name: Ensure kayobe virtualenv has the latest version of pip installed"},{"line_number":58,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_78041218","line":55,"updated":"2020-02-26 16:38:05.000000000","message":"And ansible_os_family \u003d\u003d \u0027RedHat\u0027?","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2ec8c988752c96e90c1632b1f2831f4c25501311","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            name: pip"},{"line_number":53,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":54,"context_line":"            virtualenv_site_packages: True"},{"line_number":55,"context_line":"          when: ansible_distribution_major_version | int \u003d\u003d 7"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        - name: Ensure kayobe virtualenv has the latest version of pip installed"},{"line_number":58,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_bb1e040a","line":55,"in_reply_to":"1fa4df85_78041218","updated":"2020-02-26 16:50:41.000000000","message":"I suppose strictly Ubuntu is not supported here. If we wanted to protect people trying to shoot themselves in the foot we could verify that the seed/overcloud are Centos somewhere and fail early (if we don\u0027t already)?","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a677e637701381d189b51c4b59307b1575bbc8a4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            name: pip"},{"line_number":53,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":54,"context_line":"            virtualenv_site_packages: True"},{"line_number":55,"context_line":"          when: ansible_distribution_major_version | int \u003d\u003d 7"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        - name: Ensure kayobe virtualenv has the latest version of pip installed"},{"line_number":58,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_bb24c40e","line":55,"in_reply_to":"1fa4df85_bb1e040a","updated":"2020-02-26 17:02:54.000000000","message":"I was thinking more specifically about Debian, which was still using versions 7 and 8 not too long ago. We can adopt the fail-early approach if that\u0027s generally preferred.","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f144641e36b2212cb3dc2d7b7fbab06389cb5caa","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            name: pip"},{"line_number":53,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":54,"context_line":"            virtualenv_site_packages: True"},{"line_number":55,"context_line":"          when: ansible_distribution_major_version | int \u003d\u003d 7"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        - name: Ensure kayobe virtualenv has the latest version of pip installed"},{"line_number":58,"context_line":"          pip:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_e04a8053","line":55,"in_reply_to":"1fa4df85_bb24c40e","updated":"2020-02-27 11:14:37.000000000","message":"Yeah strictly we only support CentOS for remote hosts, but it doesn\u0027t hurt to think ahead.","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            name: selinux"},{"line_number":72,"context_line":"            state: latest"},{"line_number":73,"context_line":"            virtualenv: \"{{ virtualenv }}\""},{"line_number":74,"context_line":"          when: ansible_distribution_major_version | int \u003e\u003d 8"},{"line_number":75,"context_line":"      vars:"},{"line_number":76,"context_line":"        # Use the system python interpreter since the virtualenv might not"},{"line_number":77,"context_line":"        # exist."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_1bff1802","line":74,"updated":"2020-02-26 16:38:05.000000000","message":"And ansible_os_family \u003d\u003d \u0027RedHat\u0027?","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"          easy_install:"},{"line_number":94,"context_line":"            name: pip"},{"line_number":95,"context_line":"          become: True"},{"line_number":96,"context_line":"          when: ansible_distribution_major_version | int \u003d\u003d 7"},{"line_number":97,"context_line":"      when: virtualenv is not defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_3b045415","line":96,"updated":"2020-02-26 16:38:05.000000000","message":"And ansible_os_family \u003d\u003d \u0027RedHat\u0027?","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"}],"ansible/kolla-target-venv.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            state: latest"},{"line_number":57,"context_line":"            virtualenv: \"{{ kolla_ansible_target_venv }}\""},{"line_number":58,"context_line":"          become: True"},{"line_number":59,"context_line":"          when: ansible_distribution_major_version | int \u003e\u003d 8"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        - name: Ensure kolla-ansible virtualenv has correct ownership"},{"line_number":62,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_9b122858","line":59,"updated":"2020-02-26 16:38:05.000000000","message":"ansible_os_family \u003d\u003d \u0027RedHat\u0027","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"}],"ansible/network.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a5330f4986196c432d2d2296d545d4a79ff3ca4a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu: \"{{ [veth_bridge_mtu_map.get(interface) | int, item | net_mtu] | max }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    - name: Update a fact containing veth interfaces"},{"line_number":102,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_93750afd","line":99,"range":{"start_line":99,"start_character":53,"end_line":99,"end_character":58},"updated":"2019-02-08 09:34:10.000000000","message":"Does this work if the network has no MTU set, or the interface is not in veth_bridge_mtu_map?","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74f6df6e999ae5ea1407a6a4ede2c480fcf55262","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu: \"{{ [veth_bridge_mtu_map.get(interface) | int, item | net_mtu] | max }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    - name: Update a fact containing veth interfaces"},{"line_number":102,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_18fe1238","line":99,"range":{"start_line":99,"start_character":53,"end_line":99,"end_character":58},"in_reply_to":"9fdfeff1_25c0937c","updated":"2019-02-08 13:36:27.000000000","message":"+1. Just to clarify how it works, there is a check like this in the veth role:\n\n{% if item.mtu is defined and item.mtu %}\nMTU \u003d {{ item.mtu }}\n{% endif %}\n\nSo zero is ignored.","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f4dac2eb42bab28034a4d929265deae756a406e4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu: \"{{ [veth_bridge_mtu_map.get(interface) | int, item | net_mtu] | max }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    - name: Update a fact containing veth interfaces"},{"line_number":102,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_25c0937c","line":99,"range":{"start_line":99,"start_character":53,"end_line":99,"end_character":58},"in_reply_to":"9fdfeff1_73c98623","updated":"2019-02-08 12:03:36.000000000","message":"It looks like the int filter returns zero when the variable is none or if the variable is an empty string, so I guess we need something like:\n\n  \"{{ [veth_bridge_mtu_map.get(interface) | int, item | net_mtu | int] | max }}\"","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c3eecfc9c0a80a52048f81fd40fc8f9c6b699aca","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu: \"{{ [veth_bridge_mtu_map.get(interface) | int, item | net_mtu] | max }}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    - name: Update a fact containing veth interfaces"},{"line_number":102,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fdfeff1_73c98623","line":99,"range":{"start_line":99,"start_character":53,"end_line":99,"end_character":58},"in_reply_to":"9fdfeff1_93750afd","updated":"2019-02-08 09:46:39.000000000","message":"I haven\u0027t tested all possible cases, will do. I\u0027ve set W-1 in the meantime.","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"}],"ansible/roles/disable-selinux/tasks/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure required packages are installed"},{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name: \"{% if ansible_distribution_major_version | int \u003d\u003d 7 %}libselinux-python{% else %}python3-libselinux{% endif %}\""},{"line_number":5,"context_line":"    state: present"},{"line_number":6,"context_line":"  become: True"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_7b196c77","line":4,"updated":"2020-02-26 16:38:05.000000000","message":"And ansible_os_family \u003d\u003d \u0027RedHat\u0027?","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f144641e36b2212cb3dc2d7b7fbab06389cb5caa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure required packages are installed"},{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name: \"{% if ansible_distribution_major_version | int \u003d\u003d 7 %}libselinux-python{% else %}python3-libselinux{% endif %}\""},{"line_number":5,"context_line":"    state: present"},{"line_number":6,"context_line":"  become: True"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_e091209b","line":4,"in_reply_to":"1fa4df85_7b196c77","updated":"2020-02-27 11:14:37.000000000","message":"I\u0027ve added that conditional to the role import.","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"}],"ansible/roles/kolla-ansible/tasks/install.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    state: link"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":98,"context_line":"    - ansible_distribution_major_version|int \u003d\u003d 7"},{"line_number":99,"context_line":"    - ansible_selinux !\u003d False"},{"line_number":100,"context_line":"    - ansible_selinux.status !\u003d \u0027disabled\u0027"},{"line_number":101,"context_line":"    - kolla_ansible_venv_python_major_version | int \u003d\u003d 2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_1b4dd871","line":98,"range":{"start_line":98,"start_character":40,"end_line":98,"end_character":41},"updated":"2020-02-26 16:38:05.000000000","message":"Nit: space around | to match other uses of this pattern","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"}],"ansible/roles/kolla-ansible/templates/globals.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a5330f4986196c432d2d2296d545d4a79ff3ca4a","unresolved":false,"context_lines":[{"line_number":288,"context_line":"#############################"},{"line_number":289,"context_line":"# Ironic options"},{"line_number":290,"context_line":"#############################"},{"line_number":291,"context_line":"{% if kolla_inspector_dhcp_pool_start and kolla_inspector_dhcp_pool_end %}"},{"line_number":292,"context_line":"ironic_dnsmasq_dhcp_range: {{ kolla_inspector_dhcp_pool_start }},{{ kolla_inspector_dhcp_pool_end }}"},{"line_number":293,"context_line":"{% endif %}"},{"line_number":294,"context_line":"{% if kolla_inspector_default_gateway %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_135b5a87","line":291,"range":{"start_line":291,"start_character":6,"end_line":291,"end_character":71},"updated":"2019-02-08 09:34:10.000000000","message":"We actually had an issue with this yesterday - this was evaluating as true, even though there was no inspection network allocation pool defined.","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c3eecfc9c0a80a52048f81fd40fc8f9c6b699aca","unresolved":false,"context_lines":[{"line_number":288,"context_line":"#############################"},{"line_number":289,"context_line":"# Ironic options"},{"line_number":290,"context_line":"#############################"},{"line_number":291,"context_line":"{% if kolla_inspector_dhcp_pool_start and kolla_inspector_dhcp_pool_end %}"},{"line_number":292,"context_line":"ironic_dnsmasq_dhcp_range: {{ kolla_inspector_dhcp_pool_start }},{{ kolla_inspector_dhcp_pool_end }}"},{"line_number":293,"context_line":"{% endif %}"},{"line_number":294,"context_line":"{% if kolla_inspector_default_gateway %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fdfeff1_33a1be47","line":291,"range":{"start_line":291,"start_character":6,"end_line":291,"end_character":71},"in_reply_to":"9fdfeff1_135b5a87","updated":"2019-02-08 09:46:39.000000000","message":"With Python 2.7? I assumed it was a Python 3 issue, but I don\u0027t think I ran `overcloud host configure` completely with Python 2.7 using master.","commit_id":"e6b9b2ce6db45c2bb5251d701716fc70c48c5e2a"}],"ansible/roles/kolla-ansible/templates/requirements.txt.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bd89823a6746951774b99cbd74ba582158cb6be5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# Limit the version of ansible used by kolla-ansible to avoid new releases from"},{"line_number":9,"context_line":"# breaking tested code. Changes to this limit should be tested."},{"line_number":10,"context_line":"ansible\u003e\u003d2.6,\u003c2.9"},{"line_number":11,"context_line":"{% if ansible_os_family \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version|int \u003e\u003d 8 %}"},{"line_number":12,"context_line":"selinux"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":"{% if kolla_ansible_venv_extra_requirements is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1fa4df85_bb6604ed","line":11,"range":{"start_line":11,"start_character":74,"end_line":11,"end_character":75},"updated":"2020-02-26 16:38:05.000000000","message":"Nit: spaces","commit_id":"78d2fdfdbabd3a4904dbfbf53eaa5b02d084bdb7"}]}