)]}'
{"ansible/roles/kolla-ansible/library/kolla_passwords.py":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4544a8912fdcabd5e768dde901fa4ebbdcad4bc1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        if module.params[\u0027src\u0027] and os.path.isfile(module.params[\u0027src\u0027]):"},{"line_number":118,"context_line":"            src_path \u003d create_named_tempfile()"},{"line_number":119,"context_line":"            try:"},{"line_number":120,"context_line":"                shutil.copy2(module.params[\u0027src\u0027], src_path)"},{"line_number":121,"context_line":"                if module.params[\u0027vault_password\u0027]:"},{"line_number":122,"context_line":"                    vault_decrypt(module, src_path)"},{"line_number":123,"context_line":"                kolla_mergepwd(module, src_path, temp_file_path, temp_file_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_64539a6c","line":120,"updated":"2019-03-26 15:25:52.000000000","message":"I presume this is why we lost the 600 file permissions. Should we set the umask somewhere?","commit_id":"dc082b1921794d8ee63c0df3f17de73ec1bdefe7"}],"releasenotes/notes/passwords-in-tmp-18e55d5e9b894b4d.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0cd0f1e0ba9e08dc94e32515301f668d6dc20a1c","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    It is recommended to check any systems on which Kayobe has been run for"},{"line_number":9,"context_line":"    copies of the passwords file in /tmp. A simple check for this is `grep -rn"},{"line_number":10,"context_line":"    database_password /tmp`."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Fixes an issue when generating the ``passwords.yml`` file for Kolla Ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_184eba37","line":10,"updated":"2019-03-26 15:46:19.000000000","message":"Should we mention the permissions change?","commit_id":"9117793c07ff020f0ce859cb03acbf5a170701c5"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"f3cc1352cbff8a91668735ab143ea8bae5c79f0b","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    It is recommended to check any systems on which Kayobe has been run for"},{"line_number":9,"context_line":"    copies of the passwords file in /tmp. A simple check for this is `grep -rn"},{"line_number":10,"context_line":"    database_password /tmp`."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Fixes an issue when generating the ``passwords.yml`` file for Kolla Ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_3b229053","line":10,"in_reply_to":"5fc1f717_184eba37","updated":"2019-03-26 16:21:35.000000000","message":"imo yeah, as the permissions is potentially part of the security issue.","commit_id":"9117793c07ff020f0ce859cb03acbf5a170701c5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3ee6439b666c75432c15c5564ca8bd235ef47121","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    It is recommended to check any systems on which Kayobe has been run for"},{"line_number":9,"context_line":"    copies of the passwords file in /tmp. A simple check for this is `grep -rn"},{"line_number":10,"context_line":"    database_password /tmp`."},{"line_number":11,"context_line":"fixes:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Fixes an issue when generating the ``passwords.yml`` file for Kolla Ansible"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5fc1f717_fb4ba8ad","line":10,"in_reply_to":"5fc1f717_3b229053","updated":"2019-03-26 16:28:18.000000000","message":"Good plan, done.","commit_id":"9117793c07ff020f0ce859cb03acbf5a170701c5"}]}
