)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7b111f09a141b0b6a319b7655ecb56fa8e5177c1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Added tests and documentation to add support for keystone extra configuration"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I79d0bfaac5d8191ed5a7558e87da9a3541384537"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Added kolla_enable_keystone tokayobe/kolla + defaults/main"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fce034c_101948d6","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":52},"updated":"2019-04-12 09:04:36.000000000","message":"Surprised it doesn\u0027t barf at the double change ID, but seems ok.","commit_id":"e71118d7ea41d3f35850b61bf5610805d3734b42"}],"ansible/group_vars/all/monitoring":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"92ece84b10333dc18cdbebe3f3ddcde4028f71ac","unresolved":false,"context_lines":[{"line_number":20,"context_line":"monitoring_default_network_interfaces: \u003e"},{"line_number":21,"context_line":"  {{ [admin_oc_net_name,"},{"line_number":22,"context_line":"      internal_net_name,"},{"line_number":23,"context_line":"      public_net_name] | reject(\u0027none\u0027) | unique | list }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# List of extra networks to which monitoring nodes are attached."},{"line_number":26,"context_line":"monitoring_extra_network_interfaces: []"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_0aeeae87","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":39},"updated":"2019-05-09 17:24:37.000000000","message":"Is this reject required? It wasn\u0027t used for some other host types, like compute and controllers.","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"29a9c3817160e0d96b8a7cb3c5789744fc96f206","unresolved":false,"context_lines":[{"line_number":20,"context_line":"monitoring_default_network_interfaces: \u003e"},{"line_number":21,"context_line":"  {{ [admin_oc_net_name,"},{"line_number":22,"context_line":"      internal_net_name,"},{"line_number":23,"context_line":"      public_net_name] | reject(\u0027none\u0027) | unique | list }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# List of extra networks to which monitoring nodes are attached."},{"line_number":26,"context_line":"monitoring_extra_network_interfaces: []"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"bfb3d3c7_01da5916","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":39},"in_reply_to":"dfbec78f_0aeeae87","updated":"2019-05-20 14:29:36.000000000","message":"I think it makes sense to add it to defaults, in case user config references it. I\u0027ve checked and we\u0027re doing that everywhere now. It\u0027s possible it was done in some places in the recent Swift changes.","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"}],"ansible/group_vars/all/seed":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"92ece84b10333dc18cdbebe3f3ddcde4028f71ac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"seed_default_network_interfaces: \u003e"},{"line_number":19,"context_line":"  {{ [admin_oc_net_name,"},{"line_number":20,"context_line":"      oob_oc_net_name,"},{"line_number":21,"context_line":"      provision_oc_net_name] | reject(\u0027none\u0027) | unique | list }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# List of extra networks to which seed nodes are attached."},{"line_number":24,"context_line":"seed_extra_network_interfaces: []"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_aa04424b","line":21,"range":{"start_line":21,"start_character":31,"end_line":21,"end_character":45},"updated":"2019-05-09 17:24:37.000000000","message":"Is this reject required? It wasn\u0027t used for some other host types, like compute and controllers.","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"}],"ansible/group_vars/all/storage":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"92ece84b10333dc18cdbebe3f3ddcde4028f71ac","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# Storage network interface configuration."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# List of networks to which storage nodes are attached."},{"line_number":13,"context_line":"storage_network_interfaces: \u003e"},{"line_number":14,"context_line":"  {{ (storage_default_network_interfaces +"},{"line_number":15,"context_line":"      storage_extra_network_interfaces) | unique | list }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# List of default networks to which storage nodes are attached."},{"line_number":18,"context_line":"storage_default_network_interfaces: \u003e"},{"line_number":19,"context_line":"  {{ [admin_oc_net_name,"},{"line_number":20,"context_line":"      internal_net_name,"},{"line_number":21,"context_line":"      storage_mgmt_net_name,"},{"line_number":22,"context_line":"      storage_net_name] | reject(\u0027none\u0027) | unique | list }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# List of extra networks to which storage nodes are attached."},{"line_number":25,"context_line":"storage_extra_network_interfaces: []"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dfbec78f_8af93e4e","line":22,"range":{"start_line":13,"start_character":0,"end_line":22,"end_character":59},"updated":"2019-05-09 17:24:37.000000000","message":"Other host types have the reject filter in *_network_interfaces rather than *_default_network_interfaces.","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"}],"ansible/roles/kolla-openstack/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7b111f09a141b0b6a319b7655ecb56fa8e5177c1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"kolla_enable_haproxy:"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"###############################################################################"},{"line_number":70,"context_line":"# HAProxy configuration."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Whether to enable HAProxy."},{"line_number":73,"context_line":"kolla_enable_keystone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_b082b4c7","line":70,"range":{"start_line":70,"start_character":2,"end_line":70,"end_character":9},"updated":"2019-04-12 09:04:36.000000000","message":"nit: keystone","commit_id":"e71118d7ea41d3f35850b61bf5610805d3734b42"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7b111f09a141b0b6a319b7655ecb56fa8e5177c1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"###############################################################################"},{"line_number":70,"context_line":"# HAProxy configuration."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Whether to enable HAProxy."},{"line_number":73,"context_line":"kolla_enable_keystone:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"##############################################################################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_d08740d7","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":27},"updated":"2019-04-12 09:04:36.000000000","message":"nit: keystone","commit_id":"e71118d7ea41d3f35850b61bf5610805d3734b42"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7b111f09a141b0b6a319b7655ecb56fa8e5177c1","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# HAProxy configuration."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Whether to enable HAProxy."},{"line_number":73,"context_line":"kolla_enable_keystone:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"##############################################################################"},{"line_number":76,"context_line":"# Heat configuration."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fce034c_f0783cf9","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":21},"updated":"2019-04-12 09:04:36.000000000","message":"I think the default role test will fail if you don\u0027t include a default for kolla_extra_keystone here.","commit_id":"e71118d7ea41d3f35850b61bf5610805d3734b42"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"92ece84b10333dc18cdbebe3f3ddcde4028f71ac","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Whether to enable Keystone."},{"line_number":73,"context_line":"kolla_enable_keystone:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# From form extra configuration to append to Keystone.conf"},{"line_number":76,"context_line":"kolla_extra_keystone:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"##############################################################################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_4a99061d","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":6},"updated":"2019-05-09 17:24:37.000000000","message":"Free","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"29a9c3817160e0d96b8a7cb3c5789744fc96f206","unresolved":false,"context_lines":[{"line_number":72,"context_line":"# Whether to enable Keystone."},{"line_number":73,"context_line":"kolla_enable_keystone:"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# From form extra configuration to append to Keystone.conf"},{"line_number":76,"context_line":"kolla_extra_keystone:"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"##############################################################################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfb3d3c7_8134094c","line":75,"range":{"start_line":75,"start_character":2,"end_line":75,"end_character":6},"in_reply_to":"dfbec78f_4a99061d","updated":"2019-05-20 14:29:36.000000000","message":"Done","commit_id":"71f66c4c5a58640bf8232899ed10005bf0d12d31"}]}