)]}'
{"ansible/kolla-target-venv.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"42ec9df5f54fd4e53ec140fc7d9f6a0536ee9ed7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    #      - controllers"},{"line_number":14,"context_line":"    overcloud_nodes_in_kolla_inventory: \u003e-"},{"line_number":15,"context_line":"      {{ kolla_overcloud_inventory_top_level_group_map |"},{"line_number":16,"context_line":"      json_query(\u0027*.groups\u0027) | flatten | unique | join(\u0027:\u0027) }}"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - kolla-ansible"},{"line_number":19,"context_line":"    - kolla-target-venv"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_e56514b6","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":16},"updated":"2019-07-18 14:42:25.000000000","message":"You\u0027ll need to add jmespath to requirements to use json_query.","commit_id":"91ce079a81cfce218c94930f0aeaa2575fe95c7d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dc4341d75f1d0bc6fa88df9de6f76140993382b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    #      - controllers"},{"line_number":14,"context_line":"    overcloud_nodes_in_kolla_inventory: \u003e-"},{"line_number":15,"context_line":"      {{ kolla_overcloud_inventory_top_level_group_map |"},{"line_number":16,"context_line":"      json_query(\u0027*.groups\u0027) | flatten | unique | join(\u0027:\u0027) }}"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - kolla-ansible"},{"line_number":19,"context_line":"    - kolla-target-venv"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_03bec4ad","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":16},"in_reply_to":"7faddb67_3ea041f4","updated":"2019-08-27 16:23:37.000000000","message":"Isn\u0027t `overcloud_nodes_in_kolla_inventory` a playbook var here? Not sure why this wouldn\u0027t work.","commit_id":"91ce079a81cfce218c94930f0aeaa2575fe95c7d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0033cdd2dd71673dba743c126395bba28db142d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    #      - controllers"},{"line_number":14,"context_line":"    overcloud_nodes_in_kolla_inventory: \u003e-"},{"line_number":15,"context_line":"      {{ kolla_overcloud_inventory_top_level_group_map |"},{"line_number":16,"context_line":"      json_query(\u0027*.groups\u0027) | flatten | unique | join(\u0027:\u0027) }}"},{"line_number":17,"context_line":"  tags:"},{"line_number":18,"context_line":"    - kolla-ansible"},{"line_number":19,"context_line":"    - kolla-target-venv"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_3ea041f4","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":16},"in_reply_to":"7faddb67_e56514b6","updated":"2019-08-02 10:56:30.000000000","message":"Alternatively,\n\n    overcloud_nodes_in_kolla_inventory: \u003e-\n      {{ kolla_overcloud_inventory_top_level_group_map.values() |\n      map(attribute\u003d\u0027groups\u0027) | flatten | unique | join(\u0027:\u0027) }}\n\nDoes this work when overcloud_nodes_in_kolla_inventory has not been overridden? I seem to remember having to redefine swift_hosts as a play var in swift-block-devices.yml in order to use it as a host target. We could get around this by adding an additional condition to the block.","commit_id":"91ce079a81cfce218c94930f0aeaa2575fe95c7d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3922df31442dc9e5a31e8251285d84318990cd45","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            group: \"{{ kolla_ansible_group }}\""},{"line_number":53,"context_line":"          become: True"},{"line_number":54,"context_line":"      when: |"},{"line_number":55,"context_line":"              kolla_ansible_target_venv is not none and"},{"line_number":56,"context_line":"                inventory_hostname in query(\u0027inventory_hostnames\u0027, overcloud_nodes_in_kolla_inventory)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_dff5d9cd","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":102},"updated":"2019-08-27 16:14:11.000000000","message":"why not use when list syntax?\n\nwhen:\n  - kolla_ansible_target_venv is not none\n  - inventory_hostname in query(\u0027inventory_hostnames\u0027, overcloud_nodes_in_kolla_inventory)\n\nalso, nit: indentation","commit_id":"cc75f4b4cc7209e18d940f310a8a6dc70400baac"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dc4341d75f1d0bc6fa88df9de6f76140993382b6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            group: \"{{ kolla_ansible_group }}\""},{"line_number":53,"context_line":"          become: True"},{"line_number":54,"context_line":"      when: |"},{"line_number":55,"context_line":"              kolla_ansible_target_venv is not none and"},{"line_number":56,"context_line":"                inventory_hostname in query(\u0027inventory_hostnames\u0027, overcloud_nodes_in_kolla_inventory)"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_bfd25dfc","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":102},"in_reply_to":"7faddb67_dff5d9cd","updated":"2019-08-27 16:23:37.000000000","message":"good point.","commit_id":"cc75f4b4cc7209e18d940f310a8a6dc70400baac"}]}