)]}'
{"ansible/baremetal-compute-provide.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"b74fbf518986563021ef34d0db3dfed9a27f5e59","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# it when executing the stackhpc.os-ironic-state role."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure baremetal compute nodes are available in ironic"},{"line_number":10,"context_line":"  hosts: controllers[0]"},{"line_number":11,"context_line":"  gather_facts: true"},{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    venv: \"{{ virtualenv_path }}/shade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_5c19d61f","line":10,"updated":"2019-11-14 14:41:43.000000000","message":"Since these api calls are being done on the controller, wouldn\u0027t it make sense to always use the internal interface?","commit_id":"a022c963554e2e41b0a046f9e0fe226637ec7428"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cdcfe932f973ba40a9716bf4526abd9d08d3b150","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# it when executing the stackhpc.os-ironic-state role."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure baremetal compute nodes are available in ironic"},{"line_number":10,"context_line":"  hosts: controllers[0]"},{"line_number":11,"context_line":"  gather_facts: true"},{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    venv: \"{{ virtualenv_path }}/shade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_dc8146fd","line":10,"in_reply_to":"3fa7e38b_5c19d61f","updated":"2019-11-14 14:48:37.000000000","message":"Why make it fixed? We instruct the user to source admin-openrc.sh, shouldn\u0027t we honour it? It will be internal by default.","commit_id":"a022c963554e2e41b0a046f9e0fe226637ec7428"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9615c7375ee8d4549ab6d20c2688af15127e9e5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# it when executing the stackhpc.os-ironic-state role."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure baremetal compute nodes are available in ironic"},{"line_number":10,"context_line":"  hosts: controllers[0]"},{"line_number":11,"context_line":"  gather_facts: true"},{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    venv: \"{{ virtualenv_path }}/shade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_18976792","line":10,"in_reply_to":"3fa7e38b_5c46b6c2","updated":"2019-11-25 14:02:47.000000000","message":"ok, I guess it makes sense.","commit_id":"a022c963554e2e41b0a046f9e0fe226637ec7428"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"69248d4e7f89cc94d7d75b0875a626983a8abd44","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# it when executing the stackhpc.os-ironic-state role."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure baremetal compute nodes are available in ironic"},{"line_number":10,"context_line":"  hosts: controllers[0]"},{"line_number":11,"context_line":"  gather_facts: true"},{"line_number":12,"context_line":"  vars:"},{"line_number":13,"context_line":"    venv: \"{{ virtualenv_path }}/shade\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_5c46b6c2","line":10,"in_reply_to":"3fa7e38b_dc8146fd","updated":"2019-11-14 14:55:45.000000000","message":"Seems like we are leaking an implementation detail. If my ansible control host can hit the public api but the controllers can\u0027t, I would still expect this command to work to work with OS_INTERFACE\u003dpublic.","commit_id":"a022c963554e2e41b0a046f9e0fe226637ec7428"}],"ansible/provision-net.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8b807538c7b1b0f36b327059d20dd0f465e24906","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            cacert: \"{{ openstack_cacert | default(omit, true) }}\""},{"line_number":117,"context_line":"            interface: \"{{ openstack_interface | default(omit, true) }}\""},{"line_number":118,"context_line":"            name: \"{{ cleaning_net.name }}\""},{"line_number":119,"context_line":"            interface: internal"},{"line_number":120,"context_line":"          register: cleaning_network_facts"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        - name: Set cleaning network to unshared"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_de5dfe7c","line":119,"updated":"2019-11-28 16:52:27.000000000","message":"Remove?","commit_id":"72b5f1170667b533c32a40fbb077a23ab391ad66"}]}