)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add framework to deploy user-defined containers on seed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6f065073feee42b2a0921a4aea98f7004fe5f7bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1fa4df85_e6b493d3","line":9,"updated":"2020-03-03 18:15:52.000000000","message":"Story/task","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add framework to deploy user-defined containers on seed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6f065073feee42b2a0921a4aea98f7004fe5f7bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1fa4df85_351c2a69","line":9,"in_reply_to":"1fa4df85_e6b493d3","updated":"2020-03-18 18:14:01.000000000","message":"Bump","commit_id":"32f238cd5485d093c559526e6434028529577c1e"}],"ansible/group_vars/all/seed":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# Seed node additional containers configuration"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"# List of additional containers to deploy"},{"line_number":95,"context_line":"# Example:"},{"line_number":96,"context_line":"seed_containers: {}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1fa4df85_26538b41","line":95,"range":{"start_line":95,"start_character":2,"end_line":95,"end_character":9},"updated":"2020-03-03 18:15:52.000000000","message":"Either remove or provide an example :)","commit_id":"32f238cd5485d093c559526e6434028529577c1e"}],"ansible/roles/deploy-containers/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_api_timeout: \"120\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"container_config_defaults:"},{"line_number":5,"context_line":"  capabilities: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_e1247db1","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":18},"updated":"2020-03-03 18:15:52.000000000","message":"Is this something we should be using elsewhere when interacting with docker?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_api_timeout: \"120\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"container_config_defaults:"},{"line_number":5,"context_line":"  capabilities: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_9cebe210","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":18},"in_reply_to":"1fa4df85_e1247db1","updated":"2020-03-17 13:07:36.000000000","message":"Well, probably it would be useful - I just saw timeouts on my VM when running tests, are there other places in Kayobe where we interact with docker?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_api_timeout: \"120\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"container_config_defaults:"},{"line_number":5,"context_line":"  capabilities: []"},{"line_number":6,"context_line":"  command: \"\""},{"line_number":7,"context_line":"  comparisons:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_a111a554","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":25},"updated":"2020-03-03 18:15:52.000000000","message":"nit: normally role defaults are prefixed with the role name.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_api_timeout: \"120\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"container_config_defaults:"},{"line_number":5,"context_line":"  capabilities: []"},{"line_number":6,"context_line":"  command: \"\""},{"line_number":7,"context_line":"  comparisons:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_bc47bebc","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":25},"in_reply_to":"1fa4df85_a111a554","updated":"2020-03-17 13:07:36.000000000","message":"Changed.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  capabilities: []"},{"line_number":6,"context_line":"  command: \"\""},{"line_number":7,"context_line":"  comparisons:"},{"line_number":8,"context_line":"    image: ignore # don\u0027t restart containers with older versions of the image"},{"line_number":9,"context_line":"    env: strict"},{"line_number":10,"context_line":"    volumes: strict"},{"line_number":11,"context_line":"  detach: True"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_e15c7dee","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":77},"updated":"2020-03-03 18:15:52.000000000","message":"Doesn\u0027t this mean we\u0027ll never update containers?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  capabilities: []"},{"line_number":6,"context_line":"  command: \"\""},{"line_number":7,"context_line":"  comparisons:"},{"line_number":8,"context_line":"    image: ignore # don\u0027t restart containers with older versions of the image"},{"line_number":9,"context_line":"    env: strict"},{"line_number":10,"context_line":"    volumes: strict"},{"line_number":11,"context_line":"  detach: True"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_fcdbf679","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":77},"in_reply_to":"1fa4df85_e15c7dee","updated":"2020-03-17 13:07:36.000000000","message":"Well, might be - I\u0027ll add strict here :-) It was just copy pasted from Ansible docs...","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  sysctls: {}"},{"line_number":20,"context_line":"  ulimits: []"},{"line_number":21,"context_line":"  user: \"\""},{"line_number":22,"context_line":"  volumes: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_4100f1ab","line":22,"updated":"2020-03-03 18:15:52.000000000","message":"A lot of these look like they could take the default value. e.g.\n\ncontainer.volumes | default(container_config_defaults.volumes) | default(omit)","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  sysctls: {}"},{"line_number":20,"context_line":"  ulimits: []"},{"line_number":21,"context_line":"  user: \"\""},{"line_number":22,"context_line":"  volumes: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_9592be9e","line":22,"in_reply_to":"1fa4df85_3c598efd","updated":"2020-03-18 18:14:01.000000000","message":"Maybe I meant this:\n\ncontainer.volume | default(omit)\n\nOr is the idea that this variable provides defaults for all containers?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  sysctls: {}"},{"line_number":20,"context_line":"  ulimits: []"},{"line_number":21,"context_line":"  user: \"\""},{"line_number":22,"context_line":"  volumes: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_3c598efd","line":22,"in_reply_to":"1fa4df85_4100f1ab","updated":"2020-03-17 13:07:36.000000000","message":"I think it\u0027s that way in tasks/deploy.yml, or I did not understand the recommendation? ;-)","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  sysctls: {}"},{"line_number":20,"context_line":"  ulimits: []"},{"line_number":21,"context_line":"  user: \"\""},{"line_number":22,"context_line":"  volumes: []"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_cf234fa6","line":22,"in_reply_to":"1fa4df85_9592be9e","updated":"2020-06-04 07:24:16.000000000","message":"I rather had the idea that this provides defaults - which you can set in Kayobe globals/group_vars - but I guess it\u0027s additional complexity which never will be used :-) Let me switch to default(omit) in deploy.yml","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d0ec0ce6df324c5420aa862de69a1811d1dbe01f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_api_timeout: \"120\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"deploy_containers_defaults:"},{"line_number":5,"context_line":"  comparisons:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff570b3c_b54e2c94","line":2,"updated":"2020-05-20 09:25:14.000000000","message":"should this be `deploy_containers_docker_api_timeout` as that is how it is referenced in deploy.yml?","commit_id":"990805602333e8c16616c7c205ce0807cf4347cb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c673d5f0c311d965b80f7e7817a639c199ab4cdf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    env: strict"},{"line_number":6,"context_line":"    volumes: strict"},{"line_number":7,"context_line":"  detach: True"},{"line_number":8,"context_line":"  docker_api_timeout: \"120\""},{"line_number":9,"context_line":"  network_mode: \"host\""},{"line_number":10,"context_line":"  init: True"},{"line_number":11,"context_line":"  privileged: False"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_930d7237","line":8,"updated":"2020-05-28 12:55:00.000000000","message":"It should still be a top-level variable, but the name should be deploy_containers_docker_api_timeout.","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    env: strict"},{"line_number":6,"context_line":"    volumes: strict"},{"line_number":7,"context_line":"  detach: True"},{"line_number":8,"context_line":"  docker_api_timeout: \"120\""},{"line_number":9,"context_line":"  network_mode: \"host\""},{"line_number":10,"context_line":"  init: True"},{"line_number":11,"context_line":"  privileged: False"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_e6000069","line":8,"in_reply_to":"ff570b3c_930d7237","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"}],"ansible/roles/deploy-containers/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: \"[{{ container_key }}] Ensure we have latest image\""},{"line_number":3,"context_line":"  docker_image:"},{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_e15ebd74","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":16},"updated":"2020-03-03 18:15:52.000000000","message":"We don\u0027t generally pull the latest images in a \u0027deploy\u0027, but we also don\u0027t have a \u0027pull\u0027 for seed images either. Not sure if it\u0027s a problem - the only time it makes a difference is if the image changes without changing the tag, then a pull forces the image to be updated.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: \"[{{ container_key }}] Ensure we have latest image\""},{"line_number":3,"context_line":"  docker_image:"},{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_3c0e6ee5","line":5,"range":{"start_line":2,"start_character":0,"end_line":5,"end_character":16},"in_reply_to":"1fa4df85_e15ebd74","updated":"2020-03-17 13:07:36.000000000","message":"Added tag:","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_a120c549","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":47},"updated":"2020-03-03 18:15:52.000000000","message":"tasks file","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_9c2d22ff","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":47},"in_reply_to":"1fa4df85_a120c549","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_61164df4","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":9},"updated":"2020-03-03 18:15:52.000000000","message":"include_tasks","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    source: pull"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_3c342e4a","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":9},"in_reply_to":"1fa4df85_61164df4","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""},{"line_number":12,"context_line":"  docker_container:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_81a4a9a7","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":55},"updated":"2020-03-03 18:15:52.000000000","message":"when: container_config.pre is defined?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: \"[{{ container_key }}] Include playbook for pre task(s)\""},{"line_number":8,"context_line":"  include: \"{{ container_config.pre }}\""},{"line_number":9,"context_line":"  when: (container_config.pre | default()) | length \u003e 0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""},{"line_number":12,"context_line":"  docker_container:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_7cd2a636","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":55},"in_reply_to":"1fa4df85_81a4a9a7","updated":"2020-03-17 13:07:36.000000000","message":"right :)","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""},{"line_number":12,"context_line":"  docker_container:"},{"line_number":13,"context_line":"    capabilities: \"{{ container_config.capabilities | default(container_config_defaults.capabilities }}\""},{"line_number":14,"context_line":"    command: \"{{ container_config.command | default(container_config_defaults.command) }}\""},{"line_number":15,"context_line":"    comparisons: \"{{ container_config_defaults.comparisons }}\""},{"line_number":16,"context_line":"    detach: \"{{ container_config.detach | default(container_config_defaults.detach) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_21bff5b0","line":13,"range":{"start_line":13,"start_character":54,"end_line":13,"end_character":100},"updated":"2020-03-03 18:15:52.000000000","message":"Missing )","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_key }}] Start container\""},{"line_number":12,"context_line":"  docker_container:"},{"line_number":13,"context_line":"    capabilities: \"{{ container_config.capabilities | default(container_config_defaults.capabilities }}\""},{"line_number":14,"context_line":"    command: \"{{ container_config.command | default(container_config_defaults.command) }}\""},{"line_number":15,"context_line":"    comparisons: \"{{ container_config_defaults.comparisons }}\""},{"line_number":16,"context_line":"    detach: \"{{ container_config.detach | default(container_config_defaults.detach) }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_5c37aa4e","line":13,"range":{"start_line":13,"start_character":54,"end_line":13,"end_character":100},"in_reply_to":"1fa4df85_21bff5b0","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    user: \"{{ container_config.user | default(container_config_defaults.user) }}\""},{"line_number":30,"context_line":"    volumes: \"{{ container_config.volumes | default(container_config_defaults.volumes) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"[{{ container_key }}] Include playbook for post task(s)\""},{"line_number":33,"context_line":"  include: \"{{ container_config.post }}\""},{"line_number":34,"context_line":"  when: (container_config.post | default()) | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_4119d11f","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":47},"updated":"2020-03-03 18:15:52.000000000","message":"tasks file","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    user: \"{{ container_config.user | default(container_config_defaults.user) }}\""},{"line_number":30,"context_line":"    volumes: \"{{ container_config.volumes | default(container_config_defaults.volumes) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"[{{ container_key }}] Include playbook for post task(s)\""},{"line_number":33,"context_line":"  include: \"{{ container_config.post }}\""},{"line_number":34,"context_line":"  when: (container_config.post | default()) | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_fc3d362c","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":47},"in_reply_to":"1fa4df85_4119d11f","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    volumes: \"{{ container_config.volumes | default(container_config_defaults.volumes) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"[{{ container_key }}] Include playbook for post task(s)\""},{"line_number":33,"context_line":"  include: \"{{ container_config.post }}\""},{"line_number":34,"context_line":"  when: (container_config.post | default()) | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_e1df9d37","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":9},"updated":"2020-03-03 18:15:52.000000000","message":"include_tasks","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    volumes: \"{{ container_config.volumes | default(container_config_defaults.volumes) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: \"[{{ container_key }}] Include playbook for post task(s)\""},{"line_number":33,"context_line":"  include: \"{{ container_config.post }}\""},{"line_number":34,"context_line":"  when: (container_config.post | default()) | length \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1fa4df85_1c39323e","line":33,"range":{"start_line":33,"start_character":2,"end_line":33,"end_character":9},"in_reply_to":"1fa4df85_e1df9d37","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"[{{ container_key }}] Ensure we have latest image\""},{"line_number":3,"context_line":"  docker_image:"},{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    tag: \"{{ container_config.tag }}\""},{"line_number":6,"context_line":"    source: pull"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: \"[{{ container_key }}] Include tasks file for pre task(s)\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_10025c0a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":37},"updated":"2020-03-18 18:14:01.000000000","message":"We probably need to include this in the image name, because the docker_container module doesn\u0027t have a tag parameter.","commit_id":"beee85c7748706ca388a79d002557964f5847e87"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"[{{ container_key }}] Ensure we have latest image\""},{"line_number":3,"context_line":"  docker_image:"},{"line_number":4,"context_line":"    name: \"{{ container_config.image }}\""},{"line_number":5,"context_line":"    tag: \"{{ container_config.tag }}\""},{"line_number":6,"context_line":"    source: pull"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: \"[{{ container_key }}] Include tasks file for pre task(s)\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_547a36b9","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":37},"in_reply_to":"1fa4df85_10025c0a","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"beee85c7748706ca388a79d002557964f5847e87"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    privileged: \"{{ container_config.privileged | default(deploy_containers_defaults.privileged) }}\""},{"line_number":26,"context_line":"    restart_policy: \"{{ container_config.restart_policy | default(deploy_containers_defaults.restart_policy) }}\""},{"line_number":27,"context_line":"    sysctls: \"{{ container_config.sysctls | default(deploy_containers_defaults.sysctls) }}\""},{"line_number":28,"context_line":"    tag: \"{{ container_config.tag }}\""},{"line_number":29,"context_line":"    timeout: \"{{ deploy_containers_docker_api_timeout }}\""},{"line_number":30,"context_line":"    ulimits: \"{{ container_config.ulimits | default(deploy_containers_defaults.ulimits) }}\""},{"line_number":31,"context_line":"    user: \"{{ container_config.user | default(deploy_containers_defaults.user) }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_7524e2c6","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":7},"updated":"2020-03-18 18:14:01.000000000","message":"Not a docker_container parameter.","commit_id":"beee85c7748706ca388a79d002557964f5847e87"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    privileged: \"{{ container_config.privileged | default(deploy_containers_defaults.privileged) }}\""},{"line_number":26,"context_line":"    restart_policy: \"{{ container_config.restart_policy | default(deploy_containers_defaults.restart_policy) }}\""},{"line_number":27,"context_line":"    sysctls: \"{{ container_config.sysctls | default(deploy_containers_defaults.sysctls) }}\""},{"line_number":28,"context_line":"    tag: \"{{ container_config.tag }}\""},{"line_number":29,"context_line":"    timeout: \"{{ deploy_containers_docker_api_timeout }}\""},{"line_number":30,"context_line":"    ulimits: \"{{ container_config.ulimits | default(deploy_containers_defaults.ulimits) }}\""},{"line_number":31,"context_line":"    user: \"{{ container_config.user | default(deploy_containers_defaults.user) }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_b44e3294","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":7},"in_reply_to":"1fa4df85_7524e2c6","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"beee85c7748706ca388a79d002557964f5847e87"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d0ec0ce6df324c5420aa862de69a1811d1dbe01f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: container_config.pre is defined"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: \"[{{ container_name }}] Start container\""},{"line_number":12,"context_line":"  docker_container:"},{"line_number":13,"context_line":"    capabilities: \"{{ container_config.capabilities | default(omit) }}\""},{"line_number":14,"context_line":"    command: \"{{ container_config.command | default(omit) }}\""},{"line_number":15,"context_line":"    comparisons: \"{{ container_config.comparisons | default(deploy_containers_defaults.comparisons) }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff570b3c_1586f8b9","line":12,"updated":"2020-05-20 09:25:14.000000000","message":"Worth adding:\n\n  ports: \"{{ container_config.ports | default(omit) }}\"\n\nas well?","commit_id":"990805602333e8c16616c7c205ce0807cf4347cb"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d0ec0ce6df324c5420aa862de69a1811d1dbe01f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    env: \"{{ container_config.env | default(omit) }}\""},{"line_number":18,"context_line":"    name: \"{{ container_name }}\""},{"line_number":19,"context_line":"    network_mode: \"{{ container_config.network_mode | default(deploy_containers_defaults.network_mode) }}\""},{"line_number":20,"context_line":"    image: \"{{ container_config.image }}\""},{"line_number":21,"context_line":"    init: \"{{ container_config.init | default(deploy_containers_defaults.init) }}\""},{"line_number":22,"context_line":"    ipc_mode: \"{{ container_config.ipc_mode | default(omit) }}\""},{"line_number":23,"context_line":"    pid_mode: \"{{ container_config.pid_mode | default(omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ff570b3c_55a51046","line":20,"updated":"2020-05-20 09:25:14.000000000","message":"Could we use:\n\n  image: \"{{ container_config.image }}:{{ container_config.tag }}\"\n\nand keep the tag separate?","commit_id":"990805602333e8c16616c7c205ce0807cf4347cb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c673d5f0c311d965b80f7e7817a639c199ab4cdf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    env: \"{{ container_config.env | default(omit) }}\""},{"line_number":19,"context_line":"    name: \"{{ container_name }}\""},{"line_number":20,"context_line":"    network_mode: \"{{ container_config.network_mode | default(deploy_containers_defaults.network_mode) }}\""},{"line_number":21,"context_line":"    image: \"{{ container_config.image }}:{{ container_config.tag | default(omit) }}\""},{"line_number":22,"context_line":"    init: \"{{ container_config.init | default(deploy_containers_defaults.init) }}\""},{"line_number":23,"context_line":"    ipc_mode: \"{{ container_config.ipc_mode | default(omit) }}\""},{"line_number":24,"context_line":"    pid_mode: \"{{ container_config.pid_mode | default(omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_3328e684","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":80},"updated":"2020-05-28 12:55:00.000000000","message":"omit isn\u0027t going to work here. The default of the docker_image module is \u0027latest\u0027, so we could apply that here.","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    env: \"{{ container_config.env | default(omit) }}\""},{"line_number":19,"context_line":"    name: \"{{ container_name }}\""},{"line_number":20,"context_line":"    network_mode: \"{{ container_config.network_mode | default(deploy_containers_defaults.network_mode) }}\""},{"line_number":21,"context_line":"    image: \"{{ container_config.image }}:{{ container_config.tag | default(omit) }}\""},{"line_number":22,"context_line":"    init: \"{{ container_config.init | default(deploy_containers_defaults.init) }}\""},{"line_number":23,"context_line":"    ipc_mode: \"{{ container_config.ipc_mode | default(omit) }}\""},{"line_number":24,"context_line":"    pid_mode: \"{{ container_config.pid_mode | default(omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff570b3c_26f67890","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":80},"in_reply_to":"ff570b3c_3328e684","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"}],"ansible/roles/deploy-containers/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Deploy containers (loop)"},{"line_number":3,"context_line":"  include_tasks: deploy.yml"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    container_key: \"{{ item.key }}\""},{"line_number":6,"context_line":"    container_config: \"{{ item.value }}\""},{"line_number":7,"context_line":"  with_dict: \"{{ seed_containers }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1fa4df85_5030d4e8","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"updated":"2020-03-18 18:14:01.000000000","message":"nit: container_name?","commit_id":"beee85c7748706ca388a79d002557964f5847e87"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Deploy containers (loop)"},{"line_number":3,"context_line":"  include_tasks: deploy.yml"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    container_key: \"{{ item.key }}\""},{"line_number":6,"context_line":"    container_config: \"{{ item.value }}\""},{"line_number":7,"context_line":"  with_dict: \"{{ seed_containers }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ff570b3c_54535639","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":17},"in_reply_to":"1fa4df85_5030d4e8","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"beee85c7748706ca388a79d002557964f5847e87"}],"doc/source/configuration/index.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   bifrost"},{"line_number":15,"context_line":"   ironic-python-agent"},{"line_number":16,"context_line":"   nova-cells"},{"line_number":17,"context_line":"   user-defined-containers"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_01a3d9b3","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":26},"updated":"2020-03-03 18:15:52.000000000","message":"This is specific to the seed, maybe (create and) put it in seed.rst?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   bifrost"},{"line_number":15,"context_line":"   ironic-python-agent"},{"line_number":16,"context_line":"   nova-cells"},{"line_number":17,"context_line":"   user-defined-containers"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_dceddab7","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":26},"in_reply_to":"1fa4df85_01a3d9b3","updated":"2020-03-17 13:07:36.000000000","message":"Well, bifrost is also specific to the seed - I can create seed.rst and merge both bifrost and containers inside - if that\u0027s a better approach?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   bifrost"},{"line_number":15,"context_line":"   ironic-python-agent"},{"line_number":16,"context_line":"   nova-cells"},{"line_number":17,"context_line":"   user-defined-containers"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ff570b3c_ef073317","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":26},"in_reply_to":"1fa4df85_10d57c43","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   bifrost"},{"line_number":15,"context_line":"   ironic-python-agent"},{"line_number":16,"context_line":"   nova-cells"},{"line_number":17,"context_line":"   user-defined-containers"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_10d57c43","line":17,"range":{"start_line":17,"start_character":3,"end_line":17,"end_character":26},"in_reply_to":"1fa4df85_dceddab7","updated":"2020-03-18 18:14:01.000000000","message":"Let\u0027s keep bifrost separate. It\u0027s quite long already. I think I\u0027d just like it to be a bit more clear that these are containers for the seed. Maybe also reorder it before nova-cells to keep the seed pages together. Maybe call it \u0027Seed Custom Containers\u0027 or similar?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"}],"doc/source/configuration/seed-custom-containers.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c673d5f0c311d965b80f7e7817a639c199ab4cdf","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Please notice the *optional* pre and post scripts - those need to be created in"},{"line_number":25,"context_line":"``kayobe-config`` path and will be run before and after particular container"},{"line_number":26,"context_line":"deployment."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Possible options for container deployment:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"ff570b3c_1387a263","line":26,"updated":"2020-05-28 12:55:00.000000000","message":"This should state explicitly what format these scripts should take. They\u0027re ansible task files.","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Please notice the *optional* pre and post scripts - those need to be created in"},{"line_number":25,"context_line":"``kayobe-config`` path and will be run before and after particular container"},{"line_number":26,"context_line":"deployment."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Possible options for container deployment:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"ff570b3c_06337463","line":26,"in_reply_to":"ff570b3c_1387a263","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c673d5f0c311d965b80f7e7817a639c199ab4cdf","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For a detailed explanation of each option - please see `Ansible"},{"line_number":54,"context_line":"docker_container \u003chttps://docs.ansible.com/ansible/latest/modules/docker_container_module.html\u003e`_"},{"line_number":55,"context_line":"module page."}],"source_content_type":"text/x-rst","patch_set":16,"id":"ff570b3c_73709ea6","line":55,"updated":"2020-05-28 12:55:00.000000000","message":"It should probably at least list the defaults that are applied.","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ad6c50b4271891600b68331b38b68e8868b386e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For a detailed explanation of each option - please see `Ansible"},{"line_number":54,"context_line":"docker_container \u003chttps://docs.ansible.com/ansible/latest/modules/docker_container_module.html\u003e`_"},{"line_number":55,"context_line":"module page."}],"source_content_type":"text/x-rst","patch_set":16,"id":"ff570b3c_2685d8ad","line":55,"in_reply_to":"ff570b3c_73709ea6","updated":"2020-06-04 07:24:16.000000000","message":"Done","commit_id":"6f0ef14d411c5d663bb7961275af5a26432f26fd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"99e7158166f6940ce7550282ceacba18bdce3010","unresolved":false,"context_lines":[{"line_number":57,"context_line":"List of Kayobe applied defaults to required docker_container variables:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. literalinclude:: ../../../ansible/roles/deploy-containers/defaults/main.yml"},{"line_number":60,"context_line":"    :language: yaml"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff570b3c_a97d3be8","line":60,"updated":"2020-06-04 08:13:07.000000000","message":"That\u0027s cheating! :p","commit_id":"e31ec161bf555afbe38a46694b5373968d4f6c2f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0bf36bb1458b75ca9495e67344faa0d2573dd400","unresolved":false,"context_lines":[{"line_number":57,"context_line":"List of Kayobe applied defaults to required docker_container variables:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. literalinclude:: ../../../ansible/roles/deploy-containers/defaults/main.yml"},{"line_number":60,"context_line":"    :language: yaml"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff570b3c_1ac8e752","line":60,"in_reply_to":"ff570b3c_34fa22bc","updated":"2020-06-04 10:43:00.000000000","message":"Fails pep8","commit_id":"e31ec161bf555afbe38a46694b5373968d4f6c2f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e2ca2cc1858ac9b5d7a2c54b53d71462f79e6d62","unresolved":false,"context_lines":[{"line_number":57,"context_line":"List of Kayobe applied defaults to required docker_container variables:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. literalinclude:: ../../../ansible/roles/deploy-containers/defaults/main.yml"},{"line_number":60,"context_line":"    :language: yaml"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"ff570b3c_34fa22bc","line":60,"in_reply_to":"ff570b3c_a97d3be8","updated":"2020-06-04 08:50:17.000000000","message":"I tend to disagree - at least it gets updated when somebody changes the role defaults :-)","commit_id":"e31ec161bf555afbe38a46694b5373968d4f6c2f"}],"doc/source/configuration/user-defined-containers.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":22,"context_line":"       pre: \"{{ kayobe_config_path }}/containers/squid/pre.yml\""},{"line_number":23,"context_line":"       post: \"{{ kayobe_config_path }}/containers/squid/post.yml\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Please notice the pre and post scripts - those need to be created in"},{"line_number":26,"context_line":"``kayobe-config`` path and will be run before and after particular container"},{"line_number":27,"context_line":"deployment."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Possible options for container deployment:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_e1ad5d9b","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":11},"updated":"2020-03-03 18:15:52.000000000","message":"Let\u0027s make it clear they are optional.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"       pre: \"{{ kayobe_config_path }}/containers/squid/pre.yml\""},{"line_number":23,"context_line":"       post: \"{{ kayobe_config_path }}/containers/squid/post.yml\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Please notice the pre and post scripts - those need to be created in"},{"line_number":26,"context_line":"``kayobe-config`` path and will be run before and after particular container"},{"line_number":27,"context_line":"deployment."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Possible options for container deployment:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_fc8776b5","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":11},"in_reply_to":"1fa4df85_e1ad5d9b","updated":"2020-03-17 13:07:36.000000000","message":"Done","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":31,"context_line":".. code-block:: yaml"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"   seed_containers:"},{"line_number":34,"context_line":"     containerA:"},{"line_number":35,"context_line":"       capabilities:"},{"line_number":36,"context_line":"       command:"},{"line_number":37,"context_line":"       comparisons:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_011679a9","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":15},"updated":"2020-03-03 18:15:52.000000000","message":"The key only seems to be used for task names, but we also have a mandatory name field. Maybe we should just pick one?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":31,"context_line":".. code-block:: yaml"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"   seed_containers:"},{"line_number":34,"context_line":"     containerA:"},{"line_number":35,"context_line":"       capabilities:"},{"line_number":36,"context_line":"       command:"},{"line_number":37,"context_line":"       comparisons:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_3c9e6e07","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":15},"in_reply_to":"1fa4df85_011679a9","updated":"2020-03-17 13:07:36.000000000","message":"removed name and used {{ container_key }}","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For a detailed explanation of each option - please see `Ansible"},{"line_number":54,"context_line":"docker_container \u003chttps://docs.ansible.com/ansible/latest/modules/docker_container_module.html\u003e`_"},{"line_number":55,"context_line":"module page."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_a193e55a","line":55,"updated":"2020-03-03 18:15:52.000000000","message":"Where we have defaults that are different than the docker module, we should make that clear.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"For a detailed explanation of each option - please see `Ansible"},{"line_number":54,"context_line":"docker_container \u003chttps://docs.ansible.com/ansible/latest/modules/docker_container_module.html\u003e`_"},{"line_number":55,"context_line":"module page."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1fa4df85_7c94e6e8","line":55,"in_reply_to":"1fa4df85_a193e55a","updated":"2020-03-17 13:07:36.000000000","message":"Will do.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f33d53f5679787c56991e61df3763f1fb6c5cd8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"       privileged:"},{"line_number":45,"context_line":"       restart_policy:"},{"line_number":46,"context_line":"       sysctls:"},{"line_number":47,"context_line":"       tag:"},{"line_number":48,"context_line":"       ulimits:"},{"line_number":49,"context_line":"       user:"},{"line_number":50,"context_line":"       volumes:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1fa4df85_50177446","line":47,"range":{"start_line":47,"start_character":7,"end_line":47,"end_character":11},"updated":"2020-03-18 18:14:01.000000000","message":"Not required","commit_id":"beee85c7748706ca388a79d002557964f5847e87"}],"kayobe/cli/commands.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e760cf16428a7c545144d7b18794d457123c0c34","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def take_action(self, parsed_args):"},{"line_number":665,"context_line":"        self.app.LOG.debug(\"Deploying seed services\")"},{"line_number":666,"context_line":"        playbooks \u003d _build_playbook_list("},{"line_number":667,"context_line":"            \"seed-deploy-containers\")"},{"line_number":668,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks)"},{"line_number":669,"context_line":"        self.generate_kolla_ansible_config(parsed_args, service_config\u003dFalse,"},{"line_number":670,"context_line":"                                           bifrost_config\u003dTrue)"},{"line_number":671,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_812909e7","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":57},"updated":"2020-03-03 18:15:52.000000000","message":"We need to support the upgrade command too. Should the behaviour be different for those two?","commit_id":"32f238cd5485d093c559526e6434028529577c1e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc1f040f17f5bdda66ee5aadf9e735f60ff4f1e1","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def take_action(self, parsed_args):"},{"line_number":665,"context_line":"        self.app.LOG.debug(\"Deploying seed services\")"},{"line_number":666,"context_line":"        playbooks \u003d _build_playbook_list("},{"line_number":667,"context_line":"            \"seed-deploy-containers\")"},{"line_number":668,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks)"},{"line_number":669,"context_line":"        self.generate_kolla_ansible_config(parsed_args, service_config\u003dFalse,"},{"line_number":670,"context_line":"                                           bifrost_config\u003dTrue)"},{"line_number":671,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1fa4df85_9c8c4236","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":57},"in_reply_to":"1fa4df85_812909e7","updated":"2020-03-17 13:07:36.000000000","message":"Added, behaviour should not change IMHO.","commit_id":"32f238cd5485d093c559526e6434028529577c1e"}]}