)]}'
{"ansible/group_vars/all/kolla":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"698d6b2fe5f5ff710ef458209342b3be882e6dcb","unresolved":false,"context_lines":[{"line_number":352,"context_line":"# NTP daemon on the host. On CentOS 8 the chrony container is enabled by"},{"line_number":353,"context_line":"# default because the NTP daemon is not supported. Setting this to true will"},{"line_number":354,"context_line":"# disable NTP on the host."},{"line_number":355,"context_line":"kolla_enable_chrony: \"{{ ansible_distribution_major_version | int \u003e\u003d 8 }}\""},{"line_number":356,"context_line":"kolla_enable_cinder: \"no\""},{"line_number":357,"context_line":"kolla_enable_cloudkitty: \"no\""},{"line_number":358,"context_line":"kolla_enable_collectd: \"no\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1fa4df85_fbf79cf4","line":355,"updated":"2020-02-26 16:41:42.000000000","message":"ansible_os_family \u003d\u003d \u0027RedHat\u0027","commit_id":"a9fe6bf36b97ac69aac6ef992cfc154a89517ee1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"da2b3676fcdeea214be47c44f83ea89ff6f78c67","unresolved":false,"context_lines":[{"line_number":352,"context_line":"# NTP daemon on the host. On CentOS 8 the chrony container is enabled by"},{"line_number":353,"context_line":"# default because the NTP daemon is not supported. Setting this to true will"},{"line_number":354,"context_line":"# disable NTP on the host."},{"line_number":355,"context_line":"kolla_enable_chrony: \"{{ ansible_distribution_major_version | int \u003e\u003d 8 }}\""},{"line_number":356,"context_line":"kolla_enable_cinder: \"no\""},{"line_number":357,"context_line":"kolla_enable_cloudkitty: \"no\""},{"line_number":358,"context_line":"kolla_enable_collectd: \"no\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1fa4df85_4046f423","line":355,"in_reply_to":"1fa4df85_fbf79cf4","updated":"2020-02-27 11:19:32.000000000","message":"As before, we don\u0027t support non-CentOS remote hosts yet, but doesn\u0027t hurt to consider them. We might as well treat them in the same way as CentOS 8 hosts so we can keep the logic the same post-CentOS 7.","commit_id":"a9fe6bf36b97ac69aac6ef992cfc154a89517ee1"}],"ansible/group_vars/all/ntp":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"698d6b2fe5f5ff710ef458209342b3be882e6dcb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# CentOS 8 the host NTP daemon is not supported, and kolla_enable_chrony is set"},{"line_number":16,"context_line":"# to true by default."},{"line_number":17,"context_line":"ntp_service_enabled: \u003e-"},{"line_number":18,"context_line":"  {{ ansible_distribution_major_version | int \u003d\u003d 7 and"},{"line_number":19,"context_line":"     (\u0027overcloud\u0027 not in group_names or not kolla_enable_chrony | bool) }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ntp_package_state: \"{{ \u0027present\u0027 if ntp_service_enabled | bool else \u0027absent\u0027 }}\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1fa4df85_9bdc6875","line":18,"updated":"2020-02-26 16:41:42.000000000","message":"ansible_os_family \u003d\u003d \u0027RedHat\u0027","commit_id":"a9fe6bf36b97ac69aac6ef992cfc154a89517ee1"}],"ansible/ntp.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a8ccb47595a60b92c5a9d6b7fb8e3110219c5687","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      become: True"},{"line_number":9,"context_line":"    - role: resmo.ntp"},{"line_number":10,"context_line":"      become: True"},{"line_number":11,"context_line":"      when: ansible_os_family !\u003d \u0027RedHat\u0027 or ansible_distribution_major_version | int \u003d\u003d 7"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_83fd686f","line":11,"updated":"2020-03-05 16:04:02.000000000","message":"Should this be\n\n`\nansible_os_family \u003d\u003d \u0027RedHat\u0027 and ansible_distribution_major_version | int \u003d\u003d 7`,\n\ngiven that we have:\n\n`\nkolla_enable_chrony: \"{{ ansible_os_family !\u003d \u0027RedHat\u0027 or ansible_distribution_major_version | int \u003e\u003d 8 }}\"\n`?","commit_id":"dc8cd9d8a893be6121a846f2b0106f4222489d0e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2dad697a967c530938ef7eb1d40e86de5718ee91","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      become: True"},{"line_number":9,"context_line":"    - role: resmo.ntp"},{"line_number":10,"context_line":"      become: True"},{"line_number":11,"context_line":"      when: ansible_os_family !\u003d \u0027RedHat\u0027 or ansible_distribution_major_version | int \u003d\u003d 7"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_1eb30b4f","line":11,"in_reply_to":"1fa4df85_83fd686f","updated":"2020-03-05 16:48:21.000000000","message":"You raise a good point Doug. I put this in because disabling NTPd doesn\u0027t work in this role. I proposed a fix but no response yet: https://github.com/resmo/ansible-role-ntp/pull/30.\n\nWe should probably use ntp_service_enabled directly. This isn\u0027t really specific to this patch though - I\u0027ve raised a bug for kayobe and am fixing separately.\n\nhttps://storyboard.openstack.org/#!/story/2007384","commit_id":"dc8cd9d8a893be6121a846f2b0106f4222489d0e"}]}