)]}'
{"ansible/group_vars/all/bifrost":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7f003457d100445acd55254fb7849ad9c194c9da","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# DIB default environment variables."},{"line_number":39,"context_line":"kolla_bifrost_dib_env_vars_default:"},{"line_number":40,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":41,"context_line":"  # FIXME(mgoddard): DIB fails when cleaning up old kernels if the host running"},{"line_number":42,"context_line":"  # DIB is not running the latest available kernel. Skip this cleanup as a"},{"line_number":43,"context_line":"  # workaround. https://bugs.launchpad.net/diskimage-builder/+bug/1866847"},{"line_number":44,"context_line":"  DIB_DISABLE_KERNEL_CLEANUP: 1"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# DIB additional environment variables."},{"line_number":47,"context_line":"kolla_bifrost_dib_env_vars_extra: {}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"df33271e_c5325cf2","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":31},"updated":"2020-04-09 13:17:50.000000000","message":"This might be fixed by https://review.opendev.org/#/c/713988/\n\nDo you still have a test environment to try?","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9592e554143ee9ac44f7c454da7cb70a9dc8e107","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# DIB default environment variables."},{"line_number":39,"context_line":"kolla_bifrost_dib_env_vars_default:"},{"line_number":40,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":41,"context_line":"  # FIXME(mgoddard): DIB fails when cleaning up old kernels if the host running"},{"line_number":42,"context_line":"  # DIB is not running the latest available kernel. Skip this cleanup as a"},{"line_number":43,"context_line":"  # workaround. https://bugs.launchpad.net/diskimage-builder/+bug/1866847"},{"line_number":44,"context_line":"  DIB_DISABLE_KERNEL_CLEANUP: 1"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# DIB additional environment variables."},{"line_number":47,"context_line":"kolla_bifrost_dib_env_vars_extra: {}"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"df33271e_28595d34","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":31},"in_reply_to":"df33271e_c5325cf2","updated":"2020-04-09 14:02:41.000000000","message":"Not right now, but I could spin one up at some point. Can we merge like this and remove in future?","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"}],"ansible/group_vars/all/seed-vm":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6d78921c6ec8e472e21656be390c5ad1a814faae","unresolved":false,"context_lines":[{"line_number":41,"context_line":"seed_vm_root_format: qcow2"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Base image for the seed VM root volume."},{"line_number":44,"context_line":"seed_vm_root_image: \"https://cloud.centos.org/centos/8//x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Capacity of the seed VM data volume."},{"line_number":47,"context_line":"seed_vm_data_capacity: 100G"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"df33271e_8541743c","line":44,"range":{"start_line":44,"start_character":54,"end_line":44,"end_character":56},"updated":"2020-04-09 13:25:17.000000000","message":"Nit: double slash here","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"}],"ansible/network.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f52c6d8693080e49f439ff0869f54ff1ec5d021a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu_list: \"{{ [veth_bridge_mtu_map.get(interface), item | net_mtu] | reject(\u0027none\u0027) | reject | list }}\""},{"line_number":100,"context_line":"        mtu: \"{{ mtu_list | max if mtu_list | length \u003e 0 else None }}\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    - name: Update a fact containing veth interfaces"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_6cc1d42e","line":99,"updated":"2020-03-27 21:46:07.000000000","message":"does reject imply reject(\u0027none\u0027) - falsey value?","commit_id":"4a8fd94a6eead4da78c89714ba57fa11f4b71386"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c9cad1cbb64d11055b67d3c2cd7752b9ebd29707","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # interfaces with an explicit MTU set will be taken account of. If no"},{"line_number":97,"context_line":"        # interface has an explicit MTU set, then the corresponding veth will"},{"line_number":98,"context_line":"        # not either."},{"line_number":99,"context_line":"        mtu_list: \"{{ [veth_bridge_mtu_map.get(interface), item | net_mtu] | reject(\u0027none\u0027) | reject | list }}\""},{"line_number":100,"context_line":"        mtu: \"{{ mtu_list | max if mtu_list | length \u003e 0 else None }}\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    - name: Update a fact containing veth interfaces"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df33271e_6e979aed","line":99,"in_reply_to":"df33271e_6cc1d42e","updated":"2020-04-02 14:11:48.000000000","message":"Hmm, seems this is wrong. reject without args will reject truthy values. It should be select. And yes, that does make reject(\u0027none\u0027) redundant.","commit_id":"4a8fd94a6eead4da78c89714ba57fa11f4b71386"}],"etc/kayobe/seed-vm.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6d78921c6ec8e472e21656be390c5ad1a814faae","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#seed_vm_root_format:"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Base image for the seed VM root volume. Default is"},{"line_number":27,"context_line":"# \"https://cloud.centos.org/centos/8//x86_64/images/CentOS-8-GenericCloud-8.1.1911-20200113.3.x86_64.qcow2\"."},{"line_number":28,"context_line":"#seed_vm_root_image:"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Capacity of the seed VM data volume."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_856a14b0","line":27,"range":{"start_line":27,"start_character":36,"end_line":27,"end_character":38},"updated":"2020-04-09 13:25:17.000000000","message":"Nit: double slash","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"}],"requirements.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6d78921c6ec8e472e21656be390c5ad1a814faae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- src: ahuffman.resolv"},{"line_number":3,"context_line":"  version: 1.3.1"},{"line_number":4,"context_line":"- src: jriguera.configdrive"},{"line_number":5,"context_line":"  # There are no versioned releases of this role."},{"line_number":6,"context_line":"  version: a5c3c19d0cda7b6960c9200a30b5dbe73d2eef96"},{"line_number":7,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":8,"context_line":"  version: v1.4.0"},{"line_number":9,"context_line":"- src: mrlesmithjr.manage-lvm"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_a58bd865","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":51},"updated":"2020-04-09 13:25:17.000000000","message":"I noticed yesterday that jriguera documents this fork as unmaintained and recommends using https://gitlab.com/davidblaisonneau-orange/ansible-role-configdrive instead.\n\nWe should direct our pull requests there to see if there is a response.","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9592e554143ee9ac44f7c454da7cb70a9dc8e107","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- src: ahuffman.resolv"},{"line_number":3,"context_line":"  version: 1.3.1"},{"line_number":4,"context_line":"- src: jriguera.configdrive"},{"line_number":5,"context_line":"  # There are no versioned releases of this role."},{"line_number":6,"context_line":"  version: a5c3c19d0cda7b6960c9200a30b5dbe73d2eef96"},{"line_number":7,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":8,"context_line":"  version: v1.4.0"},{"line_number":9,"context_line":"- src: mrlesmithjr.manage-lvm"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_e53320aa","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":51},"in_reply_to":"df33271e_a58bd865","updated":"2020-04-09 14:02:41.000000000","message":"Interesting. They still accept pull requests, and the most recent commit on that one is over a year ago.","commit_id":"68dc0cd469295dbf8becf47ce4f03bbdb9962f79"}]}
