)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8fa27b14186379fee5dc117d9a6add787fb090f7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix loading of Monasca Grafana dashboards"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a minimal fix to support loading dashboards into the Monasca"},{"line_number":10,"context_line":"Grafana fork. It firstly aligns the default Monasca Grafana control plane"},{"line_number":11,"context_line":"organisation and Monasca Grafana local admin username with Kolla Ansible"},{"line_number":12,"context_line":"to make the feature easier to use. Secondly, it extracts the associated"},{"line_number":13,"context_line":"OpenStack project name from this variable by stripping off the OpenStack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_0e490a8a","line":10,"range":{"start_line":10,"start_character":68,"end_line":10,"end_character":73},"updated":"2020-03-30 10:21:38.000000000","message":"Just over the limit ;-)","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e43a9371abd2f9d15b8b03024b2040defee89bc2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix loading of Monasca Grafana dashboards"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a minimal fix to support loading dashboards into the Monasca"},{"line_number":10,"context_line":"Grafana fork. It firstly aligns the default Monasca Grafana control plane"},{"line_number":11,"context_line":"organisation and Monasca Grafana local admin username with Kolla Ansible"},{"line_number":12,"context_line":"to make the feature easier to use. Secondly, it extracts the associated"},{"line_number":13,"context_line":"OpenStack project name from this variable by stripping off the OpenStack"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_297cc870","line":10,"range":{"start_line":10,"start_character":68,"end_line":10,"end_character":73},"in_reply_to":"df33271e_0e490a8a","updated":"2020-03-30 10:26:55.000000000","message":"Do you have one of those green on black CRT terminals? :)","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8fa27b14186379fee5dc117d9a6add787fb090f7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I77c94edf654565a12ce8be681e3c9b16caa55c86"},{"line_number":22,"context_line":"Story: 2007477"},{"line_number":23,"context_line":"Task:  39186"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_6e61b605","line":23,"range":{"start_line":23,"start_character":5,"end_line":23,"end_character":7},"updated":"2020-03-30 10:21:38.000000000","message":"Nit: remove double space, which allows Gerrit to generate a link.","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"}],"ansible/overcloud-grafana-configure.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8fa27b14186379fee5dc117d9a6add787fb090f7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - name: Create monitoring group with grafana enabled"},{"line_number":8,"context_line":"      group_by:"},{"line_number":9,"context_line":"        key: \"monitoring_with_grafana_enabled_{{ kolla_enable_monasca | bool }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Set the Monasca control plane project ID"},{"line_number":12,"context_line":"  hosts: monitoring_with_grafana_enabled_True[0]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_ae057e16","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":69},"updated":"2020-03-30 10:21:38.000000000","message":"What about people using the non-Monasca Grafana? Are we dropping support for it?","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"22f59cca30533e40ec5ba6cc981509c32c1a5fac","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - name: Create monitoring group with grafana enabled"},{"line_number":8,"context_line":"      group_by:"},{"line_number":9,"context_line":"        key: \"monitoring_with_grafana_enabled_{{ kolla_enable_monasca | bool }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Set the Monasca control plane project ID"},{"line_number":12,"context_line":"  hosts: monitoring_with_grafana_enabled_True[0]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_e9eae00c","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":69},"in_reply_to":"df33271e_ae057e16","updated":"2020-03-30 11:58:47.000000000","message":"We never really supported it - this playbook is all about the Monasca fork. It would be nice though, just not in this commit.","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8fa27b14186379fee5dc117d9a6add787fb090f7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - role: stackhpc.grafana-conf"},{"line_number":62,"context_line":"      grafana_conf_organisation: \"{{ grafana_control_plane_organisation }}\""},{"line_number":63,"context_line":"      grafana_conf_grafana_admin_user: \"{{ grafana_local_admin_user_name }}\""},{"line_number":64,"context_line":"      grafana_conf_grafana_admin_pass: \"{{ grafana_admin_password }}\""},{"line_number":65,"context_line":"      grafana_conf_grafana_dashboard_repo:"},{"line_number":66,"context_line":"        repo: \"{{ grafana_monitoring_node_dashboard_repo }}\""},{"line_number":67,"context_line":"        version: \"{{ grafana_monitoring_node_dashboard_repo_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_49114c52","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":65},"updated":"2020-03-30 10:21:38.000000000","message":"I had a very similar patch locally. I had to update this line too: s/grafana_admin_password/monasca_grafana_admin_password/","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"22f59cca30533e40ec5ba6cc981509c32c1a5fac","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - role: stackhpc.grafana-conf"},{"line_number":62,"context_line":"      grafana_conf_organisation: \"{{ grafana_control_plane_organisation }}\""},{"line_number":63,"context_line":"      grafana_conf_grafana_admin_user: \"{{ grafana_local_admin_user_name }}\""},{"line_number":64,"context_line":"      grafana_conf_grafana_admin_pass: \"{{ grafana_admin_password }}\""},{"line_number":65,"context_line":"      grafana_conf_grafana_dashboard_repo:"},{"line_number":66,"context_line":"        repo: \"{{ grafana_monitoring_node_dashboard_repo }}\""},{"line_number":67,"context_line":"        version: \"{{ grafana_monitoring_node_dashboard_repo_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_7f8cc27e","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":65},"in_reply_to":"df33271e_49114c52","updated":"2020-03-30 11:58:47.000000000","message":"I think changing the name of this could break some other deployments using grafana_admin_password. It is just what you set in secrets.yml (and needs to mirrors the KA password). During Queens to Rocky we explicitly set the monasca_grafana_admin_password to the grafana_admin_password. It really needs documenting, but I think we are better off focusing on moving this to KA.","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"eb0b894dc97680c0aed143e29f453e73ee597173","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - role: stackhpc.grafana-conf"},{"line_number":62,"context_line":"      grafana_conf_organisation: \"{{ grafana_control_plane_organisation }}\""},{"line_number":63,"context_line":"      grafana_conf_grafana_admin_user: \"{{ grafana_local_admin_user_name }}\""},{"line_number":64,"context_line":"      grafana_conf_grafana_admin_pass: \"{{ grafana_admin_password }}\""},{"line_number":65,"context_line":"      grafana_conf_grafana_dashboard_repo:"},{"line_number":66,"context_line":"        repo: \"{{ grafana_monitoring_node_dashboard_repo }}\""},{"line_number":67,"context_line":"        version: \"{{ grafana_monitoring_node_dashboard_repo_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_bf6be982","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":65},"in_reply_to":"df33271e_7f8cc27e","updated":"2020-03-30 12:51:06.000000000","message":"At line 59 above we include kolla/passwords.yml, so we don\u0027t need to mirror the password in secrets.yml, do we?","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fea8ce34273bc5cbd8ef23115b6c5cf3d3819dd4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    - role: stackhpc.grafana-conf"},{"line_number":62,"context_line":"      grafana_conf_organisation: \"{{ grafana_control_plane_organisation }}\""},{"line_number":63,"context_line":"      grafana_conf_grafana_admin_user: \"{{ grafana_local_admin_user_name }}\""},{"line_number":64,"context_line":"      grafana_conf_grafana_admin_pass: \"{{ grafana_admin_password }}\""},{"line_number":65,"context_line":"      grafana_conf_grafana_dashboard_repo:"},{"line_number":66,"context_line":"        repo: \"{{ grafana_monitoring_node_dashboard_repo }}\""},{"line_number":67,"context_line":"        version: \"{{ grafana_monitoring_node_dashboard_repo_version }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_bf0009ad","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":65},"in_reply_to":"df33271e_bf6be982","updated":"2020-03-30 12:52:42.000000000","message":"Missed that, thanks, I will change it.","commit_id":"92a2d7772ae93e26f5574f979ad9c0fc4c56cc2b"}]}