)]}'
{"id":"openstack%2Fkayobe~717314","triplet_id":"openstack%2Fkayobe~master~Ifa615888b6d8d54c9e6314fd90f3fc4872fc6e5a","project":"openstack/kayobe","branch":"master","topic":"cacert","hashtags":[],"change_id":"Ifa615888b6d8d54c9e6314fd90f3fc4872fc6e5a","subject":"Prevent openrc files from using wrong OS_CACERT value","status":"MERGED","created":"2020-04-03 14:49:18.000000000","updated":"2020-04-15 17:30:00.000000000","submitted":"2020-04-15 17:27:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"717314-1586971653840-c298d5ab","meta_rev_id":"c3fa59803b2602724de8fcf477e2358ae607fb04","_number":717314,"virtual_id_number":717314,"owner":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-15 17:27:33.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"value":2,"date":"2020-04-15 15:32:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":2,"date":"2020-04-15 14:19:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"value":1,"date":"2020-04-15 15:32:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-15 14:19:13.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2020-04-15 15:32:04.000000000","updated_by":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"reviewer":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"state":"REVIEWER"},{"updated":"2020-04-15 17:27:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"40a4244682a279ba44d20ffc3aa904cd724626f1","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-04-03 14:49:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"36e8f192459714b1e7f9cec936e205cdb3d7c22c","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-04-03 15:02:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7b63dda1b877bf39873869a6ad034b43d23219d7","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-04-03 15:09:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f01303c10f2141cae62942e40350b7f244710cad","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-04-03 15:14:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7d29f597c1192b2263b4f4d689951ef79bd06f42","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-04-03 15:15:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9226a1d32759e2fe7369b9f9a300960b52edba4e","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-04-03 15:17:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"71ed5741f4e44c7324bcf1f153acc0e004a39a73","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 17:33:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/38864f67e1334de880a5cf3eb5f45f57 : SUCCESS in 8m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1b470403543a40c0a28da67a9ccfa51e : SUCCESS in 9m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/646c29703ef24f048700be449dfd3567 : SUCCESS in 9m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/dd65e77729b04cd5a64f949d60aa5e36 : SUCCESS in 8m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b08faca7e91f46f4a58b043b57940398 : FAILURE in 7m 07s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/24da4f0761f547bb85b945380908bb1a : SUCCESS in 8m 23s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/434a5c8340c1441fafaf62201dab557a : SUCCESS in 6m 38s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/1cbd102e8e4a4fdca5a4b04d99b43fa9 : SUCCESS in 8m 09s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/a2cdac50469045efa45ecaa30b1b9611 : SUCCESS in 13m 00s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/6fadada681f9452d803f51f9d443c98b : SUCCESS in 37m 39s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/7ca23020421d46fb8f5ab2846cce9ce4 : SUCCESS in 1h 06m 44s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/93b07497c011497082ac99765cff2832 : SUCCESS in 2h 06m 35s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/c9badbe9537c44ca9ecec507cc73f3b1 : SUCCESS in 22m 25s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/3e042131a6224cf69569aa22b53f9014 : SUCCESS in 30m 51s","accounts_in_message":[],"_revision_number":2},{"id":"c29615bfe5ebd370d2ab11b979da97db906c7702","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-04-15 14:19:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"340cddf57d986dbfd56b46d731e247cb9207b51b","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-04-15 15:32:04.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"12eeb15e5e51a54be88a82ad9f224734a7d7fd37","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 15:32:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"05c81784df1820a8647ff70d1f39357470014e3c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 17:27:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"342aad2ca62f79009b6df61cc6fdbba925319ef5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 17:27:33.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e3653cf2907640afb9989feba5dcd583 : SUCCESS in 5m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c0a38c9925ae445f8f1c501d59fee8ab : SUCCESS in 7m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5b1843b0214149a5860e6c4fa9751c67 : SUCCESS in 5m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/676ed8adf4754e5486e3bd216c1daaa4 : SUCCESS in 6m 53s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e31b2cdf2c7342febfafb3bb5842b043 : SUCCESS in 3m 58s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/9ebc31200df34af2a34fad8f673d736c : SUCCESS in 4m 09s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/99efa290730f45d7bb14fb4e13155ea7 : SUCCESS in 10m 07s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/bf389c07a91e4c98b827b532d9c17d54 : SUCCESS in 33m 59s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/ea14c509db8d4d87b3e9b3d375ebb405 : SUCCESS in 1h 10m 28s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/899cc73cdef84c919dbd75cacbc32dda : SUCCESS in 1h 52m 15s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/cfb4e707ba434634a0a0d884c839812d : SUCCESS in 20m 07s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/67437cea716a49e08df35acd0da171e2 : SUCCESS in 27m 54s","accounts_in_message":[],"_revision_number":2},{"id":"03b4c73d7d17b50f709ce8d5f78b44fffe964b9b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-15 17:30:00.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a76b6fcc8ae491ea36d345533d71c30 : SUCCESS in 2m 02s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/63f3b16a397341a5a4a4156edec485cd : SUCCESS in 2m 00s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ce212cc23c19906571af25e54ae2379d08c0c72b","revisions":{"f2a71d43e1abec808a34ce3e5e5c4beb365289d9":{"kind":"REWORK","_number":1,"created":"2020-04-03 14:49:18.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/14/717314/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/14/717314/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/14/717314/1"}}},"commit":{"parents":[{"commit":"7110477bcbf535df644bea5a6e68402fdddecc3f","subject":"Merge \"Install python-openstackclient using upper constraints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/7110477bcbf535df644bea5a6e68402fdddecc3f"}]}],"author":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2020-04-03 14:38:48.000000000","tz":120},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2020-04-03 14:38:48.000000000","tz":120},"subject":"Prevent openrc files from using wrong OS_CACERT value","message":"Prevent openrc files from using wrong OS_CACERT value\n\nKolla Ansible sets kolla_{external,internal}_fqdn_cacert variables with\ndefault values compatible with the use of `kolla-ansible certificates`.\n\nHowever, when these variables are left unset in Kayobe, which is\ngenerally the case when using trusted certificates, we end up with\nopenrc files setting OS_CACERT to a file that does not exist:\n\n    ${KOLLA_CONFIG_PATH}/certificates/haproxy-ca.crt\n\nInstead we allow null cacert variables to be passed to kolla-ansible,\nwhich results in openrc files without the bogus OS_CACERT entry.\n\nChange-Id: Ifa615888b6d8d54c9e6314fd90f3fc4872fc6e5a\nStory: 2007516\nTask: 39299\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/f2a71d43e1abec808a34ce3e5e5c4beb365289d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/f2a71d43e1abec808a34ce3e5e5c4beb365289d9"}]},"branch":"refs/heads/master"},"ce212cc23c19906571af25e54ae2379d08c0c72b":{"kind":"REWORK","_number":2,"created":"2020-04-03 15:17:39.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/14/717314/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/14/717314/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/717314/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/14/717314/2"}}},"commit":{"parents":[{"commit":"7110477bcbf535df644bea5a6e68402fdddecc3f","subject":"Merge \"Install python-openstackclient using upper constraints\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/7110477bcbf535df644bea5a6e68402fdddecc3f"}]}],"author":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2020-04-03 15:17:24.000000000","tz":120},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2020-04-03 15:17:24.000000000","tz":120},"subject":"Prevent openrc files from using wrong OS_CACERT value","message":"Prevent openrc files from using wrong OS_CACERT value\n\nKolla Ansible sets kolla_{external,internal}_fqdn_cacert variables with\ndefault values compatible with the use of `kolla-ansible certificates`.\n\nHowever, when these variables are left unset in Kayobe, which is\ngenerally the case when using trusted certificates, we end up with\nopenrc files setting OS_CACERT to a file that does not exist:\n\n    ${KOLLA_CONFIG_PATH}/certificates/haproxy-ca.crt\n\nInstead we allow null cacert variables to be passed to kolla-ansible,\nwhich results in openrc files without the bogus OS_CACERT entry.\n\nChange-Id: Ifa615888b6d8d54c9e6314fd90f3fc4872fc6e5a\nStory: 2007516\nTask: 39299\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/ce212cc23c19906571af25e54ae2379d08c0c72b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/ce212cc23c19906571af25e54ae2379d08c0c72b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}