)]}'
{"id":"openstack%2Fkayobe~726855","triplet_id":"openstack%2Fkayobe~master~I68fb65cd3bc7c4390813747f9ac4ecebc3b4145f","project":"openstack/kayobe","branch":"master","hashtags":[],"change_id":"I68fb65cd3bc7c4390813747f9ac4ecebc3b4145f","subject":"Remove newline from default public_net_name","status":"MERGED","created":"2020-05-11 14:03:24.000000000","updated":"2020-06-05 22:42:51.000000000","submitted":"2020-06-05 13:41:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"726855-1591364487453-c58cac8c","meta_rev_id":"bd9edf7da4a3323d5fd8fdb1825df95039ca6025","_number":726855,"virtual_id_number":726855,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-05 13:41:27.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"value":2,"date":"2020-06-05 09:39:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-05-12 14:43:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"value":1,"date":"2020-06-05 09:39:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-12 14:43:26.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"state":"REVIEWER"},{"updated":"2020-06-05 09:39:36.000000000","updated_by":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"reviewer":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"state":"REVIEWER"},{"updated":"2020-06-05 13:41:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f52397e9e40022a9247f414660945439f2a0250","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-05-11 14:03:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b879be9a03682586df4a6ded1905b7867eecc37","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-11 16:42:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/926108f59e374e37bd0ebc0065b67bce : SUCCESS in 8m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1702cf47d55a4baf83793efa4b00b196 : SUCCESS in 7m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/69726b3e63ac43979d798402b70e1d7b : SUCCESS in 6m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2fa4094fd1544abc846a7037159a8b48 : SUCCESS in 7m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0ff1681c94994be1ae4ae150032b3605 : SUCCESS in 7m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e7a90e68561d4cb1a4205de20b096b5c : SUCCESS in 9m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c7dc517e03574bc88728ba964aaa8e19 : SUCCESS in 5m 55s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/bce87390b36c493f98c563ef2c0bf26c : SUCCESS in 6m 40s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/71c66d025e5444a0a68f0fb245aa7703 : SUCCESS in 10m 14s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/c5ca09ee80ab4e8d9924855ef1f9703a : SUCCESS in 33m 30s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/abdb9f7cdce7400580d228206777a893 : SUCCESS in 1h 08m 39s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/5ae28847d833443785f86dd803ad4af2 : SUCCESS in 19m 50s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/53ecda710ed947ebb7bed027d8681fc1 : SUCCESS in 2h 09m 17s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/1fbedbe46c5f4e9abe1822ea51dc9631 : SUCCESS in 18m 31s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/42425da79dde46ee89859f4da9f17db3 : SUCCESS in 33m 34s","accounts_in_message":[],"_revision_number":1},{"id":"49690a8371bc1516afce37a506243bcc03a8239e","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-05-12 14:43:26.000000000","message":"Patch Set 1: Code-Review+2\n\nTested, it works. With networks.yml as:\n\nexternal_net_names:\n  - external\n\nThe error was:\n\nTASK [Validate network interface configuration] *************************************************************************************************************************************\nfailed: [controller0] (item\u003dexternal\n) \u003d\u003e {\"ansible_loop_var\": \"item\", \"changed\": false, \"item\": \"external\\n\", \"msg\": \"Network interface validation failed - no interface configured for external\\n. This should be configured via \u0027external\\n_interface\u0027.\\n\"}","accounts_in_message":[],"_revision_number":1},{"id":"616c34114c205c46b540ada7f6de20a36a132f28","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-06-05 09:39:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"61fd39ebde3db2d6f585ff0d8077ae482072d4da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 09:39:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5788fbdaf6500c5afd1b45685b4bff4337019609","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 13:41:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/40c151299c7643cd83dcbc1d6e0e18d9 : SUCCESS in 6m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bb82f1f01ff1469099cfbcf8a9005eb0 : SUCCESS in 5m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d741ae88a2294d5cafcd663984cbd90a : SUCCESS in 6m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0b26ec82d42a40d6bde315fe5bd3c760 : SUCCESS in 7m 31s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/070c7c9604924fe580fba0532fa1c982 : SUCCESS in 5m 20s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/d5ca648acafb423bbe9c1e5d4dd74320 : SUCCESS in 4m 16s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/55d8380d8dd64c3988c69f9dbf37b49a : SUCCESS in 9m 49s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/493102bd0c4a409b969b916d3cbaa514 : SUCCESS in 34m 10s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/f4f4b7bae0ed48b1b95e408a00ac62de : SUCCESS in 1h 11m 18s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/028d2f5b93ca4fe1ac6f3567710df408 : SUCCESS in 16m 45s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/bc33954d87f14a8b82e1982901f4928b : SUCCESS in 1h 58m 17s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/662eccc200c946dc8ee737e904b2f9af : SUCCESS in 19m 02s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/8917971a169849d7a2769f241e549d23 : SUCCESS in 29m 42s","accounts_in_message":[],"_revision_number":1},{"id":"d1a04cc68badeea019c7b6d2542c973c29c204d3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 13:41:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ee06825c09c5ef692dfbfb4c32c0162e17716a7b","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-06-05 13:43:41.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 1ecf3a684f31e0d4c783ab53c26a7e5a96ac42ef","accounts_in_message":[],"_revision_number":1},{"id":"f4b0f03416c703067bec9602f789def6951272b8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-05 13:44:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/07b1ab4965fe4674b7c1ce0baed4ff3e : SUCCESS in 1m 39s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1d3aeb7f01f44981ab6aa543ab615c59 : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":1},{"id":"e5cb0ebd5a71e34325d53eb7954191af5b0d283e","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-06-05 13:44:12.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit d93e22c3fac3ab11d3cd878592129a088f32756d","accounts_in_message":[],"_revision_number":1},{"id":"bd9edf7da4a3323d5fd8fdb1825df95039ca6025","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-06-05 22:42:51.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit c93c69901a5c952012031e1775b221737a8b7969","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6beaf5b5e38c3a90651afb67899d8ee6661e2cf9","revisions":{"6beaf5b5e38c3a90651afb67899d8ee6661e2cf9":{"kind":"REWORK","_number":1,"created":"2020-05-11 14:03:24.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/55/726855/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/55/726855/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/55/726855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/55/726855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/55/726855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/55/726855/1"}}},"commit":{"parents":[{"commit":"565a0614dc322dfe38a62b3fe883137ebe64773c","subject":"Merge \"Define default variables for Monasca config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/565a0614dc322dfe38a62b3fe883137ebe64773c"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-05-11 13:52:25.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-05-11 14:03:09.000000000","tz":60},"subject":"Remove newline from default public_net_name","message":"Remove newline from default public_net_name\n\nThe public network name is set via public_net_name, and its default\nvalue is the first item in the external_net_names list. The variable\nuses the YAML folded block scalar notation, but does not use the\nchomping indictator, which means the string is assigned a trailing\nnewline.\n\nThis change fixes the issue by adding the chomping indicator.\n\nChange-Id: I68fb65cd3bc7c4390813747f9ac4ecebc3b4145f\nStory: 2007654\nTask: 39731\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/6beaf5b5e38c3a90651afb67899d8ee6661e2cf9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/6beaf5b5e38c3a90651afb67899d8ee6661e2cf9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}