)]}'
{"id":"openstack%2Fkayobe~736985","triplet_id":"openstack%2Fkayobe~master~I3865993e773dca73533f06002efcee14e623c67b","project":"openstack/kayobe","branch":"master","hashtags":[],"change_id":"I3865993e773dca73533f06002efcee14e623c67b","subject":"Add ability to exclude variables from kolla-ansibles globals.yml","status":"ABANDONED","created":"2020-06-19 12:19:09.000000000","updated":"2021-07-22 13:58:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3299e70b7d7deb5171495a0ed620238fedfcb7c4","_number":736985,"virtual_id_number":736985,"owner":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-19 14:20:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-06-19 15:52:50.000000000","_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":-1,"date":"2020-06-19 12:21:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-19 14:20:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-19 15:52:50.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"}],"messages":[{"id":"f537b5e056d1f3728f2715af52de3a9d1b524d6e","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-06-19 12:19:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"80f290429fe774776066ef9d8ec70f6351bbd509","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-06-19 12:21:07.000000000","message":"Patch Set 1: Workflow-1\n\nThought I\u0027d get some feedback on whether or not this was a good way to solve the issue, before I spent any more time. The idea is that you would guard every variable in globals.yml.j2 in a similar way.","accounts_in_message":[],"_revision_number":1},{"id":"083edd3faaa5e343aa8e5ddd96866155e2ae4151","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-19 14:20:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3f99612d7e984ad2a6bd6e683896f351 : SUCCESS in 5m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b13b689076f24c5d893267668e150206 : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/62cb1882453c41058471d77f07d42eb9 : SUCCESS in 5m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d078698a4fcb4b9f884ca7f80b253ef1 : SUCCESS in 6m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/04453c3a0d7c4695a2f529ccbe388f51 : SUCCESS in 6m 22s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/2142248ac1334601acd0ea44b783e167 : SUCCESS in 6m 15s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/cdb888eccb504e07b7eeb9807a844146 : FAILURE in 7m 59s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/68596a094aeb457e842263243d87c066 : SUCCESS in 35m 50s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/e7f6c52030e94297af6540dd3e7f5317 : SUCCESS in 1h 11m 10s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/63f1851148f34902b0a4bbb9acb988e8 : SUCCESS in 21m 40s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/3bcfa41991584709b4d98955c3b9c03d : SUCCESS in 2h 00m 10s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/5684e66a662c4289a48e4e49ffbc02e0 : SUCCESS in 18m 36s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/e0dfaeb3b6994d89ab1233ba294948e7 : SUCCESS in 25m 48s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/bbe43c8a14414219927485c2549e0b61 : SUCCESS in 10m 46s","accounts_in_message":[],"_revision_number":1},{"id":"07d1961cb8d66a7ca5944caddc5ddcea195d2343","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-06-19 14:31:15.000000000","message":"Patch Set 1:\n\nIt feels a little clunky to have to do this for every variable. There is a way around it without code changes:\n\nglobals.yml:\nglobal_var: \"{{ group_var }}\"\n\ngroup_vars/1:\ngroup_var: foo\n\ngroup_vars/2:\ngroup_var: bar\n\nAlso a little clunky. I expect we might have to do this more often with multiple environment support though. Another option is we could grab merge_yaml from kolla-ansible, and extend it to ignore a set of keys.","accounts_in_message":[],"_revision_number":1},{"id":"dd128a4bddf6c093864ba81a00de61b312fd23b6","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-06-19 14:48:21.000000000","message":"Patch Set 1:\n\n\u003e It feels a little clunky to have to do this for every variable.\n \u003e There is a way around it without code changes:\n \u003e \n \u003e globals.yml:\n \u003e global_var: \"{{ group_var }}\"\n \u003e \n \u003e group_vars/1:\n \u003e group_var: foo\n \u003e \n \u003e group_vars/2:\n \u003e group_var: bar\n \u003e \n \u003e Also a little clunky. I expect we might have to do this more often\n \u003e with multiple environment support though. Another option is we\n \u003e could grab merge_yaml from kolla-ansible, and extend it to ignore a\n \u003e set of keys.\n\nhmm, thanks for the comments. Not sure I see how your example works. Isn\u0027t globals.yml templated by localhost? So, why would the group_vars from another group be applied to the templating? . Maybe I missed something. Using merge yamls sounds promising though.","accounts_in_message":[],"_revision_number":1},{"id":"78fd3850bf53b09112c68945038d594bd46aab00","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-06-19 15:52:50.000000000","message":"Patch Set 1:\n\n\u003e \u003e It feels a little clunky to have to do this for every variable.\n \u003e \u003e There is a way around it without code changes:\n \u003e \u003e\n \u003e \u003e globals.yml:\n \u003e \u003e global_var: \"{{ group_var }}\"\n \u003e \u003e\n \u003e \u003e group_vars/1:\n \u003e \u003e group_var: foo\n \u003e \u003e\n \u003e \u003e group_vars/2:\n \u003e \u003e group_var: bar\n \u003e \u003e\n \u003e \u003e Also a little clunky. I expect we might have to do this more\n \u003e often\n \u003e \u003e with multiple environment support though. Another option is we\n \u003e \u003e could grab merge_yaml from kolla-ansible, and extend it to ignore\n \u003e a\n \u003e \u003e set of keys.\n \u003e \n \u003e hmm, thanks for the comments. Not sure I see how your example\n \u003e works. Isn\u0027t globals.yml templated by localhost? So, why would the\n \u003e group_vars from another group be applied to the templating? . Maybe\n \u003e I missed something. Using merge yamls sounds promising though.\n\nOops - missed a bit. {% raw %}","accounts_in_message":[],"_revision_number":1},{"id":"58012a92616f4c37ad94df8282b8869a9f21d058","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2021-07-22 13:58:22.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e \u003e It feels a little clunky to have to do this for every variable.\n\u003e  \u003e \u003e There is a way around it without code changes:\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e globals.yml:\n\u003e  \u003e \u003e global_var: \"{{ group_var }}\"\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e group_vars/1:\n\u003e  \u003e \u003e group_var: foo\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e group_vars/2:\n\u003e  \u003e \u003e group_var: bar\n\u003e  \u003e \u003e\n\u003e  \u003e \u003e Also a little clunky. I expect we might have to do this more\n\u003e  \u003e often\n\u003e  \u003e \u003e with multiple environment support though. Another option is we\n\u003e  \u003e \u003e could grab merge_yaml from kolla-ansible, and extend it to ignore\n\u003e  \u003e a\n\u003e  \u003e \u003e set of keys.\n\u003e  \u003e \n\u003e  \u003e hmm, thanks for the comments. Not sure I see how your example\n\u003e  \u003e works. Isn\u0027t globals.yml templated by localhost? So, why would the\n\u003e  \u003e group_vars from another group be applied to the templating? . Maybe\n\u003e  \u003e I missed something. Using merge yamls sounds promising though.\n\u003e \n\u003e Oops - missed a bit. {% raw %}\n\nAgreed that the approach you suggested is a better way around this issue. Will Abandon this patch. Thanks for the hint.","accounts_in_message":[],"_revision_number":1},{"id":"3299e70b7d7deb5171495a0ed620238fedfcb7c4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2021-07-22 13:58:36.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b6f8e306e62512021667d83c7ac1e7958384883a","revisions":{"b6f8e306e62512021667d83c7ac1e7958384883a":{"kind":"REWORK","_number":1,"created":"2020-06-19 12:19:09.000000000","uploader":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"ref":"refs/changes/85/736985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/85/736985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/85/736985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/85/736985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/85/736985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/85/736985/1"}}},"commit":{"parents":[{"commit":"da95fc897d9306f2fc082feff5497e9b6a206c05","subject":"Merge \"Fix kayobe baremetal compute commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/da95fc897d9306f2fc082feff5497e9b6a206c05"}]}],"author":{"name":"Will Szumski","email":"will@stackhpc.com","date":"2020-06-19 12:17:15.000000000","tz":60},"committer":{"name":"Will Szumski","email":"will@stackhpc.com","date":"2020-06-19 12:17:15.000000000","tz":60},"subject":"Add ability to exclude variables from kolla-ansibles globals.yml","message":"Add ability to exclude variables from kolla-ansibles globals.yml\n\nSometimes it useful to override the kayobe global defaults to per-host or\nper-group settings.\n\nChange-Id: I3865993e773dca73533f06002efcee14e623c67b\nStory: 2007834\nTask: 40121\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/b6f8e306e62512021667d83c7ac1e7958384883a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/b6f8e306e62512021667d83c7ac1e7958384883a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}