)]}'
{"ansible/filter_plugins/networks.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"71c1f435155d84542f06b5f9c7598be310fd21c9","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        ip \u003d \u0027\u0027"},{"line_number":203,"context_line":"        gateway \u003d None"},{"line_number":204,"context_line":"        netmask \u003d None"},{"line_number":205,"context_line":"    cidr \u003d net_cidr(context, name, inventory_hostname)"},{"line_number":206,"context_line":"    netmask \u003d net_mask(context, name, inventory_hostname)"},{"line_number":207,"context_line":"    gateway \u003d net_gateway(context, name, inventory_hostname)"},{"line_number":208,"context_line":"    vlan \u003d net_vlan(context, name, inventory_hostname)"},{"line_number":209,"context_line":"    mtu \u003d net_mtu(context, name, inventory_hostname)"},{"line_number":210,"context_line":"    routes \u003d net_routes(context, name, inventory_hostname)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1507d51f","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":60},"updated":"2020-09-15 08:54:05.000000000","message":"These should be inside an else clause, otherwise they will just replace the None values.","commit_id":"44b0379b868bd8c8345bb5992422d30573022504"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c79be267bfe0796b70366ea239be1e4963ae296c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    netmask \u003d net_mask(context, name, inventory_hostname)"},{"line_number":205,"context_line":"    gateway \u003d net_gateway(context, name, inventory_hostname)"},{"line_number":206,"context_line":"    if ip is None:"},{"line_number":207,"context_line":"        ip \u003d \u0027\u0027"},{"line_number":208,"context_line":"        gateway \u003d None"},{"line_number":209,"context_line":"        netmask \u003d None"},{"line_number":210,"context_line":"    vlan \u003d net_vlan(context, name, inventory_hostname)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_04000502","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":15},"updated":"2020-09-18 08:45:02.000000000","message":"@Bartosz: was there a reason you set ip to an empty string instead of using None like in my original patch? It results in ifcfg files containing:\n\nIPADDR\u003d\n\nIt appears to work the same though.","commit_id":"2606c23812be510c1f8ced03a5e0c32a218d827d"}]}