)]}'
{"id":"openstack%2Fkayobe~756571","triplet_id":"openstack%2Fkayobe~master~Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c","project":"openstack/kayobe","branch":"master","hashtags":[],"change_id":"Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c","subject":"Fix filtering of network names set to an empty string","status":"MERGED","created":"2020-10-07 19:07:24.000000000","updated":"2020-11-03 12:12:49.000000000","submitted":"2020-11-03 12:10:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"756571-1604405458885-5b3c2ee3","meta_rev_id":"d37bf27f58e660f57e6ef603ac6c5f8867320507","_number":756571,"virtual_id_number":756571,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-03 12:10:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"all":[{"value":2,"date":"2020-11-03 09:59:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-10-09 15:19:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"all":[{"value":1,"date":"2020-11-03 09:59:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-09 15:19:06.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"state":"REVIEWER"},{"updated":"2020-11-03 09:59:45.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"REVIEWER"},{"updated":"2020-11-03 12:10:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8b2bc0e0ad06f0c609940fa7639d3746f961bae2","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-10-07 19:07:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce504a61ed8f7f8b2aff308bb94bcacf692db9ff","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-10-07 19:24:52.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"5d9ca70a3e66cb8db50c5a8e979f86a9ed1250ba","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 20:59:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/57dd3e9f0d7142c8bcf8b2ba96aad1cf : SUCCESS in 6m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/51ddc76fb8e147e68b99814e32e12024 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bd43c11fb24648d2a6081b0bace4b936 : SUCCESS in 4m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aadddf5872054ca3adafacc75de03de6 : SUCCESS in 5m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e2f67dff375241098b3172200fa27527 : SUCCESS in 7m 15s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/91351c633df346e68dcff68c071a1daa : SUCCESS in 4m 48s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/1d92029796bf4be59e93ded22cf68d92 : SUCCESS in 8m 48s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/0fd6a5f46dff4bf999788a76520f4e71 : SUCCESS in 21m 28s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/7fd49550edad4834a947d1169e17ea2a : SUCCESS in 1h 01m 42s\n- kayobe-overcloud-tls-centos8 https://zuul.opendev.org/t/openstack/build/91e98fa82b4d4676b7a2ff24b5c47f9f : SUCCESS in 1h 03m 14s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/6db556fa05e04467ab554f626302bb74 : SUCCESS in 19m 36s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/7711becc430f4f13a3862ff15759f184 : SUCCESS in 1h 31m 03s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/18caa4c8ff214eb1904e21bc4690feef : SUCCESS in 17m 08s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/5b371882d989472cb5198fe73a28df4c : SUCCESS in 34m 16s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/85c070eaaa65421c947cbbb19bca74d6 : SUCCESS in 11m 42s\n\nWarning:\n  Comments left for invalid file tools/release.sh\n  Comments left for invalid file tools/test-ansible.sh\n  Comments left for invalid file roles/kayobe-diagnostics/files/get_logs.sh","accounts_in_message":[],"_revision_number":2},{"id":"57992202c2cb1acf16f4225762db49efa01ad1a6","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-10-09 15:19:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"bca5dda233f22b5c163a21c7308b1f005f596b55","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-11-03 09:59:45.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"562fd9a3209e46c9a63622ec277e73692770a3a1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 09:59:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"efde129fd22ea0499ecc20caab00cfe82edad7e5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 12:10:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c92e06a7f20445c881843a83c173a6f4 : SUCCESS in 4m 56s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/683fd78dee134f92bdf43a6a0d5a9d05 : SUCCESS in 4m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a167b36f0b91405194b7d97131c4480a : SUCCESS in 4m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8c2adb60c7a456d81733a5851881338 : SUCCESS in 7m 44s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/9bcfd3ab577a45ad9692068c4f26a321 : SUCCESS in 5m 52s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/008c04993d8841368ce5b3f3f7c09aec : SUCCESS in 8m 30s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/4c30b28048734a7f991e5dc327151cc8 : SUCCESS in 19m 07s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/f7852092dc334ec6bf4cb2c20f90b2cf : SUCCESS in 1h 04m 12s\n- kayobe-overcloud-tls-centos8 https://zuul.opendev.org/t/openstack/build/ec8a88d43b754d22b0f8369ca92f9eae : SUCCESS in 1h 10m 52s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/60b92257192542e199c92dbf49b5dd1d : SUCCESS in 15m 57s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/e441dc8dffb14d78b6bb7ebf561513a1 : SUCCESS in 2h 04m 39s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/5e615d0522254e2e83fa7d57e5e96de7 : SUCCESS in 16m 38s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/70f69f7faedf4c16b51b7b9f18a6d629 : SUCCESS in 24m 30s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/1d027fafedc04149929438b34f5f3a10 : SUCCESS in 10m 14s\n\nWarning:\n  Comments left for invalid file tools/release.sh\n  Comments left for invalid file tools/test-ansible.sh\n  Comments left for invalid file roles/kayobe-diagnostics/files/get_logs.sh","accounts_in_message":[],"_revision_number":2},{"id":"527768b708871eaf6a99f1eae87928f038b6830f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 12:10:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"d37bf27f58e660f57e6ef603ac6c5f8867320507","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 12:12:49.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7165e036d1c04c728a5f6cf1e0e4eee7 : SUCCESS in 1m 27s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d2109e1c35011fcaeec368eb1b8bf6a9ec75e238","revisions":{"e90714c9f1d34c6858636c31b4fd109163ff2461":{"kind":"REWORK","_number":1,"created":"2020-10-07 19:07:24.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/71/756571/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/71/756571/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/71/756571/1"}}},"commit":{"parents":[{"commit":"02c03839147a03ecc5da390fb3a882b09fadb282","subject":"Merge \"dev: fix test scripts when ironic is disabled\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/02c03839147a03ecc5da390fb3a882b09fadb282"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-10-07 19:04:01.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-10-07 19:06:16.000000000","tz":60},"subject":"Fix filtering of network names set to an empty string","message":"Fix filtering of network names set to an empty string\n\nCurrently we filter out networks that are set to None. However, we\nshould also filter out networks set to an empty string. This affects the\novercloud ironic networks that were disabled in\nI300d0ef136224126f25d2c70a80a42afeea5f586 when ironic is disabled.\n\nStory: 2008180\nTask: 41076\n\nChange-Id: Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/e90714c9f1d34c6858636c31b4fd109163ff2461"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/e90714c9f1d34c6858636c31b4fd109163ff2461"}]},"branch":"refs/heads/master"},"d2109e1c35011fcaeec368eb1b8bf6a9ec75e238":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-10-07 19:24:52.000000000","uploader":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"ref":"refs/changes/71/756571/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/71/756571/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/71/756571/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/71/756571/2"}}},"commit":{"parents":[{"commit":"02c03839147a03ecc5da390fb3a882b09fadb282","subject":"Merge \"dev: fix test scripts when ironic is disabled\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/02c03839147a03ecc5da390fb3a882b09fadb282"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-10-07 19:04:01.000000000","tz":60},"committer":{"name":"Pierre Riteau","email":"pierre@stackhpc.com","date":"2020-10-07 19:24:50.000000000","tz":0},"subject":"Fix filtering of network names set to an empty string","message":"Fix filtering of network names set to an empty string\n\nCurrently we filter out networks that are set to None. However, we\nshould also filter out networks set to an empty string. This affects the\novercloud ironic networks that were disabled in\nI300d0ef136224126f25d2c70a80a42afeea5f586 when ironic is disabled.\n\nStory: 2008207\nTask: 41076\n\nChange-Id: Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/d2109e1c35011fcaeec368eb1b8bf6a9ec75e238"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/d2109e1c35011fcaeec368eb1b8bf6a9ec75e238"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}