)]}'
{"id":"openstack%2Fkayobe~761330","triplet_id":"openstack%2Fkayobe~stable%2Fussuri~Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c","project":"openstack/kayobe","branch":"stable/ussuri","hashtags":[],"change_id":"Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c","subject":"Fix filtering of network names set to an empty string","status":"MERGED","created":"2020-11-04 09:35:10.000000000","updated":"2020-11-16 12:53:03.000000000","submitted":"2020-11-16 12:51:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"761330-1605531104945-28503777","meta_rev_id":"cf51754ca90608c45dc0c7521165f4159d6249ec","_number":761330,"virtual_id_number":761330,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-16 12:51:44.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":2,"date":"2020-11-16 10:48:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-12 13:54:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":1,"date":"2020-11-16 10:48:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-12 13:54:12.000000000","updated_by":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"reviewer":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"state":"REVIEWER"},{"updated":"2020-11-16 12:51:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4923ef6b6c4d2fcec9d0ebb1ad60a7b27e525c32","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-04 09:35:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7c8b0a7efe9badb4408b07126f980efc58da07b1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-04 11:54:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/749a33fdbeec413db350a892c6544b89 : SUCCESS in 3m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6529391cef7942ba83bcaeed35861288 : SUCCESS in 3m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/121a049262cf421a86432f2695081e0a : SUCCESS in 4m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/22c1db69c2e341669832c3b1bcc953e1 : SUCCESS in 4m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9ceff542fdd84aeeb547450494fd1b32 : SUCCESS in 19m 34s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/b2d554d4887d4650bd05a4b4de460a35 : SUCCESS in 3m 51s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/9796455b788b474495171c9b226c2f5d : SUCCESS in 6m 41s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/1d683a92b1eb4060be493be63a3ae879 : SUCCESS in 18m 55s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/41c1d5e852d44a2398b28cf0b4534a10 : SUCCESS in 1h 07m 46s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/bfc2265d3e984186830f73ca64a313c6 : SUCCESS in 15m 42s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/127e549292aa43eaa1f6888be59834f1 : SUCCESS in 2h 08m 34s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/0b262bcd64064a409e0f81a28954071b : SUCCESS in 17m 59s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/1734919769fa4281ae598acce030a3e5 : SUCCESS in 25m 24s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/6a947ea7ff56417cb4b61849b1980aaf : SUCCESS in 12m 38s","accounts_in_message":[],"_revision_number":1},{"id":"0619301651bc792cda3f205a426ef6936f970102","author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"date":"2020-11-12 13:54:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e06d2d910d67c1691681e19a528291753e267eb5","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-11-16 10:48:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7936a8a33fa08b7d789f567855dcd36750ff0828","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 10:49:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a85383b4f7d2f448c65b1d9360cd6ae3132766e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 12:51:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"3b90dc7f6a5a7b4b019c55ec2a4b1a86839c4314","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 12:51:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7e2f5cc486bf44678a080a4c8ee9eef6 : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a0ec16818fee4231961e6facb772b56c : SUCCESS in 4m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aa54301dacd8470590375b3e992d73af : SUCCESS in 5m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b82a443d6e6d4b1ba15109c6fb9ef51e : SUCCESS in 5m 46s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/3ad06ec055354bc0a4e81ec43f13fe1c : SUCCESS in 5m 16s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/3b348101f96e459295f26755d131de2c : SUCCESS in 9m 06s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/fbbe6fd63458439bbd7041e68b87c1ed : SUCCESS in 19m 03s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/0118b588a0bb4a1c8d0f223034765ed8 : SUCCESS in 1h 11m 47s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/475866d502ed4051a9da3c3697681fed : SUCCESS in 16m 01s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/deabf279fe404712915fe07621b8cdd6 : SUCCESS in 1h 56m 09s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/03b56f4383ec4c3e9ec5cac8a1eae2f7 : SUCCESS in 18m 44s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/ec427198d8f445d683769143ed0d7627 : SUCCESS in 29m 35s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/0c2f277052964f00b3af430168b99017 : SUCCESS in 11m 09s","accounts_in_message":[],"_revision_number":1},{"id":"cf51754ca90608c45dc0c7521165f4159d6249ec","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 12:53:03.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/545babaf16284c07bbb114d734a2f54b : SUCCESS in 52s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0bc547f75ef9347e9852f109d85f6b70d844d240","revisions":{"0bc547f75ef9347e9852f109d85f6b70d844d240":{"kind":"REWORK","_number":1,"created":"2020-11-04 09:35:10.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/30/761330/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/30/761330/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/30/761330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/30/761330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/30/761330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/30/761330/1"}}},"commit":{"parents":[{"commit":"7136a3e8fe6a45c134aa6c0107bd545541594449","subject":"Synchronise global extra variables file with defaults","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/7136a3e8fe6a45c134aa6c0107bd545541594449"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-10-07 19:04:01.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-11-04 09:35:01.000000000","tz":0},"subject":"Fix filtering of network names set to an empty string","message":"Fix filtering of network names set to an empty string\n\nCurrently we filter out networks that are set to None. However, we\nshould also filter out networks set to an empty string. This affects the\novercloud ironic networks that were disabled in\nI300d0ef136224126f25d2c70a80a42afeea5f586 when ironic is disabled.\n\nStory: 2008207\nTask: 41076\n\nChange-Id: Iba16d6232e1a6ef069cd3ccb870e5bfa89cd913c\n(cherry picked from commit d2109e1c35011fcaeec368eb1b8bf6a9ec75e238)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/0bc547f75ef9347e9852f109d85f6b70d844d240"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/0bc547f75ef9347e9852f109d85f6b70d844d240"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}