)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8cdf76066a0f9d5455958d82ad77bd45bb518322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"39c12520_c92be50f","updated":"2021-11-24 15:58:13.000000000","message":"Looks good - I\u0027m not sure what the status of the release is so leaving the W+1 for someone else.","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5504a6a224535c2121a08b9ac493500d07e0dcae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1ed68611_7c879eab","updated":"2021-11-25 13:57:47.000000000","message":"recheck","commit_id":"bc91239aedb36fa4a7401db0a765ab00a97614c3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"de83b5275d157b15a7fe7b943060d91dd76b9fc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"b9a3a2fe_81e0b47c","updated":"2021-11-26 09:23:11.000000000","message":"Looks good, I see the image build run here: https://zuul.opendev.org/t/openstack/build/3993594562ce4db8a1c36bf404422835/log/primary/ansible/seed-deploy#34221","commit_id":"c35f112a14d5e5bd49bd49429179b49b5ae0da40"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"5f312a224ad8333027a1dea732c713a8e1a4deb0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1d664407_2981f783","updated":"2021-11-26 13:28:25.000000000","message":"recheck","commit_id":"c35f112a14d5e5bd49bd49429179b49b5ae0da40"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"8132409a8cd765e24bcf505b8fe82765259c72f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6e716838_83739a32","updated":"2021-11-26 19:58:36.000000000","message":"recheck","commit_id":"c35f112a14d5e5bd49bd49429179b49b5ae0da40"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4d792598f6d62624608e2d16f1f3210dae630ec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"575ab194_0c1cb71a","in_reply_to":"b9a3a2fe_81e0b47c","updated":"2021-11-26 10:25:20.000000000","message":"You can also look at DIB logs at https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_854/772609/23/check/kayobe-seed-centos8s/854a328/primary/kayobe/deployment_image.stdout","commit_id":"c35f112a14d5e5bd49bd49429179b49b5ae0da40"}],"ansible/group_vars/all/dib":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Overcloud host disk image configuration."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"###############################################################################"},{"line_number":5,"context_line":"# Diskimage-builder configuration for overcloud host disk images."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"20091aaf_96b9c1e7","line":2,"updated":"2021-10-06 10:19:10.000000000","message":"Mulling over whether dib is specific enough as a filename/prefix, given we use DIB in other places...","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a5acd044199107b414c1d9e2df616d1688dd5630","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Overcloud host disk image configuration."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"###############################################################################"},{"line_number":5,"context_line":"# Diskimage-builder configuration for overcloud host disk images."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"2325f727_776464a9","line":2,"in_reply_to":"08c4c643_6eb0faee","updated":"2021-10-06 11:27:55.000000000","message":"I think overcloud_host_image_dib would be the most appropriate prefix, but it would lead to quite long variable names. How about overcloud_image_dib, or even overcloud_dib?","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Overcloud host disk image configuration."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"###############################################################################"},{"line_number":5,"context_line":"# Diskimage-builder configuration for overcloud host disk images."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"08c4c643_6eb0faee","line":2,"in_reply_to":"20091aaf_96b9c1e7","updated":"2021-10-06 10:42:16.000000000","message":"I am not really happy with the naming either. What about a \"host_image\" or \"hostimage\" prefix? e.g.\n\nhostimage_dib_os_element:\n\nOR\n\nhost_image_dib_os_element:","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# Whether to build host disk images with DIB directly instead of through"},{"line_number":8,"context_line":"# Bifrost. Setting it to true disables Bifrost image build and allows images to"},{"line_number":9,"context_line":"# be built with the `kayobe overcloud host image build` command. Default value"},{"line_number":10,"context_line":"# is False. This will change in a future release."},{"line_number":11,"context_line":"dib_build_host_images: False"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# DIB base OS element. Default is {{ os_distribution }}."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"52df4d00_b817f719","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":49},"updated":"2021-10-06 10:19:10.000000000","message":"What\u0027s the reason for starting with false?","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# Whether to build host disk images with DIB directly instead of through"},{"line_number":8,"context_line":"# Bifrost. Setting it to true disables Bifrost image build and allows images to"},{"line_number":9,"context_line":"# be built with the `kayobe overcloud host image build` command. Default value"},{"line_number":10,"context_line":"# is False. This will change in a future release."},{"line_number":11,"context_line":"dib_build_host_images: False"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# DIB base OS element. Default is {{ os_distribution }}."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"bc364eb5_cde4c9b6","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":49},"in_reply_to":"52df4d00_b817f719","updated":"2021-10-06 10:42:16.000000000","message":"Just thinking of giving some time to users to migrate to this approach.","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a5acd044199107b414c1d9e2df616d1688dd5630","unresolved":true,"context_lines":[{"line_number":7,"context_line":"# Whether to build host disk images with DIB directly instead of through"},{"line_number":8,"context_line":"# Bifrost. Setting it to true disables Bifrost image build and allows images to"},{"line_number":9,"context_line":"# be built with the `kayobe overcloud host image build` command. Default value"},{"line_number":10,"context_line":"# is False. This will change in a future release."},{"line_number":11,"context_line":"dib_build_host_images: False"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# DIB base OS element. Default is {{ os_distribution }}."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"b09ddf87_ad2428d1","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":49},"in_reply_to":"bc364eb5_cde4c9b6","updated":"2021-10-06 11:27:55.000000000","message":"I suppose that\u0027s reasonable.","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# List of all DIB elements."},{"line_number":32,"context_line":"dib_elements: \"{{ dib_elements_default | select | list + dib_elements_extra }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# DIB init element."},{"line_number":35,"context_line":"dib_init_element: \"cloud-init-datasources\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# DIB default environment variables."},{"line_number":38,"context_line":"dib_env_vars_default:"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"17f08767_08b7e1bc","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":42},"updated":"2021-10-06 10:19:10.000000000","message":"I don\u0027t think this is being used. Bifrost adds this to the list of elements. Maybe we should drop this variable and just add it to dib_elements_default?","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# List of all DIB elements."},{"line_number":32,"context_line":"dib_elements: \"{{ dib_elements_default | select | list + dib_elements_extra }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# DIB init element."},{"line_number":35,"context_line":"dib_init_element: \"cloud-init-datasources\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# DIB default environment variables."},{"line_number":38,"context_line":"dib_env_vars_default:"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"d59d6417_82164cca","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":42},"in_reply_to":"17f08767_08b7e1bc","updated":"2021-10-06 10:42:16.000000000","message":"Done","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":35,"context_line":"dib_init_element: \"cloud-init-datasources\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# DIB default environment variables."},{"line_number":38,"context_line":"dib_env_vars_default:"},{"line_number":39,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":40,"context_line":"  DIB_RELEASE: \"{{ dib_os_release }}\""},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"48e947bb_2f0349c2","line":38,"updated":"2021-10-06 10:19:10.000000000","message":"DIB_BOOTLOADER_DEFAULT_CMDLINE: \"nofb nomodeset gfxpayload\u003dtext net.ifnames\u003d1\"","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"dib_init_element: \"cloud-init-datasources\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# DIB default environment variables."},{"line_number":38,"context_line":"dib_env_vars_default:"},{"line_number":39,"context_line":"  DIB_CLOUD_INIT_DATASOURCES: \"ConfigDrive\""},{"line_number":40,"context_line":"  DIB_RELEASE: \"{{ dib_os_release }}\""},{"line_number":41,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"d3701fee_bd4900fa","line":38,"in_reply_to":"48e947bb_2f0349c2","updated":"2021-10-06 10:42:16.000000000","message":"Done","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"}],"ansible/group_vars/all/overcloud-dib":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"501fb944bc1dc001407ba48bcfa40e1910371801","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"overcloud_dib_elements_default:"},{"line_number":24,"context_line":"  - \"{{ dib_os_element }}\""},{"line_number":25,"context_line":"  - \"cloud-init-datasources\""},{"line_number":26,"context_line":"  - \"{% if dib_os_element \u003d\u003d \u0027centos\u0027 %}disable-selinux{% endif %}\""},{"line_number":27,"context_line":"  - \"enable-serial-console\""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"99d9c134_f4d9e09a","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":22},"updated":"2021-10-26 09:26:32.000000000","message":"overcloud_","commit_id":"bd5bdcc01513c7107a36b8fc9cf62d2d5f55cc93"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"501fb944bc1dc001407ba48bcfa40e1910371801","unresolved":true,"context_lines":[{"line_number":23,"context_line":"overcloud_dib_elements_default:"},{"line_number":24,"context_line":"  - \"{{ dib_os_element }}\""},{"line_number":25,"context_line":"  - \"cloud-init-datasources\""},{"line_number":26,"context_line":"  - \"{% if dib_os_element \u003d\u003d \u0027centos\u0027 %}disable-selinux{% endif %}\""},{"line_number":27,"context_line":"  - \"enable-serial-console\""},{"line_number":28,"context_line":"  - \"vm\""},{"line_number":29,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":12,"id":"a7dc9371_1d18ce17","line":26,"range":{"start_line":26,"start_character":11,"end_line":26,"end_character":25},"updated":"2021-10-26 09:26:32.000000000","message":"overcloud_","commit_id":"bd5bdcc01513c7107a36b8fc9cf62d2d5f55cc93"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"21ef1183d959bb2e58dcd3c1e74f4df114c87a83","unresolved":true,"context_lines":[{"line_number":17,"context_line":"overcloud_dib_os_release: \"{{ os_release }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"overcloud_dib_elements_default:"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"c3e95ee8_cca45f01","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":71},"updated":"2021-11-01 10:06:05.000000000","message":"overcloud_","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67af855cdcac0bda8edca48b6b51686f7e35e8a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"overcloud_dib_os_release: \"{{ os_release }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"overcloud_dib_elements_default:"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"3ef1db71_3f8f30f9","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":71},"in_reply_to":"c3e95ee8_cca45f01","updated":"2021-11-04 10:00:35.000000000","message":"Done","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"21ef1183d959bb2e58dcd3c1e74f4df114c87a83","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"overcloud_dib_elements_default:"},{"line_number":24,"context_line":"  - \"{{ overcloud_dib_os_element }}\""},{"line_number":25,"context_line":"  - \"cloud-init-datasources\""}],"source_content_type":"application/octet-stream","patch_set":17,"id":"16132fb0_cb442d38","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":27},"updated":"2021-11-01 10:06:05.000000000","message":"overcloud_","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67af855cdcac0bda8edca48b6b51686f7e35e8a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"overcloud_dib_elements_default:"},{"line_number":24,"context_line":"  - \"{{ overcloud_dib_os_element }}\""},{"line_number":25,"context_line":"  - \"cloud-init-datasources\""}],"source_content_type":"application/octet-stream","patch_set":17,"id":"f9e0b51e_7c330682","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":27},"in_reply_to":"16132fb0_cb442d38","updated":"2021-11-04 10:00:35.000000000","message":"Done","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"}],"ansible/overcloud-host-image-build.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"501fb944bc1dc001407ba48bcfa40e1910371801","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            -a \"src\u003d/etc/bifrost/{{ item }} dest\u003d/httpboot/{{ item }}\""},{"line_number":49,"context_line":"            -e \"ansible_python_interpreter\u003d/var/lib/kolla/venv/bin/python\"\u0027"},{"line_number":50,"context_line":"          with_items: \"{{ overcloud_host_disk_images }}\""},{"line_number":51,"context_line":"      when: dib_build_host_images | bool"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"971ac18d_b26eb72c","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":33},"updated":"2021-10-26 09:26:32.000000000","message":"overcloud_","commit_id":"bd5bdcc01513c7107a36b8fc9cf62d2d5f55cc93"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"e80868a5b54d0774b654e867ab763cc4de341f33","unresolved":true,"context_lines":[{"line_number":19,"context_line":"          vars:"},{"line_number":20,"context_line":"            os_images_venv: \"{{ virtualenv_path }}/overcloud-host-image-dib\""},{"line_number":21,"context_line":"            os_images_package_state: latest"},{"line_number":22,"context_line":"            os_images_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":23,"context_line":"            os_images_cache: \"{{ image_cache_path }}\""},{"line_number":24,"context_line":"            os_images_common: \"\""},{"line_number":25,"context_line":"            os_images_list:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"a365ac98_06a96d77","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":76},"updated":"2021-11-19 14:59:14.000000000","message":"This is likely to cause trouble with outdated default DIB elements, could change it in a follow up.","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd12ebba4a573dfca0a09642aa34d869cdbc176e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"          vars:"},{"line_number":20,"context_line":"            os_images_venv: \"{{ virtualenv_path }}/overcloud-host-image-dib\""},{"line_number":21,"context_line":"            os_images_package_state: latest"},{"line_number":22,"context_line":"            os_images_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":23,"context_line":"            os_images_cache: \"{{ image_cache_path }}\""},{"line_number":24,"context_line":"            os_images_common: \"\""},{"line_number":25,"context_line":"            os_images_list:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4fcb934a_0b83f0ec","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":76},"in_reply_to":"4688e057_72aa7412","updated":"2021-11-29 09:08:16.000000000","message":"It should be customisable via os_images_upper_constraints_file","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67b68aee2e9f3c719067b972dc0e79387595c342","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          vars:"},{"line_number":20,"context_line":"            os_images_venv: \"{{ virtualenv_path }}/overcloud-host-image-dib\""},{"line_number":21,"context_line":"            os_images_package_state: latest"},{"line_number":22,"context_line":"            os_images_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":23,"context_line":"            os_images_cache: \"{{ image_cache_path }}\""},{"line_number":24,"context_line":"            os_images_common: \"\""},{"line_number":25,"context_line":"            os_images_list:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c5b9aafd_c91d58d5","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":76},"in_reply_to":"4f168673_fc457c17","updated":"2021-11-29 11:51:12.000000000","message":"https://review.opendev.org/c/openstack/kayobe/+/819630","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5afeef1ee2a9ff1da8482a992285788e140afcfa","unresolved":true,"context_lines":[{"line_number":19,"context_line":"          vars:"},{"line_number":20,"context_line":"            os_images_venv: \"{{ virtualenv_path }}/overcloud-host-image-dib\""},{"line_number":21,"context_line":"            os_images_package_state: latest"},{"line_number":22,"context_line":"            os_images_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":23,"context_line":"            os_images_cache: \"{{ image_cache_path }}\""},{"line_number":24,"context_line":"            os_images_common: \"\""},{"line_number":25,"context_line":"            os_images_list:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4f168673_fc457c17","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":76},"in_reply_to":"4fcb934a_0b83f0ec","updated":"2021-11-29 10:51:43.000000000","message":"Indeed. I was talking about exposing it as an extra var, like we did with ipa_build_upper_constraints_file.","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bab77fcddb7040fbcc8051077e3235809e5db4b2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"          vars:"},{"line_number":20,"context_line":"            os_images_venv: \"{{ virtualenv_path }}/overcloud-host-image-dib\""},{"line_number":21,"context_line":"            os_images_package_state: latest"},{"line_number":22,"context_line":"            os_images_upper_constraints_file: \"{{ pip_upper_constraints_file }}\""},{"line_number":23,"context_line":"            os_images_cache: \"{{ image_cache_path }}\""},{"line_number":24,"context_line":"            os_images_common: \"\""},{"line_number":25,"context_line":"            os_images_list:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4688e057_72aa7412","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":76},"in_reply_to":"a365ac98_06a96d77","updated":"2021-11-26 08:28:34.000000000","message":"We can make it customisable in a follow up.","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":32657,"name":"Piotr Parczewski","email":"piotr@stackhpc.com","username":"piotrp"},"change_message_id":"e80868a5b54d0774b654e867ab763cc4de341f33","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        - name: Copy overcloud host disk image into /httpboot"},{"line_number":43,"context_line":"          command: \u003e"},{"line_number":44,"context_line":"            docker exec bifrost_deploy"},{"line_number":45,"context_line":"            bash -c \u0027export OS_CLOUD\u003dbifrost \u0026\u0026"},{"line_number":46,"context_line":"            ansible -vvvv target -i /bifrost/playbooks/inventory/target"},{"line_number":47,"context_line":"            -m copy"},{"line_number":48,"context_line":"            -a \"src\u003d/etc/bifrost/{{ item }} dest\u003d/httpboot/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"67058079_4742ae98","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":44},"updated":"2021-11-19 14:59:14.000000000","message":"It\u0027s probably not needed.","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bab77fcddb7040fbcc8051077e3235809e5db4b2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        - name: Copy overcloud host disk image into /httpboot"},{"line_number":43,"context_line":"          command: \u003e"},{"line_number":44,"context_line":"            docker exec bifrost_deploy"},{"line_number":45,"context_line":"            bash -c \u0027export OS_CLOUD\u003dbifrost \u0026\u0026"},{"line_number":46,"context_line":"            ansible -vvvv target -i /bifrost/playbooks/inventory/target"},{"line_number":47,"context_line":"            -m copy"},{"line_number":48,"context_line":"            -a \"src\u003d/etc/bifrost/{{ item }} dest\u003d/httpboot/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c57c3ba8_42eb8b1f","line":45,"range":{"start_line":45,"start_character":21,"end_line":45,"end_character":44},"in_reply_to":"67058079_4742ae98","updated":"2021-11-26 08:28:34.000000000","message":"Done","commit_id":"739a5e4d73b1b5fa880cffc9db192ae43084ff00"}],"ansible/roles/kolla-bifrost/templates/dib.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"501fb944bc1dc001407ba48bcfa40e1910371801","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% if not dib_build_host_images | bool %}"},{"line_number":3,"context_line":"# Diskimage-builder element for base OS."},{"line_number":4,"context_line":"dib_os_element: \"{{ kolla_bifrost_dib_os_element }}\""},{"line_number":5,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"cf472f60_75e097d1","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":31},"updated":"2021-10-26 09:26:32.000000000","message":"overcloud_","commit_id":"bd5bdcc01513c7107a36b8fc9cf62d2d5f55cc93"}],"etc/kayobe/overcloud-dib.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"21ef1183d959bb2e58dcd3c1e74f4df114c87a83","unresolved":true,"context_lines":[{"line_number":17,"context_line":"#overcloud_dib_os_release:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"#overcloud_dib_elements_default:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"13a63d51_61e6fca2","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":71},"updated":"2021-11-01 10:06:05.000000000","message":"ditto","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67af855cdcac0bda8edca48b6b51686f7e35e8a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#overcloud_dib_os_release:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"#overcloud_dib_elements_default:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"de2d15b2_9ca83f48","line":20,"range":{"start_line":20,"start_character":57,"end_line":20,"end_character":71},"in_reply_to":"13a63d51_61e6fca2","updated":"2021-11-04 10:00:35.000000000","message":"Done","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"21ef1183d959bb2e58dcd3c1e74f4df114c87a83","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"#overcloud_dib_elements_default:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# List of additional DIB elements. Default is none."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"72828211_469b39ca","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":27},"updated":"2021-11-01 10:06:05.000000000","message":"ditto","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"67af855cdcac0bda8edca48b6b51686f7e35e8a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# List of default DIB elements. Default is [\"centos\", \"cloud-init-datasources\","},{"line_number":20,"context_line":"# \"disable-selinux\", \"enable-serial-console\", \"vm\"] when dib_os_element is"},{"line_number":21,"context_line":"# \"centos\", or [\"ubuntu\", \"cloud-init-datasources\", \"enable-serial-console\","},{"line_number":22,"context_line":"# \"vm\"] when dib_os_element is \"ubuntu\"."},{"line_number":23,"context_line":"#overcloud_dib_elements_default:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# List of additional DIB elements. Default is none."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3181170e_3d8df670","line":22,"range":{"start_line":22,"start_character":13,"end_line":22,"end_character":27},"in_reply_to":"72828211_469b39ca","updated":"2021-11-04 10:00:35.000000000","message":"Done","commit_id":"41a960aad8b4ec2bd941e2e80a36812cc25f1b1e"}],"kayobe/cli/commands.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"        playbooks \u003d _build_playbook_list(\"overcloud-host-image-build\")"},{"line_number":1785,"context_line":"        extra_vars \u003d {}"},{"line_number":1786,"context_line":"        if parsed_args.force_rebuild:"},{"line_number":1787,"context_line":"            extra_vars[\"host_image_force_rebuild\"] \u003d True"},{"line_number":1788,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":1789,"context_line":"                                  extra_vars\u003dextra_vars)"},{"line_number":1790,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"e39ca509_f23425f4","line":1787,"range":{"start_line":1787,"start_character":24,"end_line":1787,"end_character":48},"updated":"2021-10-06 10:19:10.000000000","message":"The variable in the playbook is overcloud_host_image_force_rebuild","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":false,"context_lines":[{"line_number":1784,"context_line":"        playbooks \u003d _build_playbook_list(\"overcloud-host-image-build\")"},{"line_number":1785,"context_line":"        extra_vars \u003d {}"},{"line_number":1786,"context_line":"        if parsed_args.force_rebuild:"},{"line_number":1787,"context_line":"            extra_vars[\"host_image_force_rebuild\"] \u003d True"},{"line_number":1788,"context_line":"        self.run_kayobe_playbooks(parsed_args, playbooks,"},{"line_number":1789,"context_line":"                                  extra_vars\u003dextra_vars)"},{"line_number":1790,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5b5419cd_23e7782b","line":1787,"range":{"start_line":1787,"start_character":24,"end_line":1787,"end_character":48},"in_reply_to":"e39ca509_f23425f4","updated":"2021-10-06 10:42:16.000000000","message":"I\u0027ve fixed it when it got caught by unit tests but mistakenly included it in the next patch. I\u0027ll update.","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"}],"setup.cfg":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"38854c53da2f0414c440e31c7d82cdeddfa24591","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    infra_vm_host_package_update \u003d kayobe.cli.commands:InfraVMHostPackageUpdate"},{"line_number":104,"context_line":"    infra_vm_service_deploy \u003d kayobe.cli.commands:InfraVMServiceDeploy"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"kayobe.cli.baremetal_compute_inspect \u003d"},{"line_number":107,"context_line":"    hooks \u003d kayobe.cli.commands:HookDispatcher"},{"line_number":108,"context_line":"kayobe.cli.baremetal_compute_manage \u003d"},{"line_number":109,"context_line":"    hooks \u003d kayobe.cli.commands:HookDispatcher"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bcc42467_dcc7b4fd","line":106,"updated":"2021-10-06 10:19:10.000000000","message":"Hook me","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0d5dab46bebeccc6ef81ce1aae206602babfa3d7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    infra_vm_host_package_update \u003d kayobe.cli.commands:InfraVMHostPackageUpdate"},{"line_number":104,"context_line":"    infra_vm_service_deploy \u003d kayobe.cli.commands:InfraVMServiceDeploy"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"kayobe.cli.baremetal_compute_inspect \u003d"},{"line_number":107,"context_line":"    hooks \u003d kayobe.cli.commands:HookDispatcher"},{"line_number":108,"context_line":"kayobe.cli.baremetal_compute_manage \u003d"},{"line_number":109,"context_line":"    hooks \u003d kayobe.cli.commands:HookDispatcher"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"cfc25c24_f50121b8","line":106,"in_reply_to":"bcc42467_dcc7b4fd","updated":"2021-10-06 10:42:16.000000000","message":"Good catch.","commit_id":"f879b0767ed5f834c31bf7c04e52fc27adaa45a1"}]}