)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3e85582e129611410e7b01bdaaaa104d7998f26e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"It also needs changes in the way we interact with Bifrost to avoid using"},{"line_number":17,"context_line":"the env-vars file which has been removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe/+/772607"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, it requires building seed deployment images only after"},{"line_number":22,"context_line":"deploying Bifrost, because the task copying images onto the seed expects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"cdc8375d_1a4ee02b","line":19,"updated":"2021-01-28 09:11:23.000000000","message":"It doesn\u0027t seem to be picking this one up. TBH I\u0027ve been using the old URL format for Depends-On, https://review.opendev.org/772607","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"42b04140bcba5649b0c611793df65c40a1a8ae65","unresolved":true,"context_lines":[{"line_number":16,"context_line":"It also needs changes in the way we interact with Bifrost to avoid using"},{"line_number":17,"context_line":"the env-vars file which has been removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe/+/772607"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, it requires building seed deployment images only after"},{"line_number":22,"context_line":"deploying Bifrost, because the task copying images onto the seed expects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a5d559b2_a33930bf","line":19,"in_reply_to":"1160ea05_74789753","updated":"2021-01-28 09:38:58.000000000","message":"Why do you think it didn\u0027t pick it up? The build succeeded once I added it: https://35022c4304e2decd78d6-9933acd47b53ada512f504475355512f.ssl.cf5.rackcdn.com/772751/4/check/kayobe-seed-centos8/4a3cccd/primary/ansible/seed-deploy","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3878a887ee23600071e8a4d5a967a5fcf212b067","unresolved":true,"context_lines":[{"line_number":16,"context_line":"It also needs changes in the way we interact with Bifrost to avoid using"},{"line_number":17,"context_line":"the env-vars file which has been removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe/+/772607"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, it requires building seed deployment images only after"},{"line_number":22,"context_line":"deploying Bifrost, because the task copying images onto the seed expects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"177d0a1d_d47b03ae","line":19,"in_reply_to":"2cc7ac09_9a670568","updated":"2021-01-28 09:48:07.000000000","message":"It was still an incomplete CI run, the job logs were only available via Zuul dashboard.","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"15b37c46f3d21630aac2fe4f119c06c59c91ec3e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"It also needs changes in the way we interact with Bifrost to avoid using"},{"line_number":17,"context_line":"the env-vars file which has been removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe/+/772607"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, it requires building seed deployment images only after"},{"line_number":22,"context_line":"deploying Bifrost, because the task copying images onto the seed expects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2cc7ac09_9a670568","line":19,"in_reply_to":"a5d559b2_a33930bf","updated":"2021-01-28 09:45:38.000000000","message":"Perhaps I was looking at the wrong zuul results.","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"57ebfcd821fb750f37f37a03f2cc7877459a52dc","unresolved":true,"context_lines":[{"line_number":16,"context_line":"It also needs changes in the way we interact with Bifrost to avoid using"},{"line_number":17,"context_line":"the env-vars file which has been removed."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe/+/772607"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, it requires building seed deployment images only after"},{"line_number":22,"context_line":"deploying Bifrost, because the task copying images onto the seed expects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1160ea05_74789753","line":19,"in_reply_to":"cdc8375d_1a4ee02b","updated":"2021-01-28 09:33:27.000000000","message":"Actually, I remember someone saying all the Gerrit magic needs to be in a single block.","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"}],"dev/functions":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6f1d4e5cf5f1a354b955eecaddacc6f577284a5f","unresolved":true,"context_lines":[{"line_number":295,"context_line":"        run_kayobe seed service deploy"},{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    # Note: This must currently be done before host configure, because host"},{"line_number":299,"context_line":"    # configure runs kolla-ansible.yml, which validates the presence of the"},{"line_number":300,"context_line":"    # built deploy images."},{"line_number":301,"context_line":"    if is_deploy_image_built_locally; then"},{"line_number":302,"context_line":"        echo \"Building seed deployment images\""},{"line_number":303,"context_line":"        run_kayobe seed deployment image build"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"6682d589_30568d03","line":300,"range":{"start_line":298,"start_character":4,"end_line":300,"end_character":26},"updated":"2021-01-28 09:07:26.000000000","message":"I guess that\u0027s no longer true?","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"49f190acb4618917e8a78f07f736a3355514ac4a","unresolved":true,"context_lines":[{"line_number":295,"context_line":"        run_kayobe seed service deploy"},{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    # Note: This must currently be done before host configure, because host"},{"line_number":299,"context_line":"    # configure runs kolla-ansible.yml, which validates the presence of the"},{"line_number":300,"context_line":"    # built deploy images."},{"line_number":301,"context_line":"    if is_deploy_image_built_locally; then"},{"line_number":302,"context_line":"        echo \"Building seed deployment images\""},{"line_number":303,"context_line":"        run_kayobe seed deployment image build"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"79fb5f4d_b8340dd1","line":300,"range":{"start_line":298,"start_character":4,"end_line":300,"end_character":26},"in_reply_to":"6682d589_30568d03","updated":"2021-01-28 09:35:26.000000000","message":"I wanted to ask you about the meaning of this comment. Even in the original version of this code (Jan 2018), host configure is run before deployment image build. The code which validates the presence of locally built Ironic Python Agent (IPA) images is actually in kolla-openstack.yml and is run on controllers only when ironic is enabled.","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fbfc1fc58cdf51e5e50fc5b62a7c91b44982db54","unresolved":true,"context_lines":[{"line_number":295,"context_line":"        run_kayobe seed service deploy"},{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    # Note: This must currently be done before host configure, because host"},{"line_number":299,"context_line":"    # configure runs kolla-ansible.yml, which validates the presence of the"},{"line_number":300,"context_line":"    # built deploy images."},{"line_number":301,"context_line":"    if is_deploy_image_built_locally; then"},{"line_number":302,"context_line":"        echo \"Building seed deployment images\""},{"line_number":303,"context_line":"        run_kayobe seed deployment image build"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"22fbd1e5_4be7878b","line":300,"range":{"start_line":298,"start_character":4,"end_line":300,"end_character":26},"in_reply_to":"79fb5f4d_b8340dd1","updated":"2021-01-28 09:38:32.000000000","message":"Either the comment is incorrect, or the order of the code is wrong. Either way, my mistake 😊\n\nIt could have been a copy/paste from the overcloud_deploy function. The same applies there though","commit_id":"e4baa60e0b00cc84c34211b4ab3522d8abb66d4f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"350e152f1b9bce55d145b36b01f7d8de397357cb","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        run_kayobe seed deployment image build"},{"line_number":301,"context_line":"    else"},{"line_number":302,"context_line":"        echo \"Not building seed deployment images\""},{"line_number":303,"context_line":"    fi"},{"line_number":304,"context_line":"}"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"function seed_upgrade {"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"daea2983_642a70f7","line":303,"updated":"2021-02-09 10:27:36.000000000","message":"Checked the docs and they agree with this ordering.","commit_id":"c84a9757dd449dbd8863bb1dcc55837abe26a716"}]}