)]}'
{"playbooks/kayobe-overcloud-base/pre.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7dec7713c244336716b0d3348bd2ddba0e65a77f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  environment:"},{"line_number":4,"context_line":"    KAYOBE_CONFIG_SOURCE_PATH: \"{{ kayobe_config_src_dir }}\""},{"line_number":5,"context_line":"  vars:"},{"line_number":6,"context_line":"    kayobe_environment: \"all-in-one\""},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"    # NOTE(mgoddard): Use the name zz-overrides.yml to ensure this takes"},{"line_number":9,"context_line":"    # precedence over the standard config files."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fed8f91f_144e958d","line":6,"updated":"2021-03-10 14:07:49.000000000","message":"This is going to be a bit fiddly. There are two ways through I can see.\n\n1. Provide a zuul variable that determines whether an environment is used, default to False. Then in the kayobe-config-dev patch, override the jobs to set the variable to True. Once that merges, kayobe CI will break until we set the variable to True.\n\n2. Check whether the environments directory exists and set a fact. This could be factored out into a role to keep it DRY.\n\nIn each case, I think it makes sense to define a kayobe_env_config_path variable which has the same meaning as the Kayobe variable, and use that in the tasks below.\n\nUpgrades will need consideration too. The second more dynamic approach might be better at keeping things working when Wallaby becomes the previous release.","commit_id":"00d584f58b6d6e9ae0762edf14192564179607dd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c867988dcf1f03a0be4667e6d299a9b77fe21478","unresolved":true,"context_lines":[{"line_number":19,"context_line":"        bridge_prefix: 24"},{"line_number":20,"context_line":"        bridge_port_interface: dummy1"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - block:"},{"line_number":23,"context_line":"      - name: Create environment directory"},{"line_number":24,"context_line":"        file:"},{"line_number":25,"context_line":"          path: \"{{ kayobe_env_config_path }}\""},{"line_number":26,"context_line":"          state: directory"},{"line_number":27,"context_line":"      - name: Find configuration to move to environment"},{"line_number":28,"context_line":"        find:"},{"line_number":29,"context_line":"          path: \"{{ kayobe_config_src_dir ~ \u0027/etc/kayobe\u0027 }}\""},{"line_number":30,"context_line":"          excludes:"},{"line_number":31,"context_line":"            - \"ansible\""},{"line_number":32,"context_line":"            - \"environments\""},{"line_number":33,"context_line":"            - \"hooks\""},{"line_number":34,"context_line":"          file_type: \"any\""},{"line_number":35,"context_line":"        register: find_result"},{"line_number":36,"context_line":"      - name: Move configuration to environment directory"},{"line_number":37,"context_line":"        command: mv {{ item.path }} {{ kayobe_env_config_path }}"},{"line_number":38,"context_line":"        with_items: \"{{ find_result.files }}\""},{"line_number":39,"context_line":"        loop_control:"},{"line_number":40,"context_line":"          label: \"{{ item.path }}\""},{"line_number":41,"context_line":"      when: kayobe_env | length \u003e 0"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    # NOTE(mgoddard): Use the name zz-overrides.yml to ensure this takes"},{"line_number":44,"context_line":"    # precedence over the standard config files."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d9d1abd1_94dc3ccb","line":41,"range":{"start_line":22,"start_character":0,"end_line":41,"end_character":35},"updated":"2021-03-31 09:11:06.000000000","message":"Could make this a role in roles/. Would be nice if we could use the new command though.","commit_id":"e79e9efe6278c9c60336204ec3874cf431c20365"}]}
