)]}'
{"id":"openstack%2Fkayobe~776414","triplet_id":"openstack%2Fkayobe~master~Iabd57568fe42b27d65c4a858caddd4cadd4e9221","project":"openstack/kayobe","branch":"master","attention_set":{},"removed_from_attention_set":{"14200":{"account":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"last_update":"2023-11-01 16:31:32.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Iabd57568fe42b27d65c4a858caddd4cadd4e9221","subject":"Fix veth pair creation with VLAN interfaces","status":"ABANDONED","created":"2021-02-18 10:22:30.000000000","updated":"2023-11-01 16:31:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0753dc56af251f7a20a952b733c9f9af10dc013b","_number":776414,"virtual_id_number":776414,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-02-18 12:03:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-18 12:03:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-08-27 00:01:05.000000000","updated_by":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"reviewer":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"state":"REVIEWER"}],"messages":[{"id":"74d1cd819849183450de6e893a7ca38ef7068848","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2021-02-18 10:22:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38b093f9714c23a1bdeb672bb601bc1a070f4cd3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 12:03:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c59e2e39761740ba9f9521f64bd9ed12 : SUCCESS in 7m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0fa8ed96bf57471c89d3943467a9b34c : SUCCESS in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/62be1d3b8200484f8aae8c1a58b46c01 : SUCCESS in 5m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aacf0c9823fc40f09337f11f273b3583 : SUCCESS in 5m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/24db186b00c74fa58a0ad9bf5f8726c6 : SUCCESS in 5m 41s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f4293c4f005a4af4ae2a4a227efe0547 : SUCCESS in 7m 30s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e924bdac8154464fbdaef8e1ce9e3cc5 : SUCCESS in 4m 18s\n- kayobe-tox-ansible-syntax https://zuul.opendev.org/t/openstack/build/2da4a673cf304d6b8e2ed66bc285f499 : SUCCESS in 4m 57s\n- kayobe-tox-ansible https://zuul.opendev.org/t/openstack/build/99fce8f14e634fe2adf45c3b5e1d51b7 : SUCCESS in 11m 08s\n- kayobe-tox-molecule https://zuul.opendev.org/t/openstack/build/b1724a53c76c42e9a3d82837f3a3027c : SUCCESS in 19m 59s\n- kayobe-overcloud-centos8 https://zuul.opendev.org/t/openstack/build/dc41bc7ecec14fe087b552892b8cb3c3 : SUCCESS in 57m 05s\n- kayobe-overcloud-tls-centos8 https://zuul.opendev.org/t/openstack/build/ae310da45099414db7807208dad72daf : SUCCESS in 1h 01m 50s\n- kayobe-overcloud-host-configure-centos8 https://zuul.opendev.org/t/openstack/build/fdc63d6b52e84645adb15f57180a48f3 : SUCCESS in 17m 17s\n- kayobe-overcloud-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/5fa1384f5249418ebde9efbbc0358cfd : SUCCESS in 1h 35m 42s\n- kayobe-seed-centos8 https://zuul.opendev.org/t/openstack/build/3ea189e847c8480ba2ed8777c64455cc : SUCCESS in 26m 55s\n- kayobe-seed-upgrade-centos8 https://zuul.opendev.org/t/openstack/build/567da93419e44714a7ffefe8d6348ed0 : SUCCESS in 21m 23s\n- kayobe-seed-vm-centos8 https://zuul.opendev.org/t/openstack/build/bdd31698478c499cac5d01324699a4c0 : SUCCESS in 11m 36s\n\nWarning:\n  Comments left for invalid file roles/kayobe-diagnostics/files/get_logs.sh\n  Comments left for invalid file tools/release.sh\n  Comments left for invalid file tools/test-ansible.sh","accounts_in_message":[],"_revision_number":1},{"id":"0753dc56af251f7a20a952b733c9f9af10dc013b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2023-11-01 16:31:32.000000000","message":"Abandoned\n\nNo longer required - fixed in I10d80713c4bac21b6aed6f4b6b15919d490b753c","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"839db3d8689d4a0f600ec2b43e714a4a6486a85d","revisions":{"839db3d8689d4a0f600ec2b43e714a4a6486a85d":{"kind":"REWORK","_number":1,"created":"2021-02-18 10:22:30.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/14/776414/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kayobe","ref":"refs/changes/14/776414/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/776414/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/776414/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kayobe refs/changes/14/776414/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kayobe refs/changes/14/776414/1"}}},"commit":{"parents":[{"commit":"b8ef36047cb0218bb83192ae4bcbf012fb06e0c8","subject":"Merge \"[docs] Improve contributor\u0027s automated setup document\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/b8ef36047cb0218bb83192ae4bcbf012fb06e0c8"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2021-02-18 10:17:54.000000000","tz":0},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2021-02-18 10:17:54.000000000","tz":0},"subject":"Fix veth pair creation with VLAN interfaces","message":"Fix veth pair creation with VLAN interfaces\n\nKayobe creates virtual Ethernet pairs between Linux and OVS bridges for\nthe Neutron external networks and Ironic provisioning and cleaning\nnetworks. If these networks are defined as VLANs (as is commonly done\nfor the ironic networks), Kayobe should use the underlying tagged\ninterface rather than the VLAN interface to plug into the OVS bridge.\n\nThe issue being fixed here is that Kayobe does not create virtual\nEthernet pairs for these networks when they are defined as VLANs. This\nmay have been masked by the fact that typically the neutron external\nnetwork is a bridge, and the Ironic networks VLAN interfaces on that\nbridge.\n\nExample of a broken setup:\n\n    external_net_names:\n      - ext\n\n    provision_wl_net_name: pwl\n\n    other_net_name: br1\n\n    ext_interface: br0\n\n    pwl_interface: br1.42\n\n    br1_interface: br1\n\nThis change fixes the issue by checking whether any network has a\nbridge interface that matches the VLAN\u0027s parent interface.\n\nChange-Id: Iabd57568fe42b27d65c4a858caddd4cadd4e9221\nStory: 2008634\nTask: 41874\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/839db3d8689d4a0f600ec2b43e714a4a6486a85d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kayobe/commit/839db3d8689d4a0f600ec2b43e714a4a6486a85d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}