)]}'
{"ansible/roles/kolla-bifrost/templates/bifrost.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"994fbe1294f35fa896155f96a15e58735d87cb73","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7004bc49_554d3376","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"updated":"2021-03-15 10:47:50.000000000","message":"Given that this has been released and works using a string, should we support both formats? I tested the following and it worked:\n\n- hosts: localhost\n  vars:\n    foo: x y z \n    bar:\n      - x \n      - y \n      - z \n  tasks:\n    - debug:\n        msg: \"{{ foo if foo is string else bar | join(\u0027 \u0027) }}\"\n\n    - debug:\n        msg: \"{{ bar if bar is string else bar | join(\u0027 \u0027) }}\"","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"33eac4b5151f7ad3d9f140cb19a02fc7c6f57796","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"89d3b74e_7f635193","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"in_reply_to":"2d93a807_33abe218","updated":"2021-03-15 13:33:04.000000000","message":"Something like this? https://review.opendev.org/c/openstack/kayobe/+/780585","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0db4212d97ec002d34626f9c2ceb981041026d9","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2d93a807_33abe218","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"in_reply_to":"3e7a68dc_0f0a69eb","updated":"2021-03-15 12:31:12.000000000","message":"Works for me, assuming we merge it at the same time.","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6ed71ff150f8706bf8940457359a93b798eaa2b3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a79bdd41_a80c2720","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"in_reply_to":"6b26cc74_9029d0bf","updated":"2021-03-15 11:23:41.000000000","message":"I expect you are right. My only concern is that it will fail in quite a subtle way, since the string will be treated as a list of characters in terms of the join. So \u0027xyz\u0027 would become \u0027x y z\u0027. I\u0027d be quite annoyed if I lost a day debugging that then found this conversation 😊","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"45d13e484598d758d15653b08ce053d3134b8010","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"6b26cc74_9029d0bf","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"in_reply_to":"7004bc49_554d3376","updated":"2021-03-15 11:02:18.000000000","message":"Thanks for the suggestion. However, given it is documented as a being a list, and other similar arguments expect a list too, I expect no one has used this feature yet, so I would prefer to keep it simple. What do you think?","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"75dfe0e6c404b1f4dd6cd4331b428ad4d9f8918c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% if kolla_bifrost_extra_kernel_options %}"},{"line_number":6,"context_line":"# List of extra kernel parameters for Bifrost\u0027s Ironic PXE configuration."},{"line_number":7,"context_line":"# Default is empty."},{"line_number":8,"context_line":"extra_kernel_options: \"{{ kolla_bifrost_extra_kernel_options | join(\u0027 \u0027) }}\""},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# IP address range for DHCP."}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3e7a68dc_0f0a69eb","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":60},"in_reply_to":"a79bdd41_a80c2720","updated":"2021-03-15 11:51:54.000000000","message":"What about a follow-up that applies this trick to all kernel option variables?","commit_id":"99f6addaca960fa80efe0c14dc436bccbf5aa3a5"}]}