)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some hosts in the kayobe inventory might not be in the kolla-ansible inventory"},{"line_number":10,"context_line":"so it makes sense for kayobe to manage NTP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iacb579a46b0e9769a4c404a858d17968f74dd7e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6eab75e0_c7815f2f","line":11,"updated":"2021-04-07 16:56:05.000000000","message":"https://storyboard.openstack.org/#!/story/2007872","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f70bdf86577f49db964659fb0f6dcf5caa1a5de","unresolved":true,"context_lines":[{"line_number":10,"context_line":"so it makes sense for kayobe to manage NTP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iacb579a46b0e9769a4c404a858d17968f74dd7e0"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/78604"},{"line_number":14,"context_line":"Story: https://storyboard.openstack.org/#!/story/2007872"},{"line_number":15,"context_line":"Task: 40240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fbea35d8_5b831131","line":13,"range":{"start_line":13,"start_character":71,"end_line":13,"end_character":76},"updated":"2021-04-14 08:55:39.000000000","message":"Change number is missing a 0: https://review.opendev.org/c/openstack/kayobe-config-dev/+/786040","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e169f75b241bc9026678bc59ee622c28b1d26b69","unresolved":false,"context_lines":[{"line_number":10,"context_line":"so it makes sense for kayobe to manage NTP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iacb579a46b0e9769a4c404a858d17968f74dd7e0"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/78604"},{"line_number":14,"context_line":"Story: https://storyboard.openstack.org/#!/story/2007872"},{"line_number":15,"context_line":"Task: 40240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"693732ad_a3af95e4","line":13,"range":{"start_line":13,"start_character":71,"end_line":13,"end_character":76},"in_reply_to":"fbea35d8_5b831131","updated":"2021-04-21 11:12:58.000000000","message":"Done","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for configuring chrony"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some hosts in the kayobe inventory might not be in the kolla-ansible inventory"},{"line_number":10,"context_line":"so it makes sense for kayobe to manage NTP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iacb579a46b0e9769a4c404a858d17968f74dd7e0"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/786040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6f6b2aa2_dac9b1cd","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":43},"updated":"2021-05-05 09:39:50.000000000","message":"Please wrap lines when you update the change.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2f75f75db1750bfbc94572a3d7714eda88791d2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for configuring chrony"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some hosts in the kayobe inventory might not be in the kolla-ansible inventory"},{"line_number":10,"context_line":"so it makes sense for kayobe to manage NTP."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iacb579a46b0e9769a4c404a858d17968f74dd7e0"},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kayobe-config-dev/+/786040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a3311107_02eb66a2","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":43},"in_reply_to":"6f6b2aa2_dac9b1cd","updated":"2021-05-06 14:16:53.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"ansible/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[{"line_number":469,"context_line":"kolla_enable_blazar: \"no\""},{"line_number":470,"context_line":"kolla_enable_ceilometer: \"no\""},{"line_number":471,"context_line":"kolla_enable_central_logging: \"no\""},{"line_number":472,"context_line":"kolla_enable_chrony: \"no\""},{"line_number":473,"context_line":"kolla_enable_cinder: \"no\""},{"line_number":474,"context_line":"kolla_enable_cinder_backend_iscsi: \"{{ kolla_enable_cinder_backend_lvm | bool or kolla_enable_cinder_backend_zfssa_iscsi | bool }}\""},{"line_number":475,"context_line":"kolla_enable_cinder_backend_lvm: \"no\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"52a32c3a_39d97633","line":472,"range":{"start_line":472,"start_character":22,"end_line":472,"end_character":24},"updated":"2021-04-07 16:56:05.000000000","message":"Do we need to stop chrony containers? We did have a stop-chrony.yml playbook at one point.","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5051bbf44cb350747f1744a2d25ec7f991ac845c","unresolved":true,"context_lines":[{"line_number":469,"context_line":"kolla_enable_blazar: \"no\""},{"line_number":470,"context_line":"kolla_enable_ceilometer: \"no\""},{"line_number":471,"context_line":"kolla_enable_central_logging: \"no\""},{"line_number":472,"context_line":"kolla_enable_chrony: \"no\""},{"line_number":473,"context_line":"kolla_enable_cinder: \"no\""},{"line_number":474,"context_line":"kolla_enable_cinder_backend_iscsi: \"{{ kolla_enable_cinder_backend_lvm | bool or kolla_enable_cinder_backend_zfssa_iscsi | bool }}\""},{"line_number":475,"context_line":"kolla_enable_cinder_backend_lvm: \"no\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ab738b42_2135a9b6","line":472,"range":{"start_line":472,"start_character":22,"end_line":472,"end_character":24},"in_reply_to":"52a32c3a_39d97633","updated":"2021-04-12 14:04:22.000000000","message":"Good call. I\u0027ll resurrect that playbook.","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"}],"ansible/roles/ntp/defaults/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"ntp_actions: [\"validate\", \"prepare\", \"deploy\"]"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ntp_service_disable_list:"},{"line_number":5,"context_line":"  - systemd-timesyncd.service"},{"line_number":6,"context_line":"  - ntp.service"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a67e2d5_55a2c2a6","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":15},"updated":"2021-05-05 09:39:50.000000000","message":"Nit: alphabetic order","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ntp_actions: [\"validate\", \"prepare\", \"deploy\"]"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ntp_service_disable_list:"},{"line_number":5,"context_line":"  - systemd-timesyncd.service"},{"line_number":6,"context_line":"  - ntp.service"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f1de9143_92d7c528","line":6,"range":{"start_line":5,"start_character":0,"end_line":6,"end_character":15},"in_reply_to":"9a67e2d5_55a2c2a6","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"ansible/roles/ntp/tasks/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Validate configuration"},{"line_number":3,"context_line":"  include_tasks: validate.yml"},{"line_number":4,"context_line":"  when:"},{"line_number":5,"context_line":"    - \u0027\"validate\" in ntp_actions\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Pre-deploy preparation"},{"line_number":8,"context_line":"  include_tasks: prepare.yml"},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - \u0027\"prepare\" in ntp_actions\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy service"},{"line_number":13,"context_line":"  include_tasks: deploy.yml"},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - \u0027\"deploy\" in ntp_actions\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"799573e3_b0629a10","line":15,"range":{"start_line":1,"start_character":0,"end_line":15,"end_character":31},"updated":"2021-05-05 09:39:50.000000000","message":"No need to use lists for when: ?","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Validate configuration"},{"line_number":3,"context_line":"  include_tasks: validate.yml"},{"line_number":4,"context_line":"  when:"},{"line_number":5,"context_line":"    - \u0027\"validate\" in ntp_actions\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Pre-deploy preparation"},{"line_number":8,"context_line":"  include_tasks: prepare.yml"},{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - \u0027\"prepare\" in ntp_actions\u0027"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Deploy service"},{"line_number":13,"context_line":"  include_tasks: deploy.yml"},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - \u0027\"deploy\" in ntp_actions\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f095bea4_51fa13a3","line":15,"range":{"start_line":1,"start_character":0,"end_line":15,"end_character":31},"in_reply_to":"799573e3_b0629a10","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"ansible/roles/ntp/tasks/prepare.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- name: Populate service facts."},{"line_number":4,"context_line":"  service_facts:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Mask alternative NTP clients to prevent conflicts"},{"line_number":7,"context_line":"  systemd:"},{"line_number":8,"context_line":"    name: \"{{ item }}\""},{"line_number":9,"context_line":"    enabled: false"},{"line_number":10,"context_line":"    masked: true"},{"line_number":11,"context_line":"    state: stopped"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - item in services"},{"line_number":14,"context_line":"  with_items: \"{{ ntp_service_disable_list }}\""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"75b93d1d_a149dd31","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":46},"updated":"2021-04-07 16:56:05.000000000","message":"This probably needs become: true?","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"75cd1007d6536cb8305abdabde2e992893874485","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- name: Populate service facts."},{"line_number":4,"context_line":"  service_facts:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Mask alternative NTP clients to prevent conflicts"},{"line_number":7,"context_line":"  systemd:"},{"line_number":8,"context_line":"    name: \"{{ item }}\""},{"line_number":9,"context_line":"    enabled: false"},{"line_number":10,"context_line":"    masked: true"},{"line_number":11,"context_line":"    state: stopped"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - item in services"},{"line_number":14,"context_line":"  with_items: \"{{ ntp_service_disable_list }}\""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f4085664_70258a6c","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":46},"in_reply_to":"5abe0d7c_994b4e6e","updated":"2021-04-20 09:33:26.000000000","message":"It will try to mask the service though, better check that it works.","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"878d38aee7fb99befdafd4474c967fa616cccc8d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- name: Populate service facts."},{"line_number":4,"context_line":"  service_facts:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Mask alternative NTP clients to prevent conflicts"},{"line_number":7,"context_line":"  systemd:"},{"line_number":8,"context_line":"    name: \"{{ item }}\""},{"line_number":9,"context_line":"    enabled: false"},{"line_number":10,"context_line":"    masked: true"},{"line_number":11,"context_line":"    state: stopped"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - item in services"},{"line_number":14,"context_line":"  with_items: \"{{ ntp_service_disable_list }}\""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a16d60ae_6f825efc","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":46},"in_reply_to":"75b93d1d_a149dd31","updated":"2021-04-07 18:33:57.000000000","message":"Does this work if the service is not installed?","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5051bbf44cb350747f1744a2d25ec7f991ac845c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"- name: Populate service facts."},{"line_number":4,"context_line":"  service_facts:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Mask alternative NTP clients to prevent conflicts"},{"line_number":7,"context_line":"  systemd:"},{"line_number":8,"context_line":"    name: \"{{ item }}\""},{"line_number":9,"context_line":"    enabled: false"},{"line_number":10,"context_line":"    masked: true"},{"line_number":11,"context_line":"    state: stopped"},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - item in services"},{"line_number":14,"context_line":"  with_items: \"{{ ntp_service_disable_list }}\""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5abe0d7c_994b4e6e","line":14,"range":{"start_line":6,"start_character":0,"end_line":14,"end_character":46},"in_reply_to":"a16d60ae_6f825efc","updated":"2021-04-12 14:04:22.000000000","message":"Good call on the become. I presume that if the service isn\u0027t installed then it won\u0027t show up in the `service` set by service_facts. Will try and test this scenario in the tests that you mentioned I should add.","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"75cd1007d6536cb8305abdabde2e992893874485","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":26,"context_line":"  # to the kayobe target venv."},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - \"\u0027docker.service\u0027 in services\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3b966714_6fdc4d5d","line":28,"updated":"2021-04-20 09:33:26.000000000","message":"- not kolla_enable_chrony | bool","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e169f75b241bc9026678bc59ee622c28b1d26b69","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":26,"context_line":"  # to the kayobe target venv."},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - \"\u0027docker.service\u0027 in services\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e5380cac_f8484f2b","line":28,"in_reply_to":"3b966714_6fdc4d5d","updated":"2021-04-21 11:12:58.000000000","message":"I do have that guard in: `ansible/time.yml` already. Do you reckon we should move that?","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ee7f7d5de24927c491e8da3e8f26984fb60c294","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":26,"context_line":"  # to the kayobe target venv."},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - \"\u0027docker.service\u0027 in services\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2a4cbf97_fcec976c","line":28,"in_reply_to":"e5380cac_f8484f2b","updated":"2021-04-21 16:01:02.000000000","message":"ok, missed that","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":25,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":26,"context_line":"  # to the kayobe target venv."},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - \"\u0027docker.service\u0027 in services\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cabb4968_d549f20b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":36},"updated":"2021-05-05 09:39:50.000000000","message":"No need for list?","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":26,"context_line":"  # to the kayobe target venv."},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - \"\u0027docker.service\u0027 in services\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a81eda2_395f9518","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":36},"in_reply_to":"cabb4968_d549f20b","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"ansible/time.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  hosts: seed-hypervisor:seed:overcloud"},{"line_number":4,"context_line":"  tags:"},{"line_number":5,"context_line":"    - timezone"},{"line_number":6,"context_line":"  roles:"},{"line_number":7,"context_line":"    - role: yatesr.timezone"},{"line_number":8,"context_line":"      become: True"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Ensure Chrony is installed and configured"},{"line_number":11,"context_line":"  hosts: ntp"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"56a4d0dd_33a28b3a","line":8,"range":{"start_line":6,"start_character":0,"end_line":8,"end_character":18},"updated":"2021-04-07 16:56:05.000000000","message":"Let\u0027s go with import_role","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    - import_role:"},{"line_number":17,"context_line":"        name: ntp"},{"line_number":18,"context_line":"      when:"},{"line_number":19,"context_line":"       - not kolla_enable_chrony | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfe8d6ec_78450da4","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":39},"updated":"2021-05-05 09:39:50.000000000","message":"No need for list? Also, indentation looks off.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    - import_role:"},{"line_number":17,"context_line":"        name: ntp"},{"line_number":18,"context_line":"      when:"},{"line_number":19,"context_line":"       - not kolla_enable_chrony | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2c5fd505_f82bf6f9","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":39},"in_reply_to":"bfe8d6ec_78450da4","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"doc/source/configuration/reference/hosts.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":428,"context_line":"   :caption: ``time.yml``"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"   chrony_ntp_servers:"},{"line_number":431,"context_line":"   - server: 0.debian.pool.ntp.org"},{"line_number":432,"context_line":"     options:"},{"line_number":433,"context_line":"       - option: iburst"},{"line_number":434,"context_line":"       - option: minpoll"},{"line_number":435,"context_line":"         val: 8"},{"line_number":436,"context_line":"   chrony_maxupdateskew: 150.0"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Software RAID"}],"source_content_type":"text/x-rst","patch_set":4,"id":"f8f25293_50a8d02a","line":435,"range":{"start_line":431,"start_character":0,"end_line":435,"end_character":15},"updated":"2021-05-05 09:39:50.000000000","message":"Wrong list indentation","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":428,"context_line":"   :caption: ``time.yml``"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"   chrony_ntp_servers:"},{"line_number":431,"context_line":"   - server: 0.debian.pool.ntp.org"},{"line_number":432,"context_line":"     options:"},{"line_number":433,"context_line":"       - option: iburst"},{"line_number":434,"context_line":"       - option: minpoll"},{"line_number":435,"context_line":"         val: 8"},{"line_number":436,"context_line":"   chrony_maxupdateskew: 150.0"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"Software RAID"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b24a82bc_6cb8b57b","line":435,"range":{"start_line":431,"start_character":0,"end_line":435,"end_character":15},"in_reply_to":"f8f25293_50a8d02a","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"etc/kayobe/inventory/groups":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[{"line_number":59,"context_line":"# registries which may become unsynchronized."},{"line_number":60,"context_line":"seed"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[ntp:children]"},{"line_number":63,"context_line":"# Kayobe will configure Chrony on members of this group."},{"line_number":64,"context_line":"seed"},{"line_number":65,"context_line":"seed-hypervisor"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b419016a_5664b497","line":62,"range":{"start_line":62,"start_character":1,"end_line":62,"end_character":13},"updated":"2021-04-07 16:56:05.000000000","message":"Release note should mention this group","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"}],"etc/kayobe/ntp.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"07007071_7e298088","side":"PARENT","line":15,"updated":"2021-05-05 09:39:50.000000000","message":"This has already been removed upstream, should go away if you rebase.","commit_id":"ea54f822999e6bc43e195f38cfd66caf05fc10ef"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2f75f75db1750bfbc94572a3d7714eda88791d2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"409b3685_e9eb8d73","side":"PARENT","line":15,"in_reply_to":"07007071_7e298088","updated":"2021-05-06 14:16:53.000000000","message":"Done","commit_id":"ea54f822999e6bc43e195f38cfd66caf05fc10ef"}],"etc/kayobe/time.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#     type: pool"},{"line_number":30,"context_line":"#     options:"},{"line_number":31,"context_line":"#       - option: maxsources"},{"line_number":32,"context_line":"#         val: 3"},{"line_number":33,"context_line":"#chrony_ntp_servers:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"###############################################################################"},{"line_number":36,"context_line":"# Dummy variable to allow Ansible to accept this file."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"043e0f2b_5069ada1","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":20},"updated":"2021-05-05 09:39:50.000000000","message":"Nit: ansible/group_vars/all/time has an empty line here, which makes it a bit more readable.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#     type: pool"},{"line_number":30,"context_line":"#     options:"},{"line_number":31,"context_line":"#       - option: maxsources"},{"line_number":32,"context_line":"#         val: 3"},{"line_number":33,"context_line":"#chrony_ntp_servers:"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"###############################################################################"},{"line_number":36,"context_line":"# Dummy variable to allow Ansible to accept this file."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d38ab50c_7db9dcd5","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":20},"in_reply_to":"043e0f2b_5069ada1","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"playbooks/kayobe-overcloud-host-configure-base/tests/test_overcloud_host_configure.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"75cd1007d6536cb8305abdabde2e992893874485","unresolved":true,"context_lines":[{"line_number":132,"context_line":"def test_timezone(host):"},{"line_number":133,"context_line":"    status \u003d host.check_output(\"timedatectl status\")"},{"line_number":134,"context_line":"    assert \"Pacific/Honolulu\" in status"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def test_ntp_alternative_services_disabled(host):"},{"line_number":137,"context_line":"    # We always mask services even if they don\u0027t exist"},{"line_number":138,"context_line":"    ntpd_service \u003d host.service(\"ntp\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"f70970b8_b516442e","line":135,"updated":"2021-04-20 09:33:26.000000000","message":"nit: flake8 says two blank lines between functions","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1c46f84db727bd25d6942f0411578b672564f656","unresolved":false,"context_lines":[{"line_number":132,"context_line":"def test_timezone(host):"},{"line_number":133,"context_line":"    status \u003d host.check_output(\"timedatectl status\")"},{"line_number":134,"context_line":"    assert \"Pacific/Honolulu\" in status"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"def test_ntp_alternative_services_disabled(host):"},{"line_number":137,"context_line":"    # We always mask services even if they don\u0027t exist"},{"line_number":138,"context_line":"    ntpd_service \u003d host.service(\"ntp\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"4f4ae5de_ed52e625","line":135,"in_reply_to":"f70970b8_b516442e","updated":"2021-04-21 11:13:50.000000000","message":"Done","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"82fc35089f08163ba4eb880128695f9fde920b1f","unresolved":true,"context_lines":[{"line_number":146,"context_line":"def test_ntp(host):"},{"line_number":147,"context_line":"    assert host.package(\"chrony\").is_installed"},{"line_number":148,"context_line":"    assert host.service(\"chronyd\").is_enabled"},{"line_number":149,"context_line":"    assert host.service(\"chronyd\").is_running"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"@pytest.mark.parametrize(\u0027repo\u0027, [\"AppStream\", \"BaseOS\", \"Extras\", \"epel\","},{"line_number":152,"context_line":"                                  \"epel-modular\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e2d2ea7_fc547edc","line":149,"updated":"2021-04-21 09:24:52.000000000","message":"Consider configuring a non-default NTP server?","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1c46f84db727bd25d6942f0411578b672564f656","unresolved":false,"context_lines":[{"line_number":146,"context_line":"def test_ntp(host):"},{"line_number":147,"context_line":"    assert host.package(\"chrony\").is_installed"},{"line_number":148,"context_line":"    assert host.service(\"chronyd\").is_enabled"},{"line_number":149,"context_line":"    assert host.service(\"chronyd\").is_running"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"@pytest.mark.parametrize(\u0027repo\u0027, [\"AppStream\", \"BaseOS\", \"Extras\", \"epel\","},{"line_number":152,"context_line":"                                  \"epel-modular\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"b182d221_f17b0f1c","line":149,"in_reply_to":"6e2d2ea7_fc547edc","updated":"2021-04-21 11:13:50.000000000","message":"Done","commit_id":"7f36c05d87e876088b77fa74366fc2dae2c0ec0f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ee7f7d5de24927c491e8da3e8f26984fb60c294","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    # time.cloudflare.com"},{"line_number":159,"context_line":"    chrony_config \u003d host.file(\"/etc/chrony.conf\")"},{"line_number":160,"context_line":"    assert chrony_config.exists"},{"line_number":161,"context_line":"    assert \"time.cloudflare.com\" in chrony_config.content_string"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"@pytest.mark.parametrize(\u0027repo\u0027, [\"AppStream\", \"BaseOS\", \"Extras\", \"epel\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ad6beb4c_fdb4e380","line":161,"updated":"2021-04-21 16:01:02.000000000","message":"We could incorporate a check like the one in k-a prechecks: https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/prechecks/tasks/timesync_checks.yml","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"df55d4e53a50872b844fc62cd765d82b49ef9974","unresolved":true,"context_lines":[{"line_number":158,"context_line":"    # time.cloudflare.com"},{"line_number":159,"context_line":"    chrony_config \u003d host.file(\"/etc/chrony.conf\")"},{"line_number":160,"context_line":"    assert chrony_config.exists"},{"line_number":161,"context_line":"    assert \"time.cloudflare.com\" in chrony_config.content_string"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"@pytest.mark.parametrize(\u0027repo\u0027, [\"AppStream\", \"BaseOS\", \"Extras\", \"epel\","}],"source_content_type":"text/x-python","patch_set":4,"id":"27cf8221_41d65294","line":161,"in_reply_to":"ad6beb4c_fdb4e380","updated":"2021-05-06 14:31:41.000000000","message":"Good suggestion. I\u0027ve added the equivalent to the testinfra tests.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"releasenotes/notes/install-chrony-on-the-host-283fa6fdd9cf9b4c.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By default, switches from the kolla-ansible deployed chrony container to"},{"line_number":5,"context_line":"    configuring chrony on the host.  Chrony is now installed on all hosts in"},{"line_number":6,"context_line":"    the ``ntp`` group, which defaults to include the seed, overcloud, and"},{"line_number":7,"context_line":"    seed-hypervisor groups. On existing deployments, you should run `kayobe"},{"line_number":8,"context_line":"    overcloud host configure` to migrate from the kolla-ansible deployed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8276b10d_39c25747","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":35},"updated":"2021-05-05 09:39:50.000000000","message":"I think this reads a bit better:\n\nUpdates the NTP implementation from the chrony container deployed by kolla-ansible to configuring chrony as a host service.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"0415dc7e5cb368013d05846cf2766bb2e2a10898","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    By default, switches from the kolla-ansible deployed chrony container to"},{"line_number":5,"context_line":"    configuring chrony on the host.  Chrony is now installed on all hosts in"},{"line_number":6,"context_line":"    the ``ntp`` group, which defaults to include the seed, overcloud, and"},{"line_number":7,"context_line":"    seed-hypervisor groups. On existing deployments, you should run `kayobe"},{"line_number":8,"context_line":"    overcloud host configure` to migrate from the kolla-ansible deployed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e26a5a90_1e734596","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":35},"in_reply_to":"8276b10d_39c25747","updated":"2021-05-06 13:31:55.000000000","message":"Done","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"}],"requirements.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b21616db4a3353e31ced7283ca9303046a70fd92","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4eaf809_c3d4ff3a","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":0},"updated":"2021-04-07 16:56:05.000000000","message":"Are you going to submit a PR?","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5051bbf44cb350747f1744a2d25ec7f991ac845c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56a6548b_7e2a9d5b","line":47,"range":{"start_line":44,"start_character":0,"end_line":47,"end_character":0},"in_reply_to":"e4eaf809_c3d4ff3a","updated":"2021-04-12 14:04:22.000000000","message":"Yep, I was thinking this would be a good test of how easy it is to get changes merged upstream. I was thinking that we\u0027d wait for that PR to be merged before merging this patch.","commit_id":"8202b592534a15afa93828d07800eab5a8ef95b5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e56e271ccda69b990276e9bab8ca1d7223e6534c","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  version: v1.0.0"},{"line_number":42,"context_line":"- src: yatesr.timezone"},{"line_number":43,"context_line":"  version: 1.2.0"},{"line_number":44,"context_line":"- src: git+https://github.com/jovial/ansible-chrony"},{"line_number":45,"context_line":"  version: feature/pools"},{"line_number":46,"context_line":"  name: mrlesmithjr.chrony"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"14654c48_f9863d61","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":11},"updated":"2021-05-05 09:39:50.000000000","message":"I don\u0027t think this is necessary?","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"2f75f75db1750bfbc94572a3d7714eda88791d2b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  version: v1.0.0"},{"line_number":42,"context_line":"- src: yatesr.timezone"},{"line_number":43,"context_line":"  version: 1.2.0"},{"line_number":44,"context_line":"- src: git+https://github.com/jovial/ansible-chrony"},{"line_number":45,"context_line":"  version: feature/pools"},{"line_number":46,"context_line":"  name: mrlesmithjr.chrony"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7496265b_4030b8cf","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":11},"in_reply_to":"14654c48_f9863d61","updated":"2021-05-06 14:16:53.000000000","message":"It is with the current default where we specify pool. Luckily this has now been merged :)","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5ad94ebef473e1581d82e5b5e73599319afa4fd2","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  version: v1.0.0"},{"line_number":42,"context_line":"- src: yatesr.timezone"},{"line_number":43,"context_line":"  version: 1.2.0"},{"line_number":44,"context_line":"- src: git+https://github.com/jovial/ansible-chrony"},{"line_number":45,"context_line":"  version: feature/pools"},{"line_number":46,"context_line":"  name: mrlesmithjr.chrony"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ed732ba7_bd7fa82b","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":11},"in_reply_to":"7496265b_4030b8cf","updated":"2021-05-07 15:37:20.000000000","message":"I meant the git+https part.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5240136a34ddea8421a896684a13f76f67ab5091","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  version: v1.0.0"},{"line_number":42,"context_line":"- src: yatesr.timezone"},{"line_number":43,"context_line":"  version: 1.2.0"},{"line_number":44,"context_line":"- src: git+https://github.com/jovial/ansible-chrony"},{"line_number":45,"context_line":"  version: feature/pools"},{"line_number":46,"context_line":"  name: mrlesmithjr.chrony"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"186e40be_70053caa","line":44,"range":{"start_line":44,"start_character":7,"end_line":44,"end_character":11},"in_reply_to":"ed732ba7_bd7fa82b","updated":"2021-05-07 15:46:26.000000000","message":"Ahh, good point. Missed the highlighted text.","commit_id":"fd530077dba2fd2e92b2a39bfe050612c5f34aa5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe27fb322c2cb9759219ae6fe52f7a670b75f6d0","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  # There are no versioned releases of this role."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"- src: singleplatform-eng.users"},{"line_number":19,"context_line":"  version: v1.2.5"},{"line_number":20,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ee8c2d6f_bf1171d3","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"updated":"2021-05-07 07:59:44.000000000","message":"Can you ask mrlesmith to make a release, to avoid hitting the issue we had with mdadm?","commit_id":"486698b48f1b1ebe58c2aaf21ded542be2922300"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a971d27115794dcb51ed65aece7eb269893acd07","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  # There are no versioned releases of this role."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"- src: singleplatform-eng.users"},{"line_number":19,"context_line":"  version: v1.2.5"},{"line_number":20,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5e0ee090_acc78062","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"in_reply_to":"66e9c034_2fa46f18","updated":"2021-05-07 15:46:14.000000000","message":"The v0.1.0 release is not listed on Galaxy, but Ansible is still able to fetch it:\n\n- downloading role \u0027chrony\u0027, owned by mrlesmithjr\n- downloading role from https://github.com/mrlesmithjr/ansible-chrony/archive/v0.1.0.tar.gz","commit_id":"486698b48f1b1ebe58c2aaf21ded542be2922300"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"611c2592eb6e8f8d0d07aaf31fab4d96f7e9d3d7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  # There are no versioned releases of this role."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"- src: singleplatform-eng.users"},{"line_number":19,"context_line":"  version: v1.2.5"},{"line_number":20,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"66e9c034_2fa46f18","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"in_reply_to":"ee8c2d6f_bf1171d3","updated":"2021-05-07 08:20:20.000000000","message":"Sure, I\u0027ve made an issue here:\n\nhttps://github.com/mrlesmithjr/ansible-chrony/issues/17\n\nI believe we could also use:\n\n  - src: git+https://github.com/mrlesmithjr/ansible_chrony\n    # Using git hash until version with this commit has been released.\n    version: 5a8b0219810b4c863f9998d4e83d2989a5c03922\n    name: mrlesmithjr.chrony\n\nto avoid the issue as that doesn\u0027t do a query to galaxy.","commit_id":"486698b48f1b1ebe58c2aaf21ded542be2922300"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"5ad94ebef473e1581d82e5b5e73599319afa4fd2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: git+https://github.com/mrlesmithjr/ansible-chrony"},{"line_number":16,"context_line":"  # Using git hash until version with this commit has been released."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"  name: mrlesmithjr.chrony"},{"line_number":19,"context_line":"- src: singleplatform-eng.users"},{"line_number":20,"context_line":"  version: v1.2.5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"4c611ae3_bdc2b6bd","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"updated":"2021-05-07 15:37:20.000000000","message":"v0.1.0 was released yesterday.","commit_id":"f5484a5d9e4ed9391401e8f596427434bae3bfb7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4b43cedcbcb6b9972a4cf48f9759f23a3633ef3f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: git+https://github.com/mrlesmithjr/ansible-chrony"},{"line_number":16,"context_line":"  # Using git hash until version with this commit has been released."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"  name: mrlesmithjr.chrony"},{"line_number":19,"context_line":"- src: singleplatform-eng.users"},{"line_number":20,"context_line":"  version: v1.2.5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"b9bc82af_4d7284dc","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"in_reply_to":"0d4d1a50_0a7e5ede","updated":"2021-05-07 15:48:11.000000000","message":"It\u0027s listed on GitHub: https://github.com/mrlesmithjr/ansible-chrony/releases\n\nEither some Galaxy magic that auto-fetches from GitHub when no releases have been imported or a display bug.","commit_id":"f5484a5d9e4ed9391401e8f596427434bae3bfb7"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5240136a34ddea8421a896684a13f76f67ab5091","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: git+https://github.com/mrlesmithjr/ansible-chrony"},{"line_number":16,"context_line":"  # Using git hash until version with this commit has been released."},{"line_number":17,"context_line":"  version: 5a8b0219810b4c863f9998d4e83d2989a5c03922"},{"line_number":18,"context_line":"  name: mrlesmithjr.chrony"},{"line_number":19,"context_line":"- src: singleplatform-eng.users"},{"line_number":20,"context_line":"  version: v1.2.5"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"0d4d1a50_0a7e5ede","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":51},"in_reply_to":"4c611ae3_bdc2b6bd","updated":"2021-05-07 15:46:26.000000000","message":"I don\u0027t see any versions on galaxy: https://galaxy.ansible.com/mrlesmithjr/chrony. Am I missing something?","commit_id":"f5484a5d9e4ed9391401e8f596427434bae3bfb7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b7a92992a9267f1907fdc937d59d8c9fe1a89aa9","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  version: 8438592c84585c86e62ae07e526d3da53629b377"},{"line_number":9,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":10,"context_line":"  version: v1.11.1"},{"line_number":11,"context_line":"- src: mrlesmithjr.manage-lvm"},{"line_number":12,"context_line":"  version: v0.1.4"},{"line_number":13,"context_line":"- src: mrlesmithjr.mdadm"},{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  version: v0.1.0"},{"line_number":17,"context_line":"- src: singleplatform-eng.users"},{"line_number":18,"context_line":"  version: v1.2.5"},{"line_number":19,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"31ae5381_f1a6acb4","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":17},"updated":"2021-05-07 16:05:15.000000000","message":"Is there a reason to put in this specific order rather than alphabetic?","commit_id":"e206754294d29c7bfce3acf8fac62947e6b1fb1d"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9e24d3c9ffecfc101f7e9a1180a760b845c97ab1","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  version: 8438592c84585c86e62ae07e526d3da53629b377"},{"line_number":9,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":10,"context_line":"  version: v1.11.1"},{"line_number":11,"context_line":"- src: mrlesmithjr.manage-lvm"},{"line_number":12,"context_line":"  version: v0.1.4"},{"line_number":13,"context_line":"- src: mrlesmithjr.mdadm"},{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  version: v0.1.0"},{"line_number":17,"context_line":"- src: singleplatform-eng.users"},{"line_number":18,"context_line":"  version: v1.2.5"},{"line_number":19,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"97beaf46_fba55108","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"2147771c_728f9298","updated":"2021-05-07 16:17:19.000000000","message":"Mark would know. Anyway, not a blocker for this patch.","commit_id":"e206754294d29c7bfce3acf8fac62947e6b1fb1d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"c65aa6275ee90767363e2f105c5768113651c2fa","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  version: 8438592c84585c86e62ae07e526d3da53629b377"},{"line_number":9,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":10,"context_line":"  version: v1.11.1"},{"line_number":11,"context_line":"- src: mrlesmithjr.manage-lvm"},{"line_number":12,"context_line":"  version: v0.1.4"},{"line_number":13,"context_line":"- src: mrlesmithjr.mdadm"},{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  version: v0.1.0"},{"line_number":17,"context_line":"- src: singleplatform-eng.users"},{"line_number":18,"context_line":"  version: v1.2.5"},{"line_number":19,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"89f7cf5b_a26a0a3e","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"31ae5381_f1a6acb4","updated":"2021-05-07 16:09:28.000000000","message":"Nope, but the rest of the imports are really in alphabetical order, so I just stuck it on the end of the mrlesmithjr group. I will move it...","commit_id":"e206754294d29c7bfce3acf8fac62947e6b1fb1d"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"42a1c3fd181ff6da308f7a8e61380aaad109b7fe","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  version: 8438592c84585c86e62ae07e526d3da53629b377"},{"line_number":9,"context_line":"- src: MichaelRigart.interfaces"},{"line_number":10,"context_line":"  version: v1.11.1"},{"line_number":11,"context_line":"- src: mrlesmithjr.manage-lvm"},{"line_number":12,"context_line":"  version: v0.1.4"},{"line_number":13,"context_line":"- src: mrlesmithjr.mdadm"},{"line_number":14,"context_line":"  version: v0.1.0"},{"line_number":15,"context_line":"- src: mrlesmithjr.chrony"},{"line_number":16,"context_line":"  version: v0.1.0"},{"line_number":17,"context_line":"- src: singleplatform-eng.users"},{"line_number":18,"context_line":"  version: v1.2.5"},{"line_number":19,"context_line":"- src: stackhpc.dell-powerconnect-switch"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2147771c_728f9298","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":17},"in_reply_to":"89f7cf5b_a26a0a3e","updated":"2021-05-07 16:11:57.000000000","message":"Well I guess it is just stackhpc.systemd_networkd that isn\u0027t in order. Was that for a reason?","commit_id":"e206754294d29c7bfce3acf8fac62947e6b1fb1d"}]}