)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e78a11dcda9eb72e2cd128a63fda7c902203e979","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"kolla: Set neutron_plugin_agent to OVN when it\u0027s enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"kolla_enable_ovn currently just builds OVN images and deploys OVN without"},{"line_number":10,"context_line":"configuring Neutron to use OVN"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib756630d50cb9cf89342f32bf1d4e07df31b1a62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"24e14718_31e366fb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":73},"updated":"2021-07-26 09:46:21.000000000","message":"Please wrap line.","commit_id":"095a400238c1ef67478618667a5e86dc5c2fda18"}],"ansible/roles/kolla-ansible/templates/globals.yml.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"96deb0403b9d68ee987555236bc5cb8555d46fd5","unresolved":true,"context_lines":[{"line_number":109,"context_line":"#bifrost_network_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":110,"context_line":"#dns_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Valid options are [ openvswitch, linuxbridge ]"},{"line_number":113,"context_line":"neutron_plugin_agent: \"{% if kolla_enable_ovn | default(False) | bool %}ovn{% else %}openvswitch{% endif %}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Valid options are [ internal, infoblox ]"},{"line_number":116,"context_line":"#neutron_ipam_driver: \"internal\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"c8e81d58_61c5949f","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":108},"updated":"2021-07-27 07:47:39.000000000","message":"What if we just go with the k-a default here, and don\u0027t override it?","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4348f2f865c23cd54cdee223837347c7341c757e","unresolved":true,"context_lines":[{"line_number":109,"context_line":"#bifrost_network_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":110,"context_line":"#dns_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Valid options are [ openvswitch, linuxbridge ]"},{"line_number":113,"context_line":"neutron_plugin_agent: \"{% if kolla_enable_ovn | default(False) | bool %}ovn{% else %}openvswitch{% endif %}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Valid options are [ internal, infoblox ]"},{"line_number":116,"context_line":"#neutron_ipam_driver: \"internal\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"952828d3_ffc7e03d","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":108},"in_reply_to":"9d5cc436_25f342c6","updated":"2021-07-27 08:02:05.000000000","message":"Ah yes, you\u0027re right.","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dc598f37d10e4c557feea36d9a01948368fab5e5","unresolved":true,"context_lines":[{"line_number":109,"context_line":"#bifrost_network_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":110,"context_line":"#dns_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Valid options are [ openvswitch, linuxbridge ]"},{"line_number":113,"context_line":"neutron_plugin_agent: \"{% if kolla_enable_ovn | default(False) | bool %}ovn{% else %}openvswitch{% endif %}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Valid options are [ internal, infoblox ]"},{"line_number":116,"context_line":"#neutron_ipam_driver: \"internal\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"faf348d8_d1f96a19","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":108},"in_reply_to":"c8e81d58_61c5949f","updated":"2021-07-27 07:55:54.000000000","message":"Relying on k-a - sure, that would also work.","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c54f13831b6c965562bc7ff1b1bf1b48e5524166","unresolved":true,"context_lines":[{"line_number":109,"context_line":"#bifrost_network_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":110,"context_line":"#dns_address_family: \"{% raw %}{{ network_address_family }}{% endraw %}\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Valid options are [ openvswitch, linuxbridge ]"},{"line_number":113,"context_line":"neutron_plugin_agent: \"{% if kolla_enable_ovn | default(False) | bool %}ovn{% else %}openvswitch{% endif %}\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Valid options are [ internal, infoblox ]"},{"line_number":116,"context_line":"#neutron_ipam_driver: \"internal\""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9d5cc436_25f342c6","line":113,"range":{"start_line":112,"start_character":0,"end_line":113,"end_character":108},"in_reply_to":"faf348d8_d1f96a19","updated":"2021-07-27 07:58:17.000000000","message":"Well not really, k-a default is \"openvswitch\", k-a OVN docs say you need to set it to \"ovn\" to use OVN...","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"70c426244c8a384576fc6814fdaf0e6aed5fcb3a","unresolved":true,"context_lines":[{"line_number":123,"context_line":"#neutron_enable_rolling_upgrade: \"yes\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Comma-separated names of neutron ML2 type drivers."},{"line_number":126,"context_line":"{% if kolla_neutron_ml2_type_drivers %}"},{"line_number":127,"context_line":"neutron_type_drivers: {{ kolla_neutron_ml2_type_drivers | join(\u0027,\u0027) }}"},{"line_number":128,"context_line":"{% endif %}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5a845ca4_3e0e5080","line":126,"updated":"2021-07-30 07:28:13.000000000","message":"I think we should alter this variables in as OVN won\u0027t work with current set of defaults set in `./ansible/group_vars/all/neutron`\n\nkolla_neutron_ml2_type_drivers:\n  - flat\n  - vlan\n  - vxlan","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f9b0f3f0c2b1185c18d77a05050c37ab0a196da1","unresolved":true,"context_lines":[{"line_number":123,"context_line":"#neutron_enable_rolling_upgrade: \"yes\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Comma-separated names of neutron ML2 type drivers."},{"line_number":126,"context_line":"{% if kolla_neutron_ml2_type_drivers %}"},{"line_number":127,"context_line":"neutron_type_drivers: {{ kolla_neutron_ml2_type_drivers | join(\u0027,\u0027) }}"},{"line_number":128,"context_line":"{% endif %}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"dab47e3d_02ecf0a6","line":126,"in_reply_to":"5a845ca4_3e0e5080","updated":"2021-08-03 15:14:09.000000000","message":"Alternatively we could drop the kayobe default in ansible/group_vars/all/neutron and rely on the kolla-ansible default.","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5b08e90265d9bb21ac6d7ca09c077d3960ec664d","unresolved":true,"context_lines":[{"line_number":123,"context_line":"#neutron_enable_rolling_upgrade: \"yes\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Comma-separated names of neutron ML2 type drivers."},{"line_number":126,"context_line":"{% if kolla_neutron_ml2_type_drivers %}"},{"line_number":127,"context_line":"neutron_type_drivers: {{ kolla_neutron_ml2_type_drivers | join(\u0027,\u0027) }}"},{"line_number":128,"context_line":"{% endif %}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7df1bcd2_338edd53","line":126,"in_reply_to":"5bac60cc_800f7ed6","updated":"2021-08-04 08:14:44.000000000","message":"I\u0027m suggesting dropping the default rather than dropping the variable entirely for now. We\u0027d need to highlight that we\u0027d lose flat and vlan from neutron_tenant_network_types, but that\u0027s probably no bad thing. It should be a separate change to this one.","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4e876c4545b875f4c7b9d5460fabd7d20914bcb6","unresolved":true,"context_lines":[{"line_number":123,"context_line":"#neutron_enable_rolling_upgrade: \"yes\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Comma-separated names of neutron ML2 type drivers."},{"line_number":126,"context_line":"{% if kolla_neutron_ml2_type_drivers %}"},{"line_number":127,"context_line":"neutron_type_drivers: {{ kolla_neutron_ml2_type_drivers | join(\u0027,\u0027) }}"},{"line_number":128,"context_line":"{% endif %}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"5bac60cc_800f7ed6","line":126,"in_reply_to":"dab47e3d_02ecf0a6","updated":"2021-08-04 04:41:46.000000000","message":"I think it\u0027s not the first time we\u0027re discussing dropping that - but I think we need to deprecate them first?","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"70c426244c8a384576fc6814fdaf0e6aed5fcb3a","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Comma-separated types of tenant networks (should be listed in \u0027neutron_type_drivers\u0027)"},{"line_number":131,"context_line":"# NOTE: for ironic this list should also contain \u0027flat\u0027"},{"line_number":132,"context_line":"{% if kolla_neutron_ml2_tenant_network_types %}"},{"line_number":133,"context_line":"neutron_tenant_network_types: {{ kolla_neutron_ml2_tenant_network_types | join(\u0027,\u0027) }}"},{"line_number":134,"context_line":"{% endif %}"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1418e7e4_37a5da08","line":132,"updated":"2021-07-30 07:28:13.000000000","message":"same comment as above one\n\nkolla_neutron_ml2_tenant_network_types:\n  - flat\n  - vlan\n  - vxlan","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f9b0f3f0c2b1185c18d77a05050c37ab0a196da1","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Comma-separated types of tenant networks (should be listed in \u0027neutron_type_drivers\u0027)"},{"line_number":131,"context_line":"# NOTE: for ironic this list should also contain \u0027flat\u0027"},{"line_number":132,"context_line":"{% if kolla_neutron_ml2_tenant_network_types %}"},{"line_number":133,"context_line":"neutron_tenant_network_types: {{ kolla_neutron_ml2_tenant_network_types | join(\u0027,\u0027) }}"},{"line_number":134,"context_line":"{% endif %}"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"1e4012fd_4aaf793b","line":132,"in_reply_to":"1418e7e4_37a5da08","updated":"2021-08-03 15:14:09.000000000","message":"ditto","commit_id":"fb36029b59ff4abe00abd506fbd6bd02a2e2fa2c"}]}
