)]}'
{"ansible/apt.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5bc7b298e330e30b5b731bcf1722482620f5760","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    - name: include apt role"},{"line_number":10,"context_line":"      include_role:"},{"line_number":11,"context_line":"        name: apt"},{"line_number":12,"context_line":"      when: ansible_os_family \u003d\u003d \u0027Debian\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f549d146_c5c1406d","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":29},"updated":"2021-07-27 08:33:13.000000000","message":"Could you use ansible_facts.os_family? See https://review.opendev.org/c/openstack/kayobe/+/791304","commit_id":"e072e6dd59cb734376429ccfc8f3715b89b801c8"},{"author":{"_account_id":33694,"name":"Skylar Tristan Kelty","display_name":"Skylar Kelty","email":"skylar.kelty@kcl.ac.uk","username":"skylarkelty"},"change_message_id":"e8a9f1c1925ef05c779e196e4be70b5ac08053c7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    - name: include apt role"},{"line_number":10,"context_line":"      include_role:"},{"line_number":11,"context_line":"        name: apt"},{"line_number":12,"context_line":"      when: ansible_os_family \u003d\u003d \u0027Debian\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"01cf146b_923a88f3","line":12,"range":{"start_line":12,"start_character":12,"end_line":12,"end_character":29},"in_reply_to":"f549d146_c5c1406d","updated":"2021-07-27 08:47:40.000000000","message":"Done","commit_id":"e072e6dd59cb734376429ccfc8f3715b89b801c8"}],"ansible/roles/apt/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48af3f63a4f8677634cc2459fc86a585ddcd8a8c","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    path: /etc/apt/apt.conf.d/01proxy"},{"line_number":15,"context_line":"    state: absent"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  when: apt_proxy_http is none and apt_proxy_https is none"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ab7bcce1_9fa0937d","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":58},"updated":"2021-09-02 12:24:20.000000000","message":"Have you checked that this works? Sometimes ansible get treat variables as empty strings if they reference a variable, even if the variable\u0027s value is none.","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b696606284c87f02175b841b26682fd94e8afb8b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    path: /etc/apt/apt.conf.d/01proxy"},{"line_number":15,"context_line":"    state: absent"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  when: apt_proxy_http is none and apt_proxy_https is none"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c53d59c8_f3378eb4","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":58},"in_reply_to":"43869b88_280e9137","updated":"2021-09-17 12:42:10.000000000","message":"Done","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4c2a95379bd764297426bd731ffb7592bbbdce6b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    path: /etc/apt/apt.conf.d/01proxy"},{"line_number":15,"context_line":"    state: absent"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  when: apt_proxy_http is none and apt_proxy_https is none"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b8c70549_b5300da7","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":58},"in_reply_to":"ab7bcce1_9fa0937d","updated":"2021-09-02 15:05:59.000000000","message":"I had the same thought, but I tested it and it works. Maybe it depends on the Ansible version? It would still be safer to use apt_proxy_http(s) | length \u003e 0.","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1483d2271dd225c62fd440d823af02ed6523a1cf","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    path: /etc/apt/apt.conf.d/01proxy"},{"line_number":15,"context_line":"    state: absent"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":"  when: apt_proxy_http is none and apt_proxy_https is none"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"43869b88_280e9137","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":58},"in_reply_to":"b8c70549_b5300da7","updated":"2021-09-03 08:18:50.000000000","message":"That doesn\u0027t work if the value is None :)","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"}],"ansible/roles/apt/templates/01proxy.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"1108639889e16ca04c848f0d3c47482a9cc52503","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":" HTTP::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":3,"context_line":" HTTPS::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"458e7e82_bb493ff7","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":65},"updated":"2021-08-13 15:54:37.000000000","message":"Is it worth having different variables for HTTP and HTTPS?","commit_id":"4b91759b0c8bffca7d8ea3450c83364afeba6287"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95e2c1c3aaf41dcada44c46bce87762adbf9e809","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":" HTTP::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":3,"context_line":" HTTPS::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"d28dfba5_8d87222d","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":65},"in_reply_to":"1dceec05_aef0abce","updated":"2021-08-16 09:51:01.000000000","message":"I think this would be better and more in line with how we configure proxies in other places. I am actually working on a patch to centralise proxy configuration so having apt match dnf/pip would be good.","commit_id":"4b91759b0c8bffca7d8ea3450c83364afeba6287"},{"author":{"_account_id":33694,"name":"Skylar Tristan Kelty","display_name":"Skylar Kelty","email":"skylar.kelty@kcl.ac.uk","username":"skylarkelty"},"change_message_id":"9e9bb513106c6ef2e8b1c8f8107eb4017cf3a53c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":" HTTP::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":3,"context_line":" HTTPS::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1dceec05_aef0abce","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":65},"in_reply_to":"458e7e82_bb493ff7","updated":"2021-08-16 08:39:28.000000000","message":"I don\u0027t really see a need, though it wouldn\u0027t hurt..\nTo make it more generic, I could change to:\n HTTP::proxy \"{{ apt_proxy_http }}\";\n HTTPS::proxy \"{{ apt_proxy_https }}\";","commit_id":"4b91759b0c8bffca7d8ea3450c83364afeba6287"},{"author":{"_account_id":33694,"name":"Skylar Tristan Kelty","display_name":"Skylar Kelty","email":"skylar.kelty@kcl.ac.uk","username":"skylarkelty"},"change_message_id":"a1dd9471fab16db944dacd631261074b06c2d0ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":" HTTP::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":3,"context_line":" HTTPS::proxy \"http://{{ apt_proxy_host }}:{{ apt_proxy_port }}\";"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7244d324_4a99007f","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":65},"in_reply_to":"d28dfba5_8d87222d","updated":"2021-08-16 10:56:08.000000000","message":"Done","commit_id":"4b91759b0c8bffca7d8ea3450c83364afeba6287"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"032322eac49f9f97e98e3c4ab491ba6eef12b293","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":"{% if apt_proxy_http | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":3,"context_line":"  HTTP::proxy \"{{ apt_proxy_http }}\";"},{"line_number":4,"context_line":"{% endif -%}"},{"line_number":5,"context_line":"{% if apt_proxy_https | default(\u0027\u0027, true) | \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"6cada2b4_ca226bb3","line":2,"range":{"start_line":2,"start_character":41,"end_line":2,"end_character":46},"updated":"2021-09-21 07:27:52.000000000","message":"| length \u003e 0","commit_id":"82f9b76b9c86810aa36aec01a57043a2f93e3b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9e263db3a404e79519c862abe008944896053211","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Acquire {"},{"line_number":2,"context_line":"{% if apt_proxy_http | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":3,"context_line":"  HTTP::proxy \"{{ apt_proxy_http }}\";"},{"line_number":4,"context_line":"{% endif -%}"},{"line_number":5,"context_line":"{% if apt_proxy_https | default(\u0027\u0027, true) | \u003e 0 -%}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5e6c97f7_1a40f097","line":2,"range":{"start_line":2,"start_character":41,"end_line":2,"end_character":46},"in_reply_to":"6cada2b4_ca226bb3","updated":"2021-09-21 08:40:07.000000000","message":"Find and replace went wrong, thanks.","commit_id":"82f9b76b9c86810aa36aec01a57043a2f93e3b1e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"032322eac49f9f97e98e3c4ab491ba6eef12b293","unresolved":true,"context_lines":[{"line_number":2,"context_line":"{% if apt_proxy_http | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":3,"context_line":"  HTTP::proxy \"{{ apt_proxy_http }}\";"},{"line_number":4,"context_line":"{% endif -%}"},{"line_number":5,"context_line":"{% if apt_proxy_https | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":6,"context_line":"  HTTPS::proxy \"{{ apt_proxy_https }}\";"},{"line_number":7,"context_line":"{% endif -%}"},{"line_number":8,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"4063ac91_d93adac1","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":47},"updated":"2021-09-21 07:27:52.000000000","message":"| length \u003e 0","commit_id":"82f9b76b9c86810aa36aec01a57043a2f93e3b1e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9e263db3a404e79519c862abe008944896053211","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% if apt_proxy_http | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":3,"context_line":"  HTTP::proxy \"{{ apt_proxy_http }}\";"},{"line_number":4,"context_line":"{% endif -%}"},{"line_number":5,"context_line":"{% if apt_proxy_https | default(\u0027\u0027, true) | \u003e 0 -%}"},{"line_number":6,"context_line":"  HTTPS::proxy \"{{ apt_proxy_https }}\";"},{"line_number":7,"context_line":"{% endif -%}"},{"line_number":8,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"e1a028e0_38e025e2","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":47},"in_reply_to":"4063ac91_d93adac1","updated":"2021-09-21 08:40:07.000000000","message":"Done","commit_id":"82f9b76b9c86810aa36aec01a57043a2f93e3b1e"}],"doc/source/configuration/reference/hosts.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"48af3f63a4f8677634cc2459fc86a585ddcd8a8c","unresolved":true,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Apt can be configured to use a proxy via ``apt_proxy_http`` and"},{"line_number":311,"context_line":"``apt_proxy_https`` in ``etc/kayobe/apt.yml``. These should be set to the full"},{"line_number":312,"context_line":"URL of the relevant proxy (e.g. http://local.squid:3128)."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"SELinux"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"56f817fe_611499a4","line":312,"range":{"start_line":312,"start_character":39,"end_line":312,"end_character":50},"updated":"2021-09-02 12:24:20.000000000","message":"nit: squid.example.com","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b696606284c87f02175b841b26682fd94e8afb8b","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"Apt can be configured to use a proxy via ``apt_proxy_http`` and"},{"line_number":311,"context_line":"``apt_proxy_https`` in ``etc/kayobe/apt.yml``. These should be set to the full"},{"line_number":312,"context_line":"URL of the relevant proxy (e.g. http://local.squid:3128)."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"SELinux"},{"line_number":315,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"46a0188c_ddc565e1","line":312,"range":{"start_line":312,"start_character":39,"end_line":312,"end_character":50},"in_reply_to":"56f817fe_611499a4","updated":"2021-09-17 12:42:10.000000000","message":"Done","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"}],"etc/kayobe/apt.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a43b210f8f8c39d61df60b40778011a2fd948537","unresolved":true,"context_lines":[{"line_number":6,"context_line":"#apt_cache_valid_time:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Apt proxy URL for HTTP. Default is empty (no proxy)."},{"line_number":9,"context_line":"apt_proxy_http:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Apt proxy URL for HTTPS. Default is"},{"line_number":12,"context_line":"# {{ apt_proxy_http }}."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"86945b97_3c7cb25f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2021-09-02 12:15:55.000000000","message":"Please comment out this line.","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b696606284c87f02175b841b26682fd94e8afb8b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#apt_cache_valid_time:"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Apt proxy URL for HTTP. Default is empty (no proxy)."},{"line_number":9,"context_line":"apt_proxy_http:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Apt proxy URL for HTTPS. Default is"},{"line_number":12,"context_line":"# {{ apt_proxy_http }}."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"aa01b5d5_44138ddb","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"in_reply_to":"86945b97_3c7cb25f","updated":"2021-09-17 12:42:10.000000000","message":"Done","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a43b210f8f8c39d61df60b40778011a2fd948537","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Apt proxy URL for HTTPS. Default is"},{"line_number":12,"context_line":"# {{ apt_proxy_http }}."},{"line_number":13,"context_line":"apt_proxy_https: \"{{ apt_proxy_http }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"###############################################################################"},{"line_number":16,"context_line":"# Dummy variable to allow Ansible to accept this file."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"23edd5d0_469c523f","line":13,"range":{"start_line":13,"start_character":16,"end_line":13,"end_character":39},"updated":"2021-09-02 12:15:55.000000000","message":"The custom in Kayobe is to leave default values out of etc/kayobe files.\n\nAlso please comment out this line.","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b696606284c87f02175b841b26682fd94e8afb8b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Apt proxy URL for HTTPS. Default is"},{"line_number":12,"context_line":"# {{ apt_proxy_http }}."},{"line_number":13,"context_line":"apt_proxy_https: \"{{ apt_proxy_http }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"###############################################################################"},{"line_number":16,"context_line":"# Dummy variable to allow Ansible to accept this file."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"55f11c1d_1505bf00","line":13,"range":{"start_line":13,"start_character":16,"end_line":13,"end_character":39},"in_reply_to":"23edd5d0_469c523f","updated":"2021-09-17 12:42:10.000000000","message":"Done","commit_id":"778aeb184fd71da9e855f27c79545f7a9e330324"}]}