)]}'
{"ansible/kayobe-ansible-user.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"af3472c8d710f77ad1b88721ea7f3b6e6688ac67","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    # Configure package manager early in case we need proxy settings"},{"line_number":53,"context_line":"    # TODO(priteau): Support apt configuration too"},{"line_number":54,"context_line":"    - name: Ensure package manager configuration exists"},{"line_number":55,"context_line":"      raw: \"test -e /usr/bin/dnf \u0026\u0026 (grep ^{{ item.key }} /etc/dnf/dnf.conf || echo \u0027{{ item.key }}\u003d{{ item.value }}\u0027 | sudo tee -a /etc/dnf/dnf.conf)\""},{"line_number":56,"context_line":"      loop: \"{{ query(\u0027dict\u0027, dnf_config) }}\""},{"line_number":57,"context_line":"      when: check_python.rc !\u003d 0"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be3f8981_85782040","line":55,"range":{"start_line":55,"start_character":85,"end_line":55,"end_character":116},"updated":"2021-07-27 08:44:15.000000000","message":"Will this formatting always work?\n\nAre all options in the [main] section?\n\nDoes the file always exist? If not it would end up with no [main] section heading.\n\nWill substring matches cause problems for the grep?","commit_id":"84181b552e66fc5ec564c052aedce0a6d70aafe1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3d18d0be58c23055e29875c3b85a26c4c91b7569","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    # Configure package manager early in case we need proxy settings"},{"line_number":53,"context_line":"    # TODO(priteau): Support apt configuration too"},{"line_number":54,"context_line":"    - name: Ensure package manager configuration exists"},{"line_number":55,"context_line":"      raw: \"test -e /usr/bin/dnf \u0026\u0026 (grep ^{{ item.key }} /etc/dnf/dnf.conf || echo \u0027{{ item.key }}\u003d{{ item.value }}\u0027 | sudo tee -a /etc/dnf/dnf.conf)\""},{"line_number":56,"context_line":"      loop: \"{{ query(\u0027dict\u0027, dnf_config) }}\""},{"line_number":57,"context_line":"      when: check_python.rc !\u003d 0"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dafc7d31_1da4c9f3","line":55,"range":{"start_line":55,"start_character":85,"end_line":55,"end_character":116},"in_reply_to":"be3f8981_85782040","updated":"2021-07-29 09:51:23.000000000","message":"\u003e Will this formatting always work?\n\nDo you have a specific issue in mind?\n\nFrom dnf.conf(5): The configuration file has INI format consisting of section declaration and name\u003dvalue options below each on separate line.\n\n\u003e Are all options in the [main] section?\n\nAs quoted above, you could technically define repository sections inside dnf.conf, but we always use yum.repos.d files for this. Our dnf role actually hardcodes the main section:\n\nhttps://opendev.org/openstack/kayobe/src/branch/master/ansible/roles/dnf/tasks/main.yml#L5\n \n\u003e Does the file always exist? If not it would end up with no [main] section heading.\n\nThis file comes as part of dnf-data which is a dependency of dnf, which is a protected package. The default content (in CentOS Stream 8) is:\n\n[main]\ngpgcheck\u003d1\ninstallonly_limit\u003d3\nclean_requirements_on_remove\u003dTrue\nbest\u003dTrue\nskip_if_unavailable\u003dFalse\n\n\u003e Will substring matches cause problems for the grep?\n\nThat could be a problem, I can make it smarter.\n\nAn alternative would be to use --setopt option on the CLI.","commit_id":"84181b552e66fc5ec564c052aedce0a6d70aafe1"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"731c9322bd515e22e12f5938a4b9a96c4f12b6b0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    # Configure package manager early in case we need proxy settings"},{"line_number":53,"context_line":"    # TODO(priteau): Support apt configuration too"},{"line_number":54,"context_line":"    - name: Ensure package manager configuration exists"},{"line_number":55,"context_line":"      raw: \"test -e /usr/bin/dnf \u0026\u0026 (grep ^{{ item.key }} /etc/dnf/dnf.conf || echo \u0027{{ item.key }}\u003d{{ item.value }}\u0027 | sudo tee -a /etc/dnf/dnf.conf)\""},{"line_number":56,"context_line":"      loop: \"{{ query(\u0027dict\u0027, dnf_config) }}\""},{"line_number":57,"context_line":"      when: check_python.rc !\u003d 0"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"773215d5_06069b09","line":55,"range":{"start_line":55,"start_character":85,"end_line":55,"end_character":116},"in_reply_to":"dafc7d31_1da4c9f3","updated":"2021-10-05 21:22:15.000000000","message":"I submitted an new patch using --setopt. No more editing of dnf.conf.","commit_id":"84181b552e66fc5ec564c052aedce0a6d70aafe1"}]}