)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0bd9ac3d22b302825c8875577221a7884ba8d422","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"seed: Disable SNAT configuration by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce seed_enable_snat and change default to false"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I0fde948a306ef9b8cf9525f1e93650d36d5f14f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"27f05bba_c1a33615","line":9,"updated":"2021-09-29 07:24:53.000000000","message":"Nit: missing dot at the end","commit_id":"dde5fcecf3a3f1ec9f4cd11a5567217782fd6d8b"}],"ansible/group_vars/all/seed":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3c09a6019d1db690b2dc1c6138c6be39df1f3b1c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"# List of extra networks to which seed nodes are attached."},{"line_number":24,"context_line":"seed_extra_network_interfaces: []"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Whether to enable SNAT on seed nodes. Default is true."},{"line_number":27,"context_line":"seed_enable_snat: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"###############################################################################"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7f55f91e_1584587e","line":26,"range":{"start_line":26,"start_character":51,"end_line":26,"end_character":55},"updated":"2021-09-28 13:43:48.000000000","message":"false","commit_id":"ffdd4d528fc9a6ed33756e2ea707d180479b1a25"}],"releasenotes/notes/seed-disable-snat-4d1e7899456f7561.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0bd9ac3d22b302825c8875577221a7884ba8d422","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New variable ``seed_enable_snat`` which defaults to ``false`` that allows"},{"line_number":5,"context_line":"    users to enable SNAT service on the Seed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b1ff28e9_89775913","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2021-09-29 07:24:53.000000000","message":"Adds a new","commit_id":"dde5fcecf3a3f1ec9f4cd11a5567217782fd6d8b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0bd9ac3d22b302825c8875577221a7884ba8d422","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New variable ``seed_enable_snat`` which defaults to ``false`` that allows"},{"line_number":5,"context_line":"    users to enable SNAT service on the Seed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Seed node SNAT service is not enabled by default anymore - it can be"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c6c0a539_76fb2f23","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":44},"updated":"2021-09-29 07:24:53.000000000","message":"seed","commit_id":"dde5fcecf3a3f1ec9f4cd11a5567217782fd6d8b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0bd9ac3d22b302825c8875577221a7884ba8d422","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    users to enable SNAT service on the Seed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Seed node SNAT service is not enabled by default anymore - it can be"},{"line_number":9,"context_line":"    enabled by setting ``seed_enable_snat`` to ``true`` in ``seed.yml``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"591302c4_baf725bd","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":72},"updated":"2021-09-29 07:24:53.000000000","message":"Maybe document what is the reason for the change?","commit_id":"dde5fcecf3a3f1ec9f4cd11a5567217782fd6d8b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"35f2d34ddfe3053e368a7ac3f8323b7fd1a8c1c9","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    users to enable SNAT service on the seed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Seed node SNAT service is not enabled by default anymore, since it was also"},{"line_number":9,"context_line":"    enabling IP forwarding on the seed (thus turning it into a router) - and that"},{"line_number":10,"context_line":"    is not needed in most deployments and not expected by users. It can be enabled"},{"line_number":11,"context_line":"    by setting ``seed_enable_snat`` to ``true`` in ``seed.yml``."},{"line_number":12,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b89b53e7_6bbff0c1","line":11,"range":{"start_line":8,"start_character":1,"end_line":11,"end_character":64},"updated":"2021-09-29 08:51:16.000000000","message":"It won\u0027t actively be disabled on upgrade - it would need to be disabled manually. The iptables rules are not persistent, so would disappear after a reboot. The sysctls for IP routing are persistent however, so your seed remains a router after upgrade.","commit_id":"5dff48dfb4373546a2d4d85c1c01bf11a6473a74"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"34c2d657f37eb5144c66887184df733582813edc","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    users to enable SNAT service on the seed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Seed node SNAT service is not enabled by default anymore, since it was also"},{"line_number":9,"context_line":"    enabling IP forwarding on the seed (thus turning it into a router) - and that"},{"line_number":10,"context_line":"    is not needed in most deployments and not expected by users. It can be enabled"},{"line_number":11,"context_line":"    by setting ``seed_enable_snat`` to ``true`` in ``seed.yml``."},{"line_number":12,"context_line":"    "}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3e36f624_f3990703","line":11,"range":{"start_line":8,"start_character":1,"end_line":11,"end_character":64},"in_reply_to":"b89b53e7_6bbff0c1","updated":"2021-09-29 09:00:45.000000000","message":"Ok, I\u0027ll drop the upgrade: section and include it in a follow-up where I\u0027ll fix the rule persistency and sysctl disablement.","commit_id":"5dff48dfb4373546a2d4d85c1c01bf11a6473a74"}]}