)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"76401626fd7e37ce34ee1dc527cf6fd0dbf49348","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38cd748e_59381748","updated":"2022-03-23 08:38:07.000000000","message":"This seems inconsistent with our root image, where we set net.ifnames\u003d1.\n\nThe default of eth0 is unlikely to be correct on a typical system with multiple interfaces, even after this change.","commit_id":"69bc4e4ada49f2fc3f987ab1831c0382fe17a689"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d1b0dc775ec9ab4d8f47baac1a27c569b088e8fc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88eddba3_a2ef922f","in_reply_to":"38cd748e_59381748","updated":"2022-03-23 08:46:47.000000000","message":"It is inconsistent but it is a different use case:\n\n- for root disk image, we want consistent naming (via systemd or maybe via biosdevname) to make sure we identify and configure correctly each interface. Provisioning configures the provisioning network interface based on MAC address, so we don\u0027t need to know its naming in advance. We can connect to the host and discover its interfaces before executing host configuration.\n\n- for the IPA image, we want to gather the hostname from LLDP, which may be set on multiple interfaces. If eth0 is not working, it is easy to add rules for eth1, eth2, etc. Keeping the current approach requires discovering interface names before setting introspection rules, which is cumbersome.","commit_id":"69bc4e4ada49f2fc3f987ab1831c0382fe17a689"}],"ansible/inventory/group_vars/all/ipa":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"f2f940cd72724c22247f1fbc7be1ec5298b43d1c","unresolved":true,"context_lines":[{"line_number":165,"context_line":"  {{ [\u0027ipa-collect-lldp\u003d\u0027 ~ \u00271\u0027 if ipa_collect_lldp else \u00270\u0027] +"},{"line_number":166,"context_line":"     [\u0027ipa-inspection-collectors\u003d\u0027 ~ ipa_collectors | join(\u0027,\u0027)] +"},{"line_number":167,"context_line":"     [\u0027ipa-inspection-benchmarks\u003d\u0027 ~ ipa_benchmarks | join(\u0027,\u0027)] +"},{"line_number":168,"context_line":"     [\u0027net.ifnames\u003d0\u0027] }}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# List of additional kernel parameters for Ironic python agent."},{"line_number":171,"context_line":"ipa_kernel_options_extra: []"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"98b93dc1_ad2f2b59","line":168,"range":{"start_line":168,"start_character":5,"end_line":168,"end_character":22},"updated":"2025-01-21 11:51:40.000000000","message":"hardcode this in *_options_default is not a good idea. especially if this is only CentOS issue.","commit_id":"84bdebe466303282427030408b8f26957113158b"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1af6e024ea246f9b22ab522fa463a9b8ca5e4b28","unresolved":true,"context_lines":[{"line_number":165,"context_line":"  {{ [\u0027ipa-collect-lldp\u003d\u0027 ~ \u00271\u0027 if ipa_collect_lldp else \u00270\u0027] +"},{"line_number":166,"context_line":"     [\u0027ipa-inspection-collectors\u003d\u0027 ~ ipa_collectors | join(\u0027,\u0027)] +"},{"line_number":167,"context_line":"     [\u0027ipa-inspection-benchmarks\u003d\u0027 ~ ipa_benchmarks | join(\u0027,\u0027)] +"},{"line_number":168,"context_line":"     [\u0027net.ifnames\u003d0\u0027] }}"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# List of additional kernel parameters for Ironic python agent."},{"line_number":171,"context_line":"ipa_kernel_options_extra: []"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"85ddaf3a_2c72e7b9","line":168,"range":{"start_line":168,"start_character":5,"end_line":168,"end_character":22},"in_reply_to":"98b93dc1_ad2f2b59","updated":"2025-02-05 17:45:00.000000000","message":"One scenario where eth style names would be undesirable is if you have connections to multiples switches, but have only got the switch port description set on one of them. If you can\u0027t rely on the ordering then you might will get inconsistent results. I would suggest at least making this configurable as it does seem like a nice option for the simplest use case.","commit_id":"84bdebe466303282427030408b8f26957113158b"}]}