)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7945e849532f72420198acd1dafaf1e12fb8987c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"840b7509_b815e6d4","updated":"2023-12-14 10:45:17.000000000","message":"I like the idea of having a strict convention here and it seems like this is mostly followed.","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ab8d89cd7c7ce888cfcd4280e35dc0115de64fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ffcf9c81_74307205","updated":"2023-12-14 10:35:30.000000000","message":"Overall, looks good. Small question on docs.","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"941208b3cef9c8ad3ae6a03f39c24e8839f6b8de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"59f98df2_1ad02b36","updated":"2023-11-20 17:01:12.000000000","message":"recheck\n\nCI fixed","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a55b6cf2141b755756b142b0230464379b788ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ad662f7_15c758de","updated":"2024-04-18 09:02:37.000000000","message":"Looks good to be me. Would be good to get this one in Caracal.","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4a8ddf388411b00805af38b0b58afb86665db066","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b0b9bd3_d5ae765b","updated":"2024-05-30 13:25:05.000000000","message":"Probably ansible/logging.yml as well (once merged)","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"872d3fe64b1d02ff69f218bfe8bbbfb2013a1109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc1961cb_c2370741","updated":"2024-05-30 13:23:51.000000000","message":"This may be missing ansible/baremetal-compute-register.yml","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7210b5db12a4c512212e195d2a2ed68dbfc9bd1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a48194e4_9c88b67d","in_reply_to":"7b0b9bd3_d5ae765b","updated":"2024-05-31 13:55:44.000000000","message":"Done","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7210b5db12a4c512212e195d2a2ed68dbfc9bd1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"240e1d00_dc350c33","in_reply_to":"fc1961cb_c2370741","updated":"2024-05-31 13:55:44.000000000","message":"Done","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f5396d5dc84284b39a7ede08ac329c1058bed256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4c8a16e9_85d085fb","updated":"2024-06-03 09:44:21.000000000","message":"recheck\n\nError: Failed to download metadata for repo \u0027appstream\u0027: Cannot prepare internal mirrorlist: No URLs in mirrorlist","commit_id":"a19ea2a0be701379e44766599857ec2c900ce237"}],"ansible/baremetal-compute-inspect.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7945e849532f72420198acd1dafaf1e12fb8987c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  hosts: baremetal-compute"},{"line_number":22,"context_line":"  gather_facts: False"},{"line_number":23,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":24,"context_line":"    {{ baremetal_compute_max_fail_percentage |"},{"line_number":25,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":26,"context_line":"       default(100) }}"},{"line_number":27,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5ad1e848_274bb596","line":24,"updated":"2023-12-14 10:45:17.000000000","message":"Doesn\u0027t match the \u003cplaybook\u003e_max_fail_percentage convention","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a68e5a0e311a4f4d598bf3b4e8c70d440f407f0e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  hosts: baremetal-compute"},{"line_number":22,"context_line":"  gather_facts: False"},{"line_number":23,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":24,"context_line":"    {{ baremetal_compute_max_fail_percentage |"},{"line_number":25,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":26,"context_line":"       default(100) }}"},{"line_number":27,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fe85068_f42ef62b","line":24,"in_reply_to":"5ad1e848_274bb596","updated":"2024-04-12 09:40:06.000000000","message":"Done","commit_id":"9e062170ffa5879a20eba49912b769326af15872"}],"ansible/compute-libvirt-host.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7945e849532f72420198acd1dafaf1e12fb8987c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Ensure the libvirt daemon is configured"},{"line_number":3,"context_line":"  hosts: compute"},{"line_number":4,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":5,"context_line":"    {{ libvirt_host_max_fail_percentage |"},{"line_number":6,"context_line":"       default(host_configure_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":8,"context_line":"       default(100) }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cb3c387f_a53706e4","line":5,"updated":"2023-12-14 10:45:17.000000000","message":"Doesn\u0027t match \u003cplaybook\u003e_max_fail_percentage convention","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a68e5a0e311a4f4d598bf3b4e8c70d440f407f0e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Ensure the libvirt daemon is configured"},{"line_number":3,"context_line":"  hosts: compute"},{"line_number":4,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":5,"context_line":"    {{ libvirt_host_max_fail_percentage |"},{"line_number":6,"context_line":"       default(host_configure_max_fail_percentage) |"},{"line_number":7,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":8,"context_line":"       default(100) }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ef143a44_560c0f18","line":5,"in_reply_to":"cb3c387f_a53706e4","updated":"2024-04-12 09:40:06.000000000","message":"Done","commit_id":"9e062170ffa5879a20eba49912b769326af15872"}],"ansible/ssh-known-host.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"7945e849532f72420198acd1dafaf1e12fb8987c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  gather_facts: no"},{"line_number":5,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":6,"context_line":"    {{ ssh_known_hosts_max_fail_percentage |"},{"line_number":7,"context_line":"       default(host_configure_max_fail_percentage) |"},{"line_number":8,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":9,"context_line":"       default(100) }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8bfeb895_698d8424","line":6,"updated":"2023-12-14 10:45:17.000000000","message":"ssh_known_hosts vs ssh_known_host","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a68e5a0e311a4f4d598bf3b4e8c70d440f407f0e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  gather_facts: no"},{"line_number":5,"context_line":"  max_fail_percentage: \u003e-"},{"line_number":6,"context_line":"    {{ ssh_known_hosts_max_fail_percentage |"},{"line_number":7,"context_line":"       default(host_configure_max_fail_percentage) |"},{"line_number":8,"context_line":"       default(kayobe_max_fail_percentage) |"},{"line_number":9,"context_line":"       default(100) }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6f68a44a_2f2de100","line":6,"in_reply_to":"8bfeb895_698d8424","updated":"2024-04-12 09:40:06.000000000","message":"Done","commit_id":"9e062170ffa5879a20eba49912b769326af15872"}],"doc/source/configuration/reference/ansible.rst":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ab8d89cd7c7ce888cfcd4280e35dc0115de64fe5","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"A max fail percentage may be set for the ``kayobe * host configure`` commands"},{"line_number":165,"context_line":"using ``host_configure_max_fail_percentage``, or for a specific playbook using"},{"line_number":166,"context_line":"``\u003cplaybook\u003e_max_fail_percentage``. For example:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: yaml"},{"line_number":169,"context_line":"   :caption: ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"85ca3dfc_77afd2cc","line":166,"updated":"2023-12-14 10:35:30.000000000","message":"Isn\u0027t the pattern the tag on the play e.g in the https://review.opendev.org/c/openstack/kayobe/+/818288/5/ansible/time.yml playbook there are two such variables: `timezone_max_fail_percentage` and `ntp_max_fail_percentage`.","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a68e5a0e311a4f4d598bf3b4e8c70d440f407f0e","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"A max fail percentage may be set for the ``kayobe * host configure`` commands"},{"line_number":165,"context_line":"using ``host_configure_max_fail_percentage``, or for a specific playbook using"},{"line_number":166,"context_line":"``\u003cplaybook\u003e_max_fail_percentage``. For example:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: yaml"},{"line_number":169,"context_line":"   :caption: ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f04cbef0_8067c194","line":166,"in_reply_to":"5dd00671_1183200f","updated":"2024-04-12 09:40:06.000000000","message":"Done","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dccdd15fd21f6b21620793d4a285b9a7bba425e3","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"A max fail percentage may be set for the ``kayobe * host configure`` commands"},{"line_number":165,"context_line":"using ``host_configure_max_fail_percentage``, or for a specific playbook using"},{"line_number":166,"context_line":"``\u003cplaybook\u003e_max_fail_percentage``. For example:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: yaml"},{"line_number":169,"context_line":"   :caption: ``$KAYOBE_CONFIG_PATH/kolla/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5dd00671_1183200f","line":166,"in_reply_to":"85ca3dfc_77afd2cc","updated":"2023-12-14 10:38:51.000000000","message":"Perhaps this is actually the exception and in most cases it is using playbook","commit_id":"9e062170ffa5879a20eba49912b769326af15872"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a55b6cf2141b755756b142b0230464379b788ed7","unresolved":true,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"A max fail percentage may be set for the ``kayobe * host configure`` commands"},{"line_number":165,"context_line":"using ``host_configure_max_fail_percentage``, or for a specific playbook using"},{"line_number":166,"context_line":"``\u003cplaybook\u003e_max_fail_percentage``. For example:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: yaml"},{"line_number":169,"context_line":"   :caption: ``$KAYOBE_CONFIG_PATH/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"24e4f1f3_9396d518","line":166,"updated":"2024-04-18 09:02:37.000000000","message":"nit: Possibly worth mentioning that dashes should be replaced with underscores e.g overcloud-bios-raid.yml becomes overcloud_bios_raid_max_fail_percentage","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8496fe09bcff301616a072a87d410338950bd52c","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"A max fail percentage may be set for the ``kayobe * host configure`` commands"},{"line_number":165,"context_line":"using ``host_configure_max_fail_percentage``, or for a specific playbook using"},{"line_number":166,"context_line":"``\u003cplaybook\u003e_max_fail_percentage``. For example:"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":".. code-block:: yaml"},{"line_number":169,"context_line":"   :caption: ``$KAYOBE_CONFIG_PATH/globals.yml``"}],"source_content_type":"text/x-rst","patch_set":6,"id":"0fd8023e_0032dedd","line":166,"in_reply_to":"24e4f1f3_9396d518","updated":"2024-05-31 14:02:45.000000000","message":"Done","commit_id":"11ce339c5392fc98213c818650cf9e7c51bb73c5"}]}