)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"692c75f36ea08618abc548fa4b04694081cd2d26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1fc93502_9e99d6f7","updated":"2021-11-23 20:43:34.000000000","message":"recheck apt mirror.kna1.airship-citycloud.opendev.org failed","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b10bf60c62c3e6314a55a62058d6ada354609af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"784b2350_2c99aa86","updated":"2021-12-20 12:08:52.000000000","message":"Thanks","commit_id":"c27cc664ee4c0db97a9ba895daad6208bb33f77f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"fb46648bd4b2282fc37118e02d9a56e69aa51c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"727de301_6e1c0664","updated":"2021-11-29 19:56:11.000000000","message":"its fine. overcloud-deploy-pre-upgrade - skipped. overcloud-upgrade - ok.","commit_id":"c27cc664ee4c0db97a9ba895daad6208bb33f77f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"200f260910c4206827b0fbedbee1ff1a49e986fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b75656bc_62a455de","updated":"2022-01-06 22:12:02.000000000","message":"recheck","commit_id":"bf318310e6534c6074d15229c20555b459e517dd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2831f425417274dbcc12648c58d68e01924586b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93abab2c_8c289af1","updated":"2022-01-07 08:53:07.000000000","message":"recheck\n\nMirror issues","commit_id":"bf318310e6534c6074d15229c20555b459e517dd"}],"ansible/roles/ntp/tasks/prepare.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2e2611b2ca1cf24558e5f4dd041436a6166a809f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    cmd: \"docker rm -f -v chrony\""},{"line_number":19,"context_line":"    executable: \"/bin/bash\""},{"line_number":20,"context_line":"  changed_when: false"},{"line_number":21,"context_line":"  failed_when: false"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  # NOTE(wszumski):  There is an ordering issue where on a fresh host, docker"},{"line_number":24,"context_line":"  # will not have been configured, but if that is the case, the chrony container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4970a4f7_ac0fffdd","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"updated":"2021-11-29 09:36:24.000000000","message":"We can handle errors properly:\n\nif [[ -n $(docker ps -aq -f name\u003dchrony) ]]; then\n    docker rm -f -v chrony\nfi\n\nAnd check for changes:\n\nregister: result\nchanged_when: result.stdout !\u003d \"\"","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"56a7530bd15a43bfae3f338594ed66844562dc5f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    cmd: \"docker rm -f -v chrony\""},{"line_number":19,"context_line":"    executable: \"/bin/bash\""},{"line_number":20,"context_line":"  changed_when: false"},{"line_number":21,"context_line":"  failed_when: false"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  # NOTE(wszumski):  There is an ordering issue where on a fresh host, docker"},{"line_number":24,"context_line":"  # will not have been configured, but if that is the case, the chrony container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34537067_8556ca63","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":20},"in_reply_to":"4970a4f7_ac0fffdd","updated":"2021-11-29 16:35:12.000000000","message":"Done","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1289dec1062a8fbb1d9e3a44e424b185c3bafc1a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"43a83419_754f3f1c","line":29,"updated":"2021-11-24 09:59:05.000000000","message":"I have seen this before, when docker got installed but failed to start. I think we can check whether the service is active in the services fact. Would that solution work for your case?","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2e2611b2ca1cf24558e5f4dd041436a6166a809f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dc106ddf_2e646a61","line":29,"in_reply_to":"40437a70_ccdf2901","updated":"2021-11-29 09:36:24.000000000","message":"Understood. While you\u0027re changing this code, could you add the check for docker state\u003drunning to catch the case I described?","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2f97b4abe4a5e150a0d3827ea6211925adf4c3ab","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"40437a70_ccdf2901","line":29,"in_reply_to":"43a83419_754f3f1c","updated":"2021-11-24 17:38:57.000000000","message":"no, one of my cases is a combined deployment host and seed host, when clean kayobe env doen\u0027t have docker sdk because docker.yml execution is planed after ntp.yml which is already fails. this is the same as wszumski described, but in my case I have docker engine started and working.","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8542e76aaec637fe72a891c165d946cb39eae3ec","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b5a17ac8_20f19632","line":29,"in_reply_to":"8b22405e_8887f981","updated":"2021-12-20 14:01:36.000000000","message":"Not done?","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0e69827ca5834509698a48f654946eb382519b66","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d086c1af_85a37837","line":29,"in_reply_to":"a9e7673d_e403924a","updated":"2021-12-21 10:01:50.000000000","message":"Well it\u0027s done now that I added it in PS2","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a90e56324d578713fee92956a95466d987c18170","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a9e7673d_e403924a","line":29,"in_reply_to":"b5a17ac8_20f19632","updated":"2021-12-20 19:48:59.000000000","message":"read again and again... don\u0027t understand whats \u0027Not done\u0027 ? check for the service status is running added. so?","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"367ead4da5ce7f70d017cc7b59b0a7d433278fad","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"54d12b37_09d53854","line":29,"in_reply_to":"d086c1af_85a37837","updated":"2021-12-21 10:25:17.000000000","message":"ok than, I think need more checks)","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"56a7530bd15a43bfae3f338594ed66844562dc5f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  # with: No module named \u0027docker\u0027 as we have not yet added the docker package"},{"line_number":27,"context_line":"  # to the kayobe target venv, so we use \u0027docker rm\u0027 command with force and don\u0027t"},{"line_number":28,"context_line":"  # fail on error."},{"line_number":29,"context_line":"  when: \"\u0027docker.service\u0027 in ansible_facts.services\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8b22405e_8887f981","line":29,"in_reply_to":"dc106ddf_2e646a61","updated":"2021-11-29 16:35:12.000000000","message":"nice catch. done.","commit_id":"4f83f9b56848f60dc81e0ffde91055fd3271f364"}]}