)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"ba40756d_d19322f2","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"updated":"2022-02-15 12:12:24.000000000","message":"Is this a good idea, or should we wait for a release?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"856db402e1dd3af9add41a1ae884f91ba189abab","unresolved":true,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"9c0e8f3f_9562f900","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"in_reply_to":"29c4043a_6f791489","updated":"2022-03-23 12:26:59.000000000","message":"Maybe save that for the pre-checks we always talk about. Better to do these checks early before you start reconfiguring. I think a port binding failing should be sufficient to alert the user to the actual problem.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f2f5a33d59db0058f4d767e93222c4d4cee4aa6b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"7f5305ba_3a42fe5a","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"in_reply_to":"3b06f390_b53189d0","updated":"2022-03-24 11:40:33.000000000","message":"Done","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"befd99b9825bca420f14628c33b39ef246614eca","unresolved":true,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"29c4043a_6f791489","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"in_reply_to":"6490820b_4926f9b4","updated":"2022-03-17 11:45:32.000000000","message":"I don\u0027t think you\u0027d lose data. Probably libvirt would fail to start due to a port binding conflict.\n\nDo you think we should check for a nova_libvirt container?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9e3479b72fd46333e5e443387a8ac009eb3273d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3b06f390_b53189d0","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"in_reply_to":"9c0e8f3f_9562f900","updated":"2022-03-24 11:36:49.000000000","message":"The highlighted text in the commit message needs to be removed.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb32fa4d86b6360656fa8448501fb59378588eeb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"example, when mixing host and container OS distributions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change makes it possible to disable the nova_libvirt container, by"},{"line_number":13,"context_line":"setting kolla_enable_nova_libvirt_container to false. This is the new"},{"line_number":14,"context_line":"default."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The stackhpc.libvirt-host role is used in order to install and configure"},{"line_number":17,"context_line":"a libvirt daemon on compute hosts when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"6490820b_4926f9b4","line":14,"range":{"start_line":13,"start_character":54,"end_line":14,"end_character":8},"in_reply_to":"ba40756d_d19322f2","updated":"2022-03-16 16:09:48.000000000","message":"Are you likely to lose data if you run this on a host where you are using the containerised version?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9a02fca9c8e10e24be2be75f197098363510256e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f654b2c2_3836a86e","updated":"2022-02-15 14:25:48.000000000","message":"Ubuntu error in bare metal deploy when powering on a node:\n\nFeb 15 12:43:35 ubuntu-focal-iweb-mtl01-0028460730 vbmcd[95202]: 2022-02-15 12:43:35,240 95202 ERROR VirtualBMC [-] Error powering on the domain tk0. Error: internal error: process exited while connecting to monitor: 2022-02-15T12:43:34.959799Z qemu-system-x86_64: -blockdev {\"driver\":\"file\",\"filename\":\"/var/lib/libvirt/tenks_pool/tk0vol0\",\"node-name\":\"libvirt-1-storage\",\"auto-read-only\":true,\"discard\":\"unmap\"}: Could not open \u0027/var/lib/libvirt/tenks_pool/tk0vol0\u0027: Permission denied\n\nAppears to be caused by apparmor:\n\nFeb 15 12:43:34 ubuntu-focal-iweb-mtl01-0028460730 audit[115612]: AVC apparmor\u003d\"DENIED\" operation\u003d\"open\" profile\u003d\"libvirt-812fabc3-9f78-48a3-acd2-2436c0359be6\" name\u003d\"/var/lib/libvirt/tenks_pool/tk0vol0\" pid\u003d115612 comm\u003d\"qemu-system-x86\" requested_mask\u003d\"r\" denied_mask\u003d\"r\" fsuid\u003d64055 ouid\u003d64055","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3d1ed50280c43968bbaaba5d88e5c02e94f5c6ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"56f57d85_3aab665c","updated":"2022-02-15 16:42:23.000000000","message":"Same ubuntu error because tenks doesn\u0027t use kayobe\u0027s requirements.yml, and doesn\u0027t get the updated libvirt-host role.\n\nSeed jobs timed out during DIB build.","commit_id":"d070e3dfe4c37779a2a66d79e8b4e85032ed9477"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"02520159ef59e7a420987bb1f56aeec7973e00e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9838fe87_2437a5d7","updated":"2022-03-03 09:52:29.000000000","message":"ironic-conductor:\n\n2022-03-02 16:36:18.736 8 ERROR ironic.drivers.modules.ipmitool [req-28feda21-4e9b-4f86-a211-ff23a1f0474e 476665a036f94a338b6ba7ee67b5d978 10a1df34698f47ceabb37149603991de - default default] IPMI Error while attempting \"ipmitool -I lanplus -H 0.0.0.0 -L ADMINISTRATOR -p 6230 -U username -R 7 -N 5 -f /tmp/tmpzyov5ikk power on\" for node b94ee403-be93-49ce-ad11-3152887a768a. Error: Unexpected error while running command.\nCommand: ipmitool -I lanplus -H 0.0.0.0 -L ADMINISTRATOR -p 6230 -U username -R 7 -N 5 -f /tmp/tmpzyov5ikk power on\nExit code: 1\nStdout: \u0027\u0027\nStderr: \u0027Set Chassis Power Control to Up/On failed: Node busy\\n\u0027: oslo_concurrency.processutils.ProcessExecutionError: Unexpected error while running command.\n\nvbcmd:\n\nMar 02 16:36:18 ubuntu-focal-iweb-mtl01-0028675712 vbmcd[95581]: 2022-03-02 16:36:18,731 95581 ERROR VirtualBMC [-] Error powering on the domain tk0. Error: internal error: process exited while connecting to monitor: 2022-03-02T16:36:18.449179Z qemu-system-x86_64: -blockdev {\"driver\":\"file\",\"filename\":\"/var/lib/libvirt/tenks_pool/tk0vol0\",\"node-name\":\"libvirt-1-storage\",\"auto-read-only\":true,\"discard\":\"unmap\"}: Could not open \u0027/var/lib/libvirt/tenks_pool/tk0vol0\u0027: Permission denied","commit_id":"ce622bd10af793dbbd77527c44f8b74d47300a32"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74dc8b1d1428aa7ac4a79144841350459200bdc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f3c365cb_af573dcf","in_reply_to":"9838fe87_2437a5d7","updated":"2022-03-03 11:37:37.000000000","message":"That\u0027s ubuntu. Issue is known.\n\nThe TLS job seems to think ansible_facts.python.executable is /usr/bin/python3. Due to enabling fact caching in CI?","commit_id":"ce622bd10af793dbbd77527c44f8b74d47300a32"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe5c81c3674972a8588819eb5f562a0833b6cbba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"bc39131c_900b2a78","updated":"2022-03-03 12:09:25.000000000","message":"recheck","commit_id":"1d9007ec7ea5ebcd68e0a0331359c8b1dd516493"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95a7c46625b057969d9c00c724fcff33a2a40e18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b2e0d80f_4264c3f7","updated":"2022-03-11 09:58:35.000000000","message":"Looks good overall, just some minor comments.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1055bd15acb92890ace2b21caad201911dc5e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"14fd1de0_fc7d6326","updated":"2022-03-11 13:31:01.000000000","message":"Thanks Pierre. Do you have any thoughts on my comments on PS20?","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9159493d45833d868051a6e58eb00e8a0202a3f4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"8a99c932_2a9368a1","in_reply_to":"14fd1de0_fc7d6326","updated":"2022-03-21 13:25:31.000000000","message":"Were you referring to the comment about whether we should wait for a release (I assumed you meant release cycle). If there is no chance of terminating your active VMs by accident, I would say let\u0027s make the change now.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"72cb1582253ee9168b707da3639a407d87acfdac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"ace726eb_fe0d597f","in_reply_to":"8a99c932_2a9368a1","updated":"2022-03-21 13:43:10.000000000","message":"Yes, that one and the one about simplifying the variables (which I have done) were the main ones.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d892713583e2b841b5e3eebcf13492f34a79b43f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"13542ce3_450f05f0","updated":"2022-03-14 11:48:00.000000000","message":"recheck","commit_id":"6e1548198594e69ebd1aa8b22db85fbb15b37436"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7fd50645c52f67167ef4f6878101538e853a1654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"88767559_3cf32869","updated":"2022-03-14 11:55:59.000000000","message":"recheck","commit_id":"6e1548198594e69ebd1aa8b22db85fbb15b37436"}],"ansible/compute-libvirt-host.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95a7c46625b057969d9c00c724fcff33a2a40e18","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      vars:"},{"line_number":21,"context_line":"        libvirt_host_libvirtd_conf: \"{{ compute_libvirt_conf }}\""},{"line_number":22,"context_line":"        libvirt_host_qemu_conf: \"{{ compute_qemu_conf }}\""},{"line_number":23,"context_line":"        # Enable TCP listener by default, but disable it if TCP listener is"},{"line_number":24,"context_line":"        # enabled."},{"line_number":25,"context_line":"        libvirt_host_tcp_listen: \"{{ compute_libvirt_tcp_listen | bool }}\""},{"line_number":26,"context_line":"        libvirt_host_tcp_listen_address: \"{{ compute_libvirt_tcp_listen_address }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"57b72154_9840894f","line":23,"range":{"start_line":23,"start_character":60,"end_line":23,"end_character":63},"updated":"2022-03-11 09:58:35.000000000","message":"I think you meant TLS here.\n\nAlso this comment is prone to getting out of sync with where trueness is defined, in ansible/group_vars/all/compute.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1055bd15acb92890ace2b21caad201911dc5e0a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      vars:"},{"line_number":21,"context_line":"        libvirt_host_libvirtd_conf: \"{{ compute_libvirt_conf }}\""},{"line_number":22,"context_line":"        libvirt_host_qemu_conf: \"{{ compute_qemu_conf }}\""},{"line_number":23,"context_line":"        # Enable TCP listener by default, but disable it if TCP listener is"},{"line_number":24,"context_line":"        # enabled."},{"line_number":25,"context_line":"        libvirt_host_tcp_listen: \"{{ compute_libvirt_tcp_listen | bool }}\""},{"line_number":26,"context_line":"        libvirt_host_tcp_listen_address: \"{{ compute_libvirt_tcp_listen_address }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"d40badd2_8fb31ca3","line":23,"range":{"start_line":23,"start_character":60,"end_line":23,"end_character":63},"in_reply_to":"57b72154_9840894f","updated":"2022-03-11 13:31:01.000000000","message":"Done","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"}],"ansible/group_vars/all/compute":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":163,"context_line":"compute_firewalld_rules: []"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"###############################################################################"},{"line_number":166,"context_line":"# Compute node host libvirt configuration."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Whether to enable a host libvirt daemon. Default is true if kolla_enable_nova"},{"line_number":169,"context_line":"# is true and kolla_enable_nova_libvirt_container is false."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"c87d5fb9_2c695f53","line":166,"updated":"2022-02-15 12:12:24.000000000","message":"I\u0027m wondering if we\u0027re exposing too much here. Some of these are bordering on implementation details. Should we slim it down?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"befd99b9825bca420f14628c33b39ef246614eca","unresolved":true,"context_lines":[{"line_number":163,"context_line":"compute_firewalld_rules: []"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"###############################################################################"},{"line_number":166,"context_line":"# Compute node host libvirt configuration."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Whether to enable a host libvirt daemon. Default is true if kolla_enable_nova"},{"line_number":169,"context_line":"# is true and kolla_enable_nova_libvirt_container is false."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"dbcc03da_3ea53af9","line":166,"in_reply_to":"5b0c79ca_d8fb835f","updated":"2022-03-17 11:45:32.000000000","message":"I\u0027ve trimmed it down to remove a lot of the networking stuff.\n\nArgument splatting is for tasks rather than roles, not sure it applies here.\n\nYou can specify arbitrary role variables using group_vars","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb32fa4d86b6360656fa8448501fb59378588eeb","unresolved":true,"context_lines":[{"line_number":163,"context_line":"compute_firewalld_rules: []"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"###############################################################################"},{"line_number":166,"context_line":"# Compute node host libvirt configuration."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Whether to enable a host libvirt daemon. Default is true if kolla_enable_nova"},{"line_number":169,"context_line":"# is true and kolla_enable_nova_libvirt_container is false."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"5b0c79ca_d8fb835f","line":166,"in_reply_to":"c87d5fb9_2c695f53","updated":"2022-03-16 16:09:48.000000000","message":"I guess we could start minimal and build up if necessary. I do wonder if we could prevent the duplication of role variables by using argument splatting:\n\nhttps://github.com/ansible/ansible/pull/43798\n\nI believe this is safe now that inject facts as vars is false. \n\nYou could have compute_libvirt_host_role_vars_default, compute_libvirt_host_role_vars, and compute_libvirt_host_role_vars_extra and only put stuff in compute_libvirt_host_role_vars_default where we have changed the defaults from the role.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"856db402e1dd3af9add41a1ae884f91ba189abab","unresolved":true,"context_lines":[{"line_number":163,"context_line":"compute_firewalld_rules: []"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"###############################################################################"},{"line_number":166,"context_line":"# Compute node host libvirt configuration."},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Whether to enable a host libvirt daemon. Default is true if kolla_enable_nova"},{"line_number":169,"context_line":"# is true and kolla_enable_nova_libvirt_container is false."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"9504e9a7_d29fc046","line":166,"in_reply_to":"dbcc03da_3ea53af9","updated":"2022-03-23 12:26:59.000000000","message":"Re: argument splatting. Ah, of course looking good in newer versions of the patch.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":184,"context_line":"# compute_libvirt_conf_extra."},{"line_number":185,"context_line":"compute_libvirt_conf: \"{{ compute_libvirt_conf_default | combine(compute_libvirt_conf_extra) }}\""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"# Numerical log level for libvirtd. Default is 3."},{"line_number":188,"context_line":"compute_libvirtd_log_level: 3"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# A dict of default configuration options to write to"},{"line_number":191,"context_line":"# /etc/libvirt/qemu.conf."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"2061faa8_f279c2bc","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":29},"updated":"2022-02-15 12:12:24.000000000","message":"Could be overridden via compute_libvirt_conf_extra","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":202,"context_line":"# compute_qemu_conf_extra."},{"line_number":203,"context_line":"compute_qemu_conf: \"{{ compute_qemu_conf_default | combine(compute_qemu_conf_extra) }}\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# Maximum number of open files for QEMU. Default is 32768."},{"line_number":206,"context_line":"compute_qemu_max_files: 32768"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"de92aa70_c6c74873","line":209,"range":{"start_line":205,"start_character":0,"end_line":209,"end_character":34},"updated":"2022-02-15 12:12:24.000000000","message":"Could be overridden via compute_qemu_conf_extra","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1055bd15acb92890ace2b21caad201911dc5e0a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"# compute_qemu_conf_extra."},{"line_number":203,"context_line":"compute_qemu_conf: \"{{ compute_qemu_conf_default | combine(compute_qemu_conf_extra) }}\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# Maximum number of open files for QEMU. Default is 32768."},{"line_number":206,"context_line":"compute_qemu_max_files: 32768"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"b67bacdd_ddeb26ff","line":209,"range":{"start_line":205,"start_character":0,"end_line":209,"end_character":34},"in_reply_to":"2cac0aae_254b2f01","updated":"2022-03-11 13:31:01.000000000","message":"I\u0027ve removed these specific variables.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95a7c46625b057969d9c00c724fcff33a2a40e18","unresolved":true,"context_lines":[{"line_number":202,"context_line":"# compute_qemu_conf_extra."},{"line_number":203,"context_line":"compute_qemu_conf: \"{{ compute_qemu_conf_default | combine(compute_qemu_conf_extra) }}\""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"# Maximum number of open files for QEMU. Default is 32768."},{"line_number":206,"context_line":"compute_qemu_max_files: 32768"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."}],"source_content_type":"application/octet-stream","patch_set":20,"id":"2cac0aae_254b2f01","line":209,"range":{"start_line":205,"start_character":0,"end_line":209,"end_character":34},"in_reply_to":"de92aa70_c6c74873","updated":"2022-03-11 09:58:35.000000000","message":"Will we really need to ever change these defaults? Could they be in the Ansible role instead?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."},{"line_number":213,"context_line":"compute_libvirt_tcp_listen: \"{{ not compute_libvirt_tls_listen | bool }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"# Address for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":216,"context_line":"# is true."},{"line_number":217,"context_line":"compute_libvirt_tcp_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tcp_listen_port }}\""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# Port for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":220,"context_line":"# is true. Default is 16509"},{"line_number":221,"context_line":"compute_libvirt_tcp_listen_port: 16509"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"# Whether to enable a libvirt TLS listener. Default is false."},{"line_number":224,"context_line":"compute_libvirt_tls_listen: false"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Address for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":227,"context_line":"# is true."},{"line_number":228,"context_line":"compute_libvirt_tls_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tls_listen_port }}\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Port for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":231,"context_line":"# is true. Default is 16514."},{"line_number":232,"context_line":"compute_libvirt_tls_listen_port: 16514"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"# Whether to install a Ceph package repository. Default is true."},{"line_number":235,"context_line":"compute_libvirt_ceph_repo_install: true"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"e3b7a4c6_7cdd4c45","line":232,"range":{"start_line":211,"start_character":0,"end_line":232,"end_character":38},"updated":"2022-02-15 12:12:24.000000000","message":"Possibly we could simplify networking to:\n\n* network name\n* enable TLS\n* port","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"befd99b9825bca420f14628c33b39ef246614eca","unresolved":false,"context_lines":[{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."},{"line_number":213,"context_line":"compute_libvirt_tcp_listen: \"{{ not compute_libvirt_tls_listen | bool }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"# Address for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":216,"context_line":"# is true."},{"line_number":217,"context_line":"compute_libvirt_tcp_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tcp_listen_port }}\""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# Port for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":220,"context_line":"# is true. Default is 16509"},{"line_number":221,"context_line":"compute_libvirt_tcp_listen_port: 16509"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"# Whether to enable a libvirt TLS listener. Default is false."},{"line_number":224,"context_line":"compute_libvirt_tls_listen: false"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Address for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":227,"context_line":"# is true."},{"line_number":228,"context_line":"compute_libvirt_tls_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tls_listen_port }}\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Port for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":231,"context_line":"# is true. Default is 16514."},{"line_number":232,"context_line":"compute_libvirt_tls_listen_port: 16514"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"# Whether to install a Ceph package repository. Default is true."},{"line_number":235,"context_line":"compute_libvirt_ceph_repo_install: true"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"68bb28e3_2e3c1cc1","line":232,"range":{"start_line":211,"start_character":0,"end_line":232,"end_character":38},"in_reply_to":"bae39e10_8ed210ec","updated":"2022-03-17 11:45:32.000000000","message":"I\u0027ve trimmed this down.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"fb32fa4d86b6360656fa8448501fb59378588eeb","unresolved":true,"context_lines":[{"line_number":208,"context_line":"# Maximum number of open processes for QEMU. Default is 131072."},{"line_number":209,"context_line":"compute_qemu_max_processes: 131072"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":212,"context_line":"# compute_libvirt_tls_listen."},{"line_number":213,"context_line":"compute_libvirt_tcp_listen: \"{{ not compute_libvirt_tls_listen | bool }}\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"# Address for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":216,"context_line":"# is true."},{"line_number":217,"context_line":"compute_libvirt_tcp_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tcp_listen_port }}\""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# Port for libvirt TCP listener to listen on when compute_libvirt_tcp_listen"},{"line_number":220,"context_line":"# is true. Default is 16509"},{"line_number":221,"context_line":"compute_libvirt_tcp_listen_port: 16509"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"# Whether to enable a libvirt TLS listener. Default is false."},{"line_number":224,"context_line":"compute_libvirt_tls_listen: false"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Address for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":227,"context_line":"# is true."},{"line_number":228,"context_line":"compute_libvirt_tls_listen_address: \"{{ internal_net_name | net_ip }}:{{ compute_libvirt_tls_listen_port }}\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# Port for libvirt TLS listener to listen on when compute_libvirt_tls_listen"},{"line_number":231,"context_line":"# is true. Default is 16514."},{"line_number":232,"context_line":"compute_libvirt_tls_listen_port: 16514"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"# Whether to install a Ceph package repository. Default is true."},{"line_number":235,"context_line":"compute_libvirt_ceph_repo_install: true"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"bae39e10_8ed210ec","line":232,"range":{"start_line":211,"start_character":0,"end_line":232,"end_character":38},"in_reply_to":"e3b7a4c6_7cdd4c45","updated":"2022-03-16 16:09:48.000000000","message":"I guess a network name variable could always be introduction at a later point in time?","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"}],"ansible/roles/kolla-openstack/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":91,"context_line":"- name: Ensure extra configuration parent directories are present"},{"line_number":92,"context_line":"  file:"},{"line_number":93,"context_line":"    path: \"{{ item.0.item.dest }}/{{ item.1.path | relpath(item.0.item.src) | dirname }}\""},{"line_number":94,"context_line":"    recurse: true"},{"line_number":95,"context_line":"    state: directory"},{"line_number":96,"context_line":"    mode: 0750"},{"line_number":97,"context_line":"  with_subelements:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"97efa33b_82cafdcf","side":"PARENT","line":94,"range":{"start_line":94,"start_character":4,"end_line":94,"end_character":17},"updated":"2022-02-15 12:12:24.000000000","message":"This is arguably a separate idempotence bugfix that we should backport. I needed it here for molecule.","commit_id":"c00085da693e6ae9abe2a8e7a82c9665a6b88477"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4deabe68b578496e5dc8f4f9659931c09bc4331","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    recurse: true"},{"line_number":81,"context_line":"  with_items: \"{{ kolla_openstack_custom_config }}\""},{"line_number":82,"context_line":"  register: find_src_result"},{"line_number":83,"context_line":"  delegate_to: localhost"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- name: Find previously generated extra configuration files"},{"line_number":86,"context_line":"  find:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"45ba35da_a9f198d1","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":24},"updated":"2022-02-15 12:12:24.000000000","message":"This is mostly to keep molecule tests happy where we don\u0027t generate on localhost.","commit_id":"abe18dcd9bb7b97f798c6af8a42618a7d00bb19a"}],"doc/source/configuration/reference/hosts.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95a7c46625b057969d9c00c724fcff33a2a40e18","unresolved":true,"context_lines":[{"line_number":996,"context_line":"``compute_libvirt_tls_listen_port``"},{"line_number":997,"context_line":"    Port for libvirt TLS listener to listen on when"},{"line_number":998,"context_line":"    ``compute_libvirt_tls_listen`` is ``true``. Default is 16514."},{"line_number":999,"context_line":"``compute_libvirt_ceph_repo_install``"},{"line_number":1000,"context_line":"    Whether to install a Ceph package repository. Default is ``true``."},{"line_number":1001,"context_line":"``compute_libvirt_ceph_repo_release``"},{"line_number":1002,"context_line":"    Ceph package repository release to install when"},{"line_number":1003,"context_line":"    ``compute_libvirt_ceph_repo_install`` is ``true``. Default is ``pacific``."}],"source_content_type":"text/x-rst","patch_set":26,"id":"f5b4d68f_0d904103","line":1000,"range":{"start_line":999,"start_character":0,"end_line":1000,"end_character":70},"updated":"2022-03-11 09:58:35.000000000","message":"Could add that this is CentOS-only.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1055bd15acb92890ace2b21caad201911dc5e0a","unresolved":false,"context_lines":[{"line_number":996,"context_line":"``compute_libvirt_tls_listen_port``"},{"line_number":997,"context_line":"    Port for libvirt TLS listener to listen on when"},{"line_number":998,"context_line":"    ``compute_libvirt_tls_listen`` is ``true``. Default is 16514."},{"line_number":999,"context_line":"``compute_libvirt_ceph_repo_install``"},{"line_number":1000,"context_line":"    Whether to install a Ceph package repository. Default is ``true``."},{"line_number":1001,"context_line":"``compute_libvirt_ceph_repo_release``"},{"line_number":1002,"context_line":"    Ceph package repository release to install when"},{"line_number":1003,"context_line":"    ``compute_libvirt_ceph_repo_install`` is ``true``. Default is ``pacific``."}],"source_content_type":"text/x-rst","patch_set":26,"id":"9ceb443f_899c6fb9","line":1000,"range":{"start_line":999,"start_character":0,"end_line":1000,"end_character":70},"in_reply_to":"f5b4d68f_0d904103","updated":"2022-03-11 13:31:01.000000000","message":"Done","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9159493d45833d868051a6e58eb00e8a0202a3f4","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"Example: disabling Ceph repository installation"},{"line_number":1053,"context_line":"-----------------------------------------------"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"On CentOS hosts, a CentOS Storage SIG Ceph repository is installed that"},{"line_number":1056,"context_line":"provides more recent Ceph libraries than those available in CentOS AppStream."},{"line_number":1057,"context_line":"This may be necessary when using Ceph for Cinder volumes or Nova ephemeral"},{"line_number":1058,"context_line":"block devices. In some cases, such as when using local package mirrors, the"},{"line_number":1059,"context_line":"upstream repository may not be appropriate. The installation of the repository"},{"line_number":1060,"context_line":"may be disabled as follows:"},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"582c6db2_dd9936bf","line":1058,"range":{"start_line":1055,"start_character":0,"end_line":1058,"end_character":14},"updated":"2022-03-21 13:25:31.000000000","message":"What about Rocky Linux?","commit_id":"538b10dbf8e5a83fed3b8c1c98252a7893447cdd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"72cb1582253ee9168b707da3639a407d87acfdac","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"Example: disabling Ceph repository installation"},{"line_number":1053,"context_line":"-----------------------------------------------"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"On CentOS hosts, a CentOS Storage SIG Ceph repository is installed that"},{"line_number":1056,"context_line":"provides more recent Ceph libraries than those available in CentOS AppStream."},{"line_number":1057,"context_line":"This may be necessary when using Ceph for Cinder volumes or Nova ephemeral"},{"line_number":1058,"context_line":"block devices. In some cases, such as when using local package mirrors, the"},{"line_number":1059,"context_line":"upstream repository may not be appropriate. The installation of the repository"},{"line_number":1060,"context_line":"may be disabled as follows:"},{"line_number":1061,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"5ca28f5b_cf3f5d86","line":1058,"range":{"start_line":1055,"start_character":0,"end_line":1058,"end_character":14},"in_reply_to":"582c6db2_dd9936bf","updated":"2022-03-21 13:43:10.000000000","message":"It wasn\u0027t supported when I wrote this! I\u0027ll update.","commit_id":"538b10dbf8e5a83fed3b8c1c98252a7893447cdd"}],"doc/source/contributor/automated.rst":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"95a7c46625b057969d9c00c724fcff33a2a40e18","unresolved":true,"context_lines":[{"line_number":131,"context_line":"deployed. We can use the `Tenks \u003chttps://tenks.readthedocs.io/en/latest/\u003e`__"},{"line_number":132,"context_line":"project to create fake bare metal nodes."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"On Ubuntu, if you are running Libvirt in a container, the ``nova_libvirt``"},{"line_number":135,"context_line":"image does not contain the ``qemu-utils`` package necessary for image"},{"line_number":136,"context_line":"operations used by Tenks. Install it as follows::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sudo docker exec -u root nova_libvirt bash -c \u0027apt update \u0026\u0026 apt -y install qemu-utils\u0027"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Clone the tenks repository::"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"f81d3c30_7fe5894f","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":91},"updated":"2022-03-11 09:58:35.000000000","message":"This is not true anymore.","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1055bd15acb92890ace2b21caad201911dc5e0a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"deployed. We can use the `Tenks \u003chttps://tenks.readthedocs.io/en/latest/\u003e`__"},{"line_number":132,"context_line":"project to create fake bare metal nodes."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"On Ubuntu, if you are running Libvirt in a container, the ``nova_libvirt``"},{"line_number":135,"context_line":"image does not contain the ``qemu-utils`` package necessary for image"},{"line_number":136,"context_line":"operations used by Tenks. Install it as follows::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    sudo docker exec -u root nova_libvirt bash -c \u0027apt update \u0026\u0026 apt -y install qemu-utils\u0027"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Clone the tenks repository::"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"5e0045ba_ea8d3c52","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":91},"in_reply_to":"f81d3c30_7fe5894f","updated":"2022-03-11 13:31:01.000000000","message":"Done","commit_id":"43ebc15f7559fa5085c3c6cb013c7702d4d93475"}],"releasenotes/notes/libvirt-on-host-ff83f12923cc1f58.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c1ce3d2181c0dc98a93e66da67b9afa145d60d84","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for running a libvirt daemon on the host, rather than in a"},{"line_number":5,"context_line":"    container. This is done by setting ``kolla_enable_nova_libvirt_container``"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"362dd63b_2d430ab7","line":2,"updated":"2022-03-24 09:23:09.000000000","message":"Should we add an `upgrade` note describing that migration from libvirt container to host is not supported, so existing deployments should set kolla_enable_nova_libvirt_container to true?","commit_id":"387f619069d43c80cabf430626621c1bd01d7bcc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"aacef3af305fedbb74c6814aabc0fa16a646620c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for running a libvirt daemon on the host, rather than in a"},{"line_number":5,"context_line":"    container. This is done by setting ``kolla_enable_nova_libvirt_container``"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"c69e7434_0e776bc6","line":2,"in_reply_to":"362dd63b_2d430ab7","updated":"2022-03-24 12:13:02.000000000","message":"Done in a follow-up.","commit_id":"387f619069d43c80cabf430626621c1bd01d7bcc"}]}