)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"df622e2a7a824bd9f65c4c1263494368ec34567a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f19abdb_2d083a0e","updated":"2022-02-18 14:43:15.000000000","message":"This effectively changes the default setting from present to added. Is this what we want?","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1afeef1b31fdcd441f9566fab56b1c3ad6b0a8f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3781431_19b62587","in_reply_to":"0f19abdb_2d083a0e","updated":"2023-11-08 16:36:54.000000000","message":"Restored the default. I couldn\u0027t see this variable being used anywhere else.","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"679252ada7d8d541213fd9c4ccfd75e6fdcd6fb5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5258da8_71c1b116","in_reply_to":"a3781431_19b62587","updated":"2024-11-07 11:36:06.000000000","message":"Doesn\u0027t it still change the default value used in configuration from present to added? This is not mentioned in the release note.","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c2a9f2354fc04be42ec8f9de65059d9b455d2c86","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cdc00c57_26676823","updated":"2024-11-06 14:40:36.000000000","message":"do you planned to add precheck or merge this as is?","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"ec4200f4ff809188714b729655118079d7fecf88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"adac8369_d79e22a7","updated":"2024-10-31 09:56:16.000000000","message":"recheck","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"01f1b7893fdef5ab995b5d8cc7f1f51454ba72bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf5150b8_fa199371","in_reply_to":"cdc00c57_26676823","updated":"2024-11-07 10:35:34.000000000","message":"Let\u0027s follow-up with a precheck, it would be applicable to more than just `kolla_inspector_keep_ports`. (`kolla_inspector_add_ports` too for example)","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"}],"ansible/roles/kolla-openstack/templates/ironic-inspector.conf.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"df622e2a7a824bd9f65c4c1263494368ec34567a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"# Keep only those ports that were found during inspection."},{"line_number":17,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff29e8d9_f6da3ea2","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":58},"updated":"2022-02-18 14:43:15.000000000","message":"This comment is not valid anymore if the variable is set to all?","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1afeef1b31fdcd441f9566fab56b1c3ad6b0a8f9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"# Keep only those ports that were found during inspection."},{"line_number":17,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3613a780_1f8b0dd7","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":58},"in_reply_to":"ff29e8d9_f6da3ea2","updated":"2023-11-08 16:36:54.000000000","message":"Done","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"}],"ansible/roles/kolla-openstack/templates/kolla/config/ironic-inspector.conf":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"632192b4503d0c88786304e549e743519a6c575a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"add_ports \u003d {{ kolla_inspector_add_ports }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"c92f87f3_1e8f770e","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":35},"updated":"2023-12-03 13:21:43.000000000","message":"and kolla_inspector_keep_ports in [\u0027all\u0027, \u0027added\u0027, \u0027present\u0027]","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"de91d68f980d014af40ef90af26cd84ff526d987","unresolved":true,"context_lines":[{"line_number":12,"context_line":"add_ports \u003d {{ kolla_inspector_add_ports }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"ec85cbfb_0950e907","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":35},"in_reply_to":"0774872f_47879134","updated":"2024-11-06 14:35:41.000000000","message":"I don\u0027t agree. This would lead to surprising behavior. It would be better to add a precheck that actually failed the run instead of silently failing to add the options.","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"01f1b7893fdef5ab995b5d8cc7f1f51454ba72bf","unresolved":false,"context_lines":[{"line_number":12,"context_line":"add_ports \u003d {{ kolla_inspector_add_ports }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"59c6014f_5fb92cdc","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":35},"in_reply_to":"a18b0eae_ab7fdce5","updated":"2024-11-07 10:35:34.000000000","message":"Done, precheck should be in a follow-up patch","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"823e6870c732ff9b95fd020ae879d70caa6de59a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"add_ports \u003d {{ kolla_inspector_add_ports }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"0774872f_47879134","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":35},"in_reply_to":"c92f87f3_1e8f770e","updated":"2024-10-31 10:35:53.000000000","message":"we still need this check, as it says in reno","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d0f844d06b94e3b10f019d073f37cbe255a59294","unresolved":true,"context_lines":[{"line_number":12,"context_line":"add_ports \u003d {{ kolla_inspector_add_ports }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% if kolla_inspector_keep_ports %}"},{"line_number":16,"context_line":"keep_ports \u003d {{ kolla_inspector_keep_ports }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":""}],"source_content_type":"text/plain","patch_set":4,"id":"a18b0eae_ab7fdce5","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":35},"in_reply_to":"ec85cbfb_0950e907","updated":"2024-11-06 14:39:59.000000000","message":"very good idea. let it be a precheck.","commit_id":"a1409994e4d0a4c78bf4767761e97253c0c67abb"}],"releasenotes/notes/respect-comment-for-keep-ports-e0b1ab73395055a6.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"df622e2a7a824bd9f65c4c1263494368ec34567a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If you have customized ``inspector_keep_ports``, ensure it is set to one of: "},{"line_number":5,"context_line":"    ``all``, ``present``, ``added``."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d7dec4f_869f8b9e","line":4,"range":{"start_line":4,"start_character":80,"end_line":4,"end_character":81},"updated":"2022-02-18 14:43:15.000000000","message":"Remove trailing whitespace","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"1afeef1b31fdcd441f9566fab56b1c3ad6b0a8f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    If you have customized ``inspector_keep_ports``, ensure it is set to one of: "},{"line_number":5,"context_line":"    ``all``, ``present``, ``added``."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"46905666_60b0a868","line":4,"range":{"start_line":4,"start_character":80,"end_line":4,"end_character":81},"in_reply_to":"1d7dec4f_869f8b9e","updated":"2023-11-08 16:36:54.000000000","message":"Done","commit_id":"f65b5fd189ef364b8715fa86da782c8cc1389487"}]}