)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1fd20de333445edfddd2d66c039fada5f41a51f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e847ee53_5d03c55c","updated":"2022-02-22 09:51:23.000000000","message":"Thanks","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"faa80d4454e1144d4ae4dff083b3fdb6b9c423ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fad45e8d_71ecc4e3","updated":"2022-02-22 15:20:40.000000000","message":"can we trigger travis-ci and fix an issue here to push galaxy role?","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4228cda5c142e9c080316c8617d4c96c682f35d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0ddc5bb_bfb0e14b","in_reply_to":"fad45e8d_71ecc4e3","updated":"2022-02-22 15:43:59.000000000","message":"I just triggered an import manually. Probably that role needs some CI updates.","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"}],"ansible/roles/network-redhat/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1fd20de333445edfddd2d66c039fada5f41a51f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"interfaces_workaround_centos_remove:"},{"line_number":2,"context_line":"  - ens3"},{"line_number":3,"context_line":"  - ens3-1"},{"line_number":4,"context_line":"  - eth0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c3e7c30f_ddeaf7fd","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"updated":"2022-02-22 09:51:23.000000000","message":"It\u0027s currently possible to do this without adding the default here. I\u0027d suggest we just document that in doc/source/configuration/reference/network.rst rather than redefining the defaults here.","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"67cf08e8ec1110b7db66de0e6636f9a63e25ec03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"interfaces_workaround_centos_remove:"},{"line_number":2,"context_line":"  - ens3"},{"line_number":3,"context_line":"  - ens3-1"},{"line_number":4,"context_line":"  - eth0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a602783_b103bc83","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"8152ead0_295c47ab","updated":"2022-02-22 15:18:35.000000000","message":"should I add note about unsolved issue in Ubuntu?","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"917017fa896470ddb208241583f01a8821aec4bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"interfaces_workaround_centos_remove:"},{"line_number":2,"context_line":"  - ens3"},{"line_number":3,"context_line":"  - ens3-1"},{"line_number":4,"context_line":"  - eth0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e38e68ea_70e4faf9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"c3e7c30f_ddeaf7fd","updated":"2022-02-22 14:52:57.000000000","message":"okay, should we mention that this is only for CentOS, and the workaround for Ubuntu in still exist (fix/workaround I push on review in separate change later) ?","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d633e351c86cbdbd6a5d50425347027840adff45","unresolved":false,"context_lines":[{"line_number":1,"context_line":"interfaces_workaround_centos_remove:"},{"line_number":2,"context_line":"  - ens3"},{"line_number":3,"context_line":"  - ens3-1"},{"line_number":4,"context_line":"  - eth0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8152ead0_295c47ab","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":35},"in_reply_to":"e38e68ea_70e4faf9","updated":"2022-02-22 15:03:09.000000000","message":"Yes, mention that it is only for CentOS.","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"}],"ansible/roles/network-redhat/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1fd20de333445edfddd2d66c039fada5f41a51f1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"         list }}"},{"line_number":39,"context_line":"    interfaces_setup_filter: \"{{ kayobe_ansible_setup_filter }}\""},{"line_number":40,"context_line":"    interfaces_setup_gather_subset: \"{{ kayobe_ansible_setup_gather_subset }}\""},{"line_number":41,"context_line":"    interfaces_workaround_centos_remove: \"{{ interfaces_workaround_centos_remove }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Configure virtual ethernet patch links to connect the workload provision"},{"line_number":44,"context_line":"# and external network bridges to the Neutron OVS bridge."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f592816_3202a15d","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":84},"updated":"2022-02-22 09:51:23.000000000","message":"Unnecessary if the same name is used.","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"917017fa896470ddb208241583f01a8821aec4bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"         list }}"},{"line_number":39,"context_line":"    interfaces_setup_filter: \"{{ kayobe_ansible_setup_filter }}\""},{"line_number":40,"context_line":"    interfaces_setup_gather_subset: \"{{ kayobe_ansible_setup_gather_subset }}\""},{"line_number":41,"context_line":"    interfaces_workaround_centos_remove: \"{{ interfaces_workaround_centos_remove }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Configure virtual ethernet patch links to connect the workload provision"},{"line_number":44,"context_line":"# and external network bridges to the Neutron OVS bridge."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34c04a0e_7968c49b","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":84},"in_reply_to":"3f592816_3202a15d","updated":"2022-02-22 14:52:57.000000000","message":"Done","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"}],"doc/source/configuration/reference/network.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f838ad9b78babbbbe5ec4491fc7202e01a697b","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"   bond0_bond_mode: \"802.3ad\""},{"line_number":1076,"context_line":"   bond0_bond_slaves: [\"eno1\",\"eno2\"]"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"   bond0.11_interface: \"bond0.11\""},{"line_number":1079,"context_line":"   bond0.11_vlan: \"11\""},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d1a0bf10_4ed8be5b","line":1079,"range":{"start_line":1078,"start_character":0,"end_line":1079,"end_character":22},"updated":"2022-03-03 15:25:15.000000000","message":"I don\u0027t think it\u0027s a valid variable name. Is it used?","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ba3fd0ba2b9bda79c82406261b378edd7faa8cf","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"   bond0_bond_mode: \"802.3ad\""},{"line_number":1076,"context_line":"   bond0_bond_slaves: [\"eno1\",\"eno2\"]"},{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"   bond0.11_interface: \"bond0.11\""},{"line_number":1079,"context_line":"   bond0.11_vlan: \"11\""},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"10dd74c4_1f50e94d","line":1079,"range":{"start_line":1078,"start_character":0,"end_line":1079,"end_character":22},"in_reply_to":"d1a0bf10_4ed8be5b","updated":"2022-03-03 15:49:01.000000000","message":"valid and used","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f838ad9b78babbbbe5ec4491fc7202e01a697b","unresolved":true,"context_lines":[{"line_number":1078,"context_line":"   bond0.11_interface: \"bond0.11\""},{"line_number":1079,"context_line":"   bond0.11_vlan: \"11\""},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"   management_interface: \"brmgmt\""},{"line_number":1085,"context_line":"   management_bridge_ports: [\"bond0.11\"]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d21ac4d5_5520900d","line":1082,"range":{"start_line":1081,"start_character":1,"end_line":1082,"end_character":30},"updated":"2022-03-03 15:25:15.000000000","message":"By default, controllers don\u0027t get mapped to the provision_oc network. So this isn\u0027t used.","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ba3fd0ba2b9bda79c82406261b378edd7faa8cf","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"   bond0.11_interface: \"bond0.11\""},{"line_number":1079,"context_line":"   bond0.11_vlan: \"11\""},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"   management_interface: \"brmgmt\""},{"line_number":1085,"context_line":"   management_bridge_ports: [\"bond0.11\"]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c3aa6b64_e1324081","line":1082,"range":{"start_line":1081,"start_character":1,"end_line":1082,"end_character":30},"in_reply_to":"d21ac4d5_5520900d","updated":"2022-03-03 15:49:01.000000000","message":"it does not matter. can be changed to \u0027compute\u0027. in our production we provision and configure all the overcloud the same way. and this is not default case, as said before.","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f838ad9b78babbbbe5ec4491fc7202e01a697b","unresolved":true,"context_lines":[{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"   management_interface: \"brmgmt\""},{"line_number":1085,"context_line":"   management_bridge_ports: [\"bond0.11\"]"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"This is a correct and working configuration with some limitations caused"}],"source_content_type":"text/x-rst","patch_set":3,"id":"f99e587a_7886a33f","line":1084,"range":{"start_line":1084,"start_character":26,"end_line":1084,"end_character":32},"updated":"2022-03-03 15:25:15.000000000","message":"Does it need to be a bridge? Could be bond0.11?\n\nI think there are two basic cases where this could happen.\n\n1. Bond with VLAN management network:\n\neno1 -\u003e bond0 -\u003e bond0.11\n\n2. Bridge with VLAN management network:\n\neno1 -\u003e br0 -\u003e br0.11","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ba3fd0ba2b9bda79c82406261b378edd7faa8cf","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"   pxe_interface: \"brpxe\""},{"line_number":1082,"context_line":"   pxe_bridge_ports: [\u0027bond0\u0027]"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"   management_interface: \"brmgmt\""},{"line_number":1085,"context_line":"   management_bridge_ports: [\"bond0.11\"]"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"This is a correct and working configuration with some limitations caused"}],"source_content_type":"text/x-rst","patch_set":3,"id":"118e5ab8_245c712b","line":1084,"range":{"start_line":1084,"start_character":26,"end_line":1084,"end_character":32},"in_reply_to":"f99e587a_7886a33f","updated":"2022-03-03 15:49:01.000000000","message":"this is partial configuration, the full is much more complicated, something like:\n\neno0 \\            /--\u003e bond0.11 --\u003e brpxe\n      +-\u003e bond0 -+---\u003e bond0.12 --\u003e brmgmt\neno1 /            \\--\u003e bond0.13 --\u003e brpub\n\neno2 \\            \n      +-\u003e bond1 -+---\u003e bond1.14 --\u003e brstrg\neno3 /\n\nand once more, this is not the basic case. this is simplified scheme describe production we use.","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f838ad9b78babbbbe5ec4491fc7202e01a697b","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"``\u0027interfaces_workaround_centos_remove`` variable:"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":".. code-block:: yaml"},{"line_number":1115,"context_line":"   :caption: ``globals.yml``"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"   interfaces_workaround_centos_remove:"},{"line_number":1118,"context_line":"    - ens3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3b97ef2c_2c9f03b9","line":1115,"range":{"start_line":1115,"start_character":15,"end_line":1115,"end_character":22},"updated":"2022-03-03 15:25:15.000000000","message":"networks.yml or group_vars seems more appropriate.","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1ba3fd0ba2b9bda79c82406261b378edd7faa8cf","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"``\u0027interfaces_workaround_centos_remove`` variable:"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":".. code-block:: yaml"},{"line_number":1115,"context_line":"   :caption: ``globals.yml``"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"   interfaces_workaround_centos_remove:"},{"line_number":1118,"context_line":"    - ens3"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7b89d34d_5c0f77b8","line":1115,"range":{"start_line":1115,"start_character":15,"end_line":1115,"end_character":22},"in_reply_to":"3b97ef2c_2c9f03b9","updated":"2022-03-03 15:49:01.000000000","message":"it does not matter again. this is global for all overcloud. can be provided in the any other yaml ovveride file.","commit_id":"96744a812ecd091d016e4dadd84946f074a07e77"}],"releasenotes/notes/centos-remove-stale-interfaces-e8ed9a631282a4f6.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1fd20de333445edfddd2d66c039fada5f41a51f1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    interfaces configuration files along with default ones described in the"},{"line_number":8,"context_line":"    \u0027interfaces_workaround_centos_remove\u0027 variable in the"},{"line_number":9,"context_line":"    \u0027MichaelRigart.interfaces\u0027 role. Now we can override these interfaces via"},{"line_number":10,"context_line":"    \u0027interfaces_workaround_centos_remove\u0027 in the Kayobe. This is applicable"},{"line_number":11,"context_line":"    only for CentOS."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bed26ba9_d3e0e864","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":40},"updated":"2022-02-22 09:51:23.000000000","message":"It was already possible, no need for a reno.","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"917017fa896470ddb208241583f01a8821aec4bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    interfaces configuration files along with default ones described in the"},{"line_number":8,"context_line":"    \u0027interfaces_workaround_centos_remove\u0027 variable in the"},{"line_number":9,"context_line":"    \u0027MichaelRigart.interfaces\u0027 role. Now we can override these interfaces via"},{"line_number":10,"context_line":"    \u0027interfaces_workaround_centos_remove\u0027 in the Kayobe. This is applicable"},{"line_number":11,"context_line":"    only for CentOS."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4a05f001_1f27f8dd","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":40},"in_reply_to":"bed26ba9_d3e0e864","updated":"2022-02-22 14:52:57.000000000","message":"Done","commit_id":"d315fee9ab28f579b059ffaa65e0bd4a0a103cb9"}]}