)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"804119b376ef301de85914d936c1414d26071d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3da90197_4fbaa116","updated":"2022-03-10 14:02:14.000000000","message":"recheck","commit_id":"5313dc3184624014e43760e33f261b8d17cd9098"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fbfdaf4f2277b4fa49aa36fffb5edbfc7f004122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"584370d1_522732d9","updated":"2022-03-10 10:33:52.000000000","message":"recheck","commit_id":"5313dc3184624014e43760e33f261b8d17cd9098"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c16bb0f33cc73b2f4430cd1d06596bff66ea1f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6726969_02920091","updated":"2022-03-10 11:01:07.000000000","message":"recheck","commit_id":"5313dc3184624014e43760e33f261b8d17cd9098"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"24311b2c35f3b652164778e0b178e70c92407dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e384a41c_4dc70fbd","updated":"2022-03-15 16:07:52.000000000","message":"recheck\n\nlibvirt-host role updated","commit_id":"497dfe6d843935967f5d892645da2774caab8ba7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"956af5673c3d021a4ad65ecb30447a245d2079c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04cc36fe_8a32a8b4","updated":"2022-03-21 13:35:59.000000000","message":"LGTM. We may want to release a new role version instead of using a branch, hence the +1.","commit_id":"8a8cc41cc459ba6efec80af7cf4109650a1c8a12"}],"ansible/group_vars/all/compute":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a0491af753e955fe8778b5af1645786e1c02660e","unresolved":true,"context_lines":[{"line_number":207,"context_line":"compute_libvirt_enable_sasl: true"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# libvirt SASL password. Default is unset."},{"line_number":210,"context_line":"compute_libvirt_sasl_password:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":213,"context_line":"# compute_libvirt_tls_listen."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"36ac1eed_98eef1c4","line":210,"updated":"2022-03-16 16:24:00.000000000","message":"Does this fail if unset? If not, this is a bad default as it makes it easy to accidentally set an empty password. If so, could we pass it through a mandatory filter to make that less likely?","commit_id":"497dfe6d843935967f5d892645da2774caab8ba7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4aaf812c43b824b13eecb36920da900dc1442e84","unresolved":true,"context_lines":[{"line_number":207,"context_line":"compute_libvirt_enable_sasl: true"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# libvirt SASL password. Default is unset."},{"line_number":210,"context_line":"compute_libvirt_sasl_password:"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"# Whether to enable a libvirt TCP listener. Default is inverse of"},{"line_number":213,"context_line":"# compute_libvirt_tls_listen."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"61ec9224_e83279d9","line":210,"in_reply_to":"36ac1eed_98eef1c4","updated":"2022-03-16 17:05:33.000000000","message":"It fails in the stackhpc.libvirt-host role if unset. However a service deploy might not fail if unset.\n\nI don\u0027t think the mandatory filter would work in a lazy way though, if the password is not required.","commit_id":"497dfe6d843935967f5d892645da2774caab8ba7"}]}