)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"19d42cf1d36ff0c4be8e53b28c8d55e092ba6d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"977dd693_1f9fc202","updated":"2022-04-06 07:15:59.000000000","message":"recheck","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"}],"ansible/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5aa03ad0766fdd789f3c95258d5eabd5fbf1ee9","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":44,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Pip requirement specifier for the ansible package. Default is:"},{"line_number":47,"context_line":"# \u0027ansible\u003e\u003d4,\u003c6.0\u0027. NOTE: This limits the version of ansible used by"},{"line_number":48,"context_line":"# kolla-ansible to avoid new releases from breaking tested code. Changes to"},{"line_number":49,"context_line":"# this limit should be tested."},{"line_number":50,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d4,\u003c6.0\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Path to Kolla-ansible configuration directory."},{"line_number":53,"context_line":"kolla_config_path: \"{{ lookup(\u0027env\u0027, \u0027KOLLA_CONFIG_PATH\u0027) | default(\u0027/etc/kolla\u0027, true) }}\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"b8856f56_23544b93","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":45},"updated":"2022-03-30 08:29:12.000000000","message":"Maybe move this to the role defaults, and the tests should pass. It should be quite rare that it needs to be changed.\n\nIn that case, you could remove the default from the comment - one less thing to keep in sync.","commit_id":"2c4f330b80146c8f0b463e8e997851b0354fada5"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3cf6e8024324b67f1f6847699eff81902d5da619","unresolved":false,"context_lines":[{"line_number":43,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":44,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Pip requirement specifier for the ansible package. Default is:"},{"line_number":47,"context_line":"# \u0027ansible\u003e\u003d4,\u003c6.0\u0027. NOTE: This limits the version of ansible used by"},{"line_number":48,"context_line":"# kolla-ansible to avoid new releases from breaking tested code. Changes to"},{"line_number":49,"context_line":"# this limit should be tested."},{"line_number":50,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d4,\u003c6.0\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Path to Kolla-ansible configuration directory."},{"line_number":53,"context_line":"kolla_config_path: \"{{ lookup(\u0027env\u0027, \u0027KOLLA_CONFIG_PATH\u0027) | default(\u0027/etc/kolla\u0027, true) }}\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"e390da47_7822cc8a","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":45},"in_reply_to":"1f604d66_e2c24a9a","updated":"2022-04-07 08:15:11.000000000","message":"As long as we are careful not to remove it when we compare etc/kayobe/kolla.yml with ansible/group_vars/all/kolla.","commit_id":"2c4f330b80146c8f0b463e8e997851b0354fada5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"168044234a74a5b9a2502f4e986648e9b9f5c2ea","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":44,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Pip requirement specifier for the ansible package. Default is:"},{"line_number":47,"context_line":"# \u0027ansible\u003e\u003d4,\u003c6.0\u0027. NOTE: This limits the version of ansible used by"},{"line_number":48,"context_line":"# kolla-ansible to avoid new releases from breaking tested code. Changes to"},{"line_number":49,"context_line":"# this limit should be tested."},{"line_number":50,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d4,\u003c6.0\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Path to Kolla-ansible configuration directory."},{"line_number":53,"context_line":"kolla_config_path: \"{{ lookup(\u0027env\u0027, \u0027KOLLA_CONFIG_PATH\u0027) | default(\u0027/etc/kolla\u0027, true) }}\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"eaaf4d3f_53cce239","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":45},"in_reply_to":"b8856f56_23544b93","updated":"2022-03-30 14:37:43.000000000","message":"Thanks, good suggestions.","commit_id":"2c4f330b80146c8f0b463e8e997851b0354fada5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4ab47bd39ff22a1a5c72854e7c10f7200958ad21","unresolved":true,"context_lines":[{"line_number":43,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":44,"context_line":"kolla_ansible_venv_extra_requirements: []"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Pip requirement specifier for the ansible package. Default is:"},{"line_number":47,"context_line":"# \u0027ansible\u003e\u003d4,\u003c6.0\u0027. NOTE: This limits the version of ansible used by"},{"line_number":48,"context_line":"# kolla-ansible to avoid new releases from breaking tested code. Changes to"},{"line_number":49,"context_line":"# this limit should be tested."},{"line_number":50,"context_line":"kolla_ansible_venv_ansible: \u0027ansible\u003e\u003d4,\u003c6.0\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Path to Kolla-ansible configuration directory."},{"line_number":53,"context_line":"kolla_config_path: \"{{ lookup(\u0027env\u0027, \u0027KOLLA_CONFIG_PATH\u0027) | default(\u0027/etc/kolla\u0027, true) }}\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1f604d66_e2c24a9a","line":50,"range":{"start_line":46,"start_character":0,"end_line":50,"end_character":45},"in_reply_to":"eaaf4d3f_53cce239","updated":"2022-04-06 15:45:10.000000000","message":"@Pierre, see this thread","commit_id":"2c4f330b80146c8f0b463e8e997851b0354fada5"}],"etc/kayobe/kolla.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5b957038ef57c32ea479072ac405313b25043f80","unresolved":true,"context_lines":[{"line_number":50,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":51,"context_line":"#kolla_ansible_venv_extra_requirements:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":54,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":55,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":56,"context_line":"#kolla_ansible_venv_ansible:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Path to Kolla-ansible configuration directory. Default is $KOLLA_CONFIG_PATH"},{"line_number":59,"context_line":"# or /etc/kolla if $KOLLA_CONFIG_PATH is not set."},{"line_number":60,"context_line":"#kolla_config_path:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"314a02c6_7225996a","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":0},"updated":"2022-03-30 14:41:16.000000000","message":"Do we want it here if it\u0027s not in group_vars?","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"f6f393a16cb9ccf371d973594cc1b87b779d6dd8","unresolved":true,"context_lines":[{"line_number":50,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":51,"context_line":"#kolla_ansible_venv_extra_requirements:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":54,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":55,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":56,"context_line":"#kolla_ansible_venv_ansible:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Path to Kolla-ansible configuration directory. Default is $KOLLA_CONFIG_PATH"},{"line_number":59,"context_line":"# or /etc/kolla if $KOLLA_CONFIG_PATH is not set."},{"line_number":60,"context_line":"#kolla_config_path:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bb440df1_460d0c6b","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"314a02c6_7225996a","updated":"2022-03-30 14:49:14.000000000","message":"I was thinking that kind of officially exposes it. Can remove if you prefer.","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"61c8064e663f694d3e320ea6a794c9846aba4d13","unresolved":true,"context_lines":[{"line_number":50,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":51,"context_line":"#kolla_ansible_venv_extra_requirements:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":54,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":55,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":56,"context_line":"#kolla_ansible_venv_ansible:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Path to Kolla-ansible configuration directory. Default is $KOLLA_CONFIG_PATH"},{"line_number":59,"context_line":"# or /etc/kolla if $KOLLA_CONFIG_PATH is not set."},{"line_number":60,"context_line":"#kolla_config_path:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d19b93bd_7c232df8","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"497ae39c_9050f6ed","updated":"2022-04-06 09:54:25.000000000","message":"Except for the list of feature flags which is automatically generated, all the variables in etc/kayobe/kolla.yml appear in ansible/group_vars/all/kolla (unless I\u0027ve missed one). It makes it easy to keep them synchronised, including their comments. Could we keep the same pattern?","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1f335488fc6c5fed921619c080d360ac16974fa3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":51,"context_line":"#kolla_ansible_venv_extra_requirements:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":54,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":55,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":56,"context_line":"#kolla_ansible_venv_ansible:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Path to Kolla-ansible configuration directory. Default is $KOLLA_CONFIG_PATH"},{"line_number":59,"context_line":"# or /etc/kolla if $KOLLA_CONFIG_PATH is not set."},{"line_number":60,"context_line":"#kolla_config_path:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"497ae39c_9050f6ed","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"bb440df1_460d0c6b","updated":"2022-03-30 14:54:15.000000000","message":"As you wish","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3cf6e8024324b67f1f6847699eff81902d5da619","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# Extra requirements to install inside the kolla-ansible virtualenv."},{"line_number":51,"context_line":"#kolla_ansible_venv_extra_requirements:"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# Pip requirement specifier for the ansible package. NOTE: This limits the"},{"line_number":54,"context_line":"# version of ansible used by kolla-ansible to avoid new releases from breaking"},{"line_number":55,"context_line":"# tested code. Changes to this limit should be tested."},{"line_number":56,"context_line":"#kolla_ansible_venv_ansible:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Path to Kolla-ansible configuration directory. Default is $KOLLA_CONFIG_PATH"},{"line_number":59,"context_line":"# or /etc/kolla if $KOLLA_CONFIG_PATH is not set."},{"line_number":60,"context_line":"#kolla_config_path:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"45307242_5027ca18","line":57,"range":{"start_line":53,"start_character":0,"end_line":57,"end_character":0},"in_reply_to":"d19b93bd_7c232df8","updated":"2022-04-07 08:15:11.000000000","message":"Let\u0027s merge.","commit_id":"1375517d2b39ecbba539d05749cc01bf8d1114bf"}]}