)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bccdb029415e86534644cc240068336914260181","unresolved":true,"context_lines":[{"line_number":10,"context_line":"change in Ironic [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users may"},{"line_number":14,"context_line":"revert to using PXE for ironic inspector\u0027s dnsmasq, by setting"},{"line_number":15,"context_line":"ironic_dnsmasq_serve_ipxe to true in etc/kayobe/kolla/globals.yml."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"73c58dfd_c67cbc2c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":74},"updated":"2022-04-08 09:38:17.000000000","message":"Nit while here, line is too long.","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4b62de87e9193a652d509fac675ecb1800ecd4b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"change in Ironic [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users may"},{"line_number":14,"context_line":"revert to using PXE for ironic inspector\u0027s dnsmasq, by setting"},{"line_number":15,"context_line":"ironic_dnsmasq_serve_ipxe to true in etc/kayobe/kolla/globals.yml."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"48e9b51d_fb9d0b5b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":74},"in_reply_to":"73c58dfd_c67cbc2c","updated":"2022-04-08 10:02:12.000000000","message":"Done","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bccdb029415e86534644cc240068336914260181","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users may"},{"line_number":14,"context_line":"revert to using PXE for ironic inspector\u0027s dnsmasq, by setting"},{"line_number":15,"context_line":"ironic_dnsmasq_serve_ipxe to true in etc/kayobe/kolla/globals.yml."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/c/openstack/ironic/+/816824"},{"line_number":18,"context_line":"[2] https://review.opendev.org/c/openstack/kolla-ansible/+/834512/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"af6749a7_61f731f1","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":33},"updated":"2022-04-08 09:38:17.000000000","message":"Shouldn\u0027t this be false?","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b4b62de87e9193a652d509fac675ecb1800ecd4b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users may"},{"line_number":14,"context_line":"revert to using PXE for ironic inspector\u0027s dnsmasq, by setting"},{"line_number":15,"context_line":"ironic_dnsmasq_serve_ipxe to true in etc/kayobe/kolla/globals.yml."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/c/openstack/ironic/+/816824"},{"line_number":18,"context_line":"[2] https://review.opendev.org/c/openstack/kolla-ansible/+/834512/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"332baf03_b551daec","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":33},"in_reply_to":"af6749a7_61f731f1","updated":"2022-04-08 10:02:12.000000000","message":"Done","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"583144da6ddfa82a026242e4c994eba4679896b8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mark Goddard \u003cmark@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-08 10:01:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ironic: default to ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable the Ironic ipxe boot interface by default, following a similar"},{"line_number":10,"context_line":"change in Ironic [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3b35234f_57bf8aab","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":21},"updated":"2022-04-08 10:05:56.000000000","message":"To be fair, this change only does the things described below. The default is not set in this change.","commit_id":"d1f39c5158395c9ec688f8f7ef718ccb88816d14"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2606d12bd740bdd4ea7922a58d06621f6ce56db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mark Goddard \u003cmark@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-08 10:01:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ironic: default to ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable the Ironic ipxe boot interface by default, following a similar"},{"line_number":10,"context_line":"change in Ironic [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"14f32636_6c555003","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"16f56651_2a43d117","updated":"2022-04-08 15:12:51.000000000","message":"Done","commit_id":"d1f39c5158395c9ec688f8f7ef718ccb88816d14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bd5372c3125aaa52f58a70dbcd5b62928a2d9572","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Mark Goddard \u003cmark@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-08 10:01:36 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ironic: default to ipxe booting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable the Ironic ipxe boot interface by default, following a similar"},{"line_number":10,"context_line":"change in Ironic [1]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Drop the kolla_enable_ironic_ipxe flag, following a similar change in"},{"line_number":13,"context_line":"Kolla Ansible [2]. Both PXE and iPXE are now enabled by default. Users"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"16f56651_2a43d117","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"3b35234f_57bf8aab","updated":"2022-04-08 15:07:39.000000000","message":"You make a good point.","commit_id":"d1f39c5158395c9ec688f8f7ef718ccb88816d14"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab0fd93e35a04ec25e2e5b8014eca7d5cad95c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d70a7764_19268c35","updated":"2022-04-07 15:57:58.000000000","message":"some unrelated failure:\n\n2022-04-07 13:59:56.804 7 ERROR futurist.periodics ironic.common.exception.InterfaceNotFoundInEntrypoint: Could not find the following interface in the \u0027ironic.hardware.interfaces.inspect\u0027 entrypoint: inspector. Valid interfaces are [\u0027no-inspect\u0027, \u0027redfish\u0027].\n","commit_id":"44d23a522687ec8b0698d893dcdf8ab5975bf440"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2ee8e711fa177f2070dd955aeb54a5ea573a7b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dc788909_9bb38210","updated":"2022-04-07 19:05:46.000000000","message":"it\u0027s green 😮","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"10e495ddb4aceb04e41059a8e4c9fbcbeece2d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"af9d7dab_b1831ce2","updated":"2022-04-07 19:06:01.000000000","message":"time to merge those changes and backport","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dfeafde3c7cac613deb2b6ce5b01fad6b10dc61c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c156f57e_2c75b045","updated":"2022-04-11 09:21:08.000000000","message":"erm, what?","commit_id":"389f1c39137edb6887f361d742adb4909a8e1476"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6dcf6ef8038ff48beeba932d48b56a932d4cac9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"387ca4e8_bcfb774a","updated":"2022-04-12 09:57:06.000000000","message":"recheck","commit_id":"389f1c39137edb6887f361d742adb4909a8e1476"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e424ade30749947213e5f3ac14b291a9a69f1a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22f9b254_862a103d","in_reply_to":"c156f57e_2c75b045","updated":"2022-04-11 09:33:44.000000000","message":"http://lists.openstack.org/pipermail/openstack-discuss/2022-April/028035.html","commit_id":"389f1c39137edb6887f361d742adb4909a8e1476"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"95cd3f422931e914791137c7d475237d1cb6d6be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"24f50839_5e55cdb6","updated":"2022-04-12 11:56:50.000000000","message":"Since we\u0027re now using kolla-ansible stable/yoga, we need the change to land on that branch (https://review.opendev.org/c/openstack/kolla-ansible/+/832134/)","commit_id":"a02c4e9708443da63f17cb30867fbb8bf92d51a3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"85df6f120733dccba7c144b548ef8606ea69f9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e3ca517_ecf0b42b","in_reply_to":"24f50839_5e55cdb6","updated":"2022-04-12 11:57:35.000000000","message":"Or rather, https://review.opendev.org/c/openstack/kolla-ansible/+/837069","commit_id":"a02c4e9708443da63f17cb30867fbb8bf92d51a3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e43178fd1c3c6174e75001ac588291c938a35eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c8b877ec_9a88403d","updated":"2022-04-13 20:08:32.000000000","message":"recheck","commit_id":"05c09523fa8b67778fbde56c7c1190796ff5688f"}],"ansible/roles/kolla-ansible/templates/overcloud-services.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bccdb029415e86534644cc240068336914260181","unresolved":true,"context_lines":[{"line_number":251,"context_line":"{{ groups[\u0027controllers\u0027][0] }}"},{"line_number":252,"context_line":"{% endif %}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"[ironic-tftp:children]"},{"line_number":255,"context_line":"ironic"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"[ironic-http:children]"},{"line_number":258,"context_line":"ironic"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"# Magnum"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"2a869e94_be0c66d4","line":257,"range":{"start_line":254,"start_character":0,"end_line":257,"end_character":22},"updated":"2022-04-08 09:38:17.000000000","message":"I left a comment about the order in https://review.opendev.org/c/openstack/kolla-ansible/+/832134","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"76ffbe8aaf1fc9ba727d435293920ef9c20e378f","unresolved":false,"context_lines":[{"line_number":251,"context_line":"{{ groups[\u0027controllers\u0027][0] }}"},{"line_number":252,"context_line":"{% endif %}"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"[ironic-tftp:children]"},{"line_number":255,"context_line":"ironic"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"[ironic-http:children]"},{"line_number":258,"context_line":"ironic"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"# Magnum"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"77b188ce_84fe9b55","line":257,"range":{"start_line":254,"start_character":0,"end_line":257,"end_character":22},"in_reply_to":"2a869e94_be0c66d4","updated":"2022-04-08 09:55:04.000000000","message":"Ignore this comment.","commit_id":"b17fa4b91f0039fb3824edd1fbf3b310b0ec3ac4"}]}