)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6fd8a076_c1824ff4","updated":"2022-06-09 19:41:09.000000000","message":"Thanks Mark. Sorry for the lag in reviewing, unfortunately it needs an update again.","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"588e82abaca3bd9bb783e59b144ab3ce5a0046b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3749fcb4_48bfacc8","updated":"2023-11-08 14:50:20.000000000","message":"Sorry, missed this first time around, but looks pretty useful. We now have a merge conflict. Any chance of refreshing?","commit_id":"f3ad86517e2232a0f27e6d6747902742648bac9b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"12f2855905aebd67b1994ca2d3da32920ab89f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b50313b6_5efa6130","updated":"2024-09-18 13:20:08.000000000","message":"Thanks!","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a35e9b5d61c9d0eb7d916a6347e5ec1c9677e0dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3d32b840_a2bd2d5f","updated":"2024-08-21 11:35:17.000000000","message":"recheck\n\nCI fixed","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1ead1067d9907380e5952bb8c904507cffce9be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6aaebf1b_ed46a0cd","updated":"2024-08-22 08:43:43.000000000","message":"recheck\n\nnetwork blip","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"}],"playbooks/kayobe-overcloud-upgrade-base/overrides.yml.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"fc4745a2f6f820b78a9056aff275613ae9ec0ccc","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# Enable ironic for testing baremetal compute."},{"line_number":42,"context_line":"kolla_enable_ironic: true"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# TODO(mgoddard): Remove when previous release is Zed."},{"line_number":45,"context_line":"# In Zed we switched to the upstream ironic defaults for hardware"},{"line_number":46,"context_line":"# interfaces, which does not enable the following interfaces."},{"line_number":47,"context_line":"{% if not is_previous_release | default(false) %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"37c89898_640a89a2","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":54},"updated":"2022-06-13 11:05:44.000000000","message":"Should this explicitly say that we need to remove the if/endif statements, but no what is inside?\n\nWe need to keep this configuration as long as inspector is not included by default in Ironic, right?","commit_id":"f3ad86517e2232a0f27e6d6747902742648bac9b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"986bbd87bffcb989b14266dbc54f3a18cd464db3","unresolved":true,"context_lines":[{"line_number":41,"context_line":"# Enable ironic for testing baremetal compute."},{"line_number":42,"context_line":"kolla_enable_ironic: true"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# TODO(mgoddard): Remove when previous release is Zed."},{"line_number":45,"context_line":"# In Zed we switched to the upstream ironic defaults for hardware"},{"line_number":46,"context_line":"# interfaces, which does not enable the following interfaces."},{"line_number":47,"context_line":"{% if not is_previous_release | default(false) %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"a79385d0_4b80e873","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":54},"in_reply_to":"37c89898_640a89a2","updated":"2022-06-14 08:53:12.000000000","message":"We can remove the whole block when previous release is Zed, since the enabled drivers will not change during the upgrade.","commit_id":"f3ad86517e2232a0f27e6d6747902742648bac9b"}],"playbooks/kayobe-overcloud-upgrade-base/run.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            chdir: \"{{ kayobe_src_dir }}\""},{"line_number":111,"context_line":"            executable: /bin/bash"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2a4d8f2a_dc5972d8","line":113,"range":{"start_line":113,"start_character":58,"end_line":113,"end_character":62},"updated":"2022-06-09 19:41:09.000000000","message":"Zed","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            chdir: \"{{ kayobe_src_dir }}\""},{"line_number":111,"context_line":"            executable: /bin/bash"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fcdd551f_77973492","line":113,"range":{"start_line":113,"start_character":58,"end_line":113,"end_character":62},"in_reply_to":"2a4d8f2a_dc5972d8","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            executable: /bin/bash"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ed40364_90a92287","line":114,"range":{"start_line":114,"start_character":13,"end_line":114,"end_character":17},"updated":"2022-06-09 19:41:09.000000000","message":"Zed","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            executable: /bin/bash"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0cfbf397_cb127764","line":114,"range":{"start_line":114,"start_character":13,"end_line":114,"end_character":17},"in_reply_to":"8ed40364_90a92287","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"},{"line_number":118,"context_line":"            cmd: \u003e"},{"line_number":119,"context_line":"              source ~/tenks-venv/bin/activate \u0026\u0026"},{"line_number":120,"context_line":"              source {{ kayobe_config_src_dir }}/etc/kolla/public-openrc.sh \u0026\u0026"},{"line_number":121,"context_line":"              openstack baremetal node set {{ item }}"},{"line_number":122,"context_line":"              --console-interface no-console --inspect-interface no-inspect"},{"line_number":123,"context_line":"          loop:"},{"line_number":124,"context_line":"            - tk0"},{"line_number":125,"context_line":"            - tk1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"711c7d56_1aaaf809","line":122,"range":{"start_line":116,"start_character":0,"end_line":122,"end_character":75},"updated":"2022-06-09 19:41:09.000000000","message":"Why not set via configuration instead?","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"},{"line_number":118,"context_line":"            cmd: \u003e"},{"line_number":119,"context_line":"              source ~/tenks-venv/bin/activate \u0026\u0026"},{"line_number":120,"context_line":"              source {{ kayobe_config_src_dir }}/etc/kolla/public-openrc.sh \u0026\u0026"},{"line_number":121,"context_line":"              openstack baremetal node set {{ item }}"},{"line_number":122,"context_line":"              --console-interface no-console --inspect-interface no-inspect"},{"line_number":123,"context_line":"          loop:"},{"line_number":124,"context_line":"            - tk0"},{"line_number":125,"context_line":"            - tk1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"798f4e65_703b9ae9","line":122,"range":{"start_line":116,"start_character":0,"end_line":122,"end_character":75},"in_reply_to":"711c7d56_1aaaf809","updated":"2022-06-10 09:50:27.000000000","message":"OpenStack or Tenks config? Tenks ran with the old driver defaults, so the nodes got created with those. They\u0027re now no longer valid, so we need to update them. We could override config to include the old ones, but this seems closer to what an operator might do?","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4776f9a973ed0a062c8950e4847a96057a1db8e0","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"},{"line_number":118,"context_line":"            cmd: \u003e"},{"line_number":119,"context_line":"              source ~/tenks-venv/bin/activate \u0026\u0026"},{"line_number":120,"context_line":"              source {{ kayobe_config_src_dir }}/etc/kolla/public-openrc.sh \u0026\u0026"},{"line_number":121,"context_line":"              openstack baremetal node set {{ item }}"},{"line_number":122,"context_line":"              --console-interface no-console --inspect-interface no-inspect"},{"line_number":123,"context_line":"          loop:"},{"line_number":124,"context_line":"            - tk0"},{"line_number":125,"context_line":"            - tk1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b22061ec_0cf01813","line":122,"range":{"start_line":116,"start_character":0,"end_line":122,"end_character":75},"in_reply_to":"798f4e65_703b9ae9","updated":"2022-06-10 10:09:53.000000000","message":"I would think an operator would update their ironic.yml, as per the release notes?","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c35b50394d70e7e7ee401a71b53cf1683a17de3f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        # TODO(mgoddard): Remove when previous release is Yoga."},{"line_number":114,"context_line":"        # In Yoga we switched to the upstream ironic defaults for hardware"},{"line_number":115,"context_line":"        # interfaces, which does not enable the inspector inspection interface."},{"line_number":116,"context_line":"        - name: Set inspection interface"},{"line_number":117,"context_line":"          shell:"},{"line_number":118,"context_line":"            cmd: \u003e"},{"line_number":119,"context_line":"              source ~/tenks-venv/bin/activate \u0026\u0026"},{"line_number":120,"context_line":"              source {{ kayobe_config_src_dir }}/etc/kolla/public-openrc.sh \u0026\u0026"},{"line_number":121,"context_line":"              openstack baremetal node set {{ item }}"},{"line_number":122,"context_line":"              --console-interface no-console --inspect-interface no-inspect"},{"line_number":123,"context_line":"          loop:"},{"line_number":124,"context_line":"            - tk0"},{"line_number":125,"context_line":"            - tk1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e9e12e45_f3b7afc3","line":122,"range":{"start_line":116,"start_character":0,"end_line":122,"end_character":75},"in_reply_to":"b22061ec_0cf01813","updated":"2022-06-13 08:55:25.000000000","message":"I suppose you are right.","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":125,"context_line":"            - tk1"},{"line_number":126,"context_line":"          when:"},{"line_number":127,"context_line":"            - ansible_os_family !\u003d \u0027Debian\u0027"},{"line_number":128,"context_line":"            - previous_release \u003d\u003d \u0027xena\u0027"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        - name: Perform testing of the baremetal machines in the upgraded overcloud"},{"line_number":131,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"00934b17_d0375f76","line":128,"range":{"start_line":128,"start_character":35,"end_line":128,"end_character":39},"updated":"2022-06-09 19:41:09.000000000","message":"yoga","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            - tk1"},{"line_number":126,"context_line":"          when:"},{"line_number":127,"context_line":"            - ansible_os_family !\u003d \u0027Debian\u0027"},{"line_number":128,"context_line":"            - previous_release \u003d\u003d \u0027xena\u0027"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        - name: Perform testing of the baremetal machines in the upgraded overcloud"},{"line_number":131,"context_line":"          shell:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d25fbe4d_a910c23d","line":128,"range":{"start_line":128,"start_character":35,"end_line":128,"end_character":39},"in_reply_to":"00934b17_d0375f76","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"}],"releasenotes/notes/ironic-default-drivers-7a27baa7a301922c.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kayobe no longer overrides the enabled and default Ironic hardware types"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"517a29e3_eb229f50","line":1,"updated":"2022-06-09 19:41:09.000000000","message":"Maybe we should highlight the removal of the neutron enabled_network_interfaces, in particular?","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kayobe no longer overrides the enabled and default Ironic hardware types"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"467bb831_4db18670","line":1,"in_reply_to":"517a29e3_eb229f50","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Kayobe no longer overrides the enabled and default Ironic hardware types"},{"line_number":5,"context_line":"    and interfaces. This ensures that changes to the default values in Ironic"},{"line_number":6,"context_line":"    are automatically adopted. These may still be customised via the existing"},{"line_number":7,"context_line":"    Kayobe variables in ``etc/kayobe/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Xena was:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8964d42d_48ed3c48","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":36},"updated":"2022-06-09 19:41:09.000000000","message":"${KAYOBE_CONFIG_PATH}","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Kayobe no longer overrides the enabled and default Ironic hardware types"},{"line_number":5,"context_line":"    and interfaces. This ensures that changes to the default values in Ironic"},{"line_number":6,"context_line":"    are automatically adopted. These may still be customised via the existing"},{"line_number":7,"context_line":"    Kayobe variables in ``etc/kayobe/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Xena was:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fc1f792_e3804bf4","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":36},"in_reply_to":"8964d42d_48ed3c48","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Kayobe variables in ``etc/kayobe/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Xena was:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. code-block:: ini"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e3da7e35_f91d0356","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":57},"updated":"2022-06-09 19:41:09.000000000","message":"Yoga","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Kayobe variables in ``etc/kayobe/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Xena was:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. code-block:: ini"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"065b5237_b7f15e29","line":10,"range":{"start_line":10,"start_character":53,"end_line":10,"end_character":57},"in_reply_to":"e3da7e35_f91d0356","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"       enabled_hardware_types \u003d ipmi"},{"line_number":15,"context_line":"       enabled_bios_interfaces \u003d no-bios"},{"line_number":16,"context_line":"       enabled_boot_interfaces \u003d pxe"},{"line_number":17,"context_line":"       enabled_console_interfaces \u003d ipmitool-socat,no-console"},{"line_number":18,"context_line":"       enabled_inspect_interfaces \u003d inspector,no-inspect"},{"line_number":19,"context_line":"       enabled_management_interfaces \u003d ipmitool"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"90acd11d_1f8d3882","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":36},"updated":"2022-06-09 19:41:09.000000000","message":"ipxe,pxe","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"       enabled_hardware_types \u003d ipmi"},{"line_number":15,"context_line":"       enabled_bios_interfaces \u003d no-bios"},{"line_number":16,"context_line":"       enabled_boot_interfaces \u003d pxe"},{"line_number":17,"context_line":"       enabled_console_interfaces \u003d ipmitool-socat,no-console"},{"line_number":18,"context_line":"       enabled_inspect_interfaces \u003d inspector,no-inspect"},{"line_number":19,"context_line":"       enabled_management_interfaces \u003d ipmitool"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ab4d2a5b_f782e376","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":36},"in_reply_to":"90acd11d_1f8d3882","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":17,"context_line":"       enabled_console_interfaces \u003d ipmitool-socat,no-console"},{"line_number":18,"context_line":"       enabled_inspect_interfaces \u003d inspector,no-inspect"},{"line_number":19,"context_line":"       enabled_management_interfaces \u003d ipmitool"},{"line_number":20,"context_line":"       enabled_network_interfaces \u003d noop,flat,neutron"},{"line_number":21,"context_line":"       enabled_power_interfaces \u003d ipmitool"},{"line_number":22,"context_line":"       enabled_raid_interfaces \u003d agent,no-raid"},{"line_number":23,"context_line":"       enabled_rescue_interfaces \u003d agent,no-rescue"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"32aefb32_708be475","line":20,"range":{"start_line":20,"start_character":46,"end_line":20,"end_character":53},"updated":"2022-06-09 19:41:09.000000000","message":"Maybe we should highlight the removal of neutron from enabled_network_interfaces in particular?","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"       enabled_console_interfaces \u003d ipmitool-socat,no-console"},{"line_number":18,"context_line":"       enabled_inspect_interfaces \u003d inspector,no-inspect"},{"line_number":19,"context_line":"       enabled_management_interfaces \u003d ipmitool"},{"line_number":20,"context_line":"       enabled_network_interfaces \u003d noop,flat,neutron"},{"line_number":21,"context_line":"       enabled_power_interfaces \u003d ipmitool"},{"line_number":22,"context_line":"       enabled_raid_interfaces \u003d agent,no-raid"},{"line_number":23,"context_line":"       enabled_rescue_interfaces \u003d agent,no-rescue"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"132ade7f_8e9e94c2","line":20,"range":{"start_line":20,"start_character":46,"end_line":20,"end_character":53},"in_reply_to":"32aefb32_708be475","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b8e43e78f37e0eef3429c83c4d20c39f46bb8f55","unresolved":true,"context_lines":[{"line_number":23,"context_line":"       enabled_rescue_interfaces \u003d agent,no-rescue"},{"line_number":24,"context_line":"       enabled_vendor_interfaces \u003d no-vendor"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    In Yoga, Ironic defaults are:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    .. code-block:: ini"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ce8814d0_9a27096e","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":11},"updated":"2022-06-09 19:41:09.000000000","message":"Zed","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c52617bdb2ca28ca351f345b0a9c42fdca290b2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"       enabled_rescue_interfaces \u003d agent,no-rescue"},{"line_number":24,"context_line":"       enabled_vendor_interfaces \u003d no-vendor"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    In Yoga, Ironic defaults are:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    .. code-block:: ini"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a653e6d7_adbb9163","line":26,"range":{"start_line":26,"start_character":7,"end_line":26,"end_character":11},"in_reply_to":"ce8814d0_9a27096e","updated":"2022-06-10 09:50:27.000000000","message":"Done","commit_id":"dc3db1f4e13f35f4ccfa585e5724e2713d114630"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3fb026372fcadcaf5fb3f916677a982496fdeee3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Kayobe variables in ``${KAYOBE_CONFIG_PATH}/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Caracal was:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. code-block:: ini"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cab9e878_3c1faf22","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":65},"updated":"2024-08-22 10:52:37.000000000","message":"maybe it would be good also provide defaults before Caracal for users to upgrade to Caracal?","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bb795309096c69977bbcc336bc392d82402ed8ee","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    Kayobe variables in ``${KAYOBE_CONFIG_PATH}/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Caracal was:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. code-block:: ini"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d7517572_3b0ebd3b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":65},"in_reply_to":"87e9d2f4_d41f98c4","updated":"2024-08-22 14:31:25.000000000","message":"No, current release is not the release used in production. For now we have Xena, Yoga, and Zed all of them needed to upgrade asap. So I\u0027m asking for real life situation ;)","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"470c25b6b6078fbcbabd7c2953515edf3386153d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Kayobe variables in ``${KAYOBE_CONFIG_PATH}/ironic.yml``, e.g."},{"line_number":8,"context_line":"    ``kolla_ironic_enabled_hardware_types``."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    The default configuration generated by Kayobe in Caracal was:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. code-block:: ini"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"87e9d2f4_d41f98c4","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":65},"in_reply_to":"cab9e878_3c1faf22","updated":"2024-08-22 11:08:09.000000000","message":"The current release is dalmatian, so I think this does what you\u0027re asking for.","commit_id":"64272cf1f139fe343fee45a0f51e11a1d6df90bd"}]}