)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d3afca877f6a2f79ceeac65122f3bf63e307c539","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes an issue where generation of passwords.yml for Kolla Ansible"},{"line_number":10,"context_line":"could fail if the directory containing the file does not exist. This is"},{"line_number":11,"context_line":"typical in a multiple environment setup, when creating a new environment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TrivialFix"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f1f1eff9_bca6a35f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"updated":"2022-08-29 13:36:12.000000000","message":"Nit: line too long","commit_id":"9a7cddd272b721bbfd72dea471d06eef3f86f0c6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e6233e4269e73529ef87c14fc05739d9b789489e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes an issue where generation of passwords.yml for Kolla Ansible"},{"line_number":10,"context_line":"could fail if the directory containing the file does not exist. This is"},{"line_number":11,"context_line":"typical in a multiple environment setup, when creating a new environment."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"TrivialFix"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c4e3685_d01fbec6","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":73},"in_reply_to":"f1f1eff9_bca6a35f","updated":"2022-09-13 08:58:14.000000000","message":"Done","commit_id":"9a7cddd272b721bbfd72dea471d06eef3f86f0c6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d3afca877f6a2f79ceeac65122f3bf63e307c539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bea20841_f50800aa","updated":"2022-08-29 13:36:12.000000000","message":"Maybe register story and task?","commit_id":"9a7cddd272b721bbfd72dea471d06eef3f86f0c6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9c23b94350ef97b1def562b1f520bb95c2357f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1ecb75f_37efa224","updated":"2022-10-13 19:28:15.000000000","message":"How is it looking @pierre?","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"},{"author":{"_account_id":29543,"name":"Scott Solkhon","email":"scott.solkhon@gresearch.co.uk","username":"scott.solkhon"},"change_message_id":"06aff02aa512dd3d28ea8f7d68edc1203766c228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70674c75_af12eeae","updated":"2022-09-16 08:31:51.000000000","message":"Tested using `kayobe playbook run ansible/kolla-ansible.yml` with a new environment and works as expected.","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8c2fc0fe0bb232d253c2094f7b1d84c0d09e0b1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfde7f31_ce855c41","updated":"2022-09-15 08:31:43.000000000","message":"recheck","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aba31c6c225552810c23e357cb94ce25404d18e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b719bca8_217b1cdf","updated":"2023-04-14 05:40:34.000000000","message":"Merging since the change was only to add LP bug id and accounting for earlier Pierre\u0027s +2.","commit_id":"5287083116da2512b887529e67af4c4919e1e296"}],"ansible/roles/kolla-ansible/library/kolla_passwords.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d3afca877f6a2f79ceeac65122f3bf63e307c539","unresolved":true,"context_lines":[{"line_number":156,"context_line":"            changed \u003d checksum_dest !\u003d checksum_temp_file"},{"line_number":157,"context_line":"        else:"},{"line_number":158,"context_line":"            os.makedirs(os.path.dirname(module.params[\u0027dest\u0027]),"},{"line_number":159,"context_line":"                        mode\u003d0o700, exist_ok\u003dTrue)"},{"line_number":160,"context_line":"            changed \u003d True"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # Encrypt the file."}],"source_content_type":"text/x-python","patch_set":1,"id":"3acc959a_6d8f9dec","line":159,"range":{"start_line":159,"start_character":24,"end_line":159,"end_character":34},"updated":"2022-08-29 13:36:12.000000000","message":"Did you pick this non-default value for security reasons? Since our sample kayobe-config uses the same permissions for etc/kayobe/kolla as for other directories, this would make this environment kolla folder special.\n\nIt\u0027s also not very useful unless we also make etc/kolla secure.","commit_id":"9a7cddd272b721bbfd72dea471d06eef3f86f0c6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e6233e4269e73529ef87c14fc05739d9b789489e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            changed \u003d checksum_dest !\u003d checksum_temp_file"},{"line_number":157,"context_line":"        else:"},{"line_number":158,"context_line":"            os.makedirs(os.path.dirname(module.params[\u0027dest\u0027]),"},{"line_number":159,"context_line":"                        mode\u003d0o700, exist_ok\u003dTrue)"},{"line_number":160,"context_line":"            changed \u003d True"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # Encrypt the file."}],"source_content_type":"text/x-python","patch_set":1,"id":"f0cd550d_e29a088a","line":159,"range":{"start_line":159,"start_character":24,"end_line":159,"end_character":34},"in_reply_to":"3acc959a_6d8f9dec","updated":"2022-09-13 08:58:14.000000000","message":"Done","commit_id":"9a7cddd272b721bbfd72dea471d06eef3f86f0c6"},{"author":{"_account_id":29543,"name":"Scott Solkhon","email":"scott.solkhon@gresearch.co.uk","username":"scott.solkhon"},"change_message_id":"06aff02aa512dd3d28ea8f7d68edc1203766c228","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from ansible.module_utils.basic import *"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import os.path"},{"line_number":27,"context_line":"import shutil"},{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"41775c17_f10463bb","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"updated":"2022-09-16 08:31:51.000000000","message":"nit: It would be cleaner to remove this in favour of `import os` in the line above.","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"471dd73a833f526a73c51d7c4e7f21886f2dda6c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ansible.module_utils.basic import *"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import os.path"},{"line_number":27,"context_line":"import shutil"},{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff5ff73_f4d9b635","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"in_reply_to":"41775c17_f10463bb","updated":"2022-09-20 08:47:33.000000000","message":"os.path is required - it\u0027s a module","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"804dc4059894b32f2d4bbd688721bf89cea9b8b9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from ansible.module_utils.basic import *"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import os"},{"line_number":26,"context_line":"import os.path"},{"line_number":27,"context_line":"import shutil"},{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a195c4a8_350ea2c8","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":14},"in_reply_to":"5ff5ff73_f4d9b635","updated":"2022-10-13 20:04:05.000000000","message":"It seems to work without the more specific import. Code is fine as it is, I am just curious about Python behaviour here.\n\n\u003e\u003e\u003e import os \n\u003e\u003e\u003e os.path.dirname(\u0027/foo/bar\u0027)\n\u0027/foo\u0027","commit_id":"8289a3f3a926d21d556b3a1eb73c5618d9787a48"}]}