)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":9,"context_line":"CentOS Stream 8 support has been dropped. Migration path will be"},{"line_number":10,"context_line":"present in Yoga release - as a followup change."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"michaelrigart/ansible-role-interfaces does not support custom"},{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"52857ddd_225dcc5e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":37},"updated":"2022-12-12 17:28:09.000000000","message":"MichaelRigart.interfaces","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":9,"context_line":"CentOS Stream 8 support has been dropped. Migration path will be"},{"line_number":10,"context_line":"present in Yoga release - as a followup change."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"michaelrigart/ansible-role-interfaces does not support custom"},{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"6123fe61_3ecdff94","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":37},"in_reply_to":"52857ddd_225dcc5e","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"non-voting Centos Stream 9 CI overcloud job is using RL9 container"},{"line_number":17,"context_line":"images (as kolla CI is not building CS9 images anymore)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf5ee822b03ba40179803c981500a6bad37594bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"9713a147_445dcf1d","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":17},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"non-voting Centos Stream 9 CI overcloud job is using RL9 container"},{"line_number":17,"context_line":"images (as kolla CI is not building CS9 images anymore)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf5ee822b03ba40179803c981500a6bad37594bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"194a2269_007b41bd","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":3},"updated":"2022-12-12 17:28:09.000000000","message":"Non","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"non-voting Centos Stream 9 CI overcloud job is using RL9 container"},{"line_number":17,"context_line":"images (as kolla CI is not building CS9 images anymore)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf5ee822b03ba40179803c981500a6bad37594bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"d011fe6d_6aa54fc1","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":3},"in_reply_to":"194a2269_007b41bd","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":13,"context_line":"routes for Network Manager yet. It has been disabled in CI for"},{"line_number":14,"context_line":"Rocky Linux 9 temporarily."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"non-voting Centos Stream 9 CI overcloud job is using RL9 container"},{"line_number":17,"context_line":"images (as kolla CI is not building CS9 images anymore)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf5ee822b03ba40179803c981500a6bad37594bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":75,"id":"c1ebafd4_081e8d0d","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":17},"in_reply_to":"9713a147_445dcf1d","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"d2c5f35c317eaa13e6966bb0829d84fd60dc041d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"433b5f50_f96f29ab","updated":"2022-09-02 19:14:10.000000000","message":"recheck (MichaelRigart.interfaces v1.13.2 pushed to galaxy)","commit_id":"fdfc6eb33e1ec76d9789335e1ffbd1734c3d0e24"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"aecf76c16d04b98993fc3ee588bfa6b34bd92308","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"3dcbd7b7_f7cf6ac7","updated":"2022-09-29 10:57:58.000000000","message":"recheck (bumped interfaces role)","commit_id":"ac3261befe602e466df49f2040dfd75048fcbd40"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"811526e98b8e549d27f5596f2902c2494b55dba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"450dfcd9_bd5c1149","updated":"2022-09-29 11:49:14.000000000","message":"recheck (bumped interfaces role)","commit_id":"ac3261befe602e466df49f2040dfd75048fcbd40"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"3158ad3e129338427088a600d9526b5a7bd6aa68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"ac162309_cf59b0d5","updated":"2022-09-29 11:01:26.000000000","message":"recheck (bumped interfaces role)","commit_id":"ac3261befe602e466df49f2040dfd75048fcbd40"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"94402d8c8bc6a88f3c7a3064098c878ba36c56d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"0cbda375_e3088cd1","updated":"2022-10-06 10:32:27.000000000","message":"recheck (mirror registry retry)","commit_id":"40f0f3a4cc0b20b753a5bf1d0417b37dc95a0d2f"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"843d8b10_99a814f2","updated":"2022-10-19 09:31:32.000000000","message":"Looks promising","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"48a979f3307c6bce4dca36c5113377ca6e576b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"aaf45e59_da9c718f","updated":"2022-10-07 15:54:27.000000000","message":"This is looking good - I haven\u0027t finished looking through yet, but I can get an AIO deployment running locally under Rocky 9. I hit an issue with missing support for Rocky in Kolla, but I see that has merged now.","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c8e996113fd4d79da3d9021aa1278d2726e419b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"a5539461_c817ad23","updated":"2022-10-06 14:35:41.000000000","message":"recheck - quay.io outage","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3631b5c208b2ea99824f69f5ed7db9fbf6dec8ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"a41ba408_5f1c95c0","updated":"2022-10-24 07:36:48.000000000","message":"Are there any plans to split this patch down into smaller, more manageble ones?","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"864e1d4a5339423a8793e685d1d5598e8b5e23a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"54f2fd9a_85a26fce","updated":"2022-10-27 12:23:25.000000000","message":"recheck c9s job","commit_id":"010003dc6ff280e4734d7692c4c75938885bd6d9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"6fdb9b2bd316d649536a89044e445c13d259a445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"eb7055e2_82b049a9","updated":"2022-11-09 11:13:22.000000000","message":"recheck (interfaces role testing)","commit_id":"f074c5addd4934f14a2a4b02376f9a5baebe2a85"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5933e89c3cb8d6c0b503e287a0f5d996d8a1a9e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":60,"id":"913c6d97_9af41c38","updated":"2022-11-10 09:19:04.000000000","message":"recheck (ansible-role-interfaces update)","commit_id":"fe4f4b1406352dbac8a7b654f7a496bfa794cbd6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b6d7bfc6c3b9e46b5e490cef2c6d36bf42fa613d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"2e64085d_cdf64940","updated":"2022-11-28 08:02:21.000000000","message":"recheck - RL9.1 released","commit_id":"d9d040454090ce07971ccec730dc745faee72d5c"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"9c016cbb_cd25f064","updated":"2022-12-12 17:28:09.000000000","message":"Looking good. Most of the comments are nits or could be follow-ups, the one that really matters is in doc/source/configuration/reference/bifrost.rst.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":75,"id":"711d4082_8c2b4417","updated":"2022-12-12 18:49:40.000000000","message":"Thank you Pierre for review.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"25e51d83305ff60abc09e90be6548c332e420a54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"45a4254f_aca94d0d","updated":"2022-12-12 21:28:55.000000000","message":"I fixed indentation in zuul YAML and little nits at the same time.\n\nGreat work Bartosz, thanks!","commit_id":"2f447f65453ff278fd53e5bf7975a5a092378b97"}],"ansible/inventory/group_vars/all/infra-vms":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":47,"context_line":"# when os_distribution is \"rocky\","},{"line_number":48,"context_line":"# or"},{"line_number":49,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":50,"context_line":"# otherwise."},{"line_number":51,"context_line":"infra_vm_root_image: \u003e-"},{"line_number":52,"context_line":"  {%- if os_distribution \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"application/octet-stream","patch_set":75,"id":"3773980a_e657d617","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":110},"updated":"2022-12-12 17:28:09.000000000","message":"Let\u0027s use CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":47,"context_line":"# when os_distribution is \"rocky\","},{"line_number":48,"context_line":"# or"},{"line_number":49,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":50,"context_line":"# otherwise."},{"line_number":51,"context_line":"infra_vm_root_image: \u003e-"},{"line_number":52,"context_line":"  {%- if os_distribution \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"application/octet-stream","patch_set":75,"id":"affce43a_a8dce9bd","line":49,"range":{"start_line":49,"start_character":3,"end_line":49,"end_character":110},"in_reply_to":"3773980a_e657d617","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  {%- elif os_distribution \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":55,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":56,"context_line":"  {%- else -%}"},{"line_number":57,"context_line":"  https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2"},{"line_number":58,"context_line":"  {%- endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Capacity of the infra VM data volume."}],"source_content_type":"application/octet-stream","patch_set":75,"id":"c15f5a70_48dd6129","line":57,"range":{"start_line":57,"start_character":57,"end_line":57,"end_character":109},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  {%- elif os_distribution \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":55,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":56,"context_line":"  {%- else -%}"},{"line_number":57,"context_line":"  https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2"},{"line_number":58,"context_line":"  {%- endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Capacity of the infra VM data volume."}],"source_content_type":"application/octet-stream","patch_set":75,"id":"c94fa055_ec027541","line":57,"range":{"start_line":57,"start_character":57,"end_line":57,"end_character":109},"in_reply_to":"c15f5a70_48dd6129","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"ansible/inventory/group_vars/all/ipa":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dbf49a08086d41f9be0d3025e79c49456ba65c26","unresolved":true,"context_lines":[{"line_number":47,"context_line":"ipa_build_dib_env_default:"},{"line_number":48,"context_line":"  # TODO(mgoddard): Use {{ os_release }} here when we use os_distribution"},{"line_number":49,"context_line":"  # above."},{"line_number":50,"context_line":"  DIB_RELEASE: \"9-stream\""},{"line_number":51,"context_line":"  DIB_REPOLOCATION_ironic_python_agent: \"{{ ipa_build_source_url }}\""},{"line_number":52,"context_line":"  DIB_REPOREF_ironic_python_agent: \"{{ ipa_build_source_version }}\""},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":68,"id":"84174356_cfac0c78","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":25},"updated":"2022-12-12 12:57:58.000000000","message":"Is it final? Shouldn\u0027t we default to rocky?","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"31f12de456f97a044e8952e876fda2d6e7a437f8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"ipa_build_dib_env_default:"},{"line_number":48,"context_line":"  # TODO(mgoddard): Use {{ os_release }} here when we use os_distribution"},{"line_number":49,"context_line":"  # above."},{"line_number":50,"context_line":"  DIB_RELEASE: \"9-stream\""},{"line_number":51,"context_line":"  DIB_REPOLOCATION_ironic_python_agent: \"{{ ipa_build_source_url }}\""},{"line_number":52,"context_line":"  DIB_REPOREF_ironic_python_agent: \"{{ ipa_build_source_version }}\""},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":68,"id":"ee7c0598_893ed33c","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":25},"in_reply_to":"38cc947c_19b836a4","updated":"2022-12-12 13:48:37.000000000","message":"Done","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"847d372c0646cd2a321e90dde811dfc8a201aafd","unresolved":true,"context_lines":[{"line_number":47,"context_line":"ipa_build_dib_env_default:"},{"line_number":48,"context_line":"  # TODO(mgoddard): Use {{ os_release }} here when we use os_distribution"},{"line_number":49,"context_line":"  # above."},{"line_number":50,"context_line":"  DIB_RELEASE: \"9-stream\""},{"line_number":51,"context_line":"  DIB_REPOLOCATION_ironic_python_agent: \"{{ ipa_build_source_url }}\""},{"line_number":52,"context_line":"  DIB_REPOREF_ironic_python_agent: \"{{ ipa_build_source_version }}\""},{"line_number":53,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":68,"id":"38cc947c_19b836a4","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":25},"in_reply_to":"84174356_cfac0c78","updated":"2022-12-12 13:28:22.000000000","message":"we could look into that in follow up patch. This would need more testing as rocky needs docker/podman to build it.","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"}],"ansible/inventory/group_vars/all/kolla":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":57,"context_line":"# {{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}."},{"line_number":58,"context_line":"kolla_base_distro: \"{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Kolla container image type: source."},{"line_number":61,"context_line":"kolla_install_type: \"source\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Docker namespace to use for Kolla images."},{"line_number":64,"context_line":"kolla_docker_namespace: \"openstack.kolla\""},{"line_number":65,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":57,"id":"f54c4fd5_794af2fe","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":0},"updated":"2022-11-09 12:00:19.000000000","message":"We can drop this (in another patch)","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# {{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}."},{"line_number":58,"context_line":"kolla_base_distro: \"{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Kolla container image type: source."},{"line_number":61,"context_line":"kolla_install_type: \"source\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# Docker namespace to use for Kolla images."},{"line_number":64,"context_line":"kolla_docker_namespace: \"openstack.kolla\""},{"line_number":65,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":57,"id":"3b868554_1c709967","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":0},"in_reply_to":"f54c4fd5_794af2fe","updated":"2022-11-11 17:55:05.000000000","message":"Ack","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dbf49a08086d41f9be0d3025e79c49456ba65c26","unresolved":true,"context_lines":[{"line_number":55,"context_line":"# Kolla base container image distribution. Options are \"centos\", \"debian\","},{"line_number":56,"context_line":"# \"rocky\", \"ubuntu\". Default is"},{"line_number":57,"context_line":"# {{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}."},{"line_number":58,"context_line":"kolla_base_distro: \"{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Kolla base container image distribution version default map."},{"line_number":61,"context_line":"# Defines default versions for each distribution."}],"source_content_type":"application/octet-stream","patch_set":68,"id":"aa12a059_c0c9ced2","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":61},"updated":"2022-12-12 12:57:58.000000000","message":"Do we want that for CI only?","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"847d372c0646cd2a321e90dde811dfc8a201aafd","unresolved":false,"context_lines":[{"line_number":55,"context_line":"# Kolla base container image distribution. Options are \"centos\", \"debian\","},{"line_number":56,"context_line":"# \"rocky\", \"ubuntu\". Default is"},{"line_number":57,"context_line":"# {{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}."},{"line_number":58,"context_line":"kolla_base_distro: \"{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Kolla base container image distribution version default map."},{"line_number":61,"context_line":"# Defines default versions for each distribution."}],"source_content_type":"application/octet-stream","patch_set":68,"id":"8504f4a8_f8449fa5","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":61},"in_reply_to":"aa12a059_c0c9ced2","updated":"2022-12-12 13:28:22.000000000","message":"Done","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"}],"ansible/inventory/group_vars/all/seed-vm":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":46,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":47,"context_line":"# when os_distribution is \"rocky\","},{"line_number":48,"context_line":"# or"},{"line_number":49,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":50,"context_line":"# otherwise."},{"line_number":51,"context_line":"seed_vm_root_image: \u003e-"},{"line_number":52,"context_line":"  {%- if os_distribution \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"application/octet-stream","patch_set":75,"id":"313c9b7a_3dff1793","line":49,"range":{"start_line":49,"start_character":58,"end_line":49,"end_character":110},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":47,"context_line":"# when os_distribution is \"rocky\","},{"line_number":48,"context_line":"# or"},{"line_number":49,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":50,"context_line":"# otherwise."},{"line_number":51,"context_line":"seed_vm_root_image: \u003e-"},{"line_number":52,"context_line":"  {%- if os_distribution \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"application/octet-stream","patch_set":75,"id":"558362c9_4d9fab4a","line":49,"range":{"start_line":49,"start_character":58,"end_line":49,"end_character":110},"in_reply_to":"313c9b7a_3dff1793","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  {%- elif os_distribution \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":55,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":56,"context_line":"  {%- else -%}"},{"line_number":57,"context_line":"  https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2"},{"line_number":58,"context_line":"  {%- endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Capacity of the seed VM data volume."}],"source_content_type":"application/octet-stream","patch_set":75,"id":"05558918_6cfd3202","line":57,"range":{"start_line":57,"start_character":57,"end_line":57,"end_character":109},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  {%- elif os_distribution \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":55,"context_line":"  https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":56,"context_line":"  {%- else -%}"},{"line_number":57,"context_line":"  https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2"},{"line_number":58,"context_line":"  {%- endif %}"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Capacity of the seed VM data volume."}],"source_content_type":"application/octet-stream","patch_set":75,"id":"1c5e4746_0a730f11","line":57,"range":{"start_line":57,"start_character":57,"end_line":57,"end_character":109},"in_reply_to":"05558918_6cfd3202","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"ansible/kayobe-target-venv.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":24,"context_line":"          when: not ansible_facts"},{"line_number":25,"context_line":"          register: gather_facts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Ensure the Python virtualenv package is installed"},{"line_number":28,"context_line":"          package:"},{"line_number":29,"context_line":"            name: python3-virtualenv"},{"line_number":30,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"fcd7b622_985828ca","side":"PARENT","line":27,"updated":"2022-10-19 09:31:32.000000000","message":"You might want to keep this task for debian families, and install python3-venv instead. Unless I missed some other place it gets handled? (Needed for -m venv, it\u0027s not included in minimal installs.)","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          when: not ansible_facts"},{"line_number":25,"context_line":"          register: gather_facts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Ensure the Python virtualenv package is installed"},{"line_number":28,"context_line":"          package:"},{"line_number":29,"context_line":"            name: python3-virtualenv"},{"line_number":30,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"fb8fb157_2622a9f9","side":"PARENT","line":27,"in_reply_to":"fcd7b622_985828ca","updated":"2022-10-19 12:58:20.000000000","message":"Done","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"}],"ansible/roles/dnf/tasks/local-mirror.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":9,"context_line":"    group: root"},{"line_number":10,"context_line":"    mode: 0664"},{"line_number":11,"context_line":"  become: True"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"{{ repo_file_prefix }}-AppStream.repo\""},{"line_number":14,"context_line":"    - \"{{ repo_file_prefix }}-BaseOS.repo\""},{"line_number":15,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027CentOS\u0027"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"1de90b13_7d0d83d2","line":12,"updated":"2022-10-19 09:31:32.000000000","message":"Why no Extras for CentOS?","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    group: root"},{"line_number":10,"context_line":"    mode: 0664"},{"line_number":11,"context_line":"  become: True"},{"line_number":12,"context_line":"  loop:"},{"line_number":13,"context_line":"    - \"{{ repo_file_prefix }}-AppStream.repo\""},{"line_number":14,"context_line":"    - \"{{ repo_file_prefix }}-BaseOS.repo\""},{"line_number":15,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027CentOS\u0027"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"b93e4a7c_4da3605f","line":12,"in_reply_to":"1de90b13_7d0d83d2","updated":"2022-10-19 12:58:20.000000000","message":"I couldn\u0027t find extras for centos stream 9, it got moved to SIGs folder:\n\nhttp://mirror.stream.centos.org/SIGs/9-stream/\nhttp://mirror.iad3.inmotion.opendev.org/centos-stream/SIGs/9-stream/\n\nadded back","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    - \"{{ repo_file_prefix }}-BaseOS.repo\""},{"line_number":15,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027CentOS\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy CentOS repo templates"},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    repo_file_prefix: \"Rocky\""},{"line_number":20,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"509a8afd_be06d8b5","line":17,"updated":"2022-10-19 09:31:32.000000000","message":"This feels like duplication from the former, why can\u0027t this remain one task?\nSomething like\n repo_file_prefix: \"{{ ansible_facts.distribution }}{% if ansible_facts.distribution \u003d\u003d \u0027CentOS\u0027%}-Stream{% endif %}\"","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - \"{{ repo_file_prefix }}-BaseOS.repo\""},{"line_number":15,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027CentOS\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copy CentOS repo templates"},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    repo_file_prefix: \"Rocky\""},{"line_number":20,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"a64e20e7_e07439dd","line":17,"in_reply_to":"509a8afd_be06d8b5","updated":"2022-10-19 12:58:20.000000000","message":"Done","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"}],"ansible/roles/kolla-ansible/vars/Debian.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  - libssl-dev"},{"line_number":7,"context_line":"  - python3-dev"},{"line_number":8,"context_line":"  - python3-pip"},{"line_number":9,"context_line":"  - python3-virtualenv"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"dc0ea1fa_9108ef8d","side":"PARENT","line":9,"updated":"2022-10-19 09:31:32.000000000","message":"Maybe switch this out for python3-venv (not included in minimal installs of debian)","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - libssl-dev"},{"line_number":7,"context_line":"  - python3-dev"},{"line_number":8,"context_line":"  - python3-pip"},{"line_number":9,"context_line":"  - python3-virtualenv"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"b27ac177_5c46eecb","side":"PARENT","line":9,"in_reply_to":"dc0ea1fa_9108ef8d","updated":"2022-10-19 12:58:20.000000000","message":"Done","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"}],"ansible/roles/network-redhat/tasks/main.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    - nm_result is failed"},{"line_number":11,"context_line":"    # Ugh, Ansible\u0027s service module doesn\u0027t handle uninstalled services."},{"line_number":12,"context_line":"    - \"\u0027Could not find the requested service\u0027 not in nm_result.msg\""},{"line_number":13,"context_line":"  when: ansible_facts.distribution_major_version \u003d\u003d\u00278\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- import_role:"},{"line_number":16,"context_line":"    name: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"8737ed77_6791065c","line":13,"updated":"2022-10-19 09:31:32.000000000","message":"Suggest\n distribution_major_version | int \u003c 9","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - nm_result is failed"},{"line_number":11,"context_line":"    # Ugh, Ansible\u0027s service module doesn\u0027t handle uninstalled services."},{"line_number":12,"context_line":"    - \"\u0027Could not find the requested service\u0027 not in nm_result.msg\""},{"line_number":13,"context_line":"  when: ansible_facts.distribution_major_version \u003d\u003d\u00278\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- import_role:"},{"line_number":16,"context_line":"    name: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"b1b2838b_ba7744e9","line":13,"in_reply_to":"8737ed77_6791065c","updated":"2022-10-19 12:58:20.000000000","message":"Done","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Configure network interfaces (RedHat)"},{"line_number":21,"context_line":"  import_role:"},{"line_number":22,"context_line":"    name: ansible-role-interfaces"},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    interfaces_route_tables: \"{{ network_route_tables }}\""},{"line_number":25,"context_line":"    interfaces_ether_interfaces: \u003e"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"57de9ca5_fe7fd8ac","line":22,"updated":"2022-11-09 12:00:19.000000000","message":"Note: you can use this in requirements.yml when using a git repo:\n\n name: MichaelRigart.interfaces","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Configure network interfaces (RedHat)"},{"line_number":21,"context_line":"  import_role:"},{"line_number":22,"context_line":"    name: ansible-role-interfaces"},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    interfaces_route_tables: \"{{ network_route_tables }}\""},{"line_number":25,"context_line":"    interfaces_ether_interfaces: \u003e"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"93ec4620_045b7478","line":22,"in_reply_to":"57de9ca5_fe7fd8ac","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"dbf49a08086d41f9be0d3025e79c49456ba65c26","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure NetworkManager is disabled"},{"line_number":3,"context_line":"  service:"},{"line_number":4,"context_line":"    name: NetworkManager"},{"line_number":5,"context_line":"    state: stopped"},{"line_number":6,"context_line":"    enabled: no"},{"line_number":7,"context_line":"  become: True"},{"line_number":8,"context_line":"  register: nm_result"},{"line_number":9,"context_line":"  failed_when:"},{"line_number":10,"context_line":"    - nm_result is failed"},{"line_number":11,"context_line":"    # Ugh, Ansible\u0027s service module doesn\u0027t handle uninstalled services."},{"line_number":12,"context_line":"    - \"\u0027Could not find the requested service\u0027 not in nm_result.msg\""},{"line_number":13,"context_line":"  when: ansible_facts.distribution_major_version | int \u003c 9"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- import_role:"},{"line_number":16,"context_line":"    name: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"cc00b791_76197fe3","line":13,"range":{"start_line":2,"start_character":0,"end_line":13,"end_character":58},"updated":"2022-12-12 12:57:58.000000000","message":"We don\u0027t support lower than 9 - should we remove that task?","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"847d372c0646cd2a321e90dde811dfc8a201aafd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure NetworkManager is disabled"},{"line_number":3,"context_line":"  service:"},{"line_number":4,"context_line":"    name: NetworkManager"},{"line_number":5,"context_line":"    state: stopped"},{"line_number":6,"context_line":"    enabled: no"},{"line_number":7,"context_line":"  become: True"},{"line_number":8,"context_line":"  register: nm_result"},{"line_number":9,"context_line":"  failed_when:"},{"line_number":10,"context_line":"    - nm_result is failed"},{"line_number":11,"context_line":"    # Ugh, Ansible\u0027s service module doesn\u0027t handle uninstalled services."},{"line_number":12,"context_line":"    - \"\u0027Could not find the requested service\u0027 not in nm_result.msg\""},{"line_number":13,"context_line":"  when: ansible_facts.distribution_major_version | int \u003c 9"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- import_role:"},{"line_number":16,"context_line":"    name: ahuffman.resolv"}],"source_content_type":"text/x-yaml","patch_set":68,"id":"782dbf3a_a7a14a6c","line":13,"range":{"start_line":2,"start_character":0,"end_line":13,"end_character":58},"in_reply_to":"cc00b791_76197fe3","updated":"2022-12-12 13:28:22.000000000","message":"Done","commit_id":"76e70bd2d0e9b0d4f69eefeac8be4f57ba545346"}],"ansible/roles/veth/tasks/RedHat.yml":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    - \"ifdown-veth\""},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  register: ctl_result"},{"line_number":14,"context_line":"  when: ansible_facts.distribution_major_version \u003d\u003d \"8\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Ensure veth sysconfig network interface files exist"},{"line_number":17,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"030aff9c_60055a43","line":14,"updated":"2022-10-19 09:31:32.000000000","message":"Suggest we make a flag\n\n interfaces_use_nmconnection: ..._version | int \u003c 9\n\nSo it\u0027s a bit more clear why we\u0027re so concerned with 8 vs 9.\n\nCould we still use network-scripts with networkmanager on el9 with an additional package?","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    - \"ifdown-veth\""},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  register: ctl_result"},{"line_number":14,"context_line":"  when: ansible_facts.distribution_major_version \u003d\u003d \"8\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Ensure veth sysconfig network interface files exist"},{"line_number":17,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3c178d64_8772e515","line":14,"in_reply_to":"030aff9c_60055a43","updated":"2022-10-19 12:58:20.000000000","message":"no, veth does not work with network-scripts on network manager on el9","commit_id":"2023c94b982a98029c0dffdcc832a3c73c726f95"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3631b5c208b2ea99824f69f5ed7db9fbf6dec8ec","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  with_together:"},{"line_number":43,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":44,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":45,"context_line":"  when: ctl_result is changed or item[0] is changed or item[1] is changed"},{"line_number":46,"context_line":"  become: True"},{"line_number":47,"context_line":"  when: ansible_facts.distribution_major_version | int \u003c 9"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Ensure veth network manager connections file exists"},{"line_number":50,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"65dbe501_57b3401e","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":58},"updated":"2022-10-24 07:36:48.000000000","message":"Should probably be just one when clause","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ddee0f8f860ac8815cbc971784dd793bfddbc836","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  with_together:"},{"line_number":43,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":44,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":45,"context_line":"  when: ctl_result is changed or item[0] is changed or item[1] is changed"},{"line_number":46,"context_line":"  become: True"},{"line_number":47,"context_line":"  when: ansible_facts.distribution_major_version | int \u003c 9"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Ensure veth network manager connections file exists"},{"line_number":50,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"e392109e_93d28d31","line":47,"range":{"start_line":45,"start_character":0,"end_line":47,"end_character":58},"in_reply_to":"65dbe501_57b3401e","updated":"2022-10-27 08:45:15.000000000","message":"nice catch, thx!. Where is linter when one needs it?","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"3631b5c208b2ea99824f69f5ed7db9fbf6dec8ec","unresolved":true,"context_lines":[{"line_number":70,"context_line":"  register: peer_result"},{"line_number":71,"context_line":"  when: ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# NOTE(bbezak) For some reason adding veth pair via loading files to nmcli needs"},{"line_number":74,"context_line":"# peer device to be loaded first. If not, can\u0027t start interface."},{"line_number":75,"context_line":"# \"Error: Connection activation failed: p-br0-ovs failed to create resources:"},{"line_number":76,"context_line":"# Failed to create veth interface \u0027p-br0-ovs\u0027 for \u0027p-br0-ovs\u0027: exists\""},{"line_number":77,"context_line":"- name: Add veth interfaces to network manager"},{"line_number":78,"context_line":"  shell: |"},{"line_number":79,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.peer_device }}.nmconnection"},{"line_number":80,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.device }}.nmconnection"},{"line_number":81,"context_line":"  with_together:"},{"line_number":82,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":83,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":84,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":85,"context_line":"  become: True"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: Start veth interfaces with network manager"},{"line_number":88,"context_line":"  shell: |"},{"line_number":89,"context_line":"    nmcli connection up {{ item[0].item.device }}"},{"line_number":90,"context_line":"    nmcli connection up {{ item[0].item.peer_device }}"},{"line_number":91,"context_line":"  with_together:"},{"line_number":92,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":93,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":94,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":95,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"9573d81e_47d214b8","line":95,"range":{"start_line":73,"start_character":0,"end_line":95,"end_character":14},"updated":"2022-10-24 07:36:48.000000000","message":"could this just be a `nmcli connection reload` and let networkmanager figure out the order?","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ddee0f8f860ac8815cbc971784dd793bfddbc836","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  register: peer_result"},{"line_number":71,"context_line":"  when: ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# NOTE(bbezak) For some reason adding veth pair via loading files to nmcli needs"},{"line_number":74,"context_line":"# peer device to be loaded first. If not, can\u0027t start interface."},{"line_number":75,"context_line":"# \"Error: Connection activation failed: p-br0-ovs failed to create resources:"},{"line_number":76,"context_line":"# Failed to create veth interface \u0027p-br0-ovs\u0027 for \u0027p-br0-ovs\u0027: exists\""},{"line_number":77,"context_line":"- name: Add veth interfaces to network manager"},{"line_number":78,"context_line":"  shell: |"},{"line_number":79,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.peer_device }}.nmconnection"},{"line_number":80,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.device }}.nmconnection"},{"line_number":81,"context_line":"  with_together:"},{"line_number":82,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":83,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":84,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":85,"context_line":"  become: True"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: Start veth interfaces with network manager"},{"line_number":88,"context_line":"  shell: |"},{"line_number":89,"context_line":"    nmcli connection up {{ item[0].item.device }}"},{"line_number":90,"context_line":"    nmcli connection up {{ item[0].item.peer_device }}"},{"line_number":91,"context_line":"  with_together:"},{"line_number":92,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":93,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":94,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":95,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"ee9d1280_442334b2","line":95,"range":{"start_line":73,"start_character":0,"end_line":95,"end_character":14},"in_reply_to":"9573d81e_47d214b8","updated":"2022-10-27 08:45:15.000000000","message":"yeah, that seems reasonable","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"cf15d75b98da0d7597dc381e12ddd809fc9a7dcd","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  register: peer_result"},{"line_number":71,"context_line":"  when: ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# NOTE(bbezak) For some reason adding veth pair via loading files to nmcli needs"},{"line_number":74,"context_line":"# peer device to be loaded first. If not, can\u0027t start interface."},{"line_number":75,"context_line":"# \"Error: Connection activation failed: p-br0-ovs failed to create resources:"},{"line_number":76,"context_line":"# Failed to create veth interface \u0027p-br0-ovs\u0027 for \u0027p-br0-ovs\u0027: exists\""},{"line_number":77,"context_line":"- name: Add veth interfaces to network manager"},{"line_number":78,"context_line":"  shell: |"},{"line_number":79,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.peer_device }}.nmconnection"},{"line_number":80,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.device }}.nmconnection"},{"line_number":81,"context_line":"  with_together:"},{"line_number":82,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":83,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":84,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":85,"context_line":"  become: True"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: Start veth interfaces with network manager"},{"line_number":88,"context_line":"  shell: |"},{"line_number":89,"context_line":"    nmcli connection up {{ item[0].item.device }}"},{"line_number":90,"context_line":"    nmcli connection up {{ item[0].item.peer_device }}"},{"line_number":91,"context_line":"  with_together:"},{"line_number":92,"context_line":"    - \"{{ veth_result.results }}\""},{"line_number":93,"context_line":"    - \"{{ peer_result.results }}\""},{"line_number":94,"context_line":"  when: (item[0] is changed or item[1] is changed) and ansible_facts.distribution_major_version | int \u003e\u003d 9"},{"line_number":95,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"64b2c679_0d47467a","line":95,"range":{"start_line":73,"start_character":0,"end_line":95,"end_character":14},"in_reply_to":"ee9d1280_442334b2","updated":"2022-10-27 08:57:01.000000000","message":"although, with `nmcli connection reload` the error is still there - going back to previous version:\n\ncouldn\u0027t create the device: Failed to create veth interface \u0027p-breth1-ovs\u0027 for \u0027p-breth1-ovs\u0027: exists","commit_id":"c4f78b50db87d7a2a692b1fbf2fc306448fe0f85"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure veth sysconfig network control scripts exist"},{"line_number":3,"context_line":"  copy:"},{"line_number":4,"context_line":"    src: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"d243e747_b7527f9a","line":1,"updated":"2022-11-09 12:00:19.000000000","message":"Let\u0027s make this two separate files - network-scripts.yml \u0026 network-manager.yml","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure veth sysconfig network control scripts exist"},{"line_number":3,"context_line":"  copy:"},{"line_number":4,"context_line":"    src: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"e0fd3c3a_3e7a2bf1","line":1,"in_reply_to":"d243e747_b7527f9a","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":77,"context_line":"# Failed to create veth interface \u0027p-br0-ovs\u0027 for \u0027p-br0-ovs\u0027: exists\""},{"line_number":78,"context_line":"- name: Add veth interfaces to network manager"},{"line_number":79,"context_line":"  shell: |"},{"line_number":80,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.peer_device }}.nmconnection"},{"line_number":81,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.device }}.nmconnection"},{"line_number":82,"context_line":"  with_together:"},{"line_number":83,"context_line":"    - \"{{ veth_result.results }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"d118389b_b4fb05bb","line":80,"updated":"2022-11-09 12:00:19.000000000","message":"First one could silently fail\n\n a \u0026\u0026 b\n \nor\n \n set -e","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# Failed to create veth interface \u0027p-br0-ovs\u0027 for \u0027p-br0-ovs\u0027: exists\""},{"line_number":78,"context_line":"- name: Add veth interfaces to network manager"},{"line_number":79,"context_line":"  shell: |"},{"line_number":80,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.peer_device }}.nmconnection"},{"line_number":81,"context_line":"    nmcli connection load /etc/NetworkManager/system-connections/{{ item[0].item.device }}.nmconnection"},{"line_number":82,"context_line":"  with_together:"},{"line_number":83,"context_line":"    - \"{{ veth_result.results }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"6caff38f_5515fad6","line":80,"in_reply_to":"d118389b_b4fb05bb","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- name: Start veth interfaces with network manager"},{"line_number":91,"context_line":"  shell: |"},{"line_number":92,"context_line":"    nmcli connection up {{ item[0].item.device }}"},{"line_number":93,"context_line":"    nmcli connection up {{ item[0].item.peer_device }}"},{"line_number":94,"context_line":"  with_together:"},{"line_number":95,"context_line":"    - \"{{ veth_result.results }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"0ea77286_ad029820","line":92,"updated":"2022-11-09 12:00:19.000000000","message":"ditto","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"- name: Start veth interfaces with network manager"},{"line_number":91,"context_line":"  shell: |"},{"line_number":92,"context_line":"    nmcli connection up {{ item[0].item.device }}"},{"line_number":93,"context_line":"    nmcli connection up {{ item[0].item.peer_device }}"},{"line_number":94,"context_line":"  with_together:"},{"line_number":95,"context_line":"    - \"{{ veth_result.results }}\""}],"source_content_type":"text/x-yaml","patch_set":57,"id":"1d5eced6_77164ea3","line":92,"in_reply_to":"0ea77286_ad029820","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"}],"ansible/roles/veth/templates/peer-nmconnection.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":18,"context_line":"addr-gen-mode\u003dstable-privacy"},{"line_number":19,"context_line":"method\u003ddisabled"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[proxy]"}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"01553e03_23afd6ec","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":7},"updated":"2022-12-12 17:28:09.000000000","message":"Is there a reason for the empty section?","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":18,"context_line":"addr-gen-mode\u003dstable-privacy"},{"line_number":19,"context_line":"method\u003ddisabled"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[proxy]"}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"dd2b5256_0ec26ff3","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":7},"in_reply_to":"01553e03_23afd6ec","updated":"2022-12-12 18:49:40.000000000","message":"I\u0027ve mimicked the behaviour of nmcli generated files, you can test it with\n\nnmcli connection add type bridge con-name breth3 ifname breth3 ipv4.method manual ipv4.address 192.168.33.3/24 ipv6.method disabled\nnmcli connection add type dummy con-name eth3 ifname eth3 ipv4.method disabled ipv6.method disabled master breth3\nnmcli connection add type veth con-name p-breth3-ovs ifname p-breth3-ovs veth.peer p-breth3-phy ipv4.method disabled ipv6.method disabled\nnmcli connection add type veth con-name p-breth3-phy ifname p-breth3-phy veth.peer p-breth3-ovs ipv4.method disabled ipv6.method disabled master breth3\n\nfiles are generated in /etc/NetworkManager/system-connections","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"ansible/roles/veth/templates/veth-nmconnection.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":13,"context_line":"[veth]"},{"line_number":14,"context_line":"peer\u003d{{ item.peer_device }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[bridge-port]"}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"767faebb_293c30e0","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":13},"updated":"2022-12-12 17:28:09.000000000","message":"Is there a reason for the empty section?","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":13,"context_line":"[veth]"},{"line_number":14,"context_line":"peer\u003d{{ item.peer_device }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[bridge-port]"}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"2f75a24e_9dd1879b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":13},"in_reply_to":"767faebb_293c30e0","updated":"2022-12-12 18:49:40.000000000","message":"same as above","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"dev/functions":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"d529cec919f6177e84b6610bc6172f6bc6617c46","unresolved":true,"context_lines":[{"line_number":151,"context_line":"        exit 1"},{"line_number":152,"context_line":"    else"},{"line_number":153,"context_line":"        sudo apt update"},{"line_number":154,"context_line":"        sudo apt install -y python-is-python3 python3-dev python3-virtualenv gcc git libffi-dev"},{"line_number":155,"context_line":"    fi"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"e242fc12_e63ea1bc","side":"PARENT","line":154,"range":{"start_line":154,"start_character":58,"end_line":154,"end_character":76},"updated":"2022-10-19 09:31:32.000000000","message":"debian needs python3-venv for\n -m venv","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30a6d663f3a8daba220964e827f56ccfa6d3a5ff","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        exit 1"},{"line_number":152,"context_line":"    else"},{"line_number":153,"context_line":"        sudo apt update"},{"line_number":154,"context_line":"        sudo apt install -y python-is-python3 python3-dev python3-virtualenv gcc git libffi-dev"},{"line_number":155,"context_line":"    fi"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":44,"id":"a4a3c7b2_8b49dff5","side":"PARENT","line":154,"range":{"start_line":154,"start_character":58,"end_line":154,"end_character":76},"in_reply_to":"e242fc12_e63ea1bc","updated":"2022-10-19 12:58:20.000000000","message":"Done","commit_id":"b3cc98d3028d98a49693723db565d1f65003f522"}],"doc/source/configuration/reference/bifrost.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    releases.*"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    List of default DIB elements. Default is ``[\"disable-selinux\","},{"line_number":68,"context_line":"    \"enable-serial-console\", \"vm\"]`` when ``os_distribution`` is ``centos``, or"},{"line_number":69,"context_line":"    ``[\"enable-serial-console\", \"vm\"]`` otherwise. The ``vm`` element is"},{"line_number":70,"context_line":"    poorly named, and causes DIB to build a whole disk image rather than a"},{"line_number":71,"context_line":"    single partition."}],"source_content_type":"text/x-rst","patch_set":57,"id":"8c38e8ca_aa3e3d3c","line":68,"range":{"start_line":68,"start_character":67,"end_line":68,"end_character":73},"updated":"2022-11-09 12:00:19.000000000","message":"or rocky?","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    releases.*"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    List of default DIB elements. Default is ``[\"disable-selinux\","},{"line_number":68,"context_line":"    \"enable-serial-console\", \"vm\"]`` when ``os_distribution`` is ``centos``, or"},{"line_number":69,"context_line":"    ``[\"enable-serial-console\", \"vm\"]`` otherwise. The ``vm`` element is"},{"line_number":70,"context_line":"    poorly named, and causes DIB to build a whole disk image rather than a"},{"line_number":71,"context_line":"    single partition."}],"source_content_type":"text/x-rst","patch_set":57,"id":"a19a797b_b080bd0a","line":68,"range":{"start_line":68,"start_character":67,"end_line":68,"end_character":73},"in_reply_to":"8c38e8ca_aa3e3d3c","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":50,"context_line":":diskimage-builder-doc:`Diskimage-builder documentation \u003c\u003e` for further"},{"line_number":51,"context_line":"information on building disk images."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The default configuration builds a CentOS Stream 9 whole disk (partitioned)"},{"line_number":54,"context_line":"image with SELinux disabled and a serial console enabled. `Cloud-init"},{"line_number":55,"context_line":"\u003chttps://cloudinit.readthedocs.io/en/latest/\u003e`__ is used to process the"},{"line_number":56,"context_line":"configuration drive built by Bifrost, rather than the Bifrost default of"}],"source_content_type":"text/x-rst","patch_set":75,"id":"34a8c257_9dcec68e","line":53,"range":{"start_line":53,"start_character":35,"end_line":53,"end_character":50},"updated":"2022-12-12 17:28:09.000000000","message":"Rocky Linux 9\n\nbecause:\n\nkolla_bifrost_dib_os_element: \"{{ os_distribution }}\"\nos_distribution: \"rocky\"","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":50,"context_line":":diskimage-builder-doc:`Diskimage-builder documentation \u003c\u003e` for further"},{"line_number":51,"context_line":"information on building disk images."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"The default configuration builds a CentOS Stream 9 whole disk (partitioned)"},{"line_number":54,"context_line":"image with SELinux disabled and a serial console enabled. `Cloud-init"},{"line_number":55,"context_line":"\u003chttps://cloudinit.readthedocs.io/en/latest/\u003e`__ is used to process the"},{"line_number":56,"context_line":"configuration drive built by Bifrost, rather than the Bifrost default of"}],"source_content_type":"text/x-rst","patch_set":75,"id":"ac2c8304_5bcb4e36","line":53,"range":{"start_line":53,"start_character":35,"end_line":53,"end_character":50},"in_reply_to":"34a8c257_9dcec68e","updated":"2022-12-12 18:49:40.000000000","message":"Rocky Linux 9 needs rocky-container DIB element, which probably won\u0027t work in Docker in Docker environment. Plus we recently changed default of overcloud_dib_build_host_images: true, so users won\u0027t be building images in bifrost by default. Altering docs.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    releases.*"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    List of default DIB elements. Default is ``[\"disable-selinux\","},{"line_number":68,"context_line":"    \"enable-serial-console\", \"vm\"]`` when ``os_distribution`` is ``centos``, or"},{"line_number":69,"context_line":"    ``rocky``, ``[\"enable-serial-console\", \"vm\"]`` otherwise. The ``vm`` element"},{"line_number":70,"context_line":"    is poorly named, and causes DIB to build a whole disk image rather than a"},{"line_number":71,"context_line":"    single partition."}],"source_content_type":"text/x-rst","patch_set":75,"id":"73aaac56_9a26ea16","line":68,"range":{"start_line":68,"start_character":75,"end_line":68,"end_character":76},"updated":"2022-12-12 17:28:09.000000000","message":"Remove comma","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    releases.*"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    List of default DIB elements. Default is ``[\"disable-selinux\","},{"line_number":68,"context_line":"    \"enable-serial-console\", \"vm\"]`` when ``os_distribution`` is ``centos``, or"},{"line_number":69,"context_line":"    ``rocky``, ``[\"enable-serial-console\", \"vm\"]`` otherwise. The ``vm`` element"},{"line_number":70,"context_line":"    is poorly named, and causes DIB to build a whole disk image rather than a"},{"line_number":71,"context_line":"    single partition."}],"source_content_type":"text/x-rst","patch_set":75,"id":"4b45889a_1e31d171","line":68,"range":{"start_line":68,"start_character":75,"end_line":68,"end_character":76},"in_reply_to":"73aaac56_9a26ea16","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"doc/source/configuration/reference/kolla-ansible.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. code-block:: console"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"   registry.example.com:4000/example/rocky-source-ironic-api:15.0.0.1"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Ansible"},{"line_number":160,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":57,"id":"018edfcb_9f985006","line":157,"updated":"2022-11-09 12:00:19.000000000","message":"As before","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":".. code-block:: console"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"   registry.example.com:4000/example/rocky-source-ironic-api:15.0.0.1"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Ansible"},{"line_number":160,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":57,"id":"f8fd7446_8727403a","line":157,"in_reply_to":"018edfcb_9f985006","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"}],"doc/source/configuration/reference/kolla.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``kolla_base_distro``"},{"line_number":76,"context_line":"    Kolla base container image distribution. Options are ``centos``,"},{"line_number":77,"context_line":"    ``debian``, \u0027\u0027rocky\u0027\u0027 or ``ubuntu``. Default is ``{{ os_distribution }}``."},{"line_number":78,"context_line":"``kolla_install_type``"},{"line_number":79,"context_line":"    Kolla container image type: ``source``. Default is"},{"line_number":80,"context_line":"    ``source``."}],"source_content_type":"text/x-rst","patch_set":57,"id":"90cfd318_d5ae4347","line":77,"range":{"start_line":77,"start_character":57,"end_line":77,"end_character":72},"updated":"2022-11-09 12:00:19.000000000","message":"or rocky if centos","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``kolla_base_distro``"},{"line_number":76,"context_line":"    Kolla base container image distribution. Options are ``centos``,"},{"line_number":77,"context_line":"    ``debian``, \u0027\u0027rocky\u0027\u0027 or ``ubuntu``. Default is ``{{ os_distribution }}``."},{"line_number":78,"context_line":"``kolla_install_type``"},{"line_number":79,"context_line":"    Kolla container image type: ``source``. Default is"},{"line_number":80,"context_line":"    ``source``."}],"source_content_type":"text/x-rst","patch_set":57,"id":"ce1b4d79_ad75d746","line":77,"range":{"start_line":77,"start_character":57,"end_line":77,"end_character":72},"in_reply_to":"90cfd318_d5ae4347","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":108,"context_line":"   kolla_install_type: source"},{"line_number":109,"context_line":"   kolla_docker_namespace: example"},{"line_number":110,"context_line":"   kolla_docker_registry: registry.example.com:4000"},{"line_number":111,"context_line":"   kolla_openstack_release: 15.0.0.1"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"The ``ironic-api`` image built with this configuration would be referenced as"},{"line_number":114,"context_line":"follows:"}],"source_content_type":"text/x-rst","patch_set":57,"id":"ac320abf_ab83b372","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":36},"updated":"2022-11-09 12:00:19.000000000","message":"Drop this?","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"   kolla_install_type: source"},{"line_number":109,"context_line":"   kolla_docker_namespace: example"},{"line_number":110,"context_line":"   kolla_docker_registry: registry.example.com:4000"},{"line_number":111,"context_line":"   kolla_openstack_release: 15.0.0.1"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"The ``ironic-api`` image built with this configuration would be referenced as"},{"line_number":114,"context_line":"follows:"}],"source_content_type":"text/x-rst","patch_set":57,"id":"c6d9ae6b_1e0f0052","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":36},"in_reply_to":"ac320abf_ab83b372","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7bcd23114c483a2ef9447b1a0539fff8297dcc7c","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. code-block:: console"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   registry.example.com:4000/example/rockys-source-ironic-api:15.0.0.1"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Further customisation of the Kolla configuration file can be performed by"},{"line_number":121,"context_line":"writing a file at ``${KAYOBE_CONFIG_PATH/kolla/kolla-build.conf``. For example,"}],"source_content_type":"text/x-rst","patch_set":57,"id":"4b6e24d9_9545d6e1","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":70},"updated":"2022-11-09 12:00:19.000000000","message":"registry.example.com:4000/example/ironic-api:zed-rocky-9","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e8a45bdbe41811d89d4da61446cf610dafd2b4b3","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. code-block:: console"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"   registry.example.com:4000/example/rockys-source-ironic-api:15.0.0.1"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Further customisation of the Kolla configuration file can be performed by"},{"line_number":121,"context_line":"writing a file at ``${KAYOBE_CONFIG_PATH/kolla/kolla-build.conf``. For example,"}],"source_content_type":"text/x-rst","patch_set":57,"id":"441f6e54_5ba2208e","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":70},"in_reply_to":"4b6e24d9_9545d6e1","updated":"2022-11-11 17:55:05.000000000","message":"Done","commit_id":"9c725c86fffd1f9d5daef8c4687ed7082d39908e"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``kolla_base_distro``"},{"line_number":76,"context_line":"    Kolla base container image distribution. Options are ``centos``,"},{"line_number":77,"context_line":"    ``debian``, \u0027\u0027rocky\u0027\u0027 or ``ubuntu``. Default is ``{{ os_distribution }}``."},{"line_number":78,"context_line":"``kolla_base_distro_version``"},{"line_number":79,"context_line":"    Kolla base container image distribution version. Default is dependent on"},{"line_number":80,"context_line":"    ``kolla_base_distro``."}],"source_content_type":"text/x-rst","patch_set":75,"id":"5f5eab1b_61965f14","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":25},"updated":"2022-12-12 17:28:09.000000000","message":"I assume the change of quote style was done in error.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"``kolla_base_distro``"},{"line_number":76,"context_line":"    Kolla base container image distribution. Options are ``centos``,"},{"line_number":77,"context_line":"    ``debian``, \u0027\u0027rocky\u0027\u0027 or ``ubuntu``. Default is ``{{ os_distribution }}``."},{"line_number":78,"context_line":"``kolla_base_distro_version``"},{"line_number":79,"context_line":"    Kolla base container image distribution version. Default is dependent on"},{"line_number":80,"context_line":"    ``kolla_base_distro``."}],"source_content_type":"text/x-rst","patch_set":75,"id":"48b5fbd7_a515816e","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":25},"in_reply_to":"5f5eab1b_61965f14","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"etc/kayobe/infra-vms.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":35,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":36,"context_line":"# when os_distribution is \"rocky\","},{"line_number":37,"context_line":"# or"},{"line_number":38,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":39,"context_line":"# otherwise."},{"line_number":40,"context_line":"#infra_vm_root_image:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"8f86d858_a2bd689e","line":38,"range":{"start_line":38,"start_character":58,"end_line":38,"end_character":110},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":36,"context_line":"# when os_distribution is \"rocky\","},{"line_number":37,"context_line":"# or"},{"line_number":38,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":39,"context_line":"# otherwise."},{"line_number":40,"context_line":"#infra_vm_root_image:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"cece43ab_dc7e5316","line":38,"range":{"start_line":38,"start_character":58,"end_line":38,"end_character":110},"in_reply_to":"8f86d858_a2bd689e","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"etc/kayobe/seed-vm.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":35,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":36,"context_line":"# when os_distribution is \"rocky\","},{"line_number":37,"context_line":"# or"},{"line_number":38,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":39,"context_line":"# otherwise."},{"line_number":40,"context_line":"#seed_vm_root_image:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"8abec5e1_1d1820c4","line":38,"range":{"start_line":38,"start_character":58,"end_line":38,"end_character":111},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS-Stream-GenericCloud-9-20221206.0.x86_64.qcow2","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://dl.rockylinux.org/pub/rocky/9/images/x86_64/Rocky-9-GenericCloud.latest.x86_64.qcow2"},{"line_number":36,"context_line":"# when os_distribution is \"rocky\","},{"line_number":37,"context_line":"# or"},{"line_number":38,"context_line":"# \"https://cloud.centos.org/centos/9-stream/x86_64/images/CentOS-Stream-GenericCloud-9-20220829.0.x86_64.qcow2\""},{"line_number":39,"context_line":"# otherwise."},{"line_number":40,"context_line":"#seed_vm_root_image:"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":75,"id":"8b1bc741_892aeb94","line":38,"range":{"start_line":38,"start_character":58,"end_line":38,"end_character":111},"in_reply_to":"8abec5e1_1d1820c4","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"playbooks/kayobe-overcloud-base/overrides.yml.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":49,"context_line":"kolla_enable_horizon: false"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":53,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":54,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"f5e876ce_de251d8e","line":52,"range":{"start_line":52,"start_character":37,"end_line":52,"end_character":43},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":49,"context_line":"kolla_enable_horizon: false"},{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":53,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":54,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"6616dae7_59a7a621","line":52,"range":{"start_line":52,"start_character":37,"end_line":52,"end_character":43},"in_reply_to":"f5e876ce_de251d8e","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":53,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":54,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"d7d392b4_466dae15","line":53,"range":{"start_line":53,"start_character":26,"end_line":53,"end_character":32},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":50,"context_line":"{% endif %}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":53,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":54,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"6cd97ec3_4a18eef4","line":53,"range":{"start_line":53,"start_character":26,"end_line":53,"end_character":32},"in_reply_to":"d7d392b4_466dae15","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"playbooks/kayobe-overcloud-host-configure-base/tests/test_overcloud_host_configure.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    assert host.file(\u0027/sys/class/net/dummy2.42/lower_dummy2\u0027).exists"},{"line_number":42,"context_line":"    # FIXME(bbezak): remove following IF after ansible-role-interfaces"},{"line_number":43,"context_line":"    # receive support for custom routes in NetworkManager"},{"line_number":44,"context_line":"    if not (\u0027centos\u0027 in host.system_info.distribution.lower() or"},{"line_number":45,"context_line":"            \u0027rocky\u0027 in host.system_info.distribution.lower()):"},{"line_number":46,"context_line":"       routes \u003d host.check_output("},{"line_number":47,"context_line":"           \u0027/sbin/ip route show dev dummy2.42 table kayobe-test-route-table\u0027)"}],"source_content_type":"text/x-python","patch_set":75,"id":"2a9f675e_b749d4f6","line":44,"updated":"2022-12-12 17:28:09.000000000","message":"You could have used _is_dnf here ;-)","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    assert host.file(\u0027/sys/class/net/dummy2.42/lower_dummy2\u0027).exists"},{"line_number":42,"context_line":"    # FIXME(bbezak): remove following IF after ansible-role-interfaces"},{"line_number":43,"context_line":"    # receive support for custom routes in NetworkManager"},{"line_number":44,"context_line":"    if not (\u0027centos\u0027 in host.system_info.distribution.lower() or"},{"line_number":45,"context_line":"            \u0027rocky\u0027 in host.system_info.distribution.lower()):"},{"line_number":46,"context_line":"       routes \u003d host.check_output("},{"line_number":47,"context_line":"           \u0027/sbin/ip route show dev dummy2.42 table kayobe-test-route-table\u0027)"}],"source_content_type":"text/x-python","patch_set":75,"id":"5ce215e8_ea439cfb","line":44,"in_reply_to":"2a9f675e_b749d4f6","updated":"2022-12-12 18:49:40.000000000","message":"I\u0027ve copied a test_ntp_non_default_time_server style 😊.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"playbooks/kayobe-seed-base/overrides.yml.j2":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":40,"context_line":"overcloud_dib_elements_extra:"},{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"fa566823_3d3341ff","line":43,"range":{"start_line":43,"start_character":37,"end_line":43,"end_character":52},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS Stream 9","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":40,"context_line":"overcloud_dib_elements_extra:"},{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"9f0b4874_d08cf1a4","line":43,"range":{"start_line":43,"start_character":37,"end_line":43,"end_character":52},"in_reply_to":"fa566823_3d3341ff","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"c498b1f0_a4620abb","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":41},"updated":"2022-12-12 17:28:09.000000000","message":"CentOS Stream 9","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"763a2ebb_bc92cb54","line":44,"updated":"2022-12-12 17:28:09.000000000","message":"Rocky Linux 9","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"2003516f_ff06728b","line":44,"in_reply_to":"763a2ebb_bc92cb54","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  - \"openstack-ci-mirrors\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# NOTE(bbezak): Kolla does not build Centos 9 Stream container images."},{"line_number":44,"context_line":"# Using Rocky 9 images on Centos 9 Stream in CI."},{"line_number":45,"context_line":"kolla_base_distro: \"{% raw %}{{ \u0027rocky\u0027 if os_distribution \u003d\u003d \u0027centos\u0027 else os_distribution }}{% endraw %}\""}],"source_content_type":"text/x-jinja2","patch_set":75,"id":"f29ff0eb_6ff9635c","line":44,"range":{"start_line":44,"start_character":26,"end_line":44,"end_character":41},"in_reply_to":"c498b1f0_a4620abb","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"releasenotes/notes/rocky-linux-9-adccc4bb77fda197.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"6f54d9e48f9a2d3c53f3f231b3a51e31912c6c03","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    container image. CentOS Stream 8 is not supported anymore."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Rocky Linux 9 has become default ``os_distribution``."},{"line_number":9,"context_line":"    CentOS Stream 8 is not supported anymore."}],"source_content_type":"text/x-yaml","patch_set":75,"id":"7385eadc_df9022d4","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":57},"updated":"2022-12-12 17:28:09.000000000","message":"I would rephrase to:\n\nThe default value of ``os_distribution`` was changed to ``rocky``.","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4f5b6dda73c4f815a2354d1f0e521191c0f11692","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    container image. CentOS Stream 8 is not supported anymore."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    Rocky Linux 9 has become default ``os_distribution``."},{"line_number":9,"context_line":"    CentOS Stream 8 is not supported anymore."}],"source_content_type":"text/x-yaml","patch_set":75,"id":"270d3844_9379cc27","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":57},"in_reply_to":"7385eadc_df9022d4","updated":"2022-12-12 18:49:40.000000000","message":"Done","commit_id":"0719d3a581129481b3f2f5fdf83ce5d560c848a3"}],"zuul.d/project.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"7c7031dd01e7914cb35e0eae384e0148f12d5c5c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        - kayobe-overcloud-upgrade-ubuntu-focal"},{"line_number":22,"context_line":"        - kayobe-seed-rocky9"},{"line_number":23,"context_line":"        - kayobe-seed-ubuntu-jammy"},{"line_number":24,"context_line":"        - kayobe-seed-images-rocky9"},{"line_number":25,"context_line":"        - kayobe-seed-upgrade-ubuntu-focal"},{"line_number":26,"context_line":"        - kayobe-seed-vm-rocky9"},{"line_number":27,"context_line":"        - kayobe-seed-vm-ubuntu-jammy"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"326b5a62_30e3f20a","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":35},"updated":"2022-12-12 21:31:13.000000000","message":"Should we make the image build experimental like it was before? (can be follow up to avoid extra CI work)","commit_id":"2f447f65453ff278fd53e5bf7975a5a092378b97"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9f1e51bd64bad5974f1f0f853440db7ea439dc59","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        - kayobe-overcloud-upgrade-ubuntu-focal"},{"line_number":22,"context_line":"        - kayobe-seed-rocky9"},{"line_number":23,"context_line":"        - kayobe-seed-ubuntu-jammy"},{"line_number":24,"context_line":"        - kayobe-seed-images-rocky9"},{"line_number":25,"context_line":"        - kayobe-seed-upgrade-ubuntu-focal"},{"line_number":26,"context_line":"        - kayobe-seed-vm-rocky9"},{"line_number":27,"context_line":"        - kayobe-seed-vm-ubuntu-jammy"}],"source_content_type":"text/x-yaml","patch_set":77,"id":"75a96d36_5f7c216d","line":24,"range":{"start_line":24,"start_character":10,"end_line":24,"end_character":35},"in_reply_to":"326b5a62_30e3f20a","updated":"2022-12-13 13:40:12.000000000","message":"Before we had the centos8s image job running all the time and rocky/ubuntu experimental.\n\nI have proposed https://review.opendev.org/c/openstack/kayobe/+/867360 to mimic this, but with rocky9 as default.","commit_id":"2f447f65453ff278fd53e5bf7975a5a092378b97"}]}
