)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"c4a8078be9cd909731be95535c18335d319b1e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79bf2bf0_cef48a07","updated":"2022-09-30 08:32:25.000000000","message":"recheck","commit_id":"cf8d97920f41adf38e7309c4e1ac7fa45b57ea95"}],"ansible/roles/kolla-ansible/library/kolla_passwords.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf31f2e8538a8a7d88e3b027721b7b5394bb0490","unresolved":true,"context_lines":[{"line_number":77,"context_line":"def vault_decrypt(module, file_path):"},{"line_number":78,"context_line":"    \"\"\"Decrypt a file using Ansible vault\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Return immediately if file not encrypted"},{"line_number":81,"context_line":"    with open(file_path, \u0027r\u0027) as f:"},{"line_number":82,"context_line":"        if not f.readline()[:15] \u003d\u003d \"$ANSIBLE_VAULT;\":"},{"line_number":83,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c9ac4b1_b7f87b47","line":80,"updated":"2022-10-13 10:49:24.000000000","message":"Should we update/add a unit test under kayobe/tests/unit/test_ansible.py to test this?","commit_id":"c81d9e8b2c887171fbf5e62a1cd66051fc295bd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3ed682fce4c08c145480c3ff193bc0507a32b661","unresolved":true,"context_lines":[{"line_number":77,"context_line":"def vault_decrypt(module, file_path):"},{"line_number":78,"context_line":"    \"\"\"Decrypt a file using Ansible vault\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Return immediately if file not encrypted"},{"line_number":81,"context_line":"    with open(file_path, \u0027r\u0027) as f:"},{"line_number":82,"context_line":"        if not f.readline()[:15] \u003d\u003d \"$ANSIBLE_VAULT;\":"},{"line_number":83,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"6db0dde9_f21d922d","line":80,"in_reply_to":"1c9ac4b1_b7f87b47","updated":"2022-10-13 19:12:42.000000000","message":"It\u0027s not really set up to test this module.","commit_id":"c81d9e8b2c887171fbf5e62a1cd66051fc295bd9"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"c7d788f7b12e8191ad73b5e6329b42a8f3613dd8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"def vault_decrypt(module, file_path):"},{"line_number":78,"context_line":"    \"\"\"Decrypt a file using Ansible vault\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Return immediately if file not encrypted"},{"line_number":81,"context_line":"    with open(file_path, \u0027r\u0027) as f:"},{"line_number":82,"context_line":"        if not f.readline()[:15] \u003d\u003d \"$ANSIBLE_VAULT;\":"},{"line_number":83,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"c01517db_8640923a","line":80,"in_reply_to":"6db0dde9_f21d922d","updated":"2022-10-13 20:14:42.000000000","message":"Let\u0027s merge and backport.","commit_id":"c81d9e8b2c887171fbf5e62a1cd66051fc295bd9"}],"releasenotes/notes/fix-unnecessary-decryption-bug-adaf2f6385a77f48.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0e1218fa35d33ff126e3412115b9c463542c9a80","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue causing various commands to fail on "},{"line_number":5,"context_line":"    TASK [kolla-ansible : Ensure the Kolla passwords file exists] when "},{"line_number":6,"context_line":"    passwords.yml is not encrypted but a password has been supplied."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"726550c9_16d2545c","line":6,"updated":"2022-10-12 06:52:59.000000000","message":"no newline at end of file","commit_id":"f1829010f78c78d84678890561403d49990c243d"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"46fb3c1fac31cbf58f837ab580562d6090c538d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue causing various commands to fail on "},{"line_number":5,"context_line":"    TASK [kolla-ansible : Ensure the Kolla passwords file exists] when "},{"line_number":6,"context_line":"    passwords.yml is not encrypted but a password has been supplied."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"27505e61_b893be98","line":6,"in_reply_to":"726550c9_16d2545c","updated":"2022-10-12 13:56:35.000000000","message":"Done","commit_id":"f1829010f78c78d84678890561403d49990c243d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ee681d2dd2f4464b7e9fa4e9cb8dd37f353fcaf2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue causing various commands to fail on "},{"line_number":5,"context_line":"    TASK [kolla-ansible : Ensure the Kolla passwords file exists] when "},{"line_number":6,"context_line":"    passwords.yml is not encrypted but a password has been supplied."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f7e5ea07_91ddd0b4","line":5,"range":{"start_line":4,"start_character":52,"end_line":5,"end_character":65},"updated":"2022-10-03 14:37:11.000000000","message":"when generating passwords.yml if an unencrypted file exists but ...","commit_id":"cf8d97920f41adf38e7309c4e1ac7fa45b57ea95"},{"author":{"_account_id":35264,"name":"Alex Welsh","email":"alex@stackhpc.com","username":"alex-welsh"},"change_message_id":"04620891cf6ccfd370a04d8c42e1283bd2c69e5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes an issue causing various commands to fail on "},{"line_number":5,"context_line":"    TASK [kolla-ansible : Ensure the Kolla passwords file exists] when "},{"line_number":6,"context_line":"    passwords.yml is not encrypted but a password has been supplied."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"95c16a99_f87d8710","line":5,"range":{"start_line":4,"start_character":52,"end_line":5,"end_character":65},"in_reply_to":"f7e5ea07_91ddd0b4","updated":"2022-10-04 07:49:01.000000000","message":"Done","commit_id":"cf8d97920f41adf38e7309c4e1ac7fa45b57ea95"}]}
