)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd063e5c7b4ab8d8f9b92561ea9dcb8dbe8fe8be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb7c097c_fce334af","updated":"2023-02-10 12:47:04.000000000","message":"LGTM, but -1 for rules.","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"},{"author":{"_account_id":35555,"name":"Aaron S","display_name":"as0","email":"as3310@protonmail.com","username":"as0"},"change_message_id":"c7ae08f9c88631145191548020ff80c20c7c4344","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d288709_6bb33cd2","updated":"2023-01-09 13:58:33.000000000","message":"Thanks for the review Mark. This PR needs a bit of a rework/some polishing based on your comments","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"}],"ansible/overcloud-introspection-rules.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ad5c070bea61ed2508a9d9fe8c174ac6e980f62","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      inspector_rule_var_ipmi_username: \"{{ inspector_ipmi_username }}\""},{"line_number":74,"context_line":"      inspector_rule_var_ipmi_password: \"{{ inspector_ipmi_password }}\""},{"line_number":75,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ inspector_lldp_switch_port_interface_default }}\""},{"line_number":76,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ ipa_kernel_id.stdout | default(omit, true) }}\""},{"line_number":77,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ ipa_ramdisk_id.stdout | default(omit, true) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"188e93ce_1161bb4a","line":76,"range":{"start_line":76,"start_character":65,"end_line":76,"end_character":86},"updated":"2023-01-09 10:32:10.000000000","message":"What happens to the generated inspector rule here? Does it get the magic Ansible omit_placeholder_fpsginflkn string?","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"},{"author":{"_account_id":35555,"name":"Aaron S","display_name":"as0","email":"as3310@protonmail.com","username":"as0"},"change_message_id":"c7ae08f9c88631145191548020ff80c20c7c4344","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      inspector_rule_var_ipmi_username: \"{{ inspector_ipmi_username }}\""},{"line_number":74,"context_line":"      inspector_rule_var_ipmi_password: \"{{ inspector_ipmi_password }}\""},{"line_number":75,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ inspector_lldp_switch_port_interface_default }}\""},{"line_number":76,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ ipa_kernel_id.stdout | default(omit, true) }}\""},{"line_number":77,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ ipa_ramdisk_id.stdout | default(omit, true) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"18ebe0cb_4a3d25e6","line":76,"range":{"start_line":76,"start_character":65,"end_line":76,"end_character":86},"in_reply_to":"188e93ce_1161bb4a","updated":"2023-01-09 13:58:33.000000000","message":"Thanks for reviewing, and good question.\n\nFor our particular use case, it appears the `driver_info.deploy_(ramdisk|kernel)` value is not set on the node, at least at the stage it has been successfully inspected and reached the available state.\n\n\nI\u0027m not entirely sure of the optimal way to resolve this given the Ansible placeholder string....","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd063e5c7b4ab8d8f9b92561ea9dcb8dbe8fe8be","unresolved":true,"context_lines":[{"line_number":73,"context_line":"      inspector_rule_var_ipmi_username: \"{{ inspector_ipmi_username }}\""},{"line_number":74,"context_line":"      inspector_rule_var_ipmi_password: \"{{ inspector_ipmi_password }}\""},{"line_number":75,"context_line":"      inspector_rule_var_lldp_switch_port_interface: \"{{ inspector_lldp_switch_port_interface_default }}\""},{"line_number":76,"context_line":"      inspector_rule_var_deploy_kernel: \"{{ ipa_kernel_id.stdout | default(omit, true) }}\""},{"line_number":77,"context_line":"      inspector_rule_var_deploy_ramdisk: \"{{ ipa_ramdisk_id.stdout | default(omit, true) }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c8367c6e_902c5c6f","line":76,"range":{"start_line":76,"start_character":65,"end_line":76,"end_character":86},"in_reply_to":"18ebe0cb_4a3d25e6","updated":"2023-02-10 12:47:04.000000000","message":"Agree with Mark, omit variables here is not enough. we need completely omit rules \u0027inspector_rule_deploy_kernel\u0027 and \u0027inspector_rule_deploy_ramdisk\u0027 from the \u0027inspector_rules_default\u0027 at least.","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"}],"ansible/overcloud-ipa-images.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0ad5c070bea61ed2508a9d9fe8c174ac6e980f62","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        key: \"controllers_for_ipa_images_{{ kolla_enable_ironic | bool }}\""},{"line_number":11,"context_line":"      changed_when: false"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Ensure Ironic Python Agent (IPA) images are downloaded and registered"},{"line_number":14,"context_line":"  hosts: controllers_for_ipa_images_True[0]"},{"line_number":15,"context_line":"  tags:"},{"line_number":16,"context_line":"    - ipa-images"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7ecffbf2_031cca1e","line":13,"updated":"2023-01-09 10:32:10.000000000","message":"Is any of this play required in this use case?","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"},{"author":{"_account_id":35555,"name":"Aaron S","display_name":"as0","email":"as3310@protonmail.com","username":"as0"},"change_message_id":"c7ae08f9c88631145191548020ff80c20c7c4344","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        key: \"controllers_for_ipa_images_{{ kolla_enable_ironic | bool }}\""},{"line_number":11,"context_line":"      changed_when: false"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Ensure Ironic Python Agent (IPA) images are downloaded and registered"},{"line_number":14,"context_line":"  hosts: controllers_for_ipa_images_True[0]"},{"line_number":15,"context_line":"  tags:"},{"line_number":16,"context_line":"    - ipa-images"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c770d913_6a37ea0c","line":13,"in_reply_to":"7ecffbf2_031cca1e","updated":"2023-01-09 13:58:33.000000000","message":"No, for the use case where IPA ramdisk/kernel are not stored in Glance means that none of this play from L13 is required.\n\nWhat do you think about potentially moving the block and conditional to encapsulate this play and the following tasks?\n\nThanks","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dd063e5c7b4ab8d8f9b92561ea9dcb8dbe8fe8be","unresolved":true,"context_lines":[{"line_number":10,"context_line":"        key: \"controllers_for_ipa_images_{{ kolla_enable_ironic | bool }}\""},{"line_number":11,"context_line":"      changed_when: false"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Ensure Ironic Python Agent (IPA) images are downloaded and registered"},{"line_number":14,"context_line":"  hosts: controllers_for_ipa_images_True[0]"},{"line_number":15,"context_line":"  tags:"},{"line_number":16,"context_line":"    - ipa-images"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5c3d12ff_59d8c334","line":13,"in_reply_to":"c770d913_6a37ea0c","updated":"2023-02-10 12:47:04.000000000","message":"Looks like all playbook should be ignored in this use case. No need to use block and/or any conditionals in it, its better add \u0027ipa_glance_store\u0027 to the group_by key \u0027controllers_for_ipa_images\u0027 here and check \u0027ipa_glance_stroe\u0027 together with \u0027kolla_enable_ironic\u0027.","commit_id":"6df5d2a2ca5956841a15c2448798e8e17ee2e64d"}]}