)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"15269006711df6dc5b7d083fb74ed29bcbfc942c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a409a26d_391254f2","updated":"2023-01-12 13:43:50.000000000","message":"ebbex: this needs to be removed for routing tables to test in CI https://opendev.org/openstack/kayobe/src/branch/master/playbooks/kayobe-overcloud-host-configure-base/tests/test_overcloud_host_configure.py#L42-L52","commit_id":"7d80ad8d0db9216aee53388a45fe6ba5ad1672a0"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e6a41f8f49aa872e3b94b33492e4c475f364ceaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9e07e85_cc9c36c7","updated":"2023-01-18 14:14:20.000000000","message":"recheck - network manager role updated","commit_id":"7161a4b1b21f5dd88b85dead8671959522f21222"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"aa8e31f0018d9c9df09deda8d14758ed19f7eb97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cc62e212_767982c6","updated":"2023-01-18 18:42:00.000000000","message":"It\u0027s failing because of br0.43\nA vlan on a bridge? I suppose that\u0027s possible, why is it not the other way around though? It seems more logical to attach a vlan interface as a bridge port, no?","commit_id":"135c9f047daaee1491533c7212adaafee87232f4"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"398b1ea99ef9cfb1e86fa61e4637a3c8e6057a65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae7cc6c6_d77cada5","updated":"2023-01-18 17:30:11.000000000","message":"recheck new networkmanager commit bc11343ecfde34bc4f260a8122e035cfac958631","commit_id":"135c9f047daaee1491533c7212adaafee87232f4"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"273f0645c8687ecd5942ae93076820c506404ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ad9eb2c_87598bbd","in_reply_to":"5b96a34c_2880f7ee","updated":"2023-01-20 09:12:13.000000000","message":"One would want only one physnet for example.\n\nHmmm, how this works in current iteration of NetworkManager role?","commit_id":"135c9f047daaee1491533c7212adaafee87232f4"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"00c59e27b8315d282e0dcc9c463cce673a5069ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b96a34c_2880f7ee","in_reply_to":"82652fad_0aafe2d2","updated":"2023-01-19 09:22:58.000000000","message":"Why can\u0027t you have bond0 -\u003e br-physnet and bond0.43 -\u003e br-somevlan?\n\nBut more importantly, I don\u0027t see how under ansible-role-interfaces this works with network-scripts, but not NetworkManager nmconnection. How is the configuration applied differently?","commit_id":"135c9f047daaee1491533c7212adaafee87232f4"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"e483c1b1e26e318b63a1f5c734cfecb6a7a36925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82652fad_0aafe2d2","in_reply_to":"cc62e212_767982c6","updated":"2023-01-19 08:41:32.000000000","message":"there are cases where direct vlan interface won\u0027t work. for example when using the same underlying NIC as physnet and this vlan tag configured as a Neutron network in OpenStack. besides, we need to still support that kind of configs.","commit_id":"135c9f047daaee1491533c7212adaafee87232f4"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"f0c4c50e29044ae51c67c5f641430a2faae9a1fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e283b09d_b81ed6a9","updated":"2023-03-11 08:54:15.000000000","message":"Ok, I know why this is failing, whilst the stackhpc/networkmanager doesn\u0027t. It\u0027s the hanlder. In the stackhpc version it just does the basic \"nmcli connection reload\", which works ok for first time setups. It doesn\u0027t however handle the changing of networkinterfaces once operational, (like changing of ip addresses) which is one of the things the new handler tries to address.\n\n \"Error: \u0027bond0.44\u0027 is not an active connection.\",\n \"Error: no active connection provided.\",\n \"Error: \u0027br0.43\u0027 is not an active connection.\",\n \"Error: no active connection provided.\"\n\nNote to self, errors we\u0027re looking for are in the kayobe-overcloud-host-configure-rocky9/primary/ansible/overcloud-deploy logs.","commit_id":"c179a7d4b60e0b54fc0361122f69734db4657694"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b8bca9b8d576b2bdfa71b85f70ee864d26f9839c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"49ba94dd_175ae1e5","in_reply_to":"36a69473_c0d33aeb","updated":"2023-04-07 09:47:40.000000000","message":"Done","commit_id":"c179a7d4b60e0b54fc0361122f69734db4657694"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"c44f100eccbfa41e8629680643c12d6d3667c12d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36a69473_c0d33aeb","in_reply_to":"81f3dc40_a6824764","updated":"2023-03-30 12:33:24.000000000","message":"there is a ~30 seconds time delay before bridge link goes up\n\nMar 30 12:19:18 bartosz-rocky9-bm3.novalocal NetworkManager[1062]: \u003cinfo\u003e  [1680178758.8426] device (bond0.44): Activation: successful, device activated.\nMar 30 12:19:46 bartosz-rocky9-bm3.novalocal NetworkManager[1062]: \u003cinfo\u003e  [1680178786.9122] device (br0): carrier: link connected\nMar 30 12:19:46 bartosz-rocky9-bm3.novalocal NetworkManager[1062]: \u003cinfo\u003e  [1680178786.9125] device (br0.43): carrier: link connected\nMar 30 12:19:47 bartosz-rocky9-bm3.novalocal NetworkManager[1062]: \u003cinfo\u003e  [1680178787.3741] device (br1): carrier: link connected","commit_id":"c179a7d4b60e0b54fc0361122f69734db4657694"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"65e8ae9305c0f14a445f616e71d632d417b5d6c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"81f3dc40_a6824764","in_reply_to":"918eb7bb_362291ab","updated":"2023-03-30 11:37:33.000000000","message":"as second run of kayobe overcloud host configure is ok","commit_id":"c179a7d4b60e0b54fc0361122f69734db4657694"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5dc6d80b71d21bf6b86386482f22d0673538457a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"918eb7bb_362291ab","in_reply_to":"e283b09d_b81ed6a9","updated":"2023-03-30 11:36:58.000000000","message":"I\u0027ve reproduced those errors in my lab. And handler is coming through ok (with stderr though). However it is failing on:\n    \"msg\": \"Interface br0 is not active\"\n    \"msg\": \"Interface br1 is not active\"\n    \nBut those bridges are active - looking at nmcli connection show, and nm logs, ip addr:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0f1/869977/6/check/kayobe-overcloud-host-configure-rocky9/0f19676/primary/system_logs/ip-address.txt\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0f1/869977/6/check/kayobe-overcloud-host-configure-rocky9/0f19676/primary/system_logs/NetworkManager.txt\n\nthis check is based on ansible facts gathered in step before. I\u0027m wondering if activation of nic step is asynchronous and it is in fact not yet active when gather facts is running.","commit_id":"c179a7d4b60e0b54fc0361122f69734db4657694"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"443a2c89f981336a6fd1d60e35471b37a25ba220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8a5a1913_b68cedf8","updated":"2023-03-31 08:38:08.000000000","message":"using that for testing - https://github.com/eb4x/ansible-role-interfaces/pull/1/files","commit_id":"01753259f3b5f7626724de8e634865171293f9f3"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"82177788b7d935f54d3a9638b005d335c42735ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b66aeb6f_1d6e0ce4","updated":"2023-04-06 11:23:14.000000000","message":"recheck - nm role update","commit_id":"550d57a22936f38b9895b9d821bd67c334ca0b01"}]}