)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2dff10f88f7282136dfc6f96faddc75c3475bbfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"536ba0e9_b6213588","updated":"2023-11-21 20:45:46.000000000","message":"Rebased following the merge of https://review.opendev.org/c/openstack/kayobe/+/901059","commit_id":"ae57317ce7262a2cd4da0cdf75dc2734fdf87272"}],"ansible/roles/kolla-ansible/templates/kolla/globals.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4fe42077342a74217f584186cfa310cc8036649d","unresolved":true,"context_lines":[{"line_number":524,"context_line":"# Grafana - Data visualisation \u0026 Monitoring"},{"line_number":525,"context_line":"############################################"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"# When using the Monasca fork of Grafana if an OpenStack user with the"},{"line_number":528,"context_line":"# same name as the admin user logs into Grafana it overwrites user data"},{"line_number":529,"context_line":"# in the Grafana database, breaking the local admin account, and"},{"line_number":530,"context_line":"# preventing admin API calls to Grafana. To reduce the chance of this"},{"line_number":531,"context_line":"# happening the local admin account is renamed here."},{"line_number":532,"context_line":"# NOTE(priteau): This is kept for compatibility purpose until we validate"},{"line_number":533,"context_line":"# reverting to the original admin user."},{"line_number":534,"context_line":"{% if kolla_enable_grafana and grafana_local_admin_user_name is defined %}"},{"line_number":535,"context_line":"grafana_admin_username: \"{{ grafana_local_admin_user_name }}\""},{"line_number":536,"context_line":"{% endif %}"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"#########################################"},{"line_number":539,"context_line":"# Bootstrap-servers - Host Configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"485130ce_d0249950","side":"PARENT","line":536,"range":{"start_line":527,"start_character":0,"end_line":536,"end_character":11},"updated":"2023-03-15 07:52:39.000000000","message":"This doesn\u0027t apply only to Monasca Grafana, but also to Grafana. This will cause new deployments to use the `admin` username instead of `grafana_local_admin`. It should be covered in a release note.\n\nWe should also test what it means for existing deployments on upgrades: does it change the admin user automatically?","commit_id":"e0ff9a0283bd870df72ea7dec62d55ef0b8ed972"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f1037530064fac6d2f6c1bf1c094e610a02fb1d9","unresolved":true,"context_lines":[{"line_number":524,"context_line":"# Grafana - Data visualisation \u0026 Monitoring"},{"line_number":525,"context_line":"############################################"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"# When using the Monasca fork of Grafana if an OpenStack user with the"},{"line_number":528,"context_line":"# same name as the admin user logs into Grafana it overwrites user data"},{"line_number":529,"context_line":"# in the Grafana database, breaking the local admin account, and"},{"line_number":530,"context_line":"# preventing admin API calls to Grafana. To reduce the chance of this"},{"line_number":531,"context_line":"# happening the local admin account is renamed here."},{"line_number":532,"context_line":"# NOTE(priteau): This is kept for compatibility purpose until we validate"},{"line_number":533,"context_line":"# reverting to the original admin user."},{"line_number":534,"context_line":"{% if kolla_enable_grafana and grafana_local_admin_user_name is defined %}"},{"line_number":535,"context_line":"grafana_admin_username: \"{{ grafana_local_admin_user_name }}\""},{"line_number":536,"context_line":"{% endif %}"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"#########################################"},{"line_number":539,"context_line":"# Bootstrap-servers - Host Configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7c7f8256_563cfb5e","side":"PARENT","line":536,"range":{"start_line":527,"start_character":0,"end_line":536,"end_character":11},"in_reply_to":"485130ce_d0249950","updated":"2023-03-15 09:41:04.000000000","message":"+1 - I think we kept this part intentionally.","commit_id":"e0ff9a0283bd870df72ea7dec62d55ef0b8ed972"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"d20e3bb3d58bd38875b81ef92ac25f2f5129aae6","unresolved":true,"context_lines":[{"line_number":524,"context_line":"# Grafana - Data visualisation \u0026 Monitoring"},{"line_number":525,"context_line":"############################################"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"# When using the Monasca fork of Grafana if an OpenStack user with the"},{"line_number":528,"context_line":"# same name as the admin user logs into Grafana it overwrites user data"},{"line_number":529,"context_line":"# in the Grafana database, breaking the local admin account, and"},{"line_number":530,"context_line":"# preventing admin API calls to Grafana. To reduce the chance of this"},{"line_number":531,"context_line":"# happening the local admin account is renamed here."},{"line_number":532,"context_line":"# NOTE(priteau): This is kept for compatibility purpose until we validate"},{"line_number":533,"context_line":"# reverting to the original admin user."},{"line_number":534,"context_line":"{% if kolla_enable_grafana and grafana_local_admin_user_name is defined %}"},{"line_number":535,"context_line":"grafana_admin_username: \"{{ grafana_local_admin_user_name }}\""},{"line_number":536,"context_line":"{% endif %}"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"#########################################"},{"line_number":539,"context_line":"# Bootstrap-servers - Host Configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8c16dd0c_050192db","side":"PARENT","line":536,"range":{"start_line":527,"start_character":0,"end_line":536,"end_character":11},"in_reply_to":"7c7f8256_563cfb5e","updated":"2023-03-15 11:45:42.000000000","message":"I would be happy to move back to \"admin\", but we need to figure out the upgrade path.","commit_id":"e0ff9a0283bd870df72ea7dec62d55ef0b8ed972"}]}