)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"009bb9dc4cf29d6325202370613459769c2a90cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b18f4ec3_b67dc29e","updated":"2025-01-21 12:01:33.000000000","message":"Been here for a while, let\u0027s merge and follow-up if needed","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"},{"author":{"_account_id":35511,"name":"Dawud","email":"dawud@stackhpc.com","username":"dawudm"},"change_message_id":"45a7d4fb14fd76c6f2fcadd25456b707cb9abd4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1dabc69_95548836","updated":"2024-12-19 15:00:50.000000000","message":"LGTM. This is a much needed patch as, like you mention, we need setuptools to create a venv","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d6e46886d8fd14b5b9c9bc81cd01cf966420b8f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77f85dd3_70d5dfb4","updated":"2024-02-06 12:51:41.000000000","message":"recheck","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"b5dbcd0be2140d9738c104a7201ed956884d80a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3b146930_c6b72e48","updated":"2025-01-06 14:13:49.000000000","message":"recheck: I can get behind this one. Regarding moving to a list, we can always. optimize later.","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"}],"ansible/kayobe-target-venv.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"522a88083638865bfbf204e87c32848140d21610","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        - gather_facts is not skipped"},{"line_number":96,"context_line":"        - lookup(\u0027config\u0027, \u0027DEFAULT_GATHERING\u0027) !\u003d \u0027implicit\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    - name: Ensure Python pip package is installed"},{"line_number":99,"context_line":"      package:"},{"line_number":100,"context_line":"        name: python3-pip"},{"line_number":101,"context_line":"        state: present"},{"line_number":102,"context_line":"      become: True"},{"line_number":103,"context_line":"      when: virtualenv is not defined"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    - name: Ensure kolla-ansible virtualenv has docker SDK for python installed"},{"line_number":106,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"499d7c89_cb4c07d8","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":0},"updated":"2023-05-02 11:30:49.000000000","message":"maybe the good idea would be move the whole task up instead of splitting it?\nalso now we install python3-setuptools even if virtualenv is not used.","commit_id":"197e03b12addf4e77e2aac2c69bec9a04eaf6309"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"308b4cb4b867d0742328396378f2c8a833829082","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        - gather_facts is not skipped"},{"line_number":96,"context_line":"        - lookup(\u0027config\u0027, \u0027DEFAULT_GATHERING\u0027) !\u003d \u0027implicit\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    - name: Ensure Python pip package is installed"},{"line_number":99,"context_line":"      package:"},{"line_number":100,"context_line":"        name: python3-pip"},{"line_number":101,"context_line":"        state: present"},{"line_number":102,"context_line":"      become: True"},{"line_number":103,"context_line":"      when: virtualenv is not defined"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    - name: Ensure kolla-ansible virtualenv has docker SDK for python installed"},{"line_number":106,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"77441e87_d1315218","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":0},"in_reply_to":"499d7c89_cb4c07d8","updated":"2023-05-02 12:19:32.000000000","message":"We were installing setup tools when virtualenv was not defined already. The only change is that we are installing setuptools always now, instead of only when virtualenv is not defined.\n\nIf we move the whole task up, we will install pip even when using virtualenv, which may not be necessary.","commit_id":"197e03b12addf4e77e2aac2c69bec9a04eaf6309"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"85932beb0230cf10a1647936a371cd421f07e515","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        - gather_facts is not skipped"},{"line_number":96,"context_line":"        - lookup(\u0027config\u0027, \u0027DEFAULT_GATHERING\u0027) !\u003d \u0027implicit\u0027"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    - name: Ensure Python pip package is installed"},{"line_number":99,"context_line":"      package:"},{"line_number":100,"context_line":"        name: python3-pip"},{"line_number":101,"context_line":"        state: present"},{"line_number":102,"context_line":"      become: True"},{"line_number":103,"context_line":"      when: virtualenv is not defined"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    - name: Ensure kolla-ansible virtualenv has docker SDK for python installed"},{"line_number":106,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4cafe5c6_df59b1da","line":103,"range":{"start_line":98,"start_character":0,"end_line":103,"end_character":0},"in_reply_to":"77441e87_d1315218","updated":"2023-05-02 12:40:37.000000000","message":"we use isolated virtualenv (without system-site-packages) so when virtualenv created all the packaged copied (by default) from the system and the pip is also copied. so we need the pip package too if we install setuptools there.","commit_id":"197e03b12addf4e77e2aac2c69bec9a04eaf6309"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"de8f3d4505b246d77beee301c5b975272e949dab","unresolved":true,"context_lines":[{"line_number":24,"context_line":"          when: not ansible_facts"},{"line_number":25,"context_line":"          register: gather_facts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Ensure the Python venv package is installed on Debian family systems"},{"line_number":28,"context_line":"          package:"},{"line_number":29,"context_line":"            name: python3-venv"},{"line_number":30,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0806e360_5cf6dd6a","line":27,"updated":"2023-12-08 08:58:23.000000000","message":"Is it possible to merge with this and save a task?","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d6e46886d8fd14b5b9c9bc81cd01cf966420b8f9","unresolved":true,"context_lines":[{"line_number":24,"context_line":"          when: not ansible_facts"},{"line_number":25,"context_line":"          register: gather_facts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Ensure the Python venv package is installed on Debian family systems"},{"line_number":28,"context_line":"          package:"},{"line_number":29,"context_line":"            name: python3-venv"},{"line_number":30,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4186a2af_c08fb11b","line":27,"in_reply_to":"0806e360_5cf6dd6a","updated":"2024-02-06 12:51:41.000000000","message":"Hmm, this one is conditional. Is there a significant overhead of having an extra task over a single one with a loop?","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5f9031e6c3ef1c23ffa15a9f4c18e70ee6887779","unresolved":true,"context_lines":[{"line_number":24,"context_line":"          when: not ansible_facts"},{"line_number":25,"context_line":"          register: gather_facts"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        - name: Ensure the Python venv package is installed on Debian family systems"},{"line_number":28,"context_line":"          package:"},{"line_number":29,"context_line":"            name: python3-venv"},{"line_number":30,"context_line":"            state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7259e7f6_5650d812","line":27,"in_reply_to":"4186a2af_c08fb11b","updated":"2024-03-19 14:14:10.000000000","message":"There is some overhead at scale. We could make a list of packages and use select to remove the empty lines.","commit_id":"b10b166aaad970a56e373c7b432261ac3dc6a84a"}]}