)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"51ffef09c4812f715afb9b4f496a817a0b081bf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"294264aa_f23a31c4","updated":"2023-07-11 11:34:33.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy, kayobe-overcloud-upgrade-rocky9)","commit_id":"d7512724f7dd7bd681e6e5a2a0c6d09461236c30"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"9630a4dcc94d3f0978fe04b55a0bbdb774599f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c6b04815_0117e81b","updated":"2023-07-20 11:29:58.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy, kayobe-overcloud-upgrade-rocky9)","commit_id":"d7512724f7dd7bd681e6e5a2a0c6d09461236c30"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4a2786122ba05ffcdf98e77cb48f8e2908a48fcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"27e393e4_c23f457b","updated":"2023-08-18 08:03:07.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy)","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"6541fdd6575a7788ddef8fc26590edcd3ff78664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"328572c4_9b293475","updated":"2023-07-25 09:16:52.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy)","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"fb285c385297594d9c2188e7c6b89917e13aea94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"efc92c4d_c1c613ff","updated":"2023-07-28 08:16:24.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy)","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b06499c3374d3dc62dcf0c1539662900cb7580a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff8d0d4b_36e0980e","updated":"2023-08-18 12:26:08.000000000","message":"recheck (kayobe-overcloud-upgrade-ubuntu-jammy)","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"}],"ansible/roles/deploy-containers/tasks/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4805034be1e186c6cc9eab7b28ad294cb8b02eec","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e2070d8b_32d92682","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":70},"updated":"2023-07-10 13:06:12.000000000","message":"This is already the case given our current requirements.","commit_id":"9957f8d06dd3ac58a423c3cfd86a55e567af6d28"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"b5977ff6e3c73e98aa77df6f60c8281684cdd31e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"4d6cba26_e6497abf","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":70},"in_reply_to":"e2070d8b_32d92682","updated":"2023-07-11 08:27:44.000000000","message":"Done","commit_id":"9957f8d06dd3ac58a423c3cfd86a55e567af6d28"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3dc1227712a39ee8e00c86091d303514aa05b210","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    username: \"{{ kolla_docker_registry_username }}\""},{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":10,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a4456d79_5fa3c789","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":6},"updated":"2023-08-18 14:55:11.000000000","message":"while copy-paste from Ie5c21597266c8e470994eba16f3c2ed2224d0dcb forgot the comment, or switch to truthy filter.","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"2aa7bd42e43f87873e5788c23213b0cdb327d4ba","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    username: \"{{ kolla_docker_registry_username }}\""},{"line_number":6,"context_line":"    password: \"{{ kolla_docker_registry_password }}\""},{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":10,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"715121cb_ea3c5ce9","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":6},"in_reply_to":"a4456d79_5fa3c789","updated":"2023-08-21 05:47:05.000000000","message":"As mentioned by Pierre in previous comment, the note is no longer needed.","commit_id":"ce671c7e9fff862372c72773d69ba2c0de8973b7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"83016994ba619aa4c879a6b7781b6e01fc9a6140","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ef9d1174_4a069aea","line":10,"updated":"2023-08-22 10:31:49.000000000","message":"why not switch now?","commit_id":"5d37fd128636dd16e1c6c5d948e8c287f96edf99"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"835ac025e18a3ca557031b5a0fe0e83a659bd8bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"0776e534_80c5fbc6","line":10,"in_reply_to":"8bd3c7fe_5d6d6c24","updated":"2023-08-22 14:44:48.000000000","message":"thanks","commit_id":"5d37fd128636dd16e1c6c5d948e8c287f96edf99"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"831dde39b9b81131cf5fe923b84bf9374ebe5fb2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fcc301d1_8f37509e","line":10,"in_reply_to":"914c6459_7caf8c1c","updated":"2023-08-22 10:42:45.000000000","message":"Ie5c21597266c8e470994eba16f3c2ed2224d0dcb","commit_id":"5d37fd128636dd16e1c6c5d948e8c287f96edf99"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"86293015861c2f273a13487a7bdcb26fd30c5453","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"914c6459_7caf8c1c","line":10,"in_reply_to":"ef9d1174_4a069aea","updated":"2023-08-22 10:41:15.000000000","message":"there is another place with the same code. may be in the followup? or add the second place and mention in the change?","commit_id":"5d37fd128636dd16e1c6c5d948e8c287f96edf99"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"18af012a4b92bcdedae98dec4656a10986fac09b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    reauthorize: yes"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    # NOTE(wszumski): Switch to truthy filter when min ansible\u003e\u003d2.10.5"},{"line_number":10,"context_line":"    - kolla_docker_registry_username not in [none, \"\"]"},{"line_number":11,"context_line":"    - kolla_docker_registry_password not in [none, \"\"]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Deploy containers (loop)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8bd3c7fe_5d6d6c24","line":10,"in_reply_to":"fcc301d1_8f37509e","updated":"2023-08-22 12:31:56.000000000","message":"Switched to truthy filter and updated old code.","commit_id":"5d37fd128636dd16e1c6c5d948e8c287f96edf99"}]}