)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a9e458333ab7040098f679c0db4465de874fe714","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e5bf0a35_dd9562c1","updated":"2023-07-28 15:21:50.000000000","message":"As discussed earlier, this will change configuration on existing deployments, I understand the rationale around adapting to network-scripts defaults, but I\u0027m not convinced we need to break existing deployments (or at least cause network restart on kayobe overcloud host configure runs).","commit_id":"b677030642f367b1bc33fdb528447bb8fc740a1f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4401780b2745ca772b9c0e02cd25cd1138d09ceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1d36d4d8_233aff8f","in_reply_to":"cf116c5e_7b8aee60","updated":"2023-08-18 09:49:02.000000000","message":"Ack","commit_id":"b677030642f367b1bc33fdb528447bb8fc740a1f"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"27415cb9e66f087bbd2cbd4b17dc0c926ea7b482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5e3bb7f7_f074ee5d","in_reply_to":"cf116c5e_7b8aee60","updated":"2023-08-18 09:50:04.000000000","message":"disabling stp shouldn\u0027t break current deployments. relno anyway contains info about defaults.","commit_id":"b677030642f367b1bc33fdb528447bb8fc740a1f"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"30c7a8190951b1f06426c24212c2e732f869a5c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cf116c5e_7b8aee60","in_reply_to":"e5bf0a35_dd9562c1","updated":"2023-07-28 15:25:52.000000000","message":"I\u0027m not convinced either. As leaving the default not set, can cause disruptions for people with BDPU guard on the switches after migration to RL9 - I had that case on new deployment recently. Both options are not perfect. Let\u0027s discuss that in the review.","commit_id":"b677030642f367b1bc33fdb528447bb8fc740a1f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"344cad08a400281f05fe310889a7ae1a957c29df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"65672b81_a17c8c1c","updated":"2023-07-31 14:01:32.000000000","message":"Upgrade jobs broken.","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"a38ffe4452062fb5242a93f065542fff0b162836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"52622a87_54ef51dd","updated":"2023-07-31 09:03:58.000000000","message":"lgtm 😊","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6c61ac03f574ece8f6f5377a81acbd0a6ca5b410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8bafa9e9_4b42fad0","updated":"2023-08-10 09:53:07.000000000","message":"recheck","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"b90ac1984527930c46d36e5dd52b7e55570bdc45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"569438c4_bdeaa40c","updated":"2023-07-31 12:15:29.000000000","message":"recheck\n\nkayobe-overcloud-host-configure-ubuntu-jammy failed in test_ntp_clock_synchronized","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"a2105a4cca177cea73bbc02bbbe97a5342765bf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a6b51bc2_f79c4549","updated":"2023-08-18 07:41:05.000000000","message":"recheck - K-A fix merged","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"caa79a4d74766506571b3bee4c9db1fe29819995","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"16f0796c_673ac9c6","updated":"2023-08-18 09:44:29.000000000","message":"I have made minor nit edits to the release note.","commit_id":"f1fd127c34f07624b472e07c3e589080499b29dd"}],"kayobe/plugins/filter/networks.py":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"fe1e4506c58603081414053e9507ade39c70d51f","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    os_family \u003d context[\u0027ansible_facts\u0027][\u0027os_family\u0027]"},{"line_number":292,"context_line":"    if bridge_stp is None:"},{"line_number":293,"context_line":"        if os_family \u003d\u003d \u0027RedHat\u0027:"},{"line_number":294,"context_line":"            bridge_stp \u003d \u0027false\u0027"},{"line_number":295,"context_line":"        else:"},{"line_number":296,"context_line":"            return None"},{"line_number":297,"context_line":"    bridge_stp \u003d utils.call_bool_filter_lower(context, bridge_stp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"063fab15_b5e4d70f","line":294,"updated":"2023-07-28 21:16:31.000000000","message":"I\u0027d just return the \u0027false\u0027 string here, just to make it clear we\u0027re setting a default value, and no further processing of it is required, instead of the fall-through down to call_bool_filter_lower.","commit_id":"9f254b823522ee4f5c2d1bf374987b9ba85c9735"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"57192b8176e0de30d3aab053ee7f959c8ce2bd09","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    os_family \u003d context[\u0027ansible_facts\u0027][\u0027os_family\u0027]"},{"line_number":292,"context_line":"    if bridge_stp is None:"},{"line_number":293,"context_line":"        if os_family \u003d\u003d \u0027RedHat\u0027:"},{"line_number":294,"context_line":"            bridge_stp \u003d \u0027false\u0027"},{"line_number":295,"context_line":"        else:"},{"line_number":296,"context_line":"            return None"},{"line_number":297,"context_line":"    bridge_stp \u003d utils.call_bool_filter_lower(context, bridge_stp)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1dee700e_04cf0bee","line":294,"in_reply_to":"063fab15_b5e4d70f","updated":"2023-07-31 08:07:57.000000000","message":"Done","commit_id":"9f254b823522ee4f5c2d1bf374987b9ba85c9735"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8a2b548d508ff03e6ac75ecdf712709a9afe6f3c","unresolved":true,"context_lines":[{"line_number":278,"context_line":"def net_bridge_stp(context, name, inventory_hostname\u003dNone):"},{"line_number":279,"context_line":"    \"\"\"Return the Spanning Tree Protocol (STP) state for a bridge."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    On RL9 if STP is not defined, default it to \u0027false\u0027 to preserve"},{"line_number":282,"context_line":"    compatibility with network scripts. STP is \u0027true\u0027 in NetworkManager"},{"line_number":283,"context_line":"    by default, so we set it to \u0027false\u0027 here."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    :param context: Jinja2 Context object."}],"source_content_type":"text/x-python","patch_set":13,"id":"d1d067ef_cc38d314","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":38},"updated":"2023-07-31 14:28:19.000000000","message":"For master - I\u0027m fine (as long as we document it), what about backports? If somebody uses a bridge today with stp (ignoring the mayhem it might create in their physical switches) - he will get stp disabled and network restarted - do we backport without changing the default?","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a80f21e81e8c8450eeef274ef9cba54dbc310920","unresolved":false,"context_lines":[{"line_number":278,"context_line":"def net_bridge_stp(context, name, inventory_hostname\u003dNone):"},{"line_number":279,"context_line":"    \"\"\"Return the Spanning Tree Protocol (STP) state for a bridge."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    On RL9 if STP is not defined, default it to \u0027false\u0027 to preserve"},{"line_number":282,"context_line":"    compatibility with network scripts. STP is \u0027true\u0027 in NetworkManager"},{"line_number":283,"context_line":"    by default, so we set it to \u0027false\u0027 here."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    :param context: Jinja2 Context object."}],"source_content_type":"text/x-python","patch_set":13,"id":"f77dc20f_56c21f3e","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":38},"in_reply_to":"46949d3f_a062cc50","updated":"2023-08-18 09:33:16.000000000","message":"Ok, agree to disable and let\u0027s get over with it.","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f39d0ddb330ad11aeb6e8f7f9fd5329ded6e2251","unresolved":true,"context_lines":[{"line_number":278,"context_line":"def net_bridge_stp(context, name, inventory_hostname\u003dNone):"},{"line_number":279,"context_line":"    \"\"\"Return the Spanning Tree Protocol (STP) state for a bridge."},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    On RL9 if STP is not defined, default it to \u0027false\u0027 to preserve"},{"line_number":282,"context_line":"    compatibility with network scripts. STP is \u0027true\u0027 in NetworkManager"},{"line_number":283,"context_line":"    by default, so we set it to \u0027false\u0027 here."},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    :param context: Jinja2 Context object."}],"source_content_type":"text/x-python","patch_set":13,"id":"46949d3f_a062cc50","line":282,"range":{"start_line":281,"start_character":0,"end_line":282,"end_character":38},"in_reply_to":"d1d067ef_cc38d314","updated":"2023-08-02 09:29:54.000000000","message":"I would say let\u0027s disable in backports too. If you\u0027re concerned we could add a precheck with a flag to acknowledge/skip.","commit_id":"6b0f2471899a904a0ac3912cf43c4606f81bb283"}],"kayobe/plugins/filter/utils.py":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"fe1e4506c58603081414053e9507ade39c70d51f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    :returns: A string \"true\" or \"false\" in lowercase."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    bool_val \u003d call_bool_filter(context, value)"},{"line_number":47,"context_line":"    return context.environment.call_filter(\"lower\", bool_val, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":11,"id":"6ba8d8df_555238d0","line":47,"updated":"2023-07-28 21:16:31.000000000","message":"Creating this function and calling the lower filter seems excessive. This is just python right? Can\u0027t we just do `call_bool_filter(context, value).lower()`","commit_id":"9f254b823522ee4f5c2d1bf374987b9ba85c9735"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"211cd819b71c1732a2f20ed5075789bf76d92e90","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    :returns: A string \"true\" or \"false\" in lowercase."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    bool_val \u003d call_bool_filter(context, value)"},{"line_number":47,"context_line":"    return context.environment.call_filter(\"lower\", bool_val, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":11,"id":"82faee9c_fed14d5a","line":47,"in_reply_to":"6ba8d8df_555238d0","updated":"2023-07-31 07:21:25.000000000","message":"We could add lower\u003dFalse argument to call_bool_filter actually","commit_id":"9f254b823522ee4f5c2d1bf374987b9ba85c9735"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4ee921ba3ba61799b068d98b0ba9e0fd2209ed76","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :returns: A string \"true\" or \"false\" in lowercase."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    bool_val \u003d call_bool_filter(context, value)"},{"line_number":47,"context_line":"    return context.environment.call_filter(\"lower\", bool_val, context\u003dcontext)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fd3002e9_22580f11","line":47,"in_reply_to":"82faee9c_fed14d5a","updated":"2023-07-31 08:24:20.000000000","message":"Done. lower() needs string.","commit_id":"9f254b823522ee4f5c2d1bf374987b9ba85c9735"}]}